Jump to content


Photo

aTweaks and TobEx


  • Please log in to reply
6 replies to this topic

#1 Insomniator

Insomniator
  • Modder
  • 358 posts

Posted 20 May 2021 - 09:37 PM

Hi

 

aTweaks installer disable some TobEx's options:

// This file checks for TobEx and disables the Magic Resistance Mod Fix and Damage Fix options in TobExCore.ini if it is installed.
// Currently, the abovementioned option doesn't seem to work as intended

~Magic Resistance Mod Fix=0~
~Damage Fix=0~      
~Disintegrate Fix=0~
~Strength Mod=0~
~Correct Experience Reporting=0~ (obsolete, not exist in last TobEx)

 

Does anyone have any information about this bugs ?

 


#2 The Imp

The Imp

    Not good, see EVIL is better. You'll LIVE.

  • Member
  • 5155 posts

Posted 21 May 2021 - 04:58 AM

Does anyone have any information about this bugs ?

It's not a bug, it just doesn't work as intended.
For example, it could write dozens of resistance effects while only one is actually tried to be applied... or the like.

This is a standard ToBEx add on mod procedure, where you dump a library into the game while checking that it doesn't exist YET, and skip that process if it does, with a version check too to make sure that the already existing is not older than the one being applied so to check that the added effect is actually applied.

Aka:

aTweaks installer disable some TobEx's options:

No it doesn't. It comes featured with a version of ToBEx with them normally disabled. Which if you read just a little bit, you'll find out that you probably should install the ToBEx first so the latest version is installed first and the rest of the mods can skip the whole thing, while still with the added effect enabled ...


Edited by The Imp, 21 May 2021 - 05:04 AM.

Yep, Jarno Mikkola. my Mega Mod FAQ. Use of the BWS, and how to use it(scroll down that post a bit). 
OK, desert dweller, welcome to the sanity, you are free to search for the limit, it's out there, we drew it in the sand. Ouh, actually it was still snow then.. but anyways.


#3 Salk

Salk
  • Modder
  • 1419 posts

Donator

Posted 21 May 2021 - 09:15 AM

Perhaps you are right Imp but aTweaks' TP2 clearly states the following:

 

INCLUDE ~aTweaks/lib/tobexfix.tph~                                               // if TobEx is installed, this disables some of its currently buggy options

 

so there are two possibilities here: either aTweaks changes the options of ToBEx and disables them just like the comment states and in this case you are wrong or you are right and Wisp is stating something false there because he doesn't know what he's doing.

 

Which one is it?

 

I put my money on the first, considering that both Wisp and Insomniator strike me as very competent coders.


Edited by Salk, 21 May 2021 - 09:58 AM.


#4 The Imp

The Imp

    Not good, see EVIL is better. You'll LIVE.

  • Member
  • 5155 posts

Posted 21 May 2021 - 09:48 AM

Just remind me again, of which version of the ToBEx is the Atweaks' TP2 based on ? And how many players change the default setting of those settings in ToBEx ? PS: Intentionally. And can't do so after Atweaks.


Yep, Jarno Mikkola. my Mega Mod FAQ. Use of the BWS, and how to use it(scroll down that post a bit). 
OK, desert dweller, welcome to the sanity, you are free to search for the limit, it's out there, we drew it in the sand. Ouh, actually it was still snow then.. but anyways.


#5 Salk

Salk
  • Modder
  • 1419 posts

Donator

Posted 21 May 2021 - 09:56 AM

I'm not sure I understand what you are saying, The Imp.

 

The point here is: does aTweaks change those settings by disabling them or not? What does it matter what kind of ToBEx version aTweaks is using?

 

aTwaks says that it disable those options if it finds ToBEx installed (so the aTweaks version is completely irrelevant) and Insomniator believes it. You are saying it is not true.


Edited by Salk, 21 May 2021 - 09:57 AM.


#6 Wisp

Wisp
  • Modder
  • 1353 posts

Posted 25 June 2021 - 08:59 PM

I do not know why these options are disabled. Judging by the code style, I would guess it was aVENGER who wrote it, presumably based on testing he did.



#7 Salk

Salk
  • Modder
  • 1419 posts

Donator

Posted 26 June 2021 - 12:24 AM

It could be that at that time those options may have been buggy hence the comment "// if TobEx is installed, this disables some of its currently buggy options" but I don't think this still applies today.

 

Those options are all enabled by defautl.

 

Pending confirmation that there is no valid reason to revert the default settings, I do believe aTweaks should remove ToBEx's .ini settings changes.