15 replies to this topic

[Roberciiik]

Hi,

 

I would like to ask for permission to disable language-specific sounds. In my opinion if mod is fully translated, English sounds (Will O'Hara soundset as of now) are confiusing and even annoying for non-english mod selection. As far as I understand, I need to comment/delete the following section in tp2 file:

ACTION_BASH_FOR ~ntotsc/language/english/ogg~ ~^.+\.ogg$~ BEGIN
	ACTION_IF NOT FILE_EXISTS ~ntotsc/language/%LANGUAGE%/ogg/%BASH_FOR_FILE%~ BEGIN
		COPY ~%BASH_FOR_FILESPEC%~ ~ntotsc/language/%LANGUAGE%/ogg~
	END
END

 

Should I change something more in the code?

Game engine will replace missing sounds with text messages in console so correct translation for sound will be displayed.

 

What do you think about this?

 

 

[jastey]

I see your point, but some players might want to have a soundset nontheless. Another possibility would be to alter the Will O'Hara component into two install choices: with sounds, or without sounds. Or, add another optional component that removes the sounds if the player installs it. I'll ponder this a bit more.

[The Imp]

And if the obviousness of the answer is to be questioned, I'll just give it here; Any mod you install onto your computer is yours to do with how ever you wish, as long as you are then willing to take responsibility of those choises.

And yes, you can just quote out the code: Aka you add these, (with Notepad)

/*

<code>

*/

to the above...

[Gwendolyne]

I see your point, but some players might want to have a soundset nontheless. Another possibility would be to alter the Will O'Hara component into two install choices: with sounds, or without sounds. Or, add another optional component that removes the sounds if the player installs it. I'll ponder this a bit more.

Or you could externalize it in metada file, using variable c#english_soundset = 1. By default, the mod would install English soundset. If the player does not want them, he/she has to set the variable to 0. All you have to do is add those lines above and below your code:

 

 

ACTION_IF c#english_soundset BEGIN

   your code

END

 

[jastey]

Thanks for the suggestion! Sounds like the easiest solution, coding wise.

[The Imp]

The code doesn't work ...

ACTION_IF c#english_soundset = !"#¤%&/"!"#¤ BEGIN

   your code

END

Needs to be set to something... for the code to innitialize. Either you set it at at a meta data file or elsewhere... doesn't matter, it NEEDs to be READ. And so only the above doesn't work, so when you come up a solution idea, it would be nice to have it fully in the response.

[Gwendolyne]

Add those lines in your ini metadata file

 

[Mod_content]
# 1 = install English soundsets (by default).
# 0 = don't install English soundsets.
your_variable=1

Then copy lib folder into your mod folder and add the append_tp2.tp2 file into your tp2 and modify yourmod and your_variable names according to your needs.

 

Attached Files

•  jastey.zip   1.46K   235 downloads

[jastey]

Thanks! I downloaded it and will have a look at it.

[Roberciiik]

Using single place (ini file) to change this would be great! I think that subcomponent for Will O'Hara component would do job as well or even better because you don't need to modify mod content. And yes, in my local installation I removed ogg directory to disable english soundset but it is uncomfortable to do this for each update/installation.

[ALIEN]

@Gwendolyne While I appreciate you will to help, it is not good solution. When it comes to 'install something or not' it's allays best to use subcomponets because debugging information is lost. Also weidu.log won't have this info and it might lead to false bug report regarding 'missing soundset'.

 

Lastly, PI metadata file is not intended to be used for anything other than mod metadata. Mod configuration (if any) should atleaset have 'config' in their name.

[jastey]

Thanks for your head up ALIEN. The missing info for debug is indeed bad.

But, if there is an old mod which would would need to be recoded, externalizing is a fast way of making the mod compatible with PI without much effort.

Or in this case: Will O'Hara is a "silent" NPC with no banter or dialogues. I will not recode the mod so this not-much-used NPC gives a choice between English soundset yes/no. I prefer spending the time with updating another, more popular  mod.

[ALIEN]

Lack of time should not be a reason to implement things badly. It's not a case when you quickly need to fix game-breaking bug, this feature request can wait when you will have more time or someone else could contribute. Besides, putting "Will O'Hara copy sound code" into separate component very easy solution with few lines of code. 

[jastey]

What about making a quick and dirty possibility now and implementing something better later?

Even if it would take only 5 minutes (which it doesn't because I'd have to test it on three platforms and for at least two lanugage versions each) - I have a list with roughly 2000 "only 5 minutes" things on my modding to do list.

But sure - without trying to sound snippy - I have no problem saving my time and waiting for a contribution regarding this. It's really not worth the time (no offence, Roberciiik).

[Roberciiik]

I know that it is not a very important change. That's why I opened discussion instead of asking for patch. I think I can try to implement subcomponent (with testing on Windows) and give you results to review. Subcomponent is much better idea than my initial solution. Thanks!

[jastey]

Great! I am willing to spend time for this, just not more than I think is appropriate.

[Roberciiik]

Ok, I prepared subcomponent in the pull request https://github.com/S.../NTotSC/pull/14.