546 replies to this topic

[Almateria]

Oh! Yeah, I'll look into that after the finals (i'm having my ass kicked by Population Management and Zooecology rn).

 

I kinda need to get into the modding mindset with a clear head. I'm not a programmer by any stretch, lots of ARP was me wrangling bits of code out of other people's mods and repurposing it. Plus, it's been years since I did any meaningful work on it despite the promises of still-unearthed content so sometimes it just looks like nonsense to me, haha.

[Felipe]

I've never beaten BG2 and I'm very interested in restored content and seeing everything that was planned.

I hope you had a look at the other restoration patch that exists.

Almateria - Will you use the latest weidu? I ask because several things were fixed http://www.weidu.org...iDU-Changes.txt

[enderandrew]

Is there any update for fixing the bug Salk listed above?

http://www.shsforums...oject/?p=598414

[Roxanne]

So I was looking through BWS the other day, and everything was unmarked and red.

 

But is it safe to say that your mod is still ok to use except the Final Slayer Dream component?

If you read about the issues and decide to use the mod, you can do that. All BWS tries to do is to inform you that problems exist and it does not force the mod into your install by default.

[Almateria]

Is there any update for fixing the bug Salk listed above?

http://www.shsforums...oject/?p=598414

 

no because it works for me

i for real cannot change a problem where i do not physically see one

especially considering i haven't touched said component for years before that even came up

 

e: i really wanna help but i seriously can't lmao.

Edited by Almateria, 02 April 2018 - 04:37 AM.

[jastey]

Hi Almateria,

 

the mod adds this script block to ar4000.bcs:

 

IF
    OnCreation()
THEN
    RESPONSE #100
        SetGlobal("MasteredTheSlayer","GLOBAL",1)
END

 

Since it's patched via EXTEND_TOP and the original script starts with an "OnCreation()" trigger, this script block would need a "Continue()" for the chapter setting to be executed properly:

 

 

IF
    OnCreation()
THEN
    RESPONSE #100
        SetGlobal("MasteredTheSlayer","GLOBAL",1)

        Continue()
END

 

As it is now, it probably breaks chapter setting in ToB which leads to wrong chapter numbers which causes problems for some (NPC) mods.

Link to discussion: http://gibberlings3....topic=29295&hl=

 

[The Imp]

...

Like said, you don't want to do this.

[jastey]

Why not? The Continue() after setting a variable would only be bad if the mod expects the variable to be set for later script blocks of the same script.

 

As it is, the quoted script block might lead to the chapter number not being increased, so it should be changed. It could also be changed into a patch via EXTEND_BOTTOM, of course.

[The Imp]

Why not? The Continue() after setting a variable would only be bad if the mod expects the variable to be set for later script blocks of the same script.

 

As it is, the quoted script block might lead to the chapter number not being increased, so it should be changed. It could also be changed into a patch via EXTEND_BOTTOM, of course.

But you can't use an OnCreation() trigger on extend_bottom ...

And the first question, well, cause the OnCreation script block is used as the only one at the very first run. The only problem becomes if there's another OnCreation() trigger that's also true, later in the script... as then that's not true. And if there is, then ... it would be better to just not use the OnCreation() trigger, but something more rational, or have other conditions as well as an OnCreation that limit the others possibility of being true at the same time... and no try to fuck up everything by adding a Continue() to a OnCreation() ... cause that will fuck up things.

Edited by The Imp, 08 July 2018 - 08:21 AM.

[jastey]

... and no try to fuck up everything by adding a Continue() to a OnCreation() ... cause that will fuck up things.

Why, exactly?

[The Imp]

Because the OnCreation() trigger is specifically designed to run 1 time, and be true only that 1 time. It's false in every time after, so it's skipped ... in all the following run through...

[jastey]

I thought Continue() leads to all script blocks being executed at the same cycle.

Are you saying "OnCreation()" will only give true in the first script block, even though the following one would be executed in the same cycle because of the Continue()?

[Almateria]

Uh, for me OnCreation() was just a very hacky copy of how the game tends to deal with single time happenings in both SoA and ToB starting areas. Changing it is no big deal.

 

IESDP says to use a Continue() after it, tho.

[jastey]

Safest thing would be to change the script block to
  

IF
    !Global("MasteredTheSlayer","GLOBAL",1)
THEN
    RESPONSE #100
        SetGlobal("MasteredTheSlayer","GLOBAL",1)
END

and patch it via EXTEND_BOTTOM. - Or will the variable "MasteredTheSlayer" be set to something different later? (In EET all areas can be revisited so this would lead to the variable being reset to "1", of course.)

In that case, add another check variable, e.g.

IF
Global("Yourprefix_SetMasteredTheSlayer","MYAREA",0)
THEN
RESPONSE #100
SetGlobal("MasteredTheSlayer","GLOBAL",1)
SetGlobal("Yourprefix_SetMasteredTheSlayer","MYAREA",1)
END

(Not that I'd need to tell you this, but I like to make clear what I am referring to.)

Or take the last version, add a Continue() and patch it to TOP.

[Almateria]

and patch it via EXTEND_BOTTOM. - Or will the variable "MasteredTheSlayer" be set to something different later? (In EET all areas can be revisited so this would lead to the variable being reset to "1", of course.)

EET sure is a thing, but a) it's a bit of a pain in the butt to add extra variables for that b) i think that like, with the story explanation of Slayer form being a thing caused by your soul-ripping by Irenicus, it can be assumed that you kinda "mastered" it innately by regaining it.

 

Which would, of course, make the grove trial not doable in ToB, but said trial only changes it so your form change won't cast SLAYER_FEAR on everyone surrounding, including your teammates. (Incidentally, don't use the unmastered slayer change near plot-critical NPCs, cuz that counts as an attack. Elhan, for example, instakills you.)

[Creepin]

Jarno, I don't understand: are you saying that having the first block of the script like that
 

IF
    OnCreation()
THEN
    RESPONSE #100
        blah
        Continue()
END

will prevent second block like that

IF
    OnCreation()
THEN
    RESPONSE #100
        yada
END

from happening? Because if not, there's no reason to not to use two OnCreation's in the adjacent blocks.

[The Imp]

Jarno, I don't understand: are you saying that having the first block of the script like that

No, the exact opposite... but the exact thought is that having a OnCreation() condition in the IF, will prevent all the rest. As there is no NEED to go on.
Aka you would never use a OnCreation() ... if you intend to then use a Continue() ...

[CamDawg]

Jarno, I don't understand: are you saying that having the first block of the script like that

No, the exact opposite... but the exact thought is that having a OnCreation() condition in the IF, will prevent all the rest. As there is no NEED to go on.
Aka you would never use a OnCreation() ... if you intend to then use a Continue() ...

 

While this is the best kind of correct (technically), no one really uses it this way. Most of the time you see the instant triggers (OnCreation, Died, Opened, etc.) it's so you can skip a bounding variable. I'm not sure I've ever seen instant triggers used in the way you suggest to block other instants. Pairing OnCreation with Continue is generally SOP to avoid mods stepping on each other, like here.

 

In general, though, I recommend avoiding the instant triggers anyway as there are numerous ways they can go flaky. You're almost always better served with a different check and a bounding variable.