9 replies to this topic

[Ikki]

For DarkHorizonsBGee

There is a slight lag in some area because of missing ambiant music : some variable are not evaluated and write garbage in the .are file

 

for my game I have commented the line in blue in the tp2, the music are installed by other mod

Spoiler

COPY ~DarkHorizonsBGee\areas\CM2680.are~ ~override~

                READ_LONG  0x54  "actors_offset"

                READ_SHORT 0x58  "actors_num"

REPLACE_TEXTUALLY ~AMB_M35B~ ~%SND1%~

REPLACE_TEXTUALLY ~AMB_M35D~ ~%SND2%~

REPLACE_TEXTUALLY ~AMB_E29A~ ~%SND3%~

COPY ~DarkHorizonsBGee\areas\CM2681.are~ ~override~

REPLACE_TEXTUALLY ~AMB_M35B~ ~%SND1%~

REPLACE_TEXTUALLY ~AMB_M35D~ ~%SND2%~

REPLACE_TEXTUALLY ~AMB_E29A~ ~%SND3%~

COPY ~DarkHorizonsBGee\areas\CM3370.are~ ~override~

REPLACE_TEXTUALLY ~AMB_E15A~ ~%SND4%~

REPLACE_TEXTUALLY ~AMB_E15B~ ~%SND5%~

REPLACE_TEXTUALLY ~AMB_E15C~ ~%SND6%~

REPLACE_TEXTUALLY ~AMB_E15D~ ~%SND7%~

REPLACE_TEXTUALLY ~AMB_S05A~ ~%SND8%~

COPY ~DarkHorizonsBGee\areas\CM3372.are~ ~override~

REPLACE_TEXTUALLY ~AMB_E17B~ ~%SND9%~

COPY ~DarkHorizonsBGee\areas\CM3373.are~ ~override~

REPLACE_TEXTUALLY ~AMB_E29A~ ~%SND3%~

COPY ~DarkHorizonsBGee\areas\CM3376.are~ ~override~

REPLACE_TEXTUALLY ~AMB_E14B~ ~%SND10%~

 

- SPRINT ~item_to_add~ ~%ITM3%~

+ SPRINT ~item_to_add~ ~DAGG02~

[Ikki]

For TDDz, the ambiant music are missing too because the music are not converted to wav

i have added the following line in Setup-TDDz.tp2

Spoiler

BEGIN @901000

                REQUIRE_PREDICATE GAME_IS ~tob bg2ee eet~ ~~

               

                INCLUDE ~%MOD_FOLDER%/Lib/Importer.tpa~

                               LAF ImportComponent STR_VAR aComp = ~CORE~ END

                INCLUDE ~%MOD_FOLDER%/Lib/Helpers.tpa~

                               LAF DeleteTempFolder STR_VAR aComp = ~CORE~ END            

 

LAF HANDLE_AUDIO

  STR_VAR

    audio_path = ~TDD/ogg~ // the audio are from TDD

    oggdec_path = ~TDDz/tools/oggdec~ // the oggdec is from TDDz

END

Edited by Ikki, 05 March 2018 - 01:57 PM.

[Ikki]

I believe i had some crash because of non ASCII character

 

in the english translation of g3anniversary-v9 in setup.tra the   – é …

 

in the mod imoenromance

in imoenRomance\dialogues\SOA\Underdark\InUstNatha.d , the —

in imoenRomance\Setup-ImoenRomance.tp2 the

– Increase Dexterity by 1

– Regenerate 1 HP every 3 seconds

– Improves casting speed by 2

 

in the mod NEJ the  “ ” ’ ‘ é in the baf and tp2

 

I don't know if every of those charater cause a crash but some do

[Ikki]

Tactics2_for_EE-alpha73 has a typo SALAMANDER_ICE doesn't exist , should be SALAMANDER_FROST

Spoiler

eetact2\usr\src\patch\t2sahmod-impsaha.patch

 

+  RESPONSE #10

+    Polymorph(SAHUAGIN)

+    SetGlobalTimer("Change","LOCALS",2)

+    Continue()

+  RESPONSE #10

+    Polymorph(SAHUAGIN_LARGE)

+    SetGlobalTimer("Change","LOCALS",2)

+    Continue()

+  RESPONSE #10

+    Polymorph(SALAMANDER_FIRE)

+    SetGlobalTimer("Change","LOCALS",2)

+    Continue()

+  RESPONSE #10

+    Polymorph(SALAMANDER_ICE)

+    SetGlobalTimer("Change","LOCALS",2)

+    Continue()

 

+    Polymorph(SALAMANDER_FROST)

 

and Tactics2_for_EE-alpha73 crash with the foreign translation because it doesn't convert the charset to UTF8

[Roxanne]

For TDDz, the ambiant music are missing too because the music are not converted to wav

i have added the following line in Setup-TDDz.tp2

Spoiler

BEGIN @901000

                REQUIRE_PREDICATE GAME_IS ~tob bg2ee eet~ ~~

               

                INCLUDE ~%MOD_FOLDER%/Lib/Importer.tpa~

                               LAF ImportComponent STR_VAR aComp = ~CORE~ END

                INCLUDE ~%MOD_FOLDER%/Lib/Helpers.tpa~

                               LAF DeleteTempFolder STR_VAR aComp = ~CORE~ END            

 

LAF HANDLE_AUDIO

  STR_VAR

    audio_path = ~TDD/ogg~ // the audio are from TDD

    oggdec_path = ~TDDz/tools/oggdec~ // the oggdec is from TDDz

END

That one is added here https://github.com/B...rldProject/TDDz

 

What is your expectations for the other reports? Should that not be reported to the modders or maintainers?

Edited by Roxanne, 05 March 2018 - 02:16 PM.

[Ikki]

i have installed some component of lolfixer on EET

 

one sub component of "MAJESTIC Item Fixer" (the Placeholder Icon Assigner) remove erroneously the icon of  some item

the component  "MAJESTIC Area Fixer" crash fixing the area OH9360.ARE

[Ikki]

That one is added here https://github.com/B...rldProject/TDDz

 cool

What is your expectations for the other reports? Should that not be reported to the modders or maintainers?

no expectation, I have done those fix for myself, so if someone is experiencing some of those problems, maybe he will find the solution he his looking at

and maybe a modder, like you did, will use those report

[Roxanne]

i have installed some component of lolfixer on EET

 

one sub component of "MAJESTIC Item Fixer" (the Placeholder Icon Assigner) remove erroneously the icon of  some item

the component  "MAJESTIC Area Fixer" crash fixing the area OH9360.ARE

Can you provide some detail about this so it can be corrected in BWFixpack?

Edited by Roxanne, 06 March 2018 - 11:52 AM.

[Ikki]

for the "MAJESTIC Item Fixer" I have commented the part dealing with Placeholder Icon Assigner

Spoiler

// Placeholder Icon Assigner


// READ_SHORT 0x1c "type"
// READ_ASCII 0x3a "inv_icon"
// READ_ASCII 0x44 "gnd_icon"
// READ_ASCII 0x58 "desc_icon"
// SET "inv_exists" = 0
// SET "gnd_exists" = 0
// SET "desc_exists" = 0

// PATCH_IF FILE_EXISTS_IN_GAME ~%inv_icon%.bam~ BEGIN
// SET "inv_exists" = 1
// END
// PATCH_IF FILE_EXISTS_IN_GAME ~%gnd_icon%.bam~ BEGIN
// SET "gnd_exists" = 1
// END
// PATCH_IF FILE_EXISTS_IN_GAME ~%desc_icon%.bam~ BEGIN
// SET "desc_exists" = 1
// END

// PATCH_IF ("%inv_exists%" = 0) BEGIN
// PATCH_IF ("%inv_icon%" STRING_EQUAL_CASE "none") OR ("%inv_icon%" STRING_EQUAL_CASE "") BEGIN
// PATCH_PRINT "%SOURCE_FILE% issue: Unassigned Inventory Icon! Assigning placeholder icon..."
// END ELSE
// BEGIN
// PATCH_PRINT "%SOURCE_FILE% issue: Non-existent Inventory Icon (%inv_icon%.BAM)! Assigning placeholder icon..."
// END
// WRITE_ASCII 0x3a ~IMISC6V~ #8
// END
// PATCH_IF ("%gnd_exists%" = 0) BEGIN
// PATCH_IF ("%gnd_icon%" STRING_EQUAL_CASE "GCLCKC01") BEGIN
// PATCH_PRINT "%SOURCE_FILE% issue: Non-existent Ground Icon (%gnd_icon%.BAM)! Assigning GCLCK01.BAM..."
// WRITE_ASCII 0x44 ~GCLCK01~ #8
// END ELSE
// PATCH_IF ("%gnd_icon%" STRING_EQUAL_CASE "_GPOTN01") OR
// ("%gnd_icon%" STRING_EQUAL_CASE "GPOTN11") OR
// ("%gnd_icon%" STRING_EQUAL_CASE "GPOTN41") OR
// ("%gnd_icon%" STRING_EQUAL_CASE "PTION2KG") OR
// ("%gnd_icon%" STRING_EQUAL_CASE "PTION2LG") OR
// ("%gnd_icon%" STRING_EQUAL_CASE "PTION2MG") BEGIN
// PATCH_PRINT "%SOURCE_FILE% issue: Non-existent Ground Icon (%gnd_icon%.BAM)! Assigning GPOTN01.BAM..."
// WRITE_ASCII 0x44 ~GPOTN01~ #8
// END ELSE
// PATCH_IF ("%gnd_icon%" STRING_EQUAL_CASE "ICRATE01") BEGIN
// PATCH_PRINT "%SOURCE_FILE% issue: Non-existent Ground Icon (%gnd_icon%.BAM)! Assigning GCRATE01.BAM..."
// WRITE_ASCII 0x44 ~GCRATE01~ #8
// END ELSE
// PATCH_IF ("%gnd_icon%" STRING_EQUAL_CASE "none") OR ("%gnd_icon%" STRING_EQUAL_CASE "") BEGIN
// PATCH_PRINT "%SOURCE_FILE% issue: Unassigned Ground Icon! Assigning placeholder icon..."
// WRITE_ASCII 0x44 ~GCRATE01~ #8
// END ELSE
// BEGIN
// PATCH_PRINT "%SOURCE_FILE% issue: Non-existent Ground Icon (%gnd_icon%.BAM)! Assigning placeholder icon..."
// WRITE_ASCII 0x44 ~GCRATE01~ #8
// END
// END
// PATCH_IF ("%desc_exists%" = 0) BEGIN
// PATCH_IF ("%desc_icon%" STRING_EQUAL_CASE "none") OR ("%desc_icon%" STRING_EQUAL_CASE "") BEGIN
// PATCH_PRINT "%SOURCE_FILE% issue: Unassigned Description Icon! Assigning placeholder icon..."
// END ELSE
// BEGIN
// PATCH_PRINT "%SOURCE_FILE% issue: Non-existent Description Icon (%desc_icon%.BAM)! Assigning placeholder icon..."
// END
// WRITE_ASCII 0x58 ~CMISC6V~ #8
// END

and for the "MAJESTIC Area Fixer" i moved the area OH9360.ARE outside of the override folder before installing lolfixer

Edited by Ikki, 06 March 2018 - 02:08 PM.

[Roxanne]

for the "MAJESTIC Item Fixer" I have commented the part dealing with Placeholder Icon Assigner

Spoiler

// Placeholder Icon Assigner


// READ_SHORT 0x1c "type"
// READ_ASCII 0x3a "inv_icon"
// READ_ASCII 0x44 "gnd_icon"
// READ_ASCII 0x58 "desc_icon"
// SET "inv_exists" = 0
// SET "gnd_exists" = 0
// SET "desc_exists" = 0

// PATCH_IF FILE_EXISTS_IN_GAME ~%inv_icon%.bam~ BEGIN
// SET "inv_exists" = 1
// END
// PATCH_IF FILE_EXISTS_IN_GAME ~%gnd_icon%.bam~ BEGIN
// SET "gnd_exists" = 1
// END
// PATCH_IF FILE_EXISTS_IN_GAME ~%desc_icon%.bam~ BEGIN
// SET "desc_exists" = 1
// END

// PATCH_IF ("%inv_exists%" = 0) BEGIN
// PATCH_IF ("%inv_icon%" STRING_EQUAL_CASE "none") OR ("%inv_icon%" STRING_EQUAL_CASE "") BEGIN
// PATCH_PRINT "%SOURCE_FILE% issue: Unassigned Inventory Icon! Assigning placeholder icon..."
// END ELSE
// BEGIN
// PATCH_PRINT "%SOURCE_FILE% issue: Non-existent Inventory Icon (%inv_icon%.BAM)! Assigning placeholder icon..."
// END
// WRITE_ASCII 0x3a ~IMISC6V~ #8
// END
// PATCH_IF ("%gnd_exists%" = 0) BEGIN
// PATCH_IF ("%gnd_icon%" STRING_EQUAL_CASE "GCLCKC01") BEGIN
// PATCH_PRINT "%SOURCE_FILE% issue: Non-existent Ground Icon (%gnd_icon%.BAM)! Assigning GCLCK01.BAM..."
// WRITE_ASCII 0x44 ~GCLCK01~ #8
// END ELSE
// PATCH_IF ("%gnd_icon%" STRING_EQUAL_CASE "_GPOTN01") OR
// ("%gnd_icon%" STRING_EQUAL_CASE "GPOTN11") OR
// ("%gnd_icon%" STRING_EQUAL_CASE "GPOTN41") OR
// ("%gnd_icon%" STRING_EQUAL_CASE "PTION2KG") OR
// ("%gnd_icon%" STRING_EQUAL_CASE "PTION2LG") OR
// ("%gnd_icon%" STRING_EQUAL_CASE "PTION2MG") BEGIN
// PATCH_PRINT "%SOURCE_FILE% issue: Non-existent Ground Icon (%gnd_icon%.BAM)! Assigning GPOTN01.BAM..."
// WRITE_ASCII 0x44 ~GPOTN01~ #8
// END ELSE
// PATCH_IF ("%gnd_icon%" STRING_EQUAL_CASE "ICRATE01") BEGIN
// PATCH_PRINT "%SOURCE_FILE% issue: Non-existent Ground Icon (%gnd_icon%.BAM)! Assigning GCRATE01.BAM..."
// WRITE_ASCII 0x44 ~GCRATE01~ #8
// END ELSE
// PATCH_IF ("%gnd_icon%" STRING_EQUAL_CASE "none") OR ("%gnd_icon%" STRING_EQUAL_CASE "") BEGIN
// PATCH_PRINT "%SOURCE_FILE% issue: Unassigned Ground Icon! Assigning placeholder icon..."
// WRITE_ASCII 0x44 ~GCRATE01~ #8
// END ELSE
// BEGIN
// PATCH_PRINT "%SOURCE_FILE% issue: Non-existent Ground Icon (%gnd_icon%.BAM)! Assigning placeholder icon..."
// WRITE_ASCII 0x44 ~GCRATE01~ #8
// END
// END
// PATCH_IF ("%desc_exists%" = 0) BEGIN
// PATCH_IF ("%desc_icon%" STRING_EQUAL_CASE "none") OR ("%desc_icon%" STRING_EQUAL_CASE "") BEGIN
// PATCH_PRINT "%SOURCE_FILE% issue: Unassigned Description Icon! Assigning placeholder icon..."
// END ELSE
// BEGIN
// PATCH_PRINT "%SOURCE_FILE% issue: Non-existent Description Icon (%desc_icon%.BAM)! Assigning placeholder icon..."
// END
// WRITE_ASCII 0x58 ~CMISC6V~ #8
// END

and for the "MAJESTIC Area Fixer" i moved the area OH9360.ARE outside of the override folder before installing lolfixer

I agree with the icon assigner. I even remember there were already issues discussed with Lollorian a while ago on this topic.

 

For the OH9360 issue - I put this into the tp2

 

 

ACTION_IF FILE_EXISTS_IN_GAME ~OH9360.ARE~ THEN BEGIN
COPY_EXISTING ~OH9360.ARE~ ~BWS_workspace~
END


(run lolfiixer)


ACTION_IF FILE_EXISTS ~BWS_workspace/OH9360.ARE~ THEN BEGIN
COPY ~BWS_workspace/OH9360.ARE~ ~override~
END

 

 

Thanks for the detail.

Edited by Roxanne, 06 March 2018 - 02:41 PM.