Ok, I think I know how to prevent this situation automatically without case by case fixes. The old implementation didn't take into account that particular mod can use the same JOIN dialogue file for both BG1 and BG2 portion of the story etc. I've coded new rules for situations like this.
Rules for PIDs in BG1 version of JOIN file (that comes from BGDIALOG.2DA):
- if SoD or BG2 or ToB JOIN file is present add ~Global("EndofBG1","GLOBAL",0)~
Rules for PIDs in SOD version of JOIN file (that comes from BDDIALOG.2DA):
- if BG1 JOIN file is present add ~Global("EndofBG1","GLOBAL",1)~
- if BG2 or ToB JOIN files are present also add ~GlobalLT("CHAPTER","GLOBAL",13)~
Rules for PIDs in BG2 version of JOIN file (that comes from PDIALOG.2DA - only SoA files):
- if BG1 or SoD JOIN files are present add ~GlobalLT("CHAPTER","GLOBAL",20)~
- if ToB JOIN file is present also add ~GlobalLT("CHAPTER","GLOBAL",20)~
Rules for PIDs in ToB version of JOIN file (that comes from PDIALOG.2DA - only ToB files):
- if BG1 or SoD or BG2 JOIN files are present add ~GlobalGT("CHAPTER","GLOBAL",19)~
The same file being referenced in multiple 2da files should also not foul the patcher.
----------------
In your code theretically the new automatic PID patching code should do this:
- PIDs that comes from BG1, SoD and BG2 will be patched with this: ~GlobalLT("CHAPTER","GLOBAL",20)~
- PIDs that comes from ToB will be patched with this: ~GlobalGT("CHAPTER","GLOBAL",19)~
These triggers will be usless in your case since you already filter PIDs properly yourself, but both of these changes will be completly harmless for your content (they won't block your dialogues).
I need to test it before pushing new release and your mod would be a good candidate. Could you please uninstall both your fix + setup-eet_end and than upload CVSandrJ.DLG and CVSan25J.DLG here?
Edited by K4thos, 28 June 2017 - 05:27 PM.