24 replies to this topic

[vanatos]

Hi i am the maintainer (coder) of the Imoen Romance Mod.

 

Tashia has a conflict with the Imoen Romance mod.

 

I tracked down the issue, the modification of finsol01 state 28 is the problem.

 

In the tashi25j. there is this line of code.

 

Tashia Code

 

REPLACE FINSOL01

  IF ~~ THEN BEGIN 28

    SAY @39

    IF ~Global("TashiaRomanceActive","GLOBAL",2)~ THEN EXTERN tashi25j rom1

    IF ~!Global("TashiaRomanceActive","GLOBAL",2)~ THEN EXTERN FINSOL01 TashiaAdd1

  END

END

 

this replaces the Vanilla dialogue state in the retail code.

 

Retail Code

IF ~~ THEN BEGIN 28 // from: 27.0

  SAY #67885 /* ~The time has come to make your choice, Bhaalspawn. What is your wish?~ [SOLAR102] */

  IF ~GlobalLT("PPEvilChoices","GLOBAL",2)

~ THEN REPLY #68063 /* ~I will retain the essence of Bhaal that is my right and become a power of the planes.~ */ DO ~SetGlobal("PlayerChoseEssence","GLOBAL",1)

~ GOTO 31

  IF ~GlobalGT("PPEvilChoices","GLOBAL",1)

GlobalLT("PPEvilChoices","GLOBAL",4)

~ THEN REPLY #68064 /* ~I will retain the essence of Bhaal that is my right and become a power of the planes.~ */ DO ~SetGlobal("PlayerChoseEssence","GLOBAL",1)

~ GOTO 30

  IF ~GlobalGT("PPEvilChoices","GLOBAL",3)

GlobalLT("PPEvilChoices","GLOBAL",6)

~ THEN REPLY #68065 /* ~I will retain the essence of Bhaal that is my right and become a power of the planes.~ */ DO ~SetGlobal("PlayerChoseEssence","GLOBAL",1)

~ GOTO 29

  IF ~~ THEN REPLY #68066 /* ~I do not want the essence of Bhaal. Do what you will with it... I want to remain mortal.~ */ GOTO 32

END

 

 

As you can see the transitions have been removed so there is only 2 instead of 4.

 

So any mod that tries to modify the original transitions will cause an error.

 

Edited by vanatos, 01 January 2016 - 02:38 PM.

[Roxanne]

Hi i am the maintainer (coder) of the Imoen Romance Mod.

 

Tashia has a conflict with the Imoen Romance mod.

 

I tracked down the issue, the modification of finsol01 state 28 is the problem.

 

In the tashi25j. there is this line of code.

 

Tashia Code

 

REPLACE FINSOL01

  IF ~~ THEN BEGIN 28

    SAY @39

    IF ~Global("TashiaRomanceActive","GLOBAL",2)~ THEN EXTERN tashi25j rom1

    IF ~!Global("TashiaRomanceActive","GLOBAL",2)~ THEN EXTERN FINSOL01 TashiaAdd1

  END

END

 

this replaces the Vanilla dialogue state in the retail code.

 

Retail Code

IF ~~ THEN BEGIN 28 // from: 27.0

  SAY #67885 /* ~The time has come to make your choice, Bhaalspawn. What is your wish?~ [SOLAR102] */

  IF ~GlobalLT("PPEvilChoices","GLOBAL",2)

~ THEN REPLY #68063 /* ~I will retain the essence of Bhaal that is my right and become a power of the planes.~ */ DO ~SetGlobal("PlayerChoseEssence","GLOBAL",1)

~ GOTO 31

  IF ~GlobalGT("PPEvilChoices","GLOBAL",1)

GlobalLT("PPEvilChoices","GLOBAL",4)

~ THEN REPLY #68064 /* ~I will retain the essence of Bhaal that is my right and become a power of the planes.~ */ DO ~SetGlobal("PlayerChoseEssence","GLOBAL",1)

~ GOTO 30

  IF ~GlobalGT("PPEvilChoices","GLOBAL",3)

GlobalLT("PPEvilChoices","GLOBAL",6)

~ THEN REPLY #68065 /* ~I will retain the essence of Bhaal that is my right and become a power of the planes.~ */ DO ~SetGlobal("PlayerChoseEssence","GLOBAL",1)

~ GOTO 29

  IF ~~ THEN REPLY #68066 /* ~I do not want the essence of Bhaal. Do what you will with it... I want to remain mortal.~ */ GOTO 32

END

 

 

As you can see the transitions have been removed so there is only 2 instead of 4.

 

So any mod that tries to modify the original transitions will cause an error.

 

This is a bit more than just a conflict with Imoen, especially since it does not even check for Tashia to be present so the first transition kills the game if Tashia is not in party - what happens otherwise cannot be determined on this information (needs to check what those two EXTERN contain)

[agb1]

setup-tashia.tp2 contains:

 

COMPILE ~tashia/Dialogues/tashi25j.d~

  USING ~tashia/%s/tashi25j.tra~

 

Attached is tashi25j.d and tashi25j.tra.

 

I also found a tashi25j.d.rej in my tashia\dialogues\ folder, which I think is a failed Fixpack patch:

 

Spoiler

 ***************

*** 167,173 ****

  REPLACE FINSOL01

    IF ~~ THEN BEGIN 28

      SAY @39

-     IF ~Global("TashiaRomanceActive","GLOBAL",2)~ THEN EXTERN tashi25j rom1

      IF ~!Global("TashiaRomanceActive","GLOBAL",2)~ THEN EXTERN FINSOL01 TashiaAdd1

    END

  END

--- 167,174 ----

  REPLACE FINSOL01

    IF ~~ THEN BEGIN 28

      SAY @39

+     IF ~IsValidForPartyDialogue("Tashia")

+ Global("TashiaRomanceActive","GLOBAL",2)~ THEN EXTERN tashi25j rom1

      IF ~!Global("TashiaRomanceActive","GLOBAL",2)~ THEN EXTERN FINSOL01 TashiaAdd1

    END

  END

Attached Files

•  tashi25j.d   4K   444 downloads
•  tashi25j.tra   3.95K   430 downloads

[Roxanne]

setup-tashia.tp2 contains:

 

COMPILE ~tashia/Dialogues/tashi25j.d~

  USING ~tashia/%s/tashi25j.tra~

 

Attached is tashi25j.d and tashi25j.tra.

 

I also found a tashi25j.d.rej in my tashia\dialogues\ folder, which I think is a failed Fixpack patch:

 

Spoiler

 ***************

*** 167,173 ****

  REPLACE FINSOL01

    IF ~~ THEN BEGIN 28

      SAY @39

-     IF ~Global("TashiaRomanceActive","GLOBAL",2)~ THEN EXTERN tashi25j rom1

      IF ~!Global("TashiaRomanceActive","GLOBAL",2)~ THEN EXTERN FINSOL01 TashiaAdd1

    END

  END

--- 167,174 ----

  REPLACE FINSOL01

    IF ~~ THEN BEGIN 28

      SAY @39

+     IF ~IsValidForPartyDialogue("Tashia")

+ Global("TashiaRomanceActive","GLOBAL",2)~ THEN EXTERN tashi25j rom1

      IF ~!Global("TashiaRomanceActive","GLOBAL",2)~ THEN EXTERN FINSOL01 TashiaAdd1

    END

  END

So the first response now contains the check for Tashia

The second does not need it as it just adds a line to Finsol

however both lead (COPY_TRANS) back into Finsol01 state28 probably with the intention to continue from there, but the 4 remaining transitions are removed by the same code. So it fails.

The REPLACE should be rather EXTEND_BOTTOM and reworked.

Edited by Roxanne, 04 January 2016 - 03:10 PM.

[agb1]

Bri and Lord Ernie haven't been active on these forums in over a year.  According to the Tashia readme, it is "an 'open-mod' and subject to further change [by] all."  Is anyone knowledgeable willing to rework this code into a more compatible form?

[Roxanne]

Bri and Lord Ernie haven't been active on these forums in over a year.  According to the Tashia readme, it is "an 'open-mod' and subject to further change [by] all."  Is anyone knowledgeable willing to rework this code into a more compatible form?

I have made an attempt. It only revises the .d file using the unchanged dialogues from the tra. It covers the case of Tashia's romance beeing active or not, It checks for Tashia's presence at Final. I think it fully catches the author's initial intention.

I tested it only by install and it works, provided that Ascension is installed (if not a condition for Tashia ToB in BWS already, it should be added.)

Somebody needs to test it in the game however, I cannot because I avoided installing Tashia (causing same problem for my Sandrah as for Imoen),

 

 tashi25j_Revised.d   4K   509 downloads

 

This file needs to be renamed and replaces the original in the mod,

Edited by Roxanne, 05 January 2016 - 12:01 AM.

[agb1]

Is this revised dialogue compatible with Sandrah?

[Roxanne]

Is this revised dialogue compatible with Sandrah?

It should be generic, i.e. not have any issue with any other mod.

[agb1]

Thanks Roxanne. Your contribution is greatly appreciated!

[Lollorian]

I have a patch ready but before I put it up... why require Ascension?

[Roxanne]

I have a patch ready but before I put it up... why require Ascension?

Sorry, my mistake. The revised dialogue should work with vanilla ToB. But you should not publish it without someone having tested it before - like I pointed out, I could only see that it compiles without error and is correct via NI, I have no option to test it in the game.

[Lollorian]

Agreed

[agb1]

Yes, it will be possible to patch your game.  We'll have to restore a version of the finsol01.dlg that doesn't have the changes from Tashia.  Run a WeiDU --change-log on finsol01.dlg so we can see which other mods tweaked it.  Then upload a copy of finsol01.dlg from your generalized_biffing\prod\0\??? folder (??? varies from install to install so search for finsol01.dlg in all of the subfolders there).

[Roxanne]

Open Finsol01.dlg in your NI editor

Switch to editing mode

Go to the line that has *Response Trigger 89* and select it

In the preview box at the bottom you will see *!Global("TashiaRomanceActive","GLOBAL",2)*

Enter in the empty line below that

IfValidForPartyDialogue("Tashia")

Click *Update* in the box below that window

Click *Save* in the bottom menu

[Roxanne]

Just a short remark to those issues with Finsol01.dlg

It is the last dialogue in the normal game. The game is at its end. You may do your final decision but that really has no consequence because the game is over. All you loose from issues here are the final NPC bios (telling you what became of your friends in further life) and the end credits. Nice to have, cosmetics...maybe a feeling that the end is incomplete.

 

You do not have a mod installed that takes any consequences out of the decision you give to the Solar in the end, so it does not matter that much.