4 replies to this topic

[jastey]

Fixpack 15.1.1 is changing Gavin BG1 tp2 for version ~v9 beta_150317~.
 
This was a beta version from March this year. It was public, and I was asking for bug reports to fix them for the official release of v9.
 
WHY is Fixpack meddling with this, instead of giving me a call so I can account for the needed fixes in the mod itself?
 
 
 
While we are at it, help me understand what the fixes actually do.
 
What does this do?
 

@@ -253,6 +257,7 @@
 END

And why is the lib/b!ids.tph provided?

[Leonardo Watson]

The fix is there for about two years and it is well documented in the fixpack/_BWP fixes.txt


lib/b!ids.tph includes ~0x0000 BARBARIAN~ and ~0x0000 WILDMAGE~ instead of ~0x40000000 BARBARIAN~ and ~0x80000000 WILDMAGE~
Files with an exclamation mark "!" in the filename cannot be corrected by patch (This is a wellknown bug in the batch file language that Microsoft never corrects) so the only way is to replace them.

[The Imp]

Erhm, by the way, instead of this:

 

COPY_EXISTING ~kit.ids~ ~override~
  REPLACE_TEXTUALLY ~.*\bTRUECLASS\b~              ~0x4000 TRUECLASS~
  REPLACE_TEXTUALLY ~.*\bBERSERKER\b~              ~0x4001 BERSERKER~
  REPLACE_TEXTUALLY ~.*\bWIZARDSLAYER\b~           ~0x4002 WIZARDSLAYER~
  REPLACE_TEXTUALLY ~.*\bKENSAI\b~                 ~0x4003 KENSAI~
  REPLACE_TEXTUALLY ~.*\bCAVALIER\b~               ~0x4004 CAVALIER~
  REPLACE_TEXTUALLY ~.*\bINQUISITOR\b~             ~0x4005 INQUISITOR~
  REPLACE_TEXTUALLY ~.*\bUNDEADHUNTER\b~           ~0x4006 UNDEADHUNTER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_ABJURER\b~     ~0x0040 MAGESCHOOL_ABJURER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_CONJURER\b~    ~0x0080 MAGESCHOOL_CONJURER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_DIVINER\b~     ~0x0100 MAGESCHOOL_DIVINER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_ENCHANTER\b~   ~0x0200 MAGESCHOOL_ENCHANTER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_ILLUSIONIST\b~ ~0x0400 MAGESCHOOL_ILLUSIONIST~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_INVOKER\b~     ~0x0800 MAGESCHOOL_INVOKER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_NECROMANCER\b~ ~0x1000 MAGESCHOOL_NECROMANCER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_TRANSMUTER\b~  ~0x2000 MAGESCHOOL_TRANSMUTER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_GENERALIST\b~  ~0x4000 MAGESCHOOL_GENERALIST~
  REPLACE_TEXTUALLY ~.*\bFERALAN\b~                ~0x4007 FERALAN~
  REPLACE_TEXTUALLY ~.*\bSTALKER\b~                ~0x4008 STALKER~
  REPLACE_TEXTUALLY ~.*\bBEASTMASTER\b~            ~0x4009 BEASTMASTER~
  REPLACE_TEXTUALLY ~.*\bASSASIN\b~                ~0x400A ASSASIN~
  REPLACE_TEXTUALLY ~.*\bBOUNTYHUNTER\b~           ~0x400B BOUNTYHUNTER~
  REPLACE_TEXTUALLY ~.*\bSWASHBUCKLER\b~           ~0x400C SWASHBUCKLER~
  REPLACE_TEXTUALLY ~.*\bBLADE\b~                  ~0x400D BLADE~
  REPLACE_TEXTUALLY ~.*\bJESTER\b~                 ~0x400E JESTER~
  REPLACE_TEXTUALLY ~.*\bSKALD\b~                  ~0x400F SKALD~
  REPLACE_TEXTUALLY ~.*\bGODTALOS\b~               ~0x4013 GODTALOS~
  REPLACE_TEXTUALLY ~.*\bGODHELM\b~                ~0x4014 GODHELM~
  REPLACE_TEXTUALLY ~.*\bGODLATHANDER\b~           ~0x4015 GODLATHANDER~
  REPLACE_TEXTUALLY ~.*\bTOTEMIC\b~                ~0x4010 TOTEMIC~
  REPLACE_TEXTUALLY ~.*\bSHAPESHIFTER\b~           ~0x4011 SHAPESHIFTER~
  REPLACE_TEXTUALLY ~.*\bBEASTFRIEND\b~            ~0x4012 BEASTFRIEND~
  REPLACE_TEXTUALLY ~.*\bBARBARIAN\b~              ~0x0000 BARBARIAN~
  REPLACE_TEXTUALLY ~.*\bWILDMAGE\b~               ~0x0000 WILDMAGE~
  BUT_ONLY_IF_IT_CHANGES

APPEND ~kit.ids~ ~0x4000 TRUECLASS~
  UNLESS ~\bTRUECLASS\b~
APPEND ~kit.ids~ ~0x0000 BARBARIAN~
  UNLESS ~\bBARBARIAN\b~
APPEND ~kit.ids~ ~0x0000 WILDMAGE~
  UNLESS ~\bWILDMAGE\b~

You should use this:

COPY_EXISTING ~kit.ids~ ~override~
  REPLACE_TEXTUALLY ~0x0000 BARBARIAN~			  ~0x40000000 BARBARIAN~
  REPLACE_TEXTUALLY ~0x0000 WILDMAGE~			   ~0x80000000 WILDMAGE~
BUT_ONLY

CLEAR_INLINED

APPEND ~kit.ids~ ~0x4000 TRUECLASS~ UNLESS ~\bTRUECLASS\b~
APPEND ~kit.ids~ ~0x40000000 BARBARIAN~ UNLESS ~\bBARBARIAN\b~
APPEND ~kit.ids~ ~0x80000000 WILDMAGE~ UNLESS ~\bWILDMAGE\b~

You shouldn't use code like this:

REPLACE_TEXTUALLY ~.*\bBLADE\b~                 ~0x400D BLADE~

Because it eats the all the lines that have the BLADE as a part of it... say like "k9_blade" or what ever it was... for one of the blademasters.

[jastey]

The fix is there for about two years and it is well documented in the fixpack/_BWP fixes.txt

Well, someone obviously ubdated the entry to my beta mod version from 3 month ago, so I am curious why it wasn't possible to inform me about it. Although curious is not the exact phrase. I feel offended having the impression that the Fixpack maintainers really don't give a damn about trying to get the fixes into the actual mods, and knowing there will be new changes in the future with me having to check the Fixpack to find them.

 

It is frustrating to see how my effort to get a mod bug free and up-to-date is not being supported.

[The Imp]

Well, someone obviously updated the entry to my beta mod version from 3 month ago, so I am curious why it wasn't possible to inform me about it.

That, hmm, might have been Leonardo W... himself if that was actually even done, that is if the previous fix wasn't happening, and it was still needed... see the above code I wrote is from a fix of mine a some time ago to Refinements, it was also reported to be an issue in Level 1 NPCs, Aurora mod and several others mods 3 years ago when the fix was first made in the ToBEx, by other people. Remembering which you have reported and which you have not is actually a huge pain in the buttocks.
Yeah, see it's easier to update the fixes that remind everyone that it's still needed in several places ... as you might not have the opportunity to do so everywhere ... and Leonardo is usually pretty quiet about what he is doing anyways.

It is frustrating to see how my effort to get a mod bug free and up-to-date is not being supported.

I understand and some of us try, our very best. But we need Lollorian back.

Edited by The Imp, 18 June 2015 - 11:08 AM.