136 replies to this topic

[Argent77]

Update: Afaaq, the Djinni Companion v2.2a

Changes in v2.2a:

• Fixed missing string references in the BG2 Light Version.

Changes in v2.2:

• Added preliminary EET support.
• Added a new interjection to the Genie dialog in "Unfinished Business -> Kalah and What He Was Promised".
• Nerfed Afaaq's level progression in IWD:EE since you encounter him on much lower character levels as in BG2.
• Revised battles in the IWD:EE version. Made second battle less difficult and increased challenge of final battle.
• Added a proper introduction talk to IWD:EE version of Afaaq.
• Fixed a few historical inconsistencies in the IWD:EE version.
• Fixed an issue (again) which sometimes prevents the party to leave the current area if the djinni returned into his lamp.
• Fixed a small issue of displaying uninitialized stats when talking to Afaaq's lamp under certain circumstances.
• Fixed incorrect WAV references in Afaaq's lamp interior map in the IWD:EE version which caused the game to crash.
• Worked around an installation issue on tolowered games on Linux.
• Added a note to the Readme that djinns are immune to healing spells cast on them in IWD:EE.
• Updated the compatibility section of the Readme.

[Roxanne]

Encountered problem in EET Smuggler's cave

 

I have v2.2 installed in my EET test installation. I have not met the Djinni ever....but that is another story...

 

I encountered CtDs when entering AR5504 in ToB.

After much research and after eliminating anything else as a reason I found the issue in the ar5504.bcs.

 

When I removed the code that is added by your ar5504_top.baf, the problem was resolved.

 

Edit

I assume the problem is this in the first block

 FadeToColor([1.0], 0)

 

I always use

FadeToColor([30.0],0)
;;;;;;;
FadeFromColor([30.0],0)

Edited by Roxanne, 16 March 2016 - 12:52 PM.

[Argent77]

I never had any problems with this value in FadeToColor (neither in vBG2 nor in BG2EE) and I require an instant fade to black in that situation. I have rather thought the Activate/Deactivate or MoveGlobalObject actions would have caused some trouble.

The code in the AR5504.BCS is somewhat tricky to work with, however. I tried to make it compatible with vanilla ToB and Wheels of Prophecy. It may produce unpredictable results if other mods rewrite relevant portions of the script.

Can you show me the script before it was modified by my mod?
 

Edited by Argent77, 16 March 2016 - 01:15 PM.

[Roxanne]

I never had any problems with this value in FadeToColor (neither in vBG2 nor in BG2EE) and I require an instant fade to black in that situation. I have rather thought the Activate/Deactivate or MoveGlobalObject actions would have caused some trouble.

The code in the AR5504.BCS is somewhat tricky to work with, however. I tried to make it compatible with vanilla ToB and Wheels of Prophecy. It may produce unpredictable results if other mods rewrite relevant portions of the script.

Can you show me the script before it was modified by my mod?

The fade was just an assumption (I could not test it, since I deleted that block) This is how the BCS looks now, no idea what it was before your mod, I just installed Afaaq in the sequence proposed for EET, so I have no idea which mod added what to this area script.

Spoiler

IF
Global("RZAR5504","GLOBAL",0)
THEN
RESPONSE #100
SetGlobal("RZAR5504","GLOBAL",1)
Continue()
END

 

YOUR CODE WAS HERE

IF
OnCreation()
Global("MONKSPAWNEDSMUGGLERPLOT","GLOBAL",2)
Global("FADEDIN","MYAREA",0)
!Global("Enclave","GLOBAL",2)
THEN
RESPONSE #100
FadeToColor([1.0],0)
Wait(2)
FadeFromColor([30.0],0)
SetGlobal("FADEDIN","MYAREA",1)
END

IF
GlobalGT("A7Quest5","GLOBAL",1)
GlobalLT("CaveEnter","AR5504",2)
THEN
RESPONSE #100
IncrementGlobal("CaveEnter","AR5504",1)
END

IF
GlobalGT("A7Quest5","GLOBAL",1)
Global("MONKSPAWNEDSMUGGLERPLOT","GLOBAL",0)
!Global("Enclave","GLOBAL",2)
OR(2)
Allegiance("AMCARRAS",ENEMY)
Dead("AMCARRAS")
THEN
RESPONSE #100
SetGlobal("MONKSPAWNEDSMUGGLERPLOT","GLOBAL",1)
END

IF
GlobalGT("A7Quest5","GLOBAL",1)
Global("MONKSPAWNEDSMUGGLERPLOT","GLOBAL",0)
Global("CaveEnter","AR5504",2)
!Dead("amcarras")
!Allegiance("amcarras",ENEMY)
!HPPercentLT("amcarras",100)
!Global("Enclave","GLOBAL",2)
THEN
RESPONSE #100
CreateCreature("AMMONK02",[682.1034],S) // Monk
CreateCreature("AMMONK04",[541.1021],S) // Monk
CreateCreature("AMMONK05",[559.951],S) // Monk
CreateCreature("AMMONK06",[659.931],S) // Monk
ActionOverride("AMMONK02",FaceObject("AMCARRAS"))
ActionOverride("AMMONK04",FaceObject("AMCARRAS"))
ActionOverride("AMMONK05",FaceObject("AMCARRAS"))
ActionOverride("AMMONK06",FaceObject("AMCARRAS"))
SetGlobal("MONKSPAWNEDSMUGGLERPLOT","GLOBAL",1)
END

IF
Global("Enclave","GLOBAL",2)
Global("SaemonLeave","GLOBAL",0)
Global("PlaceBodies","AR5504",0)
!Dead("amsaemon")
THEN
RESPONSE #100
FadeToColor([20.0],0)
Wait(1)
CreateCreature("AMSAEMON",[861.942],SW) // Saemon Havarian
CreateCreature("DEDSMUG",[527.817],S) // Smuggler
CreateCreature("DEDSMUG",[900.724],E) // Smuggler
CreateCreature("DEDSMUG",[882.1041],SWW) // Smuggler
CreateCreature("DEDSMUG",[669.1002],S) // Smuggler
CreateCreature("DEDSMUG",[802.450],NW) // Smuggler
Wait(1)
FadeFromColor([20.0],0)
Wait(1)
SetGlobal("PlaceBodies","AR5504",1)
END

IF
Global("A7Q5Intro","AR5504",0)
Global("A7Quest5","GLOBAL",0)
Global("A7Q5AfaaqAppears","GLOBAL",0)
Global("A7AfaaqEnslaved","GLOBAL",0)
Global("A7AfaaqSummoned","GLOBAL",0)
PartyHasItem("A7DJLMPA") // Djinni lamp
!Global("Enclave","GLOBAL",2)
THEN
RESPONSE #100
SetGlobal("A7Q5Intro","AR5504",1)
CreateCreature("A7Karim",[481.920],E) // Karim
ActionOverride("A7Karim",FaceObject("AMCARRAS"))
ActionOverride("A7Karim",DestroyItem("A7RING01")) // Sandthief's Ring
CreateCreature("A7Q5DJ01",[518.830],SE) // Djinni
ActionOverride("A7Q5DJ01",SetDialog("A7Q5DJ01"))
ActionOverride("A7Q5DJ01",FaceObject("AMCARRAS"))
ActionOverride("A7Q5DJ01",DestroyItem("A7RING01")) // Sandthief's Ring
CreateCreature("A7Q5DJ05",[424.850],SEE) // Djinni
ActionOverride("A7Q5DJ05",SetDialog("A7Q5DJ05"))
ActionOverride("A7Q5DJ05",FaceObject("AMCARRAS"))
ActionOverride("A7Q5DJ05",DestroyItem("A7RING01")) // Sandthief's Ring
ActionOverride("AMCARRAS",FaceObject("A7Karim"))
Wait(2)
ClearAllActions()
StartCutSceneMode()
StartCutScene("A7Q5ct1a")
END

IF
Global("A7Q5Intro","AR5504",0)
Global("A7Quest5","GLOBAL",0)
Global("A7Q5AfaaqAppears","GLOBAL",0)
Global("A7AfaaqEnslaved","GLOBAL",0)
Global("A7AfaaqSummoned","GLOBAL",1)
PartyHasItem("A7DJLMPA") // Djinni lamp
!Global("Enclave","GLOBAL",2)
THEN
RESPONSE #100
SetGlobal("A7Q5Intro","AR5504",1)
CreateCreature("A7Karim",[481.920],E) // Karim
ActionOverride("A7Karim",FaceObject("AMCARRAS"))
ActionOverride("A7Karim",DestroyItem("A7RING01")) // Sandthief's Ring
CreateCreature("A7Q5DJ01",[518.830],SE) // Djinni
ActionOverride("A7Q5DJ01",SetDialog("A7Q5DJ01"))
ActionOverride("A7Q5DJ01",FaceObject("AMCARRAS"))
ActionOverride("A7Q5DJ01",DestroyItem("A7RING01")) // Sandthief's Ring
CreateCreature("A7Q5DJ05",[424.850],SEE) // Djinni
ActionOverride("A7Q5DJ05",SetDialog("A7Q5DJ05"))
ActionOverride("A7Q5DJ05",FaceObject("AMCARRAS"))
ActionOverride("A7Q5DJ05",DestroyItem("A7RING01")) // Sandthief's Ring
ActionOverride("AMCARRAS",FaceObject("A7Karim"))
Wait(2)
ActionOverride("A7Karim",StartDialogueNoSet("AMCARRAS"))
END

IF
Global("A7Q5Intro","AR5504",0)
Global("A7Quest5","GLOBAL",0)
Global("A7Q5AfaaqAppears","GLOBAL",0)
Global("A7AfaaqEnslaved","GLOBAL",1)
OR(2)
PartyHasItem("A7DJLMP") // Djinni lamp
PartyHasItem("A7DJLMPA") // Djinni lamp
!Global("Enclave","GLOBAL",2)
THEN
RESPONSE #100
SetGlobal("A7Q5Intro","AR5504",1)
CreateCreature("A7Karim",[481.920],E) // Karim
ActionOverride("A7Karim",FaceObject("AMCARRAS"))
ActionOverride("A7Karim",DestroyItem("A7RING01")) // Sandthief's Ring
CreateCreature("A7Q5DJ01",[518.830],SE) // Djinni
ActionOverride("A7Q5DJ01",SetDialog("A7Q5DJ01"))
ActionOverride("A7Q5DJ01",FaceObject("AMCARRAS"))
ActionOverride("A7Q5DJ01",DestroyItem("A7RING01")) // Sandthief's Ring
CreateCreature("A7Q5DJ05",[424.850],SEE) // Djinni
ActionOverride("A7Q5DJ05",SetDialog("A7Q5DJ05"))
ActionOverride("A7Q5DJ05",FaceObject("AMCARRAS"))
ActionOverride("A7Q5DJ05",DestroyItem("A7RING01")) // Sandthief's Ring
ActionOverride("AMCARRAS",FaceObject("A7Karim"))
Wait(2)
ActionOverride("A7Karim",StartDialogueNoSet("AMCARRAS"))
END

IF
Global("A7Q5Intro","AR5504",0)
Global("A7Quest5","GLOBAL",0)
Global("A7Q5AfaaqAppears","GLOBAL",1)
!Global("Enclave","GLOBAL",2)
THEN
RESPONSE #100
SetGlobal("A7Q5Intro","AR5504",1)
SetGlobal("A7Q5AfaaqAppears","GLOBAL",2)
CreateCreature("A7Karim",[481.920],E) // Karim
ActionOverride("A7Karim",FaceObject("AMCARRAS"))
ActionOverride("A7Karim",DestroyItem("A7RING01")) // Sandthief's Ring
CreateCreature("A7Q5DJ01",[518.830],SE) // Djinni
ActionOverride("A7Q5DJ01",SetDialog("A7Q5DJ01"))
ActionOverride("A7Q5DJ01",FaceObject("AMCARRAS"))
ActionOverride("A7Q5DJ01",DestroyItem("A7RING01")) // Sandthief's Ring
CreateCreature("A7Q5DJ05",[424.850],SEE) // Djinni
ActionOverride("A7Q5DJ05",SetDialog("A7Q5DJ05"))
ActionOverride("A7Q5DJ05",FaceObject("AMCARRAS"))
ActionOverride("A7Q5DJ05",DestroyItem("A7RING01")) // Sandthief's Ring
ActionOverride("A7Q5DJ05",SetName(175579)) // Afaaq
ActionOverride("A7Q5DJ05",ApplySpellRES("A7Q5PIC1",Myself)) // No such index
ActionOverride("A7Q5DJ05",SetGlobal("Afaaq","LOCALS",1))
ActionOverride("AMCARRAS",FaceObject("A7Karim"))
Wait(2)
ActionOverride("A7Karim",StartDialogueNoSet("AMCARRAS"))
END

IF
Global("A7Q5Intro","AR5504",0)
THEN
RESPONSE #100
SetGlobal("A7Q5Intro","AR5504",1)
SetGlobal("A7Quest5","GLOBAL",11)
END

IF
GlobalGT("A7Quest5","GLOBAL",0)
GlobalLT("A7Quest5","GLOBAL",10)
Global("A7Q5Permission","GLOBAL",1)
Global("A7Q5Protection","GLOBAL",1)
Global("A7EnablePool","AR5504",0)
THEN
RESPONSE #100
SetGlobal("A7EnablePool","AR5504",1)
TriggerActivation("A7InfoWater_1",FALSE)
TriggerActivation("A7InfoWater_2",TRUE)
END

IF
GlobalGT("A7Quest5","GLOBAL",0)
GlobalLT("A7Quest5","GLOBAL",10)
Global("A7Q5Permission","GLOBAL",1)
Global("A7Q5Protection","GLOBAL",0)
Global("A7EnablePool","AR5504",1)
THEN
RESPONSE #100
SetGlobal("A7EnablePool","AR5504",0)
TriggerActivation("A7InfoWater_2",FALSE)
TriggerActivation("A7InfoWater_1",TRUE)
END

IF
Global("A7Quest5","GLOBAL",10)
Global("A7Finalized","AR5504",0)
THEN
RESPONSE #100
SetGlobal("A7Finalized","AR5504",1)
AmbientActivate("A7Bubbles_1",FALSE)
AmbientActivate("A7Bubbles_2",FALSE)
AmbientActivate("A7Bubbles_3",FALSE)
AmbientActivate("A7Bubbles_4",FALSE)
AmbientActivate("A7Bubbles_5",FALSE)
AmbientActivate("A7Steam_1",FALSE)
AmbientActivate("A7Steam_2",FALSE)
AmbientActivate("A7Steam_3",FALSE)
AmbientActivate("A7Steam_4",FALSE)
AmbientActivate("A7Steam_5",FALSE)
TriggerActivation("A7InfoWater_2",FALSE)
TriggerActivation("A7InfoWater_1",TRUE)
END

IF
OR(2)
Global("Enclave","GLOBAL",2)
Dead("AMCARRAS")
Global("A7Q5Permission","GLOBAL",0)
THEN
RESPONSE #100
SetGlobal("A7Q5Permission","GLOBAL",1)
END

IF
Global("A7Quest5","GLOBAL",0)
GlobalLT("MONKSPAWNEDSMUGGLERPLOT","GLOBAL",3)
THEN
RESPONSE #100
SetGlobal("MONKSPAWNEDSMUGGLERPLOT","GLOBAL",3)
END

IF
GlobalGT("A7Quest5","GLOBAL",1)
Global("MONKSPAWNEDSMUGGLERPLOT","GLOBAL",3)
THEN
RESPONSE #100
SetGlobal("MONKSPAWNEDSMUGGLERPLOT","GLOBAL",0)
END

IF
Global("A7Q5Protection","GLOBAL",1)
!GlobalTimerNotExpired("A7Q5ProtectionWarnTimer","GLOBAL")
!GlobalTimerNotExpired("A7Q5ProtectionTimer","GLOBAL")
THEN
RESPONSE #100
SetGlobal("A7Q5Protection","GLOBAL",0)
SetGlobal("A7Q5ProtectionWarn","GLOBAL",1)
END

IF
!Global("A7Quest5","GLOBAL",10)
RealGlobalTimerExpired("A7Q5TremorTimer","AR5504")
RandomNum(50,1)
THEN
RESPONSE #100
RealSetGlobalTimer("A7Q5TremorTimer","AR5504",TWELVE_MINUTES)
PlaySound("EFF_P92")
ScreenShake([5.5],30)
END

IF
InParty("CVSandr")
Global("PelligFollow","GLOBAL",1)
!InActiveArea("pellig")
!See("pellig")
!Dead("pellig")
THEN
RESPONSE #100
MoveGlobalObject("Pellig","CVSandr")
END

IF
!Allegiance("Pellig",CONTROLLED)
Delay(10)
THEN
RESPONSE #100
ChangeEnemyAlly("Pellig",CONTROLLED)
END

IF
Global("HaiassJumpOn","GLOBAL",1)
Global("HaiassSeUne","GLOBAL",1)
!InActiveArea("haiass")
!See("haiass")
!Dead("haiass")
THEN
RESPONSE #100
MoveGlobalObject("haiass",Protagonist)
END

IF
!Allegiance("haiass",CONTROLLED)
Delay(12)
THEN
RESPONSE #100
ChangeEnemyAlly("haiass",CONTROLLED)
END

Edited by Roxanne, 16 March 2016 - 01:34 PM.

[Argent77]

I don't see anything that could have caused the CtD. The script portion in question sets an area-local variable and checks a bunch more variables. The only potential problem might be "!InActiveArea("A7Afaaq")" trigger in the third block. However, the game should not crash even if the creature is not available.

Does the game crash as soon as you enter the cave or after a certain delay? Can you try again with the code in place and replace the trigger "!InActiveArea("A7Afaaq")" by "False()"?

[Roxanne]

I don't see anything that could have caused the CtD. The script portion in question sets an area-local variable and checks a bunch more variables. The only potential problem might be "!InActiveArea("A7Afaaq")" trigger in the third block. However, the game should not crash even if the creature is not available.

Does the game crash as soon as you enter the cave or after a certain delay? Can you try again with the code in place and replace the trigger "!InActiveArea("A7Afaaq")" by "False()"?

Do I need to reset any globals? I have no save from before I entered the cave anymore - on my second attempt to enter, the CtD even prevented creation of an autosave.

[Argent77]

Yes, you have to set:
SetGlobal("A7Quest5", "GLOBAL", 0)
SetGlobal("A7FirstTime", "AR5504", 0)
SetGlobal("A7Q5Intro","AR5504",0)

The latter two can probably only be set in a resource editor since they are updated as soon as you enter the cave.

You could also try to start the game from the command line to see a number of debug messages. Maybe there is a hint to why the game crashes.
 

[Roxanne]

Yes, you have to set:
SetGlobal("A7Quest5", "GLOBAL", 0)
SetGlobal("A7FirstTime", "AR5504", 0)
SetGlobal("A7Q5Intro","AR5504",0)

The latter two can probably only be set in a resource editor since they are updated as soon as you enter the cave.

You could also try to start the game from the command line to see a number of debug messages. Maybe there is a hint to why the game crashes.
 

It looks like I cannot reproduce the situation after I re-introduced the code again.

So - most likely there was a compile error of some sort.

 

After I had the CtDs, I deleted your code and all was well. At that time I did not check each single line of those blocks,

 

Now I copied it out of the baf and recompiled it (all was done using NI) and now both variations "!InActiveArea("A7Afaaq")" or "False()" work without CtD.

Ergo, what was in the bcs before this *repair* had caused the issue.

 

 

PS - I meanwhile found out why I missed your NPC. I did not recognise that portal animation to be a portal, I took it for the animation of a transport/dryad teleport_spell from one of those spellcasters you fight in the hut

Edited by Roxanne, 16 March 2016 - 02:56 PM.

[Argent77]

Update: Afaaq, the Djinni Companion v2.3

Note: The latest Enhanced Edition patch v2.x adds quest entries into the "Journal" section instead of the "Quest" section of the Journal. This is caused by a new method how quest entries are stored internally by the game which is not yet supported by WeiDU.

Changes in v2.3:

• Added new side quest: Put Adratha's spirit to rest.
• Rebalanced Afaaq's "Transfer Knowledge" ability.
• Made script to keep Afaaq hasted more user-friendly.
• Fixed incompatibilities with Enhanced Edition patch v2.0.
• Various internal fixes and optimizations.

[Isewein]

Hello hello,

 

thanks for a great mod! Afaaq was perfectly timed to replace that increasingly useless dragon familiar that died on my charname, both mechanically and storywise! Really fitting for a sorcerer in BG2s pseudo oriental setting to have their very own djinn tagalong.

 

Just wanted to report a little, non-critical bug - for some reason, Afaaq refuses to return to his lamp now. I understand this isn't much of a bug report, since I can't pinpoint when this behaviour started. I did finish his quest when you get teleported to the Rakshasa jungle temple (awesome setting and challenging but well-balanced fights there; great fun!) some time ago. Now when I use PID he obliges in dialogue, but never actually vanishes into the lamp anymore...

[Argent77]

His refusal to retreat into the lamp is most likely caused by an incorrectly set variable. Talk to the djinni and select the option "You are behaving oddly. Care to fix it?". It should fix many states automatically.

If that doesn't work then enter the following line into the debug console while the mouse cursor is placed over the djinni:

CLUAConsole:SetGlobal("BanterActive","LOCALS",0)

Replace "CLUAConsole:" with "C:" on BG2:EE.

If this line doesn't work either then attach a save to your post, so that I can try to fix Afaaq myself.

Edited by Argent77, 30 July 2016 - 07:21 AM.

[Isewein]

just to let you know - I've tried the string fixer before, but cluaing the local did it! thanks:)

[Argent77]

Good to know. I'll incorporate the local fix into the string fixer with the next release.

[Roxanne]

In EET I have this in A7AfQTLK.bcs

 

:::::

GlobalGT("Chapter","GLOBAL",4)
    Global("BanterPCHeritage","LOCALS",6)
THEN
    RESPONSE #100
        SetInterrupt(FALSE)
        SetGlobal("BanterPCHeritage","LOCALS",7)

 

Should probably be chapter GT 16 in EET, i.e after Irenicus stole your soul in Spellhold.

[Argent77]

Yes, the current version (v2.3) doesn't provide full EET compatibility yet. The chapter numbers and more EET-specific stuff has already been fixed in the development branch. I plan to release a new stable version as soon as WeiDU v240 comes out (which is needed for a couple of features).

[Argent77]

Update: Afaaq, the Djinni Companion v2.4

Changes in v2.4:

• Added full EET support.
• Improved Afaaq's correction dialog.
• Added pieces of advice about BG1 and SoD areas to Afaaq's PID (EET only).
• Removed a duplicate line in skull purification dialog.
• Fixed an incorrect condition in Afaaq's introduction talk.
• Adapted previously hardcoded strings regarding familiars not allowed to execute specific actions (EEs only).
• Textual fixes in Adratha side quest.

[Roxanne]

I had the following issue with the version 2.3 when in EET transiting from BG2 to ToB with the djinni. It has probably not been changed in the new version?

Spoiler

In ar4000.bcs you add this

 

IF
Global("A7AfaaqLeaveParty","GLOBAL",1)
Global("A7AfaaqEnslaved","GLOBAL",0)
Global("A7AfaaqSummoned","GLOBAL",0)
PartyHasItem("A7DJLMPA") // Djinni lamp
!StateCheck(Player1,CD_STATE_NOTVALID)
THEN
RESPONSE #100
ClearAllActions()
StartCutSceneMode()
StartCutScene("A7Cut05")
END

 

He was still summoned from the fight against Irenicus - in EET the whole transition to ToB happened and of course the cutscene was not triggered. Afterwards I had Afaaq still talking about the PC getting back her soul, etc Also his behaviour was unusual - following me to all new areas but standing there just in one place. After sending him to the lamp and cheating back to ar4000, he was *repaired* (met him again with the smugglers). Unless the condition has some intention I miss, I would delete it.

[Argent77]

In version 2.3 Afaaq's conversations were triggered incorrectly because of incorrect chapter checks in EET. It should be fixed in v2.4. I'll test it again to make sure.

The cutscene simply summons the djinni if he in his lamp, and is supposed to trigger a specific conversation. If he's already outside of his lamp the same conversation should be automatically triggered from his character script.
 

[Argent77]

Update: I've tried to trigger the conversation that should take place at the beginning of ToB without success in EET. The cause is the variable Global("InToB","GLOBAL") which is automatically set in vanilla BG2:EE when you start ToB, but not set in EET. I'll report it over in the EET forums.

Edited by Argent77, 29 September 2016 - 01:07 PM.

[Roxanne]

Update: I've tried to trigger the conversation that should take place at the beginning of ToB without success in EET. The cause is the variable Global("InToB","GLOBAL") which is automatically set in vanilla BG2:EE when you start ToB, but not set in EET. I'll report it over in the EET forums.

At least I understand now why my search for wrong chapter on this case did not find the issue.