300 replies to this topic

[Nightfarer]

Hi Lollorian. I wrote you a PM about Jarl's mods. Awaiting a confirmation

[Leonardo Watson]

Hi Lollorian. With DarkHorizons I got an error message because of an incorrect patch in the current Fixpack-master:

 

[action list near line 17, column 2 of DarkHorizons/dlgs/cmquest1.d] PARSE WARNING at line 17 column 1-39
Near Text: )
    Not enough arguments to [GiveItemCreate]. Recovering.

[action list near line 28, column 2 of DarkHorizons/dlgs/cmquest1.d] PARSE WARNING at line 28 column 1-39
Near Text: )
    Not enough arguments to [GiveItemCreate]. Recovering.
Processing 1 dialogues/scripts ...

  IF ~~ THEN DO ~GiveItemCreate("RING07",LastTalkedToBy)

probably should be something like this:

  IF ~~ THEN DO ~GiveItemCreate("RING07",LastTalkedToBy,1,0,0)

Please check this!



Also there is an typo in Vildra/T#Vil.baf.patch in line 10:
+ etGlobal("T#VildraTalked","LOCALS",1) should be +SetGlobal("T#VildraTalked","LOCALS",1)

[Lollorian]

@Leonardo: Both BWPFixpack'd

 

@ALIEN: I don't understand how to mark a CRE as summoned, however I tried fixing the others (please have a look at the BAM in-game and confirm whether it's fixed)

[The Imp]

@ALIEN: I don't understand how to mark a CRE as summoned,

You mark them as Summoned in their gender ...
Aka:

COPY ~*~ ~override~ // the * being their .cre file
WRITE_BYTE ~0x0275~ ~6~ //summoned and restriced to 1 of the possible 5 if caster is a partymember and target for several gender related death effects

Edited by The Imp, 24 November 2015 - 08:45 AM.

[Lollorian]

Thanks

[Lollorian]

Hey guys

 

I noticed there was interest in getting fixes from test branches of various mods in github patched into current releases until the fixes are actually out in a proper release of the mod. BG1UB is a good example. I've seen various other mods with this including BG2Fixpack & BG1NPC.

 

Is this needed? Oldies around here might remember that I once tried doing something like this way back but was shot down quickly because of reasons... Things these days are pretty slow (mod releases being way apart etc) so I wonder whether it would be a good idea

 

Also, I plan to include only technical fixes - no typo bashing or new features - from the WIP branches.

 

Good idea? Yes? No? Murder?

[The Imp]

Hey guys

My vote on the matter is that do as much as you can, my only worry is that there will be this sort of suggestions... so try to keep in the limits that you know that work. Like in there, I am not definitelly sure solution I had with the UNLESS fix actually works, as I never tried it on an actual install, as I don't have a way to verify it. And then I also worry that you might have too much in your greedy little talons hands.

[agb1]

Definitely yes, but we need to make the fixes work, so don't be too hasty about it.

[Creepin]

Good idea? Yes? No? Murder?

Totally yes! Would just love* it!

_{*even if it means another week before I finally install BWS.}

Edited by Creepin, 27 November 2015 - 09:26 AM.

[agb1]

@Lollorian I see it like this: For mod authors willing to support users from their master branch and who are careful to verify their changes before committing/merging to master, ideally we will use the master branch in BWS so that users always get the highest quality and latest fixes directly from the author. For authors who prefer to collect multiple fixes between updates, you are proposing to take some of their support burden away by applying interim patches through BWFixpack and then supporting those patches yourself. This is great as long as you do not over-extend yourself.

Edited by agb1, 27 November 2015 - 09:29 AM.

[Lollorian]

_{*even if it means another week before I finally install BWS.}

I'd suggest you go ahead with your install man

 

I'm aiming for maybe next weekend for this one (depending on the hangover I have on saturday) - have some stuff with worldmap patching and Nightfarer stuff on my plate this week (sorry)

 

@Impy: Heh wish I had the EEs to test stuff like that out - I'll add stuff like that if they're reported here in this thread or even in the Megamod forums

[agb1]

@Creepin I want to do some conflict analysis this weekend, focusing on BP and SCS and some of the tactical mods.  If you are planning to use those then maybe you'd want to wait a bit.

[Creepin]

_{*even if it means another week before I finally install BWS.}

I'd suggest you go ahead with your install man

Naah, your idea is too cool to play without it. I'll wait (in a not-pressury way)

[Munchkin Mooch]

@Creepin I want to do some conflict analysis this weekend, focusing on BP and SCS and some of the tactical mods.  If you are planning to use those then maybe you'd want to wait a bit.

 

Guess I'm waiting too then kek Good luck!

[Creepin]

@Creepin I want to do some conflict analysis this weekend, focusing on BP and SCS and some of the tactical mods. If you are planning to use those then maybe you'd want to wait a bit.

Thanks for letting me know agb1! I personally have long since stopped using SCS (found out it totally screw enemy AI in Megamod), but I'm all for putting it back on menu, so wait then it is

Edited by Creepin, 27 November 2015 - 11:09 AM.

[Lollorian]

Well since I couldn't make sense of the sc#addWmpAre function, here's the bg2fixpack updated to v11 Alpha.

 

It includes the following:

:: Latest commit from FredrikLindgren/BG2-Fixpack used as base
:: https://github.com/F...4f34446b5b67344

:: Hurricane's icon fixes
:: http://gibberlings3....=25208&p=208507

:: aVENGER's EE fixes
:: http://gibberlings3....=25208&p=214380
:: http://gibberlings3....=25208&p=214527
:: http://gibberlings3....=25208&p=214720
:: http://gibberlings3....=25208&p=214727

:: polytope's skipping Staff of Air elven immunity
:: http://gibberlings3....=25208&p=214540

:: Ardanis's misc fixes
:: http://gibberlings3....=25208&p=214540

:: polytope's Soul Reaver duration fix
:: http://gibberlings3....=25208&p=216291

:: Hurricane's better BG:EE check (used NOT GAME_IS ~bgee~)
:: http://gibberlings3....=25208&p=221002

:: lynx's Tree of life canopy area marked outdoors
:: http://gibberlings3....showtopic=27392

:: Alesia_BH's Sunfire power level fix
:: http://gibberlings3....showtopic=27401

 

Meanwhile, can someone help me out getting this fix in?

 

I tried this bit of code and quickly found that it has no effect

 

 

  //level 6 fixes
  SET "lev6" = 0
  PATCH_IF ("%level%" > 11) BEGIN
    SET "lev6" = ("%lev6%" + 1)
    INSERT_BYTES  ("%mem_off%" +        (0x0c * ("%delta%" + "%idx_start%"))) 0x0c
      WRITE_ASCII ("%mem_off%" +        (0x0c * ("%delta%" + "%idx_start%"))) ~spwi616~
      WRITE_SHORT ("%mem_off%" + 0x08 + (0x0c * ("%delta%" + "%idx_start%"))) 1
    SET "delta" = ("%delta%" + 1)
  END
  WRITE_SHORT ("%mem_info%" + 0x02 + (12 * 0x10)) "%lev6%"
  WRITE_SHORT ("%mem_info%" + 0x04 + (12 * 0x10)) "%lev6%"
  WRITE_LONG  ("%mem_info%" + 0x08 + (12 * 0x10)) (("%idx_start%" + "%delta%") - "%lev6%")
  WRITE_SHORT ("%mem_info%" + 0x0c + (12 * 0x10)) "%lev6%"

Edited by Lollorian, 29 November 2015 - 01:29 AM.

[Lollorian]

And bg1npc now uses AstroBryGuy's latest commit from here

[agb1]

Please consider http://gibberlings3....iew=getlastpost

[Lollorian]

As you command

[Quiet]

Coincidentally, this part caught my attention:

CA_AddDown=http://www.arcanecoast.ru/download/BWFixpack_aurora_fix.7z
CA_AddSave=BWFixpack_aurora_fix.7z
CA_AddSize=1259
CA_AddTest=BiG World Fixpack\aurora\t-kobold.tpa.patch:-

Is there a fix to BWP Fixpack on Arcanecoast? If so, how comes it wasn't incorporated into, ugh, Fixpack itself?

 

Just for the record:
CA_ means that this is only used when building the mod.ini for the config-folder CA, which contains the BWS files for Classic Adventures.
You can also find other examples like stuff that's used for IWD1 only if you look into the global 1pp-file.
If you look into the BWP's mod.ini, you won't find the CA_lines. If you configure CA and check the mod.ini, you'll find.

AddDown=http://www.arcanecoast.ru/download/BWFixpack_aurora_fix.7z
AddSave=BWFixpack_aurora_fix.7z
AddSize=1259
AddTest=BiG World Fixpack\aurora\t-kobold.tpa.patch:- 

Those are very likely lines that were in the games mod.inis before we merged them into the global ini-files.
Maybe there are some more of these leftovers.

By the way, it's would be nice to add this fix to BWFixpack to remove it from Arcanecoast (click and click).