300 replies to this topic

[Roxanne]

Update time

 

@Creepin: Done

 

@Nightfarer: Done & please do attach the fixed file

 

@agb1:

 

Re: Revision betas

That's not possible purely via the fixpack framework unfortunately The workaround would be to make sure the item_rev and spell_rev folders in the fixpack are deleted before installing.

 

Like the Imp said, however, the patch might not even install correctly if they reworked the files (or fixed them)

 

Re: WMA

Done

 

@Roxanne:

Re: Askaria

Done

 

@SoA:

I couldn't find this block anywhere

@SoA:

I couldn't find this block anywhere

 

It is in soa/snips/ar4300.baf >>> ar4300 being BGT ar3200 however the refence is not updated in BGT installation and furthermore the code itself does not work

Spoiler

IF
Global("DoorS001Active","AR4300",1)
GlobalLT("CearwinQuest","GLOBAL",2)
THEN
RESPONSE #100
TriggerActivation("DoorS001",FALSE)
SetGlobal("DoorS001Active","AR4300",0)
Continue()
END

IF
Global("DoorS001Active","AR4300",0)
GlobalGT("CearwinQuest","GLOBAL",1)
THEN
RESPONSE #100
TriggerActivation("DoorS001",TRUE)
SetGlobal("DoorS001Active","AR4300",1)
Continue()
END

 

It looks for two situations

A) Global("DoorS001Active","AR4300",1)
GlobalLT("CearwinQuest","GLOBAL",2)

B)Global("DoorS001Active","AR4300",0)
GlobalGT("CearwinQuest","GLOBAL",1)

However when you first enter ar3200 (North Nashkel Road) you will always have

C) Global("DoorS001Active","AR4300",0) (Does not exist)

Global("CearwinQuest","GLOBAL",0) (Does not exist)

Consequently the door supposed to be closed until you receive CearwinQuest is open and those blocks never trigger.

For BGT I therefore proposed to use

Spoiler

IF
Global("DoorS001Active","AR3200",0)
GlobalLT("CearwinQuest","GLOBAL",2)
THEN
RESPONSE #100
TriggerActivation("DoorS001",FALSE)
SetGlobal("DoorS001Active","AR3200",1)
Continue()
END

IF
Global("DoorS001Active","AR3200",1)
GlobalGT("CearwinQuest","GLOBAL",1)
THEN
RESPONSE #100
TriggerActivation("DoorS001",TRUE)
SetGlobal("DoorS001Active","AR3200",2)
Continue()
END

While at it, maybe the premature display of the SOA maps ARS002 and ARS005 could also be inhibited by expanding the proposed code:

Spoiler

]IF
Global("DoorS001Active","AR3200",0)
GlobalLT("CearwinQuest","GLOBAL",2)
THEN
RESPONSE #100
TriggerActivation("DoorS001",FALSE)

HideAreaOnMap("ARS002")
HideAreaOnMap("ARS005")
SetGlobal("DoorS001Active","AR3200",1)
Continue()
END

IF
Global("DoorS001Active","AR3200",1)
GlobalGT("CearwinQuest","GLOBAL",1)
THEN
RESPONSE #100
TriggerActivation("DoorS001",TRUE)
SetGlobal("DoorS001Active","AR3200",2)
Continue()
END

The areas are supposed to be shown after Cearwin dialogue, not from the edge of adjacent areas.

IF ~~ THEN BEGIN 18 // from: 17.0
  SAY @48
  IF ~~ THEN DO ~SetGlobal("SpokeToCearwin","GLOBAL",3)SetGlobal("CearwinQuest","GLOBAL",2)SetInterrupt(FALSE)

CreateItem("SOAITM21",0,0,0)GiveItem("SOAITM21",LastTalkedToBy)

RevealAreaOnMap("ARS002")

RevealAreaOnMap("ARS005")~ %UNSOLVED_JOURNAL% @10006 EXIT

 

Edited by Roxanne, 11 November 2015 - 08:46 AM.

[Lollorian]

Heh I'm stupid (and my grep seems to ignore .patch files now )

 

BWPFixpack'd

[Roxanne]

I had this issue installing Nehtaniel (no way to report it on mod webside)

 

EXTEND_BOTTOM PPBODHI4 7
IF ~InParty("SK#Neht")
InMyArea("SK#Neht")
!StateCheck("SK#Neht",CD_STATE_NOTVALID)~ ~ THEN GOTO TauntNeht
END

 

Could install after removing second *~*  prior THEN GOTO

[Lollorian]

Shit! That's not the vanilla mod's issue but a problem with the BWPFixpack patch - fixed sorry

[Roxanne]

Another candidate

http://www.shsforums...e-2#entry582336

[Creepin]

Lollorian, another request from me in case I might catch you before your vacation
 
Micbaldur reported bug in Saerileth mod and proposed a fix. I saw your further discussion with micbaldur drifted towards fixing DD0903 area so I am not sure if you noticed that issue. Any chance micbaldur's fix is (or going to be) included in your fixpack?

[Lollorian]

@Roxanne: BWPFixpack'd

 

@Creepin: Already done

[Creepin]

Great, thanks a lot Lollorian!

[Nightfarer]

@Lollorian. I'm going to write you a PM. TS25MiniMod rewritten setup

[Lollorian]

Wow man! Dude that is awesome as fuck Have a look! I've renamed the patch to Nightfarer's Update because it's too awesome not to give credit lol.

[Nightfarer]

  You're welcome Lollorian. Thanks for the credit... but thanks to Micbaldur and Creepin as well

[Roxanne]

Breagar starting with SoA dialogue in Candlekeep when using BGT

 

An older problem but never fixed - the mod is hosted at Kerzenburg, so no way for me to report there. I have repaired it several times locally but maybe it is worth publishing here.

 

The issue is in ACBre/d/Bg2/ACBre.d

The second dialogue block

IF ~%BGT_VAR2%Global("ACBREINPARTY","GLOBAL",0)InPartySlot(LastTalkedToBy(),0)~ THEN BEGIN BG2.START.2

SAY @69

++ @70 + BG2.1

++ @71 + BG2.2

++ @72 + BG2.3

END

 

Should be

IF ~%BGT_VAR2%Global("ACBREINPARTY","GLOBAL",0)InPartySlot(LastTalkedToBy(),0)Global("endofbg1","GLOBAL",2)~ THEN BEGIN BG2.START.2 blablabla

 

With this condition added BGT works fine.

[Lollorian]

Had a look at the code and it would seem like %BGT_VAR2% is supposed to evaluate to Global("endofbg1","GLOBAL",2) if GAME_IS ~bgt~

 

This is ACBre\lib\ac_bre_cpmvars.tpa:

Spoiler

ACTION_IF GAME_IS ~bgee~ THEN BEGIN
OUTER_SPRINT "WTASIGHT" "WTASIGHT"
OUTER_SPRINT "MISC83" "MISC83"
OUTER_SPRINT ~BGT_VAR2~ ~Global("endofbg1","GLOBAL",2)~ //This Condition is never true! ;)
OUTER_SPRINT "SKELWA02" "SKELWA02"
OUTER_SPRINT "SLAVLEAD"  "SLAVLEAD"
OUTER_SPRINT ~EDWIN_STATE_0~ ~0~
OUTER_SPRINT ~EDWIN_STATE_1~ ~1~
OUTER_SPRINT ~EDWIN_STATE_2~ ~2~
OUTER_SPRINT "Exit3301" "Exit3301"
OUTER_SPRINT "Exit3300" "Exit3300"
OUTER_SPRINT "Door3300" "Door3300"
END
ACTION_IF GAME_IS ~bgt~ THEN BEGIN
OUTER_SPRINT "WTASIGHT" "WTASIGHT"
OUTER_SPRINT "MISC83" "BGMISC83"
OUTER_SPRINT ~BGT_VAR2~ ~Global("endofbg1","GLOBAL",2)~
OUTER_SPRINT "SKELWA02" "BGSKEL02"
OUTER_SPRINT "SLAVLEAD"  "SLAVLEAD"
OUTER_SET "EDWIN_STATE_0" = (STATE_WHICH_SAYS 99991 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%tutu_var%EDWIN~)
OUTER_SET "EDWIN_STATE_1" = (STATE_WHICH_SAYS 99992 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%tutu_var%EDWIN~)
OUTER_SET "EDWIN_STATE_2" = (STATE_WHICH_SAYS 99993 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%tutu_var%EDWIN~)
OUTER_SET "IMOEN_STATE_26" = (STATE_WHICH_SAYS 99990 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%IMOEN_JOINED%~)
OUTER_SPRINT "Exit3301" "Exit6701"
OUTER_SPRINT "Exit3300" "Exit6700"
OUTER_SPRINT "Door3300" "Door6700"
END
ACTION_IF GAME_IS ~tutu tutu_totsc~ THEN BEGIN
OUTER_SPRINT "WTASIGHT" "_TASIGHT"
OUTER_SPRINT "MISC83" "_MISC83"
OUTER_SPRINT ~BGT_VAR2~ ~Global("endofbg1","GLOBAL",2)~ //This condition is never true ;)
OUTER_SPRINT "SKELWA02" "_KELWA02"
OUTER_SPRINT "SLAVLEAD"  "_LAVLEAD"
OUTER_SPRINT ~EDWIN_STATE_0~ ~0~
OUTER_SPRINT ~EDWIN_STATE_1~ ~1~
OUTER_SPRINT ~EDWIN_STATE_2~ ~2~
OUTER_SPRINT "Exit3301" "Exit3301"
OUTER_SPRINT "Exit3300" "Exit3300"
OUTER_SPRINT "Door3300" "Door3300"
END
ACTION_IF GAME_IS "eet" BEGIN
OUTER_SPRINT "WTASIGHT" "WTASIGHT"
OUTER_SPRINT "MISC83" "BGMISC83"
OUTER_SPRINT ~BGT_VAR2~ ~Global("endofbg1","GLOBAL",2)~
OUTER_SPRINT "SKELWA02" "BGSKEL02"
OUTER_SPRINT "SLAVLEAD"  "SLAVLEAD"
OUTER_SET "EDWIN_STATE_0" = (STATE_WHICH_SAYS 99991 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%tutu_var%EDWIN~)
OUTER_SET "EDWIN_STATE_1" = (STATE_WHICH_SAYS 99992 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%tutu_var%EDWIN~)
OUTER_SET "EDWIN_STATE_2" = (STATE_WHICH_SAYS 99993 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%tutu_var%EDWIN~)
OUTER_SET "IMOEN_STATE_26" = (STATE_WHICH_SAYS 99990 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%IMOEN_JOINED%~)
OUTER_SPRINT "Exit3301" "Exit3301"
OUTER_SPRINT "Exit3300" "Exit3300"
OUTER_SPRINT "Door3300" "Door3300"
END
ACTION_IF GAME_IS "tob bg2ee" AND !GAME_IS "bgt eet" BEGIN
OUTER_SPRINT ~BGT_VAR~ ~!Global("endofbg1","GLOBAL",2)~ //This condition is never true ;)
OUTER_SPRINT ~BGT_VAR2~ ~~
OUTER_SPRINT "IMOEN_JOINED" "IMOENJ"
OUTER_SET "IMOEN_STATE_26" = (STATE_WHICH_SAYS 99990 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%IMOEN_JOINED%~)
END

 

Should I assume that the variables are not being properly evaluated? I did notice the conspicuous lack of ELSE in the various IF blocks (but I think the ! condition in the last block should easily handle that) - what say you Roxanne?

[Roxanne]

Had a look at the code and it would seem like %BGT_VAR2% is supposed to evaluate to Global("endofbg1","GLOBAL",2) if GAME_IS ~bgt~

 

This is ACBre\lib\ac_bre_cpmvars.tpa:

Spoiler

ACTION_IF GAME_IS ~bgee~ THEN BEGIN
OUTER_SPRINT "WTASIGHT" "WTASIGHT"
OUTER_SPRINT "MISC83" "MISC83"
OUTER_SPRINT ~BGT_VAR2~ ~Global("endofbg1","GLOBAL",2)~ //This Condition is never true! ;)
OUTER_SPRINT "SKELWA02" "SKELWA02"
OUTER_SPRINT "SLAVLEAD"  "SLAVLEAD"
OUTER_SPRINT ~EDWIN_STATE_0~ ~0~
OUTER_SPRINT ~EDWIN_STATE_1~ ~1~
OUTER_SPRINT ~EDWIN_STATE_2~ ~2~
OUTER_SPRINT "Exit3301" "Exit3301"
OUTER_SPRINT "Exit3300" "Exit3300"
OUTER_SPRINT "Door3300" "Door3300"
END
ACTION_IF GAME_IS ~bgt~ THEN BEGIN
OUTER_SPRINT "WTASIGHT" "WTASIGHT"
OUTER_SPRINT "MISC83" "BGMISC83"
OUTER_SPRINT ~BGT_VAR2~ ~Global("endofbg1","GLOBAL",2)~
OUTER_SPRINT "SKELWA02" "BGSKEL02"
OUTER_SPRINT "SLAVLEAD"  "SLAVLEAD"
OUTER_SET "EDWIN_STATE_0" = (STATE_WHICH_SAYS 99991 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%tutu_var%EDWIN~)
OUTER_SET "EDWIN_STATE_1" = (STATE_WHICH_SAYS 99992 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%tutu_var%EDWIN~)
OUTER_SET "EDWIN_STATE_2" = (STATE_WHICH_SAYS 99993 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%tutu_var%EDWIN~)
OUTER_SET "IMOEN_STATE_26" = (STATE_WHICH_SAYS 99990 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%IMOEN_JOINED%~)
OUTER_SPRINT "Exit3301" "Exit6701"
OUTER_SPRINT "Exit3300" "Exit6700"
OUTER_SPRINT "Door3300" "Door6700"
END
ACTION_IF GAME_IS ~tutu tutu_totsc~ THEN BEGIN
OUTER_SPRINT "WTASIGHT" "_TASIGHT"
OUTER_SPRINT "MISC83" "_MISC83"
OUTER_SPRINT ~BGT_VAR2~ ~Global("endofbg1","GLOBAL",2)~ //This condition is never true ;)
OUTER_SPRINT "SKELWA02" "_KELWA02"
OUTER_SPRINT "SLAVLEAD"  "_LAVLEAD"
OUTER_SPRINT ~EDWIN_STATE_0~ ~0~
OUTER_SPRINT ~EDWIN_STATE_1~ ~1~
OUTER_SPRINT ~EDWIN_STATE_2~ ~2~
OUTER_SPRINT "Exit3301" "Exit3301"
OUTER_SPRINT "Exit3300" "Exit3300"
OUTER_SPRINT "Door3300" "Door3300"
END
ACTION_IF GAME_IS "eet" BEGIN
OUTER_SPRINT "WTASIGHT" "WTASIGHT"
OUTER_SPRINT "MISC83" "BGMISC83"
OUTER_SPRINT ~BGT_VAR2~ ~Global("endofbg1","GLOBAL",2)~
OUTER_SPRINT "SKELWA02" "BGSKEL02"
OUTER_SPRINT "SLAVLEAD"  "SLAVLEAD"
OUTER_SET "EDWIN_STATE_0" = (STATE_WHICH_SAYS 99991 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%tutu_var%EDWIN~)
OUTER_SET "EDWIN_STATE_1" = (STATE_WHICH_SAYS 99992 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%tutu_var%EDWIN~)
OUTER_SET "EDWIN_STATE_2" = (STATE_WHICH_SAYS 99993 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%tutu_var%EDWIN~)
OUTER_SET "IMOEN_STATE_26" = (STATE_WHICH_SAYS 99990 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%IMOEN_JOINED%~)
OUTER_SPRINT "Exit3301" "Exit3301"
OUTER_SPRINT "Exit3300" "Exit3300"
OUTER_SPRINT "Door3300" "Door3300"
END
ACTION_IF GAME_IS "tob bg2ee" AND !GAME_IS "bgt eet" BEGIN
OUTER_SPRINT ~BGT_VAR~ ~!Global("endofbg1","GLOBAL",2)~ //This condition is never true ;)
OUTER_SPRINT ~BGT_VAR2~ ~~
OUTER_SPRINT "IMOEN_JOINED" "IMOENJ"
OUTER_SET "IMOEN_STATE_26" = (STATE_WHICH_SAYS 99990 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%IMOEN_JOINED%~)
END

 

 

Should I assume that the variables are not being properly evaluated? I did notice the conspicuous lack of ELSE in the various IF blocks (but I think the ! condition in the last block should easily handle that) - what say you Roxanne?

I checked the compiled dialogue in NI in my BGT game and the condition is not there, it is simply

Global("ACBREINPARTY","GLOBAL",0)InPartySlot(LastTalkedToBy(),0) and since that is triggered in sequence prior the BG1 triggers it is found true at initial appearance of Breagar at Candlekeep. I added it manually and it works.

I have seen some reports about the issue in some forum threads before, so it seems it is not always compiled correctly. I am not the expert for this type of code, just observing that it is not translated - here is the debug file, I cannot see how the tps code was applied at all .

 

Most likely this is not an issue to be fixed here but something the mod author should look into.

[Roxanne]

Had a look at the code and it would seem like %BGT_VAR2% is supposed to evaluate to Global("endofbg1","GLOBAL",2) if GAME_IS ~bgt~

 

This is ACBre\lib\ac_bre_cpmvars.tpa:

Spoiler

ACTION_IF GAME_IS ~bgee~ THEN BEGIN
OUTER_SPRINT "WTASIGHT" "WTASIGHT"
OUTER_SPRINT "MISC83" "MISC83"
OUTER_SPRINT ~BGT_VAR2~ ~Global("endofbg1","GLOBAL",2)~ //This Condition is never true! ;)
OUTER_SPRINT "SKELWA02" "SKELWA02"
OUTER_SPRINT "SLAVLEAD"  "SLAVLEAD"
OUTER_SPRINT ~EDWIN_STATE_0~ ~0~
OUTER_SPRINT ~EDWIN_STATE_1~ ~1~
OUTER_SPRINT ~EDWIN_STATE_2~ ~2~
OUTER_SPRINT "Exit3301" "Exit3301"
OUTER_SPRINT "Exit3300" "Exit3300"
OUTER_SPRINT "Door3300" "Door3300"
END
ACTION_IF GAME_IS ~bgt~ THEN BEGIN
OUTER_SPRINT "WTASIGHT" "WTASIGHT"
OUTER_SPRINT "MISC83" "BGMISC83"
OUTER_SPRINT ~BGT_VAR2~ ~Global("endofbg1","GLOBAL",2)~
OUTER_SPRINT "SKELWA02" "BGSKEL02"
OUTER_SPRINT "SLAVLEAD"  "SLAVLEAD"
OUTER_SET "EDWIN_STATE_0" = (STATE_WHICH_SAYS 99991 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%tutu_var%EDWIN~)
OUTER_SET "EDWIN_STATE_1" = (STATE_WHICH_SAYS 99992 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%tutu_var%EDWIN~)
OUTER_SET "EDWIN_STATE_2" = (STATE_WHICH_SAYS 99993 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%tutu_var%EDWIN~)
OUTER_SET "IMOEN_STATE_26" = (STATE_WHICH_SAYS 99990 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%IMOEN_JOINED%~)
OUTER_SPRINT "Exit3301" "Exit6701"
OUTER_SPRINT "Exit3300" "Exit6700"
OUTER_SPRINT "Door3300" "Door6700"
END
ACTION_IF GAME_IS ~tutu tutu_totsc~ THEN BEGIN
OUTER_SPRINT "WTASIGHT" "_TASIGHT"
OUTER_SPRINT "MISC83" "_MISC83"
OUTER_SPRINT ~BGT_VAR2~ ~Global("endofbg1","GLOBAL",2)~ //This condition is never true ;)
OUTER_SPRINT "SKELWA02" "_KELWA02"
OUTER_SPRINT "SLAVLEAD"  "_LAVLEAD"
OUTER_SPRINT ~EDWIN_STATE_0~ ~0~
OUTER_SPRINT ~EDWIN_STATE_1~ ~1~
OUTER_SPRINT ~EDWIN_STATE_2~ ~2~
OUTER_SPRINT "Exit3301" "Exit3301"
OUTER_SPRINT "Exit3300" "Exit3300"
OUTER_SPRINT "Door3300" "Door3300"
END
ACTION_IF GAME_IS "eet" BEGIN
OUTER_SPRINT "WTASIGHT" "WTASIGHT"
OUTER_SPRINT "MISC83" "BGMISC83"
OUTER_SPRINT ~BGT_VAR2~ ~Global("endofbg1","GLOBAL",2)~
OUTER_SPRINT "SKELWA02" "BGSKEL02"
OUTER_SPRINT "SLAVLEAD"  "SLAVLEAD"
OUTER_SET "EDWIN_STATE_0" = (STATE_WHICH_SAYS 99991 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%tutu_var%EDWIN~)
OUTER_SET "EDWIN_STATE_1" = (STATE_WHICH_SAYS 99992 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%tutu_var%EDWIN~)
OUTER_SET "EDWIN_STATE_2" = (STATE_WHICH_SAYS 99993 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%tutu_var%EDWIN~)
OUTER_SET "IMOEN_STATE_26" = (STATE_WHICH_SAYS 99990 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%IMOEN_JOINED%~)
OUTER_SPRINT "Exit3301" "Exit3301"
OUTER_SPRINT "Exit3300" "Exit3300"
OUTER_SPRINT "Door3300" "Door3300"
END
ACTION_IF GAME_IS "tob bg2ee" AND !GAME_IS "bgt eet" BEGIN
OUTER_SPRINT ~BGT_VAR~ ~!Global("endofbg1","GLOBAL",2)~ //This condition is never true ;)
OUTER_SPRINT ~BGT_VAR2~ ~~
OUTER_SPRINT "IMOEN_JOINED" "IMOENJ"
OUTER_SET "IMOEN_STATE_26" = (STATE_WHICH_SAYS 99990 IN ~ACBre/tra/autotra/%language%/ACStates.tra~ FROM ~%IMOEN_JOINED%~)
END

 

 

Should I assume that the variables are not being properly evaluated? I did notice the conspicuous lack of ELSE in the various IF blocks (but I think the ! condition in the last block should easily handle that) - what say you Roxanne?

I checked the compiled dialogue in NI in my BGT game and the condition is not there, it is simply

Global("ACBREINPARTY","GLOBAL",0)InPartySlot(LastTalkedToBy(),0) and since that is triggered in sequence prior the BG1 triggers it is found true at initial appearance of Breagar at Candlekeep. I added it manually and it works.

I have seen some reports about the issue in some forum threads before, so it seems it is not always compiled correctly. I am not the expert for this type of code, just observing that it is not translated - here is the debug file, I cannot see how the tps code was applied at all Setup-ACBre.debug.

 

Most likely this is not an issue to be fixed here but something the mod author should look into.

I had Breagar added in various BGT installations and it was always with this mistake - I never installed him in a BG1 or BG2 game to check there (actually I always do BGT installations)

[Lollorian]

Found the issue and fixed The BWPFixpack is at fault here - it removed the final ! check for some reason which meant BGT_VAR2 evaulated to an empty string

[micbaldur]

Lollorian there's big MY mistake in BWP Fixpack. Big truck load patches i send you while back was accidently included bugged Assassinations.d patch for Assassination mod, that shouldn't have been there.

 

If you would kindly remove that from BWP Fixpack, because it breaks the mod (Daton and probably Qyr doesn't spawn).

 

Sorry, i should have double and triple check everything and now i go to

[Lollorian]

Ok you mean this?

 

Spoiler

--- Assassinations\Dialogue\Assassinations.d    Tue Aug 06 17:57:30 2013
+++ C:\BWP Patchstudio\patched files\Assassinations\Dialogue\Assassinations.d    Sun Mar 08 19:09:02 2015
@@ -2058,13 +2058,17 @@
 CHAIN O#LYNN f1.10
 @631
 == O#RHIN @632
-DO ~SetGlobal("O#CrLynnFinalQuest","GLOBAL",3)
+DO ~ClearAllActions()
+StartCutSceneMode()
+SetGlobal("O#CrLynnFinalQuest","GLOBAL",3)
 EraseJournalEntry(@10450)
 EraseJournalEntry(@10460)
 EraseJournalEntry(@10560)
 AddJournalEntry(@10470,QUEST)
 ApplySpell("O#Rhin",DRYAD_TELEPORT)
-ApplySpell("O#Lynn",DRYAD_TELEPORT)~
+ActionOverride("O#Lynn",CreateVisualEffectObject("spdimndr",Myself))
+ActionOverride("O#Lynn",MoveBetweenAreas("AR0800",[1584.790],0))
+EndCutSceneMode()~
 EXIT
 
 CHAIN IF ~Global("O#CrLynnFinalQuest","GLOBAL",3)~ THEN O#LYNN f2
@@ -2954,9 +2958,10 @@
 
 BEGIN O#DATON   // Inspector Daton
 
-CHAIN IF ~NumTimesTalkedTo(0)~ THEN O#DATON d1
+CHAIN IF ~Global("O#CrSpawnedDatonTalked","GLOBAL",0)~ THEN O#DATON d1
 @975
-DO ~SetGlobal("O#CrSpawnedDaton","GLOBAL",2)~
+DO ~SetGlobal("O#CrSpawnedDaton","GLOBAL",2)
+SetGlobal("O#CrSpawnedDatonTalked","GLOBAL",1)~
 END
 + ~ReputationGT(Player1,7)~ + @976 EXTERN O#DATON d1.1
 + ~ReputationLT(Player1,8)~ + @976 EXTERN O#DATON d1.2
@@ -3015,10 +3020,10 @@
 CHAIN O#DATON d1.9
 @993
 DO ~AddJournalEntry(@10220,QUEST)
-EscapeAreaMove("AR0300",4304,2458,0)~
+EscapeArea()~
 EXIT
 
-CHAIN IF ~NumTimesTalkedToGT(0)~ THEN O#DATON d2
+CHAIN IF ~Global("O#CrSpawnedDatonTalked","GLOBAL",2)~ THEN O#DATON d2
 @994
 END
 ++ @995 EXTERN O#DATON d2.0
@@ -3094,7 +3099,8 @@
 == MAZZYJ IF ~InParty("Mazzy") Range(Player1,30) !StateCheck("Mazzy",CD_STATE_NOTVALID)~ THEN @1034
 DO ~LeaveParty() Enemy()~
 == O#DATON @1035
-DO ~AddJournalEntry(@10240,QUEST)
+DO ~SetGlobal("O#CrSpawnedDatonTalked","GLOBAL",3)
+AddJournalEntry(@10240,QUEST)
 ReputationInc(-2)
 Enemy()~
 EXIT
@@ -3118,7 +3124,8 @@
 
 CHAIN O#DATON d2.betray2
 @1046
-DO ~SetGlobal("O#CrLynnBetrayed","GLOBAL",1)
+DO ~SetGlobal("O#CrSpawnedDatonTalked","GLOBAL",3)
+SetGlobal("O#CrLynnBetrayed","GLOBAL",1)
 SetGlobal("O#CrLynnAmbush","GLOBAL",1)
 AddJournalEntry(@10230,QUEST)
 EscapeArea()~
@@ -3605,9 +3612,10 @@
 
 BEGIN O#CRQYR
 
-CHAIN IF ~NumTimesTalkedTo(0)~ THEN O#CRQYR q1
+CHAIN IF ~Global("O#CrLynnQuestSpawnTalked7","GLOBAL",0)~ THEN O#CRQYR q1
 @1246
 DO ~SetGlobal("O#CrLynnQuestSpawn7","GLOBAL",2)
+SetGlobal("O#CrLynnQuestSpawnTalked7","GLOBAL",1)
 AddJournalEntry(@10360,QUEST)~
 END
 ++ @1247 EXTERN O#CRQYR q1.1
@@ -3631,7 +3639,7 @@
 
 CHAIN O#CRQYR q1.3
 @1256
-DO ~EscapeAreaMove("AR2000",1563,166,0)~
+DO ~EscapeArea()~
 EXIT
 
 CHAIN O#CRQYR q1.4
@@ -3646,11 +3654,12 @@
 
 CHAIN O#CRQYR q1.end
 @1259
-DO ~EscapeAreaMove("AR2000",1563,166,0)~
+DO ~EscapeArea()~
 EXIT
 
-CHAIN IF ~NumTimesTalkedToGT(0)~ THEN O#CRQYR q2
+CHAIN IF ~Global("O#CrLynnQuestSpawnTalked7","GLOBAL",2)~ THEN O#CRQYR q2
 @1260
+DO ~SetGlobal("O#CrLynnQuestSpawnTalked7","GLOBAL",3)~
 == KORGANJ IF ~InParty("Korgan") InMyArea("Korgan") !StateCheck("Korgan",CD_STATE_NOTVALID)~ THEN @1261
 == VICONIJ IF ~InParty("Viconia") InMyArea("Viconia") !StateCheck("Viconia",CD_STATE_NOTVALID)~ THEN @1262
 == JANJ IF ~InParty("Jan") InMyArea("Jan") !StateCheck("Jan",CD_STATE_NOTVALID)~ THEN @1263

 

I've removed it - what was the issue you made the patch for btw? Maybe someone could take a look for you?

[micbaldur]

I am trying to fix this hanging cutscene:

ClearAllActions()
StartCutSceneMode()
SetGlobal("O#CrLynnFinalQuest","GLOBAL",3)
EraseJournalEntry(190332)
EraseJournalEntry(189747)
EraseJournalEntry(189756)
AddJournalEntry(190385,QUEST)
ApplySpell("O#Rhin",DRYAD_TELEPORT)

ApplySpell("O#Lynn",DRYAD_TELEPORT)
ActionOverride("O#Lynn",CreateVisualEffectObject("spdimndr",Myself))
ActionOverride("O#Lynn",MoveBetweenAreas("AR0800",[1584.790],0))
EndCutSceneMode()

I removed "ApplySpell("O#Lynn",DRYAD_TELEPORT)" and that fixed hanging cutscene back then. I'm testing it later in this install.

 

I accidently made patch from edited v9 not newest v11 back then and sent it accidently to you. Kulyok made changes to spawning of Daton and Qyr in v10 or v11.

[Lollorian]

Oh I get it Awaiting confirmation then