300 replies to this topic

[Lollorian]

I renamed the organization to BiGWorldProject sorry for the trouble

[agb1]

planarspheremod also needs to bundle iconv - I forgot to mention that because for me on Linux it is not needed, but on Windows the HANDLE_CHARSETS macro won't work without it.

For now, this has been done using the same _copy method as other mods.

[agb1]

Stuff of the Magi v4 is another mod which has been confirmed to work on EE after adding HANDLE_CHARSETS and iconv: https://forums.beamd...#Comment_701546

BWPFixpack'd

 

Or we could, ya know, make all dem mods point to the iconv inside the BWPFixpack yo! Dem HANDLE_CHARSETSs takes dem parameters called iconv_path

Done.  Added iconv folder to _utils folder in BiG World Fixpack, so iconv_path = BiG World Fixpack/_utils/iconv can be used for future HANDLE_CHARSETS patches.

[Lollorian]

Very nice

[Ineth]

Yes, that's much simpler than my idea...

 

---

 

Next up, for the TOD (Tower of Deception) mod it should be possible to make the TP2 cross-platform by replacing this:

AT_NOW ~TOD/MovieInstall.bat~

PRINT @105

AT_INTERACTIVE_UNINSTALL ~TOD/MovieUninstall.bat~

with something like this:

MAKE_BIFF ~VA#Movie~ BEGIN ~Mve~ ~.*\.mve~ END

PRINT @105

..right?
 

[agb1]

WeiDU doesn't like spaces in ~BiG World Fixpack/tools/iconv~ -- the HANDLE_CHARSETS patching fails.  I reverted to putting separate iconv in each folder.

[agb1]

Sorry, missed your point Ineth.  Cross-platform TOD -- yes, I think we can replace the movieinstall.bat and movieuninstall.bat.

 

http://gibberlings3....showtopic=27741 and https://forums.beamd...ption-for-bg2ee

Edited by agb1, 18 January 2016 - 04:40 PM.

[The Imp]

WeiDU doesn't like spaces in ~BiG World Fixpack/tools/iconv~ -- the HANDLE_CHARSETS patching fails.  I reverted to putting separate iconv in each folder.

But that action can be done with other tools, not weidu.exe's commands.

[agb1]

WeiDU doesn't like spaces in ~BiG World Fixpack/tools/iconv~ -- the HANDLE_CHARSETS patching fails.  I reverted to putting separate iconv in each folder.

But that action can be done with other tools, not weidu.exe's commands.

Please explain what you have in mind.  The problem we're trying to solve is duplication of iconv for each mod that needs to use HANDLE_CHARSETS.  We tried putting iconv in _utils/iconv in the BiG World Fixpack folder and pointing to it from multiple mods with iconv_path as an argument the HANDLE_CHARSETS but WeiDU doesn't like the spaces in "BiG World Fixpack" and the patching fails.  Actually worse, it zeroes out the original tra files...

[agb1]

Next up, for the TOD (Tower of Deception) mod it should be possible to make the TP2 cross-platform by replacing this:

AT_NOW ~TOD/MovieInstall.bat~

PRINT @105

AT_INTERACTIVE_UNINSTALL ~TOD/MovieUninstall.bat~

with something like this:

MAKE_BIFF ~VA#Movie~ BEGIN ~Mve~ ~.*\.mve~ END

PRINT @105

 

BG1UB does it like this:

 

MAKE_BIFF UBTAVERN BEGIN ~bg1ub/tavern/~ ~ubtavern.mve~ END

 

The path containing the file(s) to be biffed is relative path from game directory, not inside mod folder.  So a slight adjustment is needed from what you wrote, I think:  MAKE_BIFF ~VA#Movie~ BEGIN ~TOD/Mve/~ ~*.mve~ END

 

I've posted this suggestion on the Beamdog forum.

Edited by agb1, 19 January 2016 - 07:01 AM.

[agb1]

I am reviewing the changes in Baldurdash 1.73 for compatibility with BG2 Fixpack.  Has anyone else looked at this already?

 

There is a new tweak in with the "core Baldurdash fixes" component:

 

//-------------------------------------------------------------------------

//No failure and no limitation in spell memorisation (agb1: new in 1.73)

//-------------------------------------------------------------------------

 

COPY_EXISTING ~intmod.2da~ ~override~

  COUNT_2DA_ROWS ~5~ "rows"

  FOR (index = 3; index < rows ; index = index + 1) BEGIN

    SET_2DA_ENTRY_LATER ~intmod~ index 1 ~150~

    SET_2DA_ENTRY_LATER ~intmod~ index 2 ~9~

    SET_2DA_ENTRY_LATER ~intmod~ index 3 ~99~

  END

SET_2DA_ENTRIES_NOW ~intmod~ 1

BUT_ONLY_IF_IT_CHANGES

 

[Roxanne]

I am reviewing the changes in Baldurdash 1.73 for compatibility with BG2 Fixpack.  Has anyone else looked at this already?

 

There is a new tweak in with the "core Baldurdash fixes" component:

 

//-------------------------------------------------------------------------

//No failure and no limitation in spell memorisation (agb1: new in 1.73)

//-------------------------------------------------------------------------

 

COPY_EXISTING ~intmod.2da~ ~override~

  COUNT_2DA_ROWS ~5~ "rows"

  FOR (index = 3; index < rows ; index = index + 1) BEGIN

    SET_2DA_ENTRY_LATER ~intmod~ index 1 ~150~

    SET_2DA_ENTRY_LATER ~intmod~ index 2 ~9~

    SET_2DA_ENTRY_LATER ~intmod~ index 3 ~99~

  END

SET_2DA_ENTRIES_NOW ~intmod~ 1

BUT_ONLY_IF_IT_CHANGES

 

You can learn 99 spells on each level up to level 9 without limitation from your intelligence/specialisation or possibility to fail regardless of your current level (theoretically).

I cannot put my finger on it, but I seem to remember to have seen it  before, maybe it was just moved from somwhere else into Baldurdash?

Edited by Roxanne, 19 January 2016 - 03:19 PM.

[The Imp]

Yeah, it does exactly what it says... in broad strokes. The 150 could be closer to 115-125, and it give the possibility to learn 99 spells per level.

115 +-15 is 100% learning even with the -15% from the specialist made thingy that effects them. But my guess is that the value doesn't actually have a half word sized upper limit, but it's in ~206, where it becomes -50.

Make sure that the kit.ids numerazion is correct ... aka: the line number 7442 starts with:

//KIT.IDS (by Wisp !)
    COPY_EXISTING ~kit.ids~ ~override~
      REPLACE_TEXTUALLY ~.*[ %TAB%]TRUECLASS[ %TAB%]*~              ~0x4000 TRUECLASS~
      REPLACE_TEXTUALLY ~.*[ %TAB%]BERSERKER[ %TAB%]*~              ~0x4001 BERSERKER~
      REPLACE_TEXTUALLY ~.*[ %TAB%]WIZARDSLAYER[ %TAB%]*~           ~0x4002 WIZARDSLAYER~
      REPLACE_TEXTUALLY ~.*[ %TAB%]KENSAI[ %TAB%]*~                 ~0x4003 KENSAI~
      REPLACE_TEXTUALLY ~.*[ %TAB%]CAVALIER[ %TAB%]*~               ~0x4004 CAVALIER~
      REPLACE_TEXTUALLY ~.*[ %TAB%]INQUISITOR[ %TAB%]*~             ~0x4005 INQUISITOR~
      REPLACE_TEXTUALLY ~.*[ %TAB%]UNDEADHUNTER[ %TAB%]*~           ~0x4006 UNDEADHUNTER~
      REPLACE_TEXTUALLY ~.*[ %TAB%]MAGESCHOOL_ABJURER[ %TAB%]*~     ~0x0040 MAGESCHOOL_ABJURER~
      REPLACE_TEXTUALLY ~.*[ %TAB%]MAGESCHOOL_CONJURER[ %TAB%]*~    ~0x0080 MAGESCHOOL_CONJURER~
      REPLACE_TEXTUALLY ~.*[ %TAB%]MAGESCHOOL_DIVINER[ %TAB%]*~     ~0x0100 MAGESCHOOL_DIVINER~
      REPLACE_TEXTUALLY ~.*[ %TAB%]MAGESCHOOL_ENCHANTER[ %TAB%]*~   ~0x0200 MAGESCHOOL_ENCHANTER~
      REPLACE_TEXTUALLY ~.*[ %TAB%]MAGESCHOOL_ILLUSIONIST[ %TAB%]*~ ~0x0400 MAGESCHOOL_ILLUSIONIST~
      REPLACE_TEXTUALLY ~.*[ %TAB%]MAGESCHOOL_INVOKER[ %TAB%]*~     ~0x0800 MAGESCHOOL_INVOKER~
      REPLACE_TEXTUALLY ~.*[ %TAB%]MAGESCHOOL_NECROMANCER[ %TAB%]*~ ~0x1000 MAGESCHOOL_NECROMANCER~
      REPLACE_TEXTUALLY ~.*[ %TAB%]MAGESCHOOL_TRANSMUTER[ %TAB%]*~  ~0x2000 MAGESCHOOL_TRANSMUTER~
      REPLACE_TEXTUALLY ~.*[ %TAB%]MAGESCHOOL_GENERALIST[ %TAB%]*~  ~0x4000 MAGESCHOOL_GENERALIST~
      REPLACE_TEXTUALLY ~.*[ %TAB%]FERALAN[ %TAB%]*~                ~0x4007 FERALAN~
      REPLACE_TEXTUALLY ~.*[ %TAB%]STALKER[ %TAB%]*~                ~0x4008 STALKER~
      REPLACE_TEXTUALLY ~.*[ %TAB%]BEASTMASTER[ %TAB%]*~            ~0x4009 BEASTMASTER~
      REPLACE_TEXTUALLY ~.*[ %TAB%]ASSASIN[ %TAB%]*~                ~0x400A ASSASIN~
      REPLACE_TEXTUALLY ~.*[ %TAB%]BOUNTYHUNTER[ %TAB%]*~           ~0x400B BOUNTYHUNTER~
      REPLACE_TEXTUALLY ~.*[ %TAB%]SWASHBUCKLER[ %TAB%]*~           ~0x400C SWASHBUCKLER~
      REPLACE_TEXTUALLY ~.*[ %TAB%]BLADE[ %TAB%]*~                  ~0x400D BLADE~
      REPLACE_TEXTUALLY ~.*[ %TAB%]JESTER[ %TAB%]*~                 ~0x400E JESTER~
      REPLACE_TEXTUALLY ~.*[ %TAB%]SKALD[ %TAB%]*~                  ~0x400F SKALD~
      REPLACE_TEXTUALLY ~.*[ %TAB%]GODTALOS[ %TAB%]*~               ~0x4013 GODTALOS~
      REPLACE_TEXTUALLY ~.*[ %TAB%]GODHELM[ %TAB%]*~                ~0x4014 GODHELM~
      REPLACE_TEXTUALLY ~.*[ %TAB%]GODLATHANDER[ %TAB%]*~           ~0x4015 GODLATHANDER~
      REPLACE_TEXTUALLY ~.*[ %TAB%]TOTEMIC[ %TAB%]*~                ~0x4010 TOTEMIC~
      REPLACE_TEXTUALLY ~.*[ %TAB%]SHAPESHIFTER[ %TAB%]*~           ~0x4011 SHAPESHIFTER~
      REPLACE_TEXTUALLY ~.*[ %TAB%]BEASTFRIEND[ %TAB%]*~            ~0x4012 BEASTFRIEND~
      REPLACE_TEXTUALLY ~.*[ %TAB%]BARBARIAN[ %TAB%]*~              ~0x40000000 BARBARIAN~
      REPLACE_TEXTUALLY ~.*[ %TAB%]WILDMAGE[ %TAB%]*~               ~0x80000000 WILDMAGE~
    BUT_ONLY
     
    APPEND ~kit.ids~ ~0x4000 TRUECLASS~ UNLESS ~[ %TAB%]TRUECLASS[ %TAB%]*~
    APPEND ~kit.ids~ ~0x40000000 BARBARIAN~ UNLESS ~[ %TAB%]BARBARIAN[ %TAB%]*~
    APPEND ~kit.ids~ ~0x80000000 WILDMAGE~ UNLESS ~[ %TAB%]WILDMAGE[ %TAB%]*~

Instead of what's in it now.

Edited by The Imp, 19 January 2016 - 03:19 PM.

[agb1]

That seems like a tweak, not a core fix -- ?

 

Here is another new one:

 

//-------------------------------------------------------------------------

//Drow Item\Avatar Fixes (agb1: new in 1.73)

//-------------------------------------------------------------------------

 

Edited by agb1, 21 January 2016 - 06:58 PM.

[agb1]

Two more new tweaks, still in the core fixes component:

 

Spoiler

//-------------------------------------------------------------------------

//Botomless Bag of Holding (agb1: new in 1.73)

//-------------------------------------------------------------------------

 

COPY_EXISTING_REGEXP GLOB ~^.+\.sto$~ ~override~

  READ_LONG 0x08 "itemtype" ELSE 0

  PATCH_IF ("%itemtype%" = 5) BEGIN

    WRITE_SHORT 0x22 32767

  END

BUT_ONLY_IF_IT_CHANGES

 

 

//-------------------------------------------------------------------------

//Stackable items (agb1: new in 1.73)

//-------------------------------------------------------------------------

 

//Potions

COPY_EXISTING_REGEXP GLOB ~^.+\.itm$~ ~override~

  READ_SHORT  0x1C "type" ELSE 0

  PATCH_IF ("%type%" = 9) BEGIN

    WRITE_SHORT 0x38 999

  END

  BUT_ONLY_IF_IT_CHANGES

 

//Scrolls

COPY_EXISTING_REGEXP GLOB ~^.+\.itm$~ ~override~

  READ_SHORT  0x1C "type" ELSE 0

  PATCH_IF ("%type%" = 11) BEGIN

    WRITE_SHORT 0x38 999

  END

BUT_ONLY_IF_IT_CHANGES

 

//Ammo (arrows, bullets, daggers, bolts, darts and axes)

COPY_EXISTING_REGEXP GLOB ~^.+\.itm$~ ~override~

  READ_SHORT  0x1C "type" ELSE 0

  READ_SHORT  0x38 "max"  ELSE 0

  PATCH_IF (

             ("%max%" > 1) AND

             (

               ("%type%" =  5) OR

               ("%type%" = 14) OR

               ("%type%" = 16) OR

               ("%type%" = 31) OR

               ("%type%" = 24) OR

               ("%type%" = 25)

             )

           ) BEGIN

    WRITE_SHORT 0x38 999

  END

BUT_ONLY_IF_IT_CHANGES

 

//Amulets, rings, coins and gems 

COPY_EXISTING_REGEXP GLOB ~^.+\.itm$~ ~override~

  PATCH_IF (SOURCE_SIZE > 0x71) THEN BEGIN

    READ_SHORT 0x1c "type"     ELSE 0

    READ_SHORT 0x68 "max_abil" ELSE 0

    READ_SHORT 0x70 "max_fx"   ELSE 0

    PATCH_IF (

               ("%max_abil%" = 0) AND

               ("%max_fx%" = 0) AND

               (

                 ("%type%" =  1) OR

                 ("%type%" = 10) OR

                 ("%type%" = 33) OR

                 ("%type%" = 34)

               )

             ) BEGIN

      WRITE_SHORT 0x38 999

    END

  END

BUT_ONLY_IF_IT_CHANGES

[agb1]

Here's one that hasn't changed since Bdash 1.68 but BWFixpack had it commented out with a note "(LW: unsure, whether in Fixpack)":

 

//-------------------------------------------------------------------------

//Druid Multi\Dual-Class Stronghold Fix (agb1: same as 1.68, not in Fixpack)

//-------------------------------------------------------------------------

COPY_EXISTING ~ar1901.bcs~ ~override~

 DECOMPILE_BCS_TO_BAF

 REPLACE_TEXTUALLY ~CreateCreatureObjectEffect("Drshsp01","SPFLESHS",Player1)~ ~CreateCreatureObject("Drshsp01",Player1,0,0,0)~

 REPLACE_TEXTUALLY ~CreateCreatureObjectEffect("TREVIL03","SPDIMNDR",Player1)~ ~CreateCreatureObject("TREVIL03",Player1,0,0,0)~

 COMPILE_BAF_TO_BCS

 EXTEND_BOTTOM ~ar1901.bcs~ ~BDash\BAF_b\bAR1901.BAF~

 

COMPILE ~BDash\D\rCECHALL.D~

 

bAR1901.baf:  

Spoiler

IF

!Global("DruidLevel14","AR1901",1)

Class(Player1,DRUID)

LevelGT(Player1,13)

CheckStat(Player1,0,LEVEL2)

THEN

RESPONSE #100

SetGlobal("DruidLevel14","AR1901",1)

END

 

IF

!Global("DruidLevel14","AR1901",1)

Class(Player1,DRUID_ALL)

CheckStatGT(Player1,13,LEVEL2)

THEN

RESPONSE #100

SetGlobal("DruidLevel14","AR1901",1)

END

 

IF

!Global("DruidLevel14","AR1901",2)

Class(Player1,DRUID)

OR(2)

LevelLT(Player1,14)

CheckStatGT(Player1,0,LEVEL2)

THEN

RESPONSE #100

SetGlobal("DruidLevel14","AR1901",2)

END

 

IF

!Global("DruidLevel14","AR1901",2)

Class(Player1,FIGHTER_DRUID)

CheckStatLT(Player1,14,LEVEL2)

THEN

RESPONSE #100

SetGlobal("DruidLevel14","AR1901",2)

END

 

IF

!Global("DruidLevel14","AR1901",0)

!Class(Player1,DRUID_ALL)

THEN

RESPONSE #100

SetGlobal("DruidLevel14","AR1901",0)

END

 

rCECHALL.D:  

Spoiler

REPLACE_TRIGGER_TEXT ~CECHALLE~

~Class(Player1,DRUID_ALL)[^!]*

LevelGT(Player1,13)[^!]*

Global("GreatDruid","GLOBAL",0)[^!]*

!Global("GaveTitle","LOCALS",1)~

~Global("DruidLevel14","AR1901",1)

Global("GreatDruid","GLOBAL",0)

!Global("GaveTitle","LOCALS",1)~

 

REPLACE_TRIGGER_TEXT ~CECHALLE~

~Class(Player1,DRUID_ALL)[^!]*

LevelLT(Player1,14)[^!]*

Global("GreatDruid","GLOBAL",0)[^!]*

!Global("GaveTitle","LOCALS",1)~

~Global("DruidLevel14","AR1901",2)

Global("GreatDruid","GLOBAL",0)

!Global("GaveTitle","LOCALS",1)~

 

//state #2

[agb1]

Here is another carry-over from 1.68 that was disabled by BW Fixpack but doesn't appear to conflict with BG2 Fixpack:

 

//-------------------------------------------------------------------------

//Wands Fixes (LW: unsure, whether in Fixpack)

//-------------------------------------------------------------------------

Spoiler

COPY_EXISTING ~WAND02.ITM~ ~override~

              ~WAND04.ITM~ ~override~

              ~WAND05.ITM~ ~override~

              ~WAND06.ITM~ ~override~

              ~WAND07.ITM~ ~override~

              ~WAND09.ITM~ ~override~

              ~WAND10.ITM~ ~override~

              ~WAND11.ITM~ ~override~

              ~WAND14.ITM~ ~override~

              ~WAND15.ITM~ ~override~

 WRITE_LONG 0x1e 0x20720800

BUT_ONLY_IF_IT_CHANGES

 

COPY_EXISTING ~WAND13.ITM~ ~override~

 WRITE_LONG 0x1e 0x20720800

 READ_LONG 0x64 "ability_offset"

 READ_SHORT 0x68 "ability_cnt"

 READ_LONG 0x6a "eff_offset"

 FOR( cnt=0; cnt<"%ability_cnt%"; cnt=cnt+1 ) BEGIN

   READ_BYTE ("%ability_offset%"+0x38*cnt) "type"

   PATCH_IF ("%type%"=3) BEGIN      //Magical

     READ_SHORT ("%ability_offset%"+0x38*cnt+0x1e)  eff_number

     READ_SHORT ("%ability_offset%"+0x38*cnt+0x20)  eff_idx

     FOR( cnt2=0; cnt2<eff_number; cnt2=cnt2+1 ) BEGIN

       READ_SHORT ("%eff_offset%"+0x30*(cnt2+eff_idx))  "eff_type"

       PATCH_IF( "%eff_type%" = 12 ) BEGIN  //damage

         WRITE_BYTE ("%eff_offset%"+0x30*(cnt2+eff_idx)+13) 1   //dispell\not bypass resistance

       END

     END

   END

 END

BUT_ONLY_IF_IT_CHANGES

 

On closer look, the second block is identical to BG2 Fixpack (fixes wand of cloudkill bypassing MR).  The first block I don't know what it does, and I'm not sure if it conflicts with BG2 Fixpack ... which also patches the same wands using different code.

Edited by agb1, 19 January 2016 - 04:24 PM.

[The Imp]

The first block I don't know what it does, and I'm not sure if it conflicts with BG2 Fixpack ... which also patches the same wands using different code.

It's sets the wands usability flags to what ever they finally become from that.

Two more new tweaks...

Yep, one sets arrows etc items to be stack-able to 999 limit, while the other sets the bags of holding to be bottomless with an actual bottom, aka the items won't disappear.

Edited by The Imp, 19 January 2016 - 04:48 PM.

[agb1]

Bag of holding default storage capacity is 100, so patching it to 32767 is not a necessary fix, right?

 

Any thoughts on the stronghold fix above?

Edited by agb1, 19 January 2016 - 05:49 PM.

[The Imp]

Bag of holding default storage capacity is 100, so patching it to 32767 is not a necessary fix, right?

Well to me it's a fix, but to others it depends on how stupid they want to feel ... ... but that's just my thinking on it, there's several tweak mods that do the same. And as they are later, they cover more items and so do it better.
Well, I put it to 32000 cause I am sometimes bad calculator and want to make sure it won't go over hte border.

The stronghold... well I would use DECOMPILE_AND_PATCH BEGIN
//patch
END

-command structure instead of the DECOMPILE_BCS_TO_BAF
//patch
COMPILE_BAF_TO_BCS

But that's just me.

Edited by The Imp, 19 January 2016 - 06:55 PM.