100 replies to this topic

[horred the plague]

I found this problem, as well as another with the same script snippet. It was just a matter of missing Identifiers, and this was caused by BP and not by Tactics. Just replaced them with raw numerical entries instead. Those can compile independent of any IDS naming. Thus, I have it all fixed up and ready for next release version.

[horred the plague]

can you give us the solution Mikael ? I have the same problem (obviously)

 

 tAR3000.BAF   841bytes   360 downloads

 

(From the newest version, a WIP.) Throw this in your BP/RITUAL folder, reinstall and game on.

[horred the plague]

Minor addition from my part: there's another tAR3000.BAF in BP/REDB folder, which needs similar modification since it has similar codes.
Please don't get mad at me if this is redundant. :-s

Thanks for pointing it out. It doesn't need any fixes; nobody tried to use compass points (letters) instead of numbers here. Either that or it was fixed a while back. I never play Weimer's Tactics mods, because I dislike their whole approach to AI. I look forward to the day they are no longer a part of BP. Thus, I won't spend a minute on them unless somebody brings something like this to my attention.

[horred the plague]

Hello everyone!

I've got a problem with component of BP - "Patching all innates abilities to level one". The error is about phrasing in sftrolxd.bcs, which makes patching a failure. I've found just one post related to the name of this file and it looks like it is a BGSpawn fault, am I right? Is there any way to repair it without starting all over?

Regards.

 

Sorry, I posted in another forum about this one. In cases like these, when other mods are getting in the way, I advise using Lol's Mod Fixer instead. I devised the original code which made this fix, but Lollorian ran w/ the ball and made it work w/ many mods also.

 

As for repairing it at this point...I can't say for sure, but it sounds possible if all you missed was that singular piece. You could just install Lol's Fixer at the end, and game on.

 

 

IMPORTANT: I keep forgetting to mention this. The level one innate fix is not as important in BG2EE/BGEE as it was in BG2:ToB. In the latter it was cause a CTD. The CTD side at least was fixed for the EE series. Worst you might see is a spell not being cast, and possibly not even that. So, you can probably skip that if you like and not suffer too greatly (I hope).

Edited by horred the plague, 16 February 2014 - 08:09 AM.

[pro5]

After starting a new BGT game, I was a bit surprised to have Firebeard Elvenhair start casting hostile spells (in various attempts it was either horror, melf's acid arrow, or magic missile) at me right after first entering Candlekeep Inn. He remained neutral (blue circle) and did not cast more spells after the first one.

I tracked the problem down to BPMAGE6 script the old man had assigned.

This script block (used in most BP scripts, apparently) should be preventing the above from happening - in theory. Hostile actions follow it, so they won't get a chance to execute if this block fires:

IF
  OR(2)
  !Allegiance(Myself,EVILCUTOFF)
  !Detect([GOODCUTOFF])
THEN
  RESPONSE #100
END

However, for some reason it doesn't work on the first round after entering the area. The engine seems to treat such empty block as one with Continue() and Firebead happily proceeds to blast LastSeenBy(hisass) with all his sorcerous might.

I added NoAction() into the block and this appears to have fixed the problem:

IF
  OR(2)
  !Allegiance(Myself,EVILCUTOFF)
  !Detect([GOODCUTOFF])
THEN
  RESPONSE #100
    NoAction()
END

At first I thought this was a result of some other mod messing with BP scripts (I was running large BWS install), but then I was able to reproduce this on a cleaner BGT + BP only install, so I'm reporting the problem.

The total amount of BP scripts with exact same script block is over a hundred.

[horred the plague]

After starting a new BGT game, I was a bit surprised to have Firebeard Elvenhair start casting hostile spells (in various attempts it was either horror, melf's acid arrow, or magic missile) at me right after first entering Candlekeep Inn. He remained neutral (blue circle) and did not cast more spells after the first one.

I tracked the problem down to BPMAGE6 script the old man had assigned.

This script block (used in most BP scripts, apparently) should be preventing the above from happening - in theory. Hostile actions follow it, so they won't get a chance to execute if this block fires:

IF
  OR(2)
  !Allegiance(Myself,EVILCUTOFF)
  !Detect([GOODCUTOFF])
THEN
  RESPONSE #100
END

However, for some reason it doesn't work on the first round after entering the area. The engine seems to treat such empty block as one with Continue() and Firebead happily proceeds to blast LastSeenBy(hisass) with all his sorcerous might.

I added NoAction() into the block and this appears to have fixed the problem:

IF
  OR(2)
  !Allegiance(Myself,EVILCUTOFF)
  !Detect([GOODCUTOFF])
THEN
  RESPONSE #100
    NoAction()
END

At first I thought this was a result of some other mod messing with BP scripts (I was running large BWS install), but then I was able to reproduce this on a cleaner BGT + BP only install, so I'm reporting the problem.

The total amount of BP scripts with exact same script block is over a hundred.

 

Thanks, and I'm glad it solved your immediate problem. There's a larger problem with doing this on a grand scale however. The action NoAction() causes all script actions to end for that parsing round. So, no scripts after this, in the entire 5 slots available for creatures, will fire either. This in turn can break far more serious things, than cause something simple like casting a buff spell. To fix this exclusively would require special scripting for Firebeard, not a generic fix that would break dozens of other situations. Honestly, it's just a buff that happens to be visible. For the harm it causes (next to none), I'm not really sure it's worth the time and effort it would take to fix this on a grand scale. It would be easier to add an exclusion for Firebeard, let him keep his vanilla scripts, and be done with it.

[pro5]

Thanks, and I'm glad it solved your immediate problem. There's a larger problem with doing this on a grand scale however. The action NoAction() causes all script actions to end for that parsing round. So, no scripts after this, in the entire 5 slots available for creatures, will fire either. This in turn can break far more serious things, than cause something simple like casting a buff spell. To fix this exclusively would require special scripting for Firebeard, not a generic fix that would break dozens of other situations. Honestly, it's just a buff that happens to be visible. For the harm it causes (next to none), I'm not really sure it's worth the time and effort it would take to fix this on a grand scale. It would be easier to add an exclusion for Firebeard, let him keep his vanilla scripts, and be done with it.

Ok, I didn't actually know that empty execution blocks allows lower scripts to fire. Or I did know, but completely forgot - one of those.

But I still think there's a better solution than to fix this on an exclusion basis (which would likely miss something somewhere and also wouldn't cover any mod-introduced NPCs unless you're volunteering to add hundreds of compatibility checks into your TP2). I can confirm that this also works:

IF
  OnCreation()
  OR(2)
  !Allegiance(Myself,EVILCUTOFF)
  !Detect([GOODCUTOFF])
THEN
  RESPONSE #100
    NoAction()
END

IF
  OR(2)
  !Allegiance(Myself,EVILCUTOFF)
  !Detect([GOODCUTOFF])
THEN
  RESPONSE #100    
END

Like I originally thought, the problem only happens in the first AI round after entering the area. Additional OnCreation() check prevents it from happening in that particular round. Personally, I'll take the risk of some script not firing at once after entering over risk of getting a fireball or something nastier in my face for no reason. But maybe that's just me.

Note that it's not just "buffs" - the consequences depend on the script and the creature, and in this case, Firebeard could cast for instance Melf's Acid Arrow. Which at level 1 in Candlekeep could, well, kill you. Not to mention such things are immersion-breaking.

Edited by pro5, 24 February 2014 - 09:00 AM.

[The Imp]

Note that it's not just "buffs" - the consequences depend on the script and the creature, and in this case, Firebeard could cast for instance Melf's Acid Arrow. Which at level 1 in Candlekeep could, well, kill you. Not to mention such things are immersion-breaking.

Erhm, if that's so then who ever coded the MAA's casting script was unconsciously cheating, after all it's target needs first of all be visible to the caster--- as the LastSeenBy() by itself should never be used as the target ... but with an inner function, such as LastSeenBy(Myself) ---during the targeting phase. 

[pro5]

Note that it's not just "buffs" - the consequences depend on the script and the creature, and in this case, Firebeard could cast for instance Melf's Acid Arrow. Which at level 1 in Candlekeep could, well, kill you. Not to mention such things are immersion-breaking.

Erhm, if that's so then who ever coded the MAA's casting script was unconsciously cheating, after all it's target needs first of all be visible to the caster--- as the LastSeenBy() by itself should never be used as the target ... but with an inner function, such as LastSeenBy(Myself) ---during the targeting phase. 
 

Targeting blocks are there, but they have Continue(), so the casting phase happens in the same first round. At least that's my guess without picking the script apart line by line.

[horred the plague]

Note that it's not just "buffs" - the consequences depend on the script and the creature, and in this case, Firebeard could cast for instance Melf's Acid Arrow. Which at level 1 in Candlekeep could, well, kill you. Not to mention such things are immersion-breaking.

 

 

Potential is not actual, in this case. In 11 years of that script, not one single report has come in of Firebeard attacking anybody that didn't have it coming (pickpocket failed, attacked first, etc). Not even your report makes this claim. The fire shield buff is well-known, and was dismissed as benign/trivial. Mages are well-known to buff, albeit fire shield is more a short duration combat buff than a general type. So the worst crime I can see is using the wrong buff at the right time.

 

Scripts aren't in front of my face ATM. Is the buff block before, or after, the shutoff block that you're trying to fix? As is I think you're attacking the wrong problem, and your 'fix' was more coincidental than effective. If the buffing is before this block, try moving it after that block. Also, that's not the only shutoff block in the scripts, if memory serves correctly. 

 

I'm not doing any major surgery on these scripts, especially for just a beauty-fix. I neither have the time nor inclination for a complete reworking after all these years. I was going to simply retire this old mod a couple months back, until I was asked nicely not-to.

[pro5]

Horred, when I say 'for no reason' it means just that. I enter the tavern, he starts casting. There's no fire-shield or any other kind of buff, he's casting offensive spells (usually Horror, sometimes Magic Missile or MAA depending on what the RandomNum triggers roll).

The shutoff block I'm changing is at line 439. The spells being cast (Horror, Magic Missile, MAA) are after it, at lines 1259, 1295, and 1313.

Weidu.log is this:

Spoiler

// Log of Currently Installed WeiDU Mods
// The top of the file is the 'oldest' mod
// ~TP2_File~ #language_number #component_number // [Subcomponent Name ->] Component Name [ : Version]
~SETUP-BGT.TP2~ #0 #0 // Baldur's Gate Trilogy - Core: 1.18 (28 Apr 13)
~SETUP-GUI.TP2~ #0 #2 // ?????? -> : ???
~SETUP-TUTUSOUNDS.TP2~ #0 #1 // Casting Sounds -> Restored BG1 Casting Sounds Only
~TXTMUSIC/TXTMUSIC.TP2~ #0 #0 // Restored Textscreen Music for BG1TuTu, EasyTutu, and BGT-WeiDU
~SETUP-XPMOD.TP2~ #0 #9 // Locks, Traps and Spells XP Reduction -> Reduce to 10%
~WIDESCREEN/WIDESCREEN.TP2~ #0 #0 // Widescreen Mod -> for the original Infinity Engine (CHOOSE THIS!): Widescreen Mod v2.31
~SETUP-BGTMUSIC.TP2~ #0 #2 // Baldur's Gate Trilogy - Music -> Full Baldur's Gate/Shadows of Amn/Throne of Bhaal Music (WARNING: patches BGMain.exe)
~BP/SETUP-BP.TP2~ #0 #0 // Big Picture, core component (required for most subcomponents): v181-b4611
~BP/SETUP-BP.TP2~ #0 #10 // Patching all the existing innate spells, setting level to one.....: v181-b4611
~BP/SETUP-BP.TP2~ #0 #35 // Add Bags and Magic Throwing Daggers to Stores: v181-b4611
~BP/SETUP-BP.TP2~ #0 #50 // Level-50 Ruleset (Code By King Diamond): v181-b4611
~BP/SETUP-BP.TP2~ #0 #60 // Custom Grandmastery (w/ extra attacks): v181-b4611
~BP/SETUP-BP.TP2~ #0 #325 // Animals: v181-b4611
~BP/SETUP-BP.TP2~ #0 #350 // Beholders: v181-b4611
~BP/SETUP-BP.TP2~ #0 #375 // Demons and Devils: v181-b4611
~BP/SETUP-BP.TP2~ #0 #390 // Djinni, Efreet, & Dao: v181-b4611
~BP/SETUP-BP.TP2~ #0 #400 // Dragons: v181-b4611
~BP/SETUP-BP.TP2~ #0 #425 // Drow: v181-b4611
~BP/SETUP-BP.TP2~ #0 #440 // Duergars -> Duergar: The Works: v181-b4611
~BP/SETUP-BP.TP2~ #0 #475 // Elementals: v181-b4611
~BP/SETUP-BP.TP2~ #0 #500 // Generic Mages: v181-b4611
~BP/SETUP-BP.TP2~ #0 #525 // Generic Priests: v181-b4611
~BP/SETUP-BP.TP2~ #0 #550 // Generic Thieves: v181-b4611
~BP/SETUP-BP.TP2~ #0 #575 // Githyanki: v181-b4611
~BP/SETUP-BP.TP2~ #0 #600 // Golems: v181-b4611
~BP/SETUP-BP.TP2~ #0 #625 // Hellhounds: v181-b4611
~BP/SETUP-BP.TP2~ #0 #650 // Humanoids: v181-b4611
~BP/SETUP-BP.TP2~ #0 #675 // Knights and Paladins: v181-b4611
~BP/SETUP-BP.TP2~ #0 #700 // Mind Flayers: v181-b4611
~BP/SETUP-BP.TP2~ #0 #725 // Mists: v181-b4611
~BP/SETUP-BP.TP2~ #0 #750 // Sea Devils: Sahuagin and Kuo-Toan Enhancements: v181-b4611
~BP/SETUP-BP.TP2~ #0 #760 // Shadow and Wraith Enhancements -> Shadows - The Works: v181-b4611
~BP/SETUP-BP.TP2~ #0 #800 // Shadow Thieves: v181-b4611
~BP/SETUP-BP.TP2~ #0 #875 // Trolls: v181-b4611
~BP/SETUP-BP.TP2~ #0 #900 // Undead (Except Shadows/Wraiths/Vampires): v181-b4611
~BP/SETUP-BP.TP2~ #0 #925 // Were-Animals: v181-b4611
~BP/SETUP-BP.TP2~ #0 #150 // Generic Creature & Script Processing: v181-b4611
~BP/SETUP-BP.TP2~ #0 #175 // Fewer On-Screen Shouts: v181-b4611
~BP/SETUP-BP.TP2~ #0 #1000 // Generic Encounter Enhancements: v181-b4611
~BP/SETUP-BP.TP2~ #0 #1020 // Beholder Cult: v181-b4611
~BP/SETUP-BP.TP2~ #0 #1070 // Vampire Encounters -> Chapter 3 and 6 (w/ bodhi): v181-b4611
~BP/SETUP-BP.TP2~ #0 #1100 // Copper Coronet and Slavers: v181-b4611
~BP/SETUP-BP.TP2~ #0 #1130 // Drizzt Encounter (Chapter 6): v181-b4611
~BP/SETUP-BP.TP2~ #0 #1140 // Druidic Improvements -> Druid Grove (with Druid Encounter): v181-b4611
~BP/SETUP-BP.TP2~ #0 #1170 // Treant Encounter: v181-b4611
~BP/SETUP-BP.TP2~ #0 #1190 // Hell Trial Additions: v181-b4611
~BP/SETUP-BP.TP2~ #0 #1200 // Horreds Lair: v181-b4611
~BP/SETUP-BP.TP2~ #0 #1210 // Irenicus Dungeon Enhancements (except Duergar): v181-b4611
~BP/SETUP-BP.TP2~ #0 #1300 // Mae Var: v181-b4611
~BP/SETUP-BP.TP2~ #0 #1315 // Nalia Quests: v181-b4611
~BP/SETUP-BP.TP2~ #0 #1330 // Tavern Brawl (In the Seven Veils): v181-b4611
~BP/SETUP-BP.TP2~ #0 #1350 // Planar Prison: v181-b4611
~BP/SETUP-BP.TP2~ #0 #1375 // Planar Sphere Enhancements (including Tolgerias): v181-b4611
~BP/SETUP-BP.TP2~ #0 #1570 // Improved Spellhold -> Spellhold Enhancments - Full Package: v181-b4611
~BP/SETUP-BP.TP2~ #0 #1600 // Improved Suldanessallar: v181-b4611
~BP/SETUP-BP.TP2~ #0 #1625 // Tanners Quest: v181-b4611
~BP/SETUP-BP.TP2~ #0 #1650 // Trademeet Enhancements: v181-b4611
~BP/SETUP-BP.TP2~ #0 #1675 // Wand of Orcus Add-In: v181-b4611
~BP/SETUP-BP.TP2~ #0 #1700 // Windspear Hills Enhancements: v181-b4611
~BP/SETUP-BP.TP2~ #0 #1725 // Improved Xvart Village, for BGT-weidu: v181-b4611
~BP/SETUP-BP.TP2~ #0 #1750 // Watchers Keep Improvements: v181-b4611
~BP/SETUP-BP.TP2~ #0 #1800 // ToB Improvements: v181-b4611
~BP/SETUP-BP.TP2~ #0 #2000 // Ascension for BP: v181-b4611
~BP/SETUP-BP.TP2~ #0 #2100 // Improved Abazigal: v181-b4611
~BP/SETUP-BP.TP2~ #0 #2200 // Improved Demogorgon: v181-b4611
~BP/SETUP-BP.TP2~ #0 #2300 // Improved Gromnir: v181-b4611
~BP/SETUP-BP.TP2~ #0 #2400 // Improved Illasera: v181-b4611
~BP/SETUP-BP.TP2~ #0 #2500 // Improved Sendai: v181-b4611
~BP/SETUP-BP.TP2~ #0 #2600 // Improved Yaga-Shura: v181-b4611

Attached Images

• 
• 

[horred the plague]

When I finish my second job of the day, after this job--if I'm not comatose, I'll dust off my copy and fire up BGT and give this a try. Forgive my skepticism but I need to see it for myself. It's very odd that a script that has been stable for 11 years suddenly acts up, when nobody has touched it.

Edited by horred the plague, 24 February 2014 - 11:54 AM.

[pro5]

When I finish my second job of the day, after this job--if I'm not comatose, I'll dust off my copy and fire up BGT and give this a try. Forgive my skepticism but I need to see it for myself. It's very odd that a script that has been stable for 11 years suddenly acts up, when nobody has touched it.

I understand. I'll try this on a new install on my side just in case to see if maybe my "clean" BGT installation is fubared somehow.

[pro5]

Was able to reproduce it again on a clean install with this WeiDU log:

~BG2FIXPACK/SETUP-BG2FIXPACK.TP2~ #0 #0 // BG2 Fixpack - Core Fixes: v10
~BG2FIXPACK/SETUP-BG2FIXPACK.TP2~ #0 #1000 // BG2 Fixpack - Game Text Update -> GTU Light (by Wisp): v10
~SETUP-BGT.TP2~ #0 #0 // Baldur's Gate Trilogy - Core: 1.18 (28 Apr 13)
~SETUP-BGTMUSIC.TP2~ #0 #2 // Baldur's Gate Trilogy - Music -> Full Baldur's Gate/Shadows of Amn/Throne of Bhaal Music (WARNING: patches BGMain.exe)
~BP/SETUP-BP.TP2~ #0 #0 // Big Picture, core component (required for most subcomponents): v181-b4611
~BP/SETUP-BP.TP2~ #0 #10 // Patching all the existing innate spells, setting level to one.....: v181-b4611
~BP/SETUP-BP.TP2~ #0 #500 // Generic Mages: v181-b4611
~BP/SETUP-BP.TP2~ #0 #150 // Generic Creature & Script Processing: v181-b4611

In case it matters for script targeting, I always used the same choices in character generation (and I always started a new game for each test): male, human, fighter.

[horred the plague]

Was bothering me enough, I checked on it between jobs. Sure enough, I saw what you described. I checked on a BP backup from 2006--the same line is in there. Obviously this hasn't been going on for 8 years, or I'd have heard it by now.

 

So, on a whim, I assigned Firebeard the vanilla script equivalents of the BP scripts--mage6 and wtasight. Did you try this test? I had the same results as with the BP scripts. Firebeard still attacked. So, obviously there's something going on, but BP is innocent I say. I don't see anything in his CRE file to cause this either. Not sure what exactly to expect, but if you installed just bp and bgt like I did, and BP is not to blame, nor the vanilla game, what's left? tob-ex and bgt. I don't recall ever seeing this in the early days of bgt, before there was a tob-ex, so tob-ex is my suspect.

 

I stake this claim on nothing more than the evidence I had in front of me--couldn't begin to tell you what is wrong. I can only tell you what isn't causing it---my mod.

 

 

P.S: My install was just BGT w/ the BP core, a couple tweaks, and all the creature AI components (inc mages & generic)

Edited by horred the plague, 24 February 2014 - 03:22 PM.

[pro5]

So, on a whim, I assigned Firebeard the vanilla script equivalents of the BP scripts--mage6 and wtasight. Did you try this test? I had the same results as with the BP scripts. Firebeard still attacked. So, obviously there's something going on, but BP is innocent I say. I don't see anything in his CRE file to cause this either. Not sure what exactly to expect, but if you installed just bp and bgt like I did, and BP is not to blame, nor the vanilla game, what's left? tob-ex and bgt. I don't recall ever seeing this in the early days of bgt, before there was a tob-ex, so tob-ex is my suspect.

I didn't try it, but I'm trying it now and I also tried uninstalling BP. I hate to say it, but in either case (changing script to mage6 and uninstalling) , Firebeard doesn't attack on my end. To be sure, I tried several times, because I noticed earlier there's a certain randomness to the result (in one case during my earlier tests, he didn't attack me; although in the next attempt in exact same install, he did).

The vanilla MAGE6 script only has 80 lines and every block starts with See(NearestEnemyOf(Myself)) condition... are you certain yours is the same when he's assaulting you with it? I don't think BGT includes anything from TobEx, as Ascension64 specifically did not want it to depend on the latter. It doesn't even include the exe patch to remove songlist limit - that one was outsourced into BGTMusic.

I'll understand if you don't want to waste more time on debugging this, but it'd be nice to have a bit more clarity as to what causes this.