5 replies to this topic

[Anomaly]

Hello,

I have to report a very odd problem that seems to be caused by TobEx.

If a mod adds (vanilla) spells scrolls to a store after Tobex core (24) is installed, the newly added spells will only cost 1gp. Without TobEx there is no problem, and already existing spells for sale get a correct price.

Way to reproduce :

- Install TobEx 24 core only on a BG2 vanilla install (even without BG2FixPack, but the problem is the same with BG2 FixPack)
- Install component 410 of my Anomaly Tweak Pack Mod (a component that adds some spells scrolls to the scroll shop in Adventurer's Mart, see below for the code I use and download link)
- Start a TOB game (to avoid the SOA cutscene)
- Teleport to AR0702 with console
- Ask to see the scroll shop
- Notice that the original scrolls are of the correct price, but the added ones (at the end) cost 1 gp only
- If you remove TobEx and retry, all scrolls will get the correct price

My mod is only using basic WeiDU stuff to add scrolls :

BEGIN @410 DESIGNATED 410
REQUIRE_PREDICATE GAME_IS ~tob~ @999

COPY_EXISTING ~scrolls.sto~ ~override/scrolls.sto~
ADD_STORE_ITEM ~SCRL6H~ LAST #0 #0 #0 ~IDENTIFIED~ #3 // Protection contre le feu
ADD_STORE_ITEM ~SCRL6I~ LAST #0 #0 #0 ~IDENTIFIED~ #3 // Protection contre le froid
ADD_STORE_ITEM ~SCRL5T~ LAST #0 #0 #0 ~IDENTIFIED~ #3 // Protection contre l'<E9>lectricit<E9>
ADD_STORE_ITEM ~SCRL6Y~ LAST #0 #0 #0 ~IDENTIFIED~ #3 // Protection contre l'acide
ADD_STORE_ITEM ~SCRL1V~ LAST #0 #0 #0 ~IDENTIFIED~ #3 // Porte dimensionnelle
ADD_STORE_ITEM ~SCRL1J~ LAST #0 #0 #0 ~IDENTIFIED~ #3 // Invisibilit<E9> sur 3m
ADD_STORE_ITEM ~SCRLA7~ LAST #0 #0 #0 ~IDENTIFIED~ #3 // D<E9>livrance de la magie
ADD_STORE_ITEM ~SCRL8X~ LAST #0 #0 #0 ~IDENTIFIED~ #3 // Bouclier <E0> sorts
ADD_STORE_ITEM ~SCRL8C~ LAST #0 #0 #0 ~IDENTIFIED~ #3 // Transmutation de la pierre en chair
ADD_STORE_ITEM ~SCRL8B~ LAST #0 #0 #0 ~IDENTIFIED~ #3 // Convocation de Nishruu
ADD_STORE_ITEM ~SCRL8V~ LAST #0 #0 #0 ~IDENTIFIED~ #3 // Contr<F4>le des morts vivants
ADD_STORE_ITEM ~SCRL8R~ LAST #0 #0 #0 ~IDENTIFIED~ #3 // <C9>p<E9>e de Mordenkainen
ADD_STORE_ITEM ~SCRL8G~ LAST #0 #0 #0 ~IDENTIFIED~ #3 // Rayon rubis d'inversion
ADD_STORE_ITEM ~SCRL9C~ LAST #0 #0 #0 ~IDENTIFIED~ #3 // Manteau sup<E9>rieur
ADD_STORE_ITEM ~SCRL9A~ LAST #0 #0 #0 ~IDENTIFIED~ #3 // Perce-bouclier
ADD_STORE_ITEM ~SCRLB1~ LAST #0 #0 #0 ~IDENTIFIED~ #3 // Poing serr<E9> de Bigby
ADD_STORE_ITEM ~SCRLB2~ LAST #0 #0 #0 ~IDENTIFIED~ #3 // Main broyante de Bigby
ADD_STORE_ITEM ~SCRL9Z~ LAST #0 #0 #0 ~IDENTIFIED~ #9 // Libert<E9>

Trying to WeiDU --change-log scrl9z.itm gives no result (the spell scroll does not seem to have been changed by anything).

If you want to try, my mod can be downloaded here.

I have really no clues of why TobEx affects scrolls prices that way and only mod-added ones.

Edited by Anomaly, 24 September 2012 - 04:54 AM.

[Beleg33]

Known "Item Recharge Mod" component bugginess with stackable items added to stores with 0 charge. Disable it in TobEx_ini\TobExCore.ini (or add your scrolls with #1 #0 #0 charges? I think that should work.)

Fixed in test release of v25.

[Anomaly]

Okay. Do you think I should include a special case in my mod to get around this particular TobEx bug? A way to detect reliabily the affected TobEx versions?

[Beleg33]

Honestly I don't think you should bother about it, if you get any reports about it, point them here.

Otherwise you could try something like that (needs confirmation that it would work, stolen bits from tobex.tpa and tobex.tp2)

Spoiler

ACTION_IF (FILE_EXISTS ~TobEx_ini/TobExVer.txt~) BEGIN
COPY "TobEx_ini/TobExVer.txt" "TobEx_ini/TobExVer.txt"
	READ_2DA_ENTRY 0 0 1 tobex_installed_version
  BUT_ONLY

ACTION_IF (%tobex_installed_version% = 24) BEGIN
COPY "TobEx_ini/TobExCore.ini" "TobEx_ini/TobExCore.ini"
REPLACE_TEXTUALLY ~Item Recharge Mod=1~ ~Item Recharge Mod=0~
BUT_ONLY
END

ACTION_IF (%tobex_installed_version% = 23) BEGIN
COPY "TobEx_ini/TobExCore.ini" "TobEx_ini/TobExCore.ini"
REPLACE_TEXTUALLY ~Item Recharge in Bag Fix=1~ ~Item Recharge in Bag Fix=0~
BUT_ONLY
END
END

Edited by Beleg33, 25 September 2012 - 11:59 AM.

[Anomaly]

Thanks, that's an interesting bit of code. The fact that TobEx is often bundled silently with other mods is reason enough to handle buggy Tobex versions if there is a simple fix like this one.

Edited by Anomaly, 25 September 2012 - 03:23 AM.

[Beleg33]

Copy-pasta typo in that bit above, fixed.

EDIT: whoa I was incredibly stupid when writing this, fixed again...


I agree about the bundled versions... v21 with poison death creating zombies plagued SCS v20 for a while (until updated ) I think it has v23 within it now, which is pretty much stable except the item recharge thing?
The marvelous thing about TobEx is that the new buggy stuff can be disabled at any time with a text editor

Edited by Beleg33, 25 September 2012 - 11:58 AM.