10 replies to this topic

[Tonton Fred]

This mod, part of the BWP install, screws up the Ritual Scroll in Watcher's Keep, effectively preventing the resolution of the dungeon (other than directly fighting the Imprisoned One). PLOT01.itm (the Ritual Scroll) uses SPIN593.SPL, which is set to level 1 by the mod. Setting it back to the original value (5) allows the plot to proceed when using the scroll.

The bug has apparently been around since 2005, involving various mods that modify innates' levels.

EDIT : same thing happens with the second scroll that the ghostly spirit gives you after you leave (PLOT01Q.ITM and SPIN592.SPL).

Edited by Tonton Fred, 10 August 2012 - 12:38 PM.

[Lollorian]

HasSpell() and HasSpellRES() on non level-1 innates causes crashes...
SpellCaseInnate() on erroneously level-1'ed innates causes script shittiness... This topic is a font of knowledge here

How does someone go about fixing this? Probably look at the spells referenced by SpellCastInnate() on a case by case basis because HasSpell(RES) can refer to a MUCH broader group of spells

So far only found these references and this is some rough but working code to fix this within both BPv180 and the InnateFixer used by the BWP. I'm sure someone could streamline it even further though (how the hell do you trim strings in WeiDU? )

The TRUE_SIGHT references come from the Tower of Deception mod and aren't used in vanilla or BP

Spoiler

PATCH_IF ((%spell_type% = 4) AND
   		   ((~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL232~) AND (%spell_level% != 2)) OR // INQUIS_TRUE_SIGHT
			  ((~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL412~) AND (%spell_level% != 4)) OR // SET_SNARE_TRAP
			  ((~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL414~) AND (%spell_level% != 4)) OR // SET_SPECIAL_SNARE_TRAP
			  ((~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPIN592~) AND (%spell_level% != 5)) OR // HELM_RITUAL_SCROLL
			  ((~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPIN593~) AND (%spell_level% != 5)) OR // ODREN_RITUAL_SCROLL
			  ((~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPIN666~) AND (%spell_level% != 6)) OR // ZOMBIE_LEVEL_DRAIN
			  ((~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL732~) AND (%spell_level% != 7)) OR // HELM_TRUE_SIGHT
			  ((~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL910~) AND (%spell_level% != 9)) OR // ROGUE_SET_SPIKE_TRAP
			  ((~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL911~) AND (%spell_level% != 9)) OR // ROGUE_SET_EXPLODING_TRAP
			  ((~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL912~) AND (%spell_level% != 9))) BEGIN // ROGUE_SET_TIME_TRAP
	  PATCH_PRINT "%SOURCE_FILE% error: Innate Spell is referenced by CastSpellInnate() and has mismatched index with SPELL.IDS! Correcting..."
	  PATCH_IF (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL232~) BEGIN
	    WRITE_LONG 0x34 ~2~
	  END ELSE
	  PATCH_IF (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL412~) OR
			   (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL414~) BEGIN
	    WRITE_LONG 0x34 ~4~
	  END ELSE
	  PATCH_IF (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPIN592~) OR
			   (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPIN593~) BEGIN
	    WRITE_LONG 0x34 ~5~
	  END ELSE
	  PATCH_IF (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPIN666~) BEGIN
	    WRITE_LONG 0x34 ~6~
	  END ELSE
	  PATCH_IF (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL910~) OR
			   (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL911~) OR
			   (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL912~) BEGIN
	    WRITE_LONG 0x34 ~9~
	  END
    END

If someone doesn't, I'll upload the BP and InnateFix files with the above code when in about half a day I'll need to apply the BWPFixpack patches on BPv180 before adding this so...

[Lollorian]

You could start your install actually The fixes would keep coming as long as BG modding is alive And it may be a while before the BWPFixpack gets an update... speaking of which it might be good to add this to their thread

Besides... I'll also be adding that block into the lolfixer soon for easy post biffing fixing Relevant but kinda ancient lolfixer topic here (It's the Wrye Bash for BGII :mwaha:)

[Lollorian]

And here ya go You'll be surprised at how easy it was to add that code

Small note though: I've changed the original condition for setting innates to level 1

Original: check level = 0 and check level > 1
Now: check level != 1 (shouldn't cause problems unless a spell has -1 as a level... in which case it should probably be set to 1 - the new condition does that )

EDIT: Attachment was stupid and hence removed, check out newer fixed stuff a couple of posts down

Edited by Lollorian, 13 August 2012 - 12:31 AM.

[Lollorian]

Shit I fucked up Sorry about that... needed a BEGIN in line 5925 (BP.tp2) and 45 (InnateFix.tp2)

Attached Files

•  BPv180_InnateFix_devSin_innate_borkage_exclusion_list_fixed.7z   93.16K   314 downloads

[Lollorian]

A small update to this, it seems INQUIS_TRUE_SIGHT and HELM_TRUE_SIGHT are used un HaveSpell() checks by a LOT of mods so a better exclusion list was attached to this post

New code just in case:

READ_SHORT 0x1c "spell_type"
    READ_LONG  0x34 "spell_level"

    PATCH_IF (%spell_type% = 4) BEGIN
	  PATCH_IF (((~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL412~) AND (%spell_level% != 4)) OR // SET_SNARE_TRAP
			    ((~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL414~) AND (%spell_level% != 4)) OR // SET_SPECIAL_SNARE_TRAP
			    ((~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPIN592~) AND (%spell_level% != 5)) OR // HELM_RITUAL_SCROLL - TOD
			    ((~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPIN593~) AND (%spell_level% != 5)) OR // ODREN_RITUAL_SCROLL
			    ((~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPIN642~) AND (%spell_level% != 6)) OR // POISONOUS_CLOUD - eSeries
			    ((~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPIN666~) AND (%spell_level% != 6)) OR // ZOMBIE_LEVEL_DRAIN
			    ((~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL910~) AND (%spell_level% != 9)) OR // ROGUE_SET_SPIKE_TRAP
			    ((~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL911~) AND (%spell_level% != 9)) OR // ROGUE_SET_EXPLODING_TRAP
			    ((~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL912~) AND (%spell_level% != 9)) OR // ROGUE_SET_TIME_TRAP
			    ((~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPIN940~) AND (%spell_level% != 9)) OR // MEPHIT_STINKING_CLOUD - eSeries
			    ((~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPIN979~) AND (%spell_level% != 9))) BEGIN // GOLEM_GASCLOUD - eSeries
	    PATCH_PRINT "%SOURCE_FILE% error: Innate Spell is referenced by CastSpellInnate() and has mismatched index with SPELL.IDS! Correcting..."
	    PATCH_IF (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL412~) OR
				 (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL414~) BEGIN
		  WRITE_LONG 0x34 ~4~
	    END ELSE
	    PATCH_IF (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPIN592~) OR
				 (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPIN593~) BEGIN
		  WRITE_LONG 0x34 ~5~
	    END ELSE
	    PATCH_IF (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPIN642~) OR
				 (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPIN666~) BEGIN
		  WRITE_LONG 0x34 ~6~
	    END ELSE
	    PATCH_IF (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL910~) OR
				 (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL911~) OR
				 (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPCL912~) OR
				 (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPIN940~) OR
				 (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SPIN979~) BEGIN
		  WRITE_LONG 0x34 ~9~
	    END
	  END ELSE
	  PATCH_IF (%spell_level% != 1) BEGIN
	    PATCH_PRINT "%SOURCE_FILE% error: Innate Spell is not Level 1! Setting level to 1..."
	    WRITE_LONG 0x34 ~1~
	  END
    END