Javascript Disabled Detected

You currently have javascript disabled. Several functions may not work. Please re-enable javascript to access full functionality.

Tortured Souls v 7.04 possibly messes Songlist.2da

Started by micbaldur, May 19 2012 10:51 PM

Please log in to reply

13 replies to this topic

#1 micbaldur

Retired Perkele, Ultimate BWP player

Member
1692 posts

Posted 19 May 2012 - 10:51 PM

While playing my BWP 11 i noticed that some romances played wrong music.

I checked songlist.2da:

Spoiler

I noticed that after 95 comes 85. That's probably not right.

I made changelogged songlist.2da:

Spoiler

Because Kachiko, Valygar and Sime are from Tortured Souls i checked 0004:

Spoiler

Then i checked 0005:

Spoiler

Numbering is meshed up after Torturted Souls install.

Then i checked TS.tp and found this:

Spoiler

I'm no modder but think that's bugged. I could be totally wrong. :ermm:

I was wondering does this meshed songlist.2da causes any other problems other than wrong music. I can live with wrong music. Re-installation is not an option for me.

I don't know is this real bug or only BWP bug in my local install only. Just curious about the issue.

CHARNAMEs excellent adventures in the world of BWP expert-install here

Thanks to Leonardo Watson for making this possible

Back to top

#2 dabus

Member
1982 posts

Posted 20 May 2012 - 12:02 AM

Yes, that's messed up.
I thought BGTMusic would fix that though after reading Setup-BGTMusic.tp2.

Spoiler

DEFINE_ACTION_MACRO ~TSSongCompat~ BEGIN
  ACTION_IF FILE_EXISTS_IN_GAME ~kachi01.wav~ THEN BEGIN //TS song compatibility
    COPY_EXISTING + ~songlist.2da~ ~override/songlist.2da~
      SET kachiko = 0
      SET valygar = 0
      SET sime = 0
      COUNT_2DA_ROWS 3 "rows_cnt_ts"
      FOR(cnt=0; cnt<"%rows_cnt_ts%"; cnt=cnt+1 ) BEGIN
        READ_2DA_ENTRY cnt 1 3  "name_ts"
        PATCH_IF( ("%name_ts%" STRING_COMPARE_CASE "Kachiko")=0 ) BEGIN
          READ_2DA_ENTRY cnt 0 3  "kachiko"
        END
        PATCH_IF( ("%name_ts%" STRING_COMPARE_CASE "Sime")=0 ) BEGIN
          READ_2DA_ENTRY cnt 0 3  "sime"
        END
        PATCH_IF( ("%name_ts%" STRING_COMPARE_CASE "Valygar")=0 ) BEGIN
          READ_2DA_ENTRY cnt 0 3  "valygar"
        END
      END

  COPY_EXISTING ~kachiko.bcs~  ~override/kachiko.bcs~
                ~kach25.bcs~   ~override/kach25.bcs~
                ~kachi25d.bcs~ ~override/kachi25d.bcs~
                ~kachid.bcs~   ~override/kachid.bcs~
    DECOMPILE_BCS_TO_BAF
    REPLACE_TEXTUALLY ~PlaySong(%kachiko%)~ ~PlaySong(0)~
    COMPILE_BAF_TO_BCS

  COPY_EXISTING ~sime.bcs~    ~override/sime.bcs~
                ~simed.bcs~   ~override/simed.bcs~
    DECOMPILE_BCS_TO_BAF
    REPLACE_TEXTUALLY ~PlaySong(%sime%)~ ~PlaySong(0)~
    COMPILE_BAF_TO_BCS

  COPY_EXISTING ~valygar.bcs~    ~override/valygar.bcs~
                ~valy25.bcs~     ~override/valy25.bcs~
                ~valyg25d.bcs~   ~override/valyg25d.bcs~
                ~valygard.bcs~   ~override/valygard.bcs~
    DECOMPILE_BCS_TO_BAF
    REPLACE_TEXTUALLY ~PlaySong(%valygar%)~ ~PlaySong(0)~
    COMPILE_BAF_TO_BCS
  END
END

.

THINK! - It's not illegal.

Back to top

#3 Lollorian

smiley addict

Member
4150 posts

Posted 20 May 2012 - 01:00 AM

The order could be preserved by using the new WeiDU ADD_MUSIC function rather than the APPEND stuff

Maybe change this:

Spoiler

COPY_EXISTING ~SONGLIST.2da~ ~override~
   APPEND ~SONGLIST.2da~
	~85	  Kachiko		 MXKACHI.MUS~
   APPEND ~SONGLIST.2da~
	~86	  Valygar		 MXVALYG.MUS~
   APPEND ~SONGLIST.2da~
	~87	  Sime			MXSIMEL.MUS~
  COPY ~TS/music/MxKachi.mus~ ~music~
  COPY ~TS/music/MxSimel.mus~ ~music~
  COPY ~TS/music/MxValyg.mus~ ~music~

into this? :unsure:

Spoiler

ADD_MUSIC ~Kachiko~	~TS/music/MxKachi.mus~
   ADD_MUSIC ~Valygar~	~TS/music/MxSimel.mus~
   ADD_MUSIC ~Sime~	~TS/music/MxValyg.mus~

CtB, RoT and TS use this method btw so it might be better to mod them too

Considering that BWP installs implicitly apply the 500 music patch in BGT, I don't think blindly and sequentially adding music would be a problem now :cheers:

Edited by Lollorian, 20 May 2012 - 01:18 AM.

"I am the smiley addict, yellow and round, this is my grin when I'm usually around .
When there's trouble brewing, see me post, cuz it's usually a wall o' yellow and your eyes are toast!!!"

BWP GUIDE - BWP FIXES - impFAQ - NPC LIST - KIT LIST - AREA LIST

GitHub Links : BWP Fixpack | Lolfixer | BWP Trimpack | RezMod

Back to top

#4 Azazello

The Anti-Spammer

Staff
1912 posts

Posted 21 May 2012 - 09:10 AM

Lollorian, do you know if ADD_MUSIC changes were added for various mods in the BiG Fixpack? (sorry, am too lazy to check myself :lol:

)

"I gladly simp for jastey" -- Aza
==========================================================
"You ever notice that "What the hell?!" is the answer to just about everything?"
==========================================================

"Girls are like phones, they like to be held and talked too, but if you press the wrong button, you will be disconnected!" DJ Nikodemus
================================================================
Community Contributions
* Level 1 NPCs * gMinion: expanded TP2 for MegaInstalls * PSM (PSQM): expanded scripts for Melanthium * Shar Nadal (DSotSC-BGT) revision * non-detectable Cloak of Non-Detection ?? * Weimer's-Tactics: revised TP2 for MegaInstalls * a directory of Mega-Installation Guides *

Back to top

#5 Lollorian

smiley addict

Member
4150 posts

Posted 21 May 2012 - 11:59 AM

I noticed that there's a patch in the BWPFixpack (for the Longer Road methinks :unsure:

) that removes the restriction for 100 lines of music that the mod contains

Nothing specifically converts all the APPEND stuff into ADD_MUSIC though :cheers:

The BWPFixpack could use an update though, someone should collect all the stuff (as well as the updated stuff from the various github repos) and start posting stuff into the fixpack thread like Leonardo asked... I'd give it a shot, but then again... DAMN YOU EXAMS!!! :wall:

"I am the smiley addict, yellow and round, this is my grin when I'm usually around .
When there's trouble brewing, see me post, cuz it's usually a wall o' yellow and your eyes are toast!!!"

BWP GUIDE - BWP FIXES - impFAQ - NPC LIST - KIT LIST - AREA LIST

GitHub Links : BWP Fixpack | Lolfixer | BWP Trimpack | RezMod

Back to top

#6 micbaldur

Retired Perkele, Ultimate BWP player

Member
1692 posts

Posted 12 January 2013 - 09:43 PM

Is this problem fixed, i guess probably not.

CHARNAMEs excellent adventures in the world of BWP expert-install here

Thanks to Leonardo Watson for making this possible

Back to top

#7 Lollorian

smiley addict

Member
4150 posts

Posted 12 January 2013 - 10:41 PM

Nope not yet

Edited by Lollorian, 12 January 2013 - 10:42 PM.

"I am the smiley addict, yellow and round, this is my grin when I'm usually around .
When there's trouble brewing, see me post, cuz it's usually a wall o' yellow and your eyes are toast!!!"

BWP GUIDE - BWP FIXES - impFAQ - NPC LIST - KIT LIST - AREA LIST

GitHub Links : BWP Fixpack | Lolfixer | BWP Trimpack | RezMod

Back to top

#8 Mad Mate

Member
191 posts

Posted 13 January 2013 - 04:01 AM

I just did BWP install and can confirm that TS 7.04 is not good yet for BWP. Install makes errors in few other mods like Edwin and has conflicts with BG2Fixpack.

It has already been reported by Beleg33 in : http://www.shsforums...-35#entry543979 and the post after it.

I think it is better to use TS-BP 6.10 in megamods for now until someone fix original mod.

Back to top

#9 Lollorian

smiley addict

Member
4150 posts

Posted 13 January 2013 - 05:58 AM

Well whaddya know

This issue affects only TS v7.04 and not TS-BP v6.10 (which seems to patch the SONGLIST.2DA with dynamic indices like the rest of the megamods... which I hope is safe because there don't seem to be bug reports like this for them)

Shitty code mumbo jumbo aside, here's the patched file for TS v7.04 only!

(don't replace the setup-TS.tp2 from TS v6.10 with this because it'll break your mod, your game, your little dog and everything else you love in your life) :ph34r:

I agree that TS-BP would probably be the better choice until someone overhauls TSv7.04 to work with megamods

Attached Files

TS_with_new_ADD_MUSIC_stuffz_7_04_ONLY.7z 27.9K 221 downloads

"I am the smiley addict, yellow and round, this is my grin when I'm usually around .
When there's trouble brewing, see me post, cuz it's usually a wall o' yellow and your eyes are toast!!!"

BWP GUIDE - BWP FIXES - impFAQ - NPC LIST - KIT LIST - AREA LIST

GitHub Links : BWP Fixpack | Lolfixer | BWP Trimpack | RezMod

Back to top

#10 Jarno Mikkola

The Imp in his pink raincoat.

Member
10911 posts

Posted 13 January 2013 - 06:18 AM

Well whaddya know
This issue affects only TS v7.04 and not TS-BP v6.10

Well, yeah, the TS v7.04 would probablyneed to be reconverted to the TS-BP format for it to work at all well with the rest of the BWP at all.

Deactivated account. The user today is known as The Imp.

Back to top

#11 micbaldur

Retired Perkele, Ultimate BWP player

Member
1692 posts

Posted 13 January 2013 - 08:42 AM

I agree that TS-BP would probably be the better choice until someone overhauls TSv7.04 to work with megamods

I think that i'm going back to TS-BP for my next BWP install.

Does anybody know why NEJ and TS are installed in wrong order, because both Vlad and Horred recommends to install TS first and then NEJ. I think that i try this in my next BWP install.

CHARNAMEs excellent adventures in the world of BWP expert-install here

Thanks to Leonardo Watson for making this possible

Back to top

#12 Jarno Mikkola

The Imp in his pink raincoat.

Member
10911 posts

Posted 13 January 2013 - 11:58 AM

Does anybody know why NEJ and TS are installed in wrong order, because both Vlad and Horred recommends to install TS first and then NEJ. I think that i try this in my next BWP install.

Well, it has to do with history... is my bet, as the NEJ was made first, then BGT came out... then the TS was adopted to the BP on top of that and other mods...

Deactivated account. The user today is known as The Imp.

Back to top

#13 rbx4

Member
40 posts

Posted 15 January 2013 - 12:03 AM

I've tried both major Tortured Souls possibilities, and both of them seem to be causing troubles. However, it's been a very long time since a mega-mod installation has worked for me. I'll possibly post a list of bugs soon. I want to be 100% sure of what's causing troubles, before I do that.

Back to top

#14 micbaldur

Retired Perkele, Ultimate BWP player

Member
1692 posts

Posted 15 January 2013 - 12:23 AM

I've tried both major Tortured Souls possibilities, and both of them seem to be causing troubles. However, it's been a very long time since a mega-mod installation has worked for me. I'll possibly post a list of bugs soon. I want to be 100% sure of what's causing troubles, before I do that.

Just to be sure, you have tried NEJ first and then TS and TS first and then NEJ.

My BWP expert installs have worked just fine, nothing really major that expert fixers/modders (Hoppy, Miloch and Lollorian) can't handle. Maybe i helped a little. :lol:

My bugs and other experiences are here.

Edited by micbaldur, 15 January 2013 - 12:24 AM.

CHARNAMEs excellent adventures in the world of BWP expert-install here

Thanks to Leonardo Watson for making this possible

Back to top

Back to Mega Mod Help