4 replies to this topic

[Sasha Al'Therin]

I had some stutter issues with Imoen and so I applied the stutter test which displays which scripts are running and most likely to be causing the stutter. I found the problem and it was actually with something that I had done script wise and corrected it. However on my subsequent check after the fact. I kept getting a repeat run of a specific block in ar6600.bcs

After a little bit of tracking down the issue (running the cleanup batch from BWP is not advised -- it removes stuff needed to check whats going on) and then examining the installation files for DSotSC from my "lite" big world setup (since cleanup batch file removed everything from the 'insane' install), I found the repeating block....

IF
Global("Chapter","GLOBAL",2)
Global("RandomSpawn","GLOBAL",3)
THEN
RESPONSE #100
  SetGlobalTimer("RandomSpawnTime","GLOBAL",TWO_DAYS)
END

There is nothing being set to prevent this block from running again. The script can never get past this point. It's in a hold pattern so to speak waiting for an external source to change one of the two variables. The RandomSpawn would be the most likely to be changed

I think you could be ok adding in as an additional check
!GlobalTimerNotExpired("RandomSpawnTime","GLOBAL")
the double negative means that it is expired or it was never set.

In fact I will test this and see what happens...

[Turambar]

Thanks, let me know. I don't have much time right now, but I'll check that ASAP.
I have indexed it in the bug report topic, so that it doesn't get forgotten

[Sasha Al'Therin]

thought about this some more... while the timer check i suggested will keep that block from looping. it still won't let it pass to the next block which is intended to reset certain variables after the timer has expired.

so flip the two blocks and add a timer check to the one that initiates the timer as in the following:

IF
GlobalTimerExpired("RandomSpawnTime","GLOBAL")
Global("Chapter","GLOBAL",2)
Global("RandomSpawn","GLOBAL",3)
THEN
RESPONSE #100
  SetGlobal("RandomSpawn","GLOBAL",0)
END
IF
!GlobalTimerNotExpired("RandomSpawnTime","GLOBAL")
Global("Chapter","GLOBAL",2)
Global("RandomSpawn","GLOBAL",3)
THEN
RESPONSE #100
  SetGlobalTimer("RandomSpawnTime","GLOBAL",TWO_DAYS)
END

Reason this works is that GlobalTimerExpired requires that the timer first exist, whereas !GlobalTimerNotExpired doesn't require the timer to exist.

Edited by Sasha Al'Therin, 29 April 2012 - 06:54 AM.

[Lollorian]

Flipping those 2 blocks made the (now) last block unreachable Because RandomSpawn is incremented to 3 in the blocks above those 2 blocks... Which means the timer is never reset and continues to remain expired.. which means... OMFG KOBOLD PARTY!!!

Might I suggest combining both blocks into one?

IF
	!GlobalTimerNotExpired("RandomSpawnTime","GLOBAL")
	Global("Chapter","GLOBAL",2)
	Global("RandomSpawn","GLOBAL",3)
THEN
	RESPONSE #100
		SetGlobal("RandomSpawn","GLOBAL",0)
		SetGlobalTimer("RandomSpawnTime","GLOBAL",TWO_DAYS)
END

Attached Files

•  dsotsc_Sasha_AlTherin_script_loop_fix_deux.7z   993bytes   294 downloads

[Turambar]

@sasha: thanks for reporting and investigating

@lollorian: I've come to the same conclusion

Fixed; ready for version 217 (which I plan to upload soon)