6 replies to this topic

[Sasha Al'Therin]

Discovered this during a general check for a specific error type found in a BWP setup that was preventing one mod from installing.

Regarding boot09.itm (and other platform variants) when the equipping effect was added the # of equipping effects was increased, however the ability effect index was not updated. NI & DLTCEP do not report errors regarding this at least not in anyway that I can find.

You can read more about the discovery and what I used to track down this particular file here

This block in the aurora tp2 needs to be adjusted
from this

Spoiler

COPY_EXISTING ~boot09.itm~ ~override~ //Boot09 header fixes
  PATCH_IF SOURCE_SIZE > 0x71 BEGIN
	READ_LONG 0x64 ho //Header offset
	WRITE_BYTE (ho + 0x1) 1 //ID required
	WRITE_ASCIIT (ho + 0x4) ~iboot09~ //Use icon
	READ_LONG  0x6a fb //Feature offset
	READ_SHORT 0x70 fc //Feature count
	INSERT_BYTES fb 0x30
	  WRITE_SHORT fb 142 //Opcode (Display special effect icon)
	  WRITE_BYTE (fb + 0x2) 1 //Target (Self)
	  WRITE_LONG (fb + 0x8) 83 //Icon (Spell Failure)
	  WRITE_LONG (fb + 0xe) 20 //Duration
	WRITE_SHORT 0x70 (fc + 1)
  END
BUT_ONLY

into something more like this (needs tested & could be 'cleaned up' to fit existing code writing style

Spoiler

COPY_EXISTING ~boot09.itm~ ~override~ //Boot09 header fixes
  PATCH_IF SOURCE_SIZE > 0x71 BEGIN
//i'm too lazy so just copy paste pieces of code from the code i'd copy pasted from the mod that wouldn't install cause helmla.itm from NEJ was busted LOL
  READ_LONG  0x64 "abil_off"
  READ_SHORT 0x68 "abil_num"
//back to what was original
	READ_LONG 0x64 ho //Header offset
	WRITE_BYTE (ho + 0x1) 1 //ID required
	WRITE_ASCIIT (ho + 0x4) ~iboot09~ //Use icon
	READ_LONG  0x6a fb //Feature offset
	READ_SHORT 0x70 fc //Feature count
	INSERT_BYTES fb 0x30
	  WRITE_SHORT fb 142 //Opcode (Display special effect icon)
	  WRITE_BYTE (fb + 0x2) 1 //Target (Self)
	  WRITE_LONG (fb + 0x8) 83 //Icon (Spell Failure)
	  WRITE_LONG (fb + 0xe) 20 //Duration
	WRITE_SHORT 0x70 (fc + 1)
//and switch to my laziness again...
   FOR (index = 0; index < abil_num; index = index + 1) BEGIN
	READ_SHORT  ("%abil_off%" + 0x1e + ("%index%" * 0x38)) "abil_fx_num"
	READ_SHORT  ("%abil_off%" + 0x20 + ("%index%" * 0x38)) "abil_fx_idx"
	PATCH_IF (%abil_fx_idx% =< %fc%) BEGIN
	 WRITE_SHORT ("%abil_off%" + 0x20 + ("%index%" * 0x38)) (%abil_fx_idx% + 1)
	END
   END
//for what it is worth... back to original  ^^
  END
BUT_ONLY

[Wisp]

Better yet, can this homebrew stuff and use standard WeiDU functions.

[Sasha Al'Therin]

Better yet, can this homebrew stuff and use standard WeiDU functions.

its most likely one they forgot to update since just a few blocks above they use

LAUNCH_PATCH_MACRO ADD_ITEM_EQEFFECT

which they could have used on this item too.

my additions show where their current code went wrong.

its up to the mod author to decide how to fix it.

Don't bash the messenger...

[Wisp]

Don't bash the messenger...

I wasn't.

[Miloch]

Yeah, we should use ADD_ITEM_EFFECT or whatever. I don't recall why we even do this or where we got it from (was thinking we got it from UB but I don't see it there either). I don't see that we use these boots, and I don't see that any other mod does either. Odd.

[Miloch]

My boots of the gargoyle are messed up though, stoneskin doesn't work, fixed it manually

I think they're messed up in the game normally; IIRC, we attempt to fix them in Aurora. If they're still messed up after installing that, please post your WeiDU.log in spoiler tags.