355 replies to this topic

[Sasha Al'Therin]

weidu does have a cap. I've reached it a few times doing some ass-e-nine things and that on a very limited mod install.

it is possible that it does this because it is looking at every script AND dialog file within the area patch.

Try splitting it into two sections one that copies areas and looks at scripts
then one that copies areas and looks at dialogs.

other than that... clueless, I am

[Lollorian]

I took a slightly different approach Instead of loading all the scripts and dialogues for every unlocked door found, we just load every script and dialogue and search for the unlocked doors

Cut down install time by around 30 mins for me

New Door Lock Debugger

BEGIN ~Area Stuff - Door Lock Debugger~
  GROUP ~Area Stuff~

ACTION_IF !(FILE_EXISTS ~override/xr2400.are~) THEN BEGIN
  COPY_EXISTING ~ar0087.are~ ~override/xr2400.are~
END
ACTION_IF !(FILE_EXISTS ~override/xr2600.are~) THEN BEGIN
  COPY_EXISTING ~ar0087.are~ ~override/xr2600.are~
END

COPY_EXISTING_REGEXP GLOB ~^.+\.are$~ ~override~
  PATCH_IF (SOURCE_SIZE > 0x11b) THEN BEGIN
    READ_LONG  0xa4 "door_num" ELSE 0
    READ_LONG  0xa8 "door_off" ELSE 0
    SPRINT area ~%SOURCE_FILE%~
    FOR (index = 0 ; index < door_num ; index = index + 1) BEGIN
      READ_ASCII ("%door_off%" +        ("%index%" * 0xc8)) "door_name" (32) NULL
      READ_ASCII ("%door_off%" + 0x78 + ("%index%" * 0xc8)) "resref"
      PATCH_IF NOT (("%resref%" STRING_EQUAL_CASE "") OR ("%resref%" STRING_EQUAL_CASE "none")) BEGIN // legit key entry
        READ_BYTE ("%door_off%" + 0x28 + ("%index%" * 0xc8)) "flags"
        PATCH_IF ((("%flags%" BAND 0b00000010) != 0b00000010) AND (FILE_EXISTS_IN_GAME ~%resref%.itm~)) BEGIN
          PATCH_PRINT "%area% error: Door #%index% (%door_name%) has key (%resref%.itm) but was not locked! Checking..."
//        WRITE_BYTE ("%door_off%" + 0x28 + ("%index%" * 0xc8)) ("%flags%" BOR 0b00000010)
          INNER_ACTION BEGIN
            APPEND_OUTER ~lolfixer/check.txt~ ~%area% %door_name% %resref%~
	  END
        END
      END
    END
  END
BUT_ONLY_IF_IT_CHANGES

COPY_EXISTING_REGEXP GLOB ~^.+\.bcs$~ ~override~
  INNER_PATCH_FILE ~lolfixer/check.txt~ BEGIN
    COUNT_2DA_ROWS 1 num_lines
  END
  SPRINT file ~%SOURCE_FILE%~
  SET ld=99999
  DECOMPILE_AND_PATCH BEGIN  
    FOR (i = 0 ; i < num_lines ; i = i + 1) BEGIN
      INNER_PATCH_FILE ~lolfixer/check.txt~ BEGIN
        READ_2DA_ENTRY i 1 1 "door_name"
      END
      COUNT_REGEXP_INSTANCES CASE_SENSITIVE ~Lock("%door_name%")~ ld
      INNER_ACTION BEGIN
        ACTION_IF (%ld%>0) AND !(%ld%=99999) THEN BEGIN
          PRINT ~SCRIPT: %file% uses Lock("%door_name%")~
          APPEND_OUTER ~lolfixer/check1.txt~  ~SCRIPT: %file% uses Lock("%door_name%")~
        END
      END
    END
  END
BUT_ONLY_IF_IT_CHANGES

COPY_EXISTING_REGEXP GLOB ~^.+\.dlg$~ ~override~
  INNER_PATCH_FILE ~lolfixer/check.txt~ BEGIN
    COUNT_2DA_ROWS 1 num_lines
  END
  SPRINT file ~%SOURCE_FILE%~
  SET ld=99999
  DECOMPILE_AND_PATCH BEGIN  
    FOR (i = 0 ; i < num_lines ; i = i + 1) BEGIN
      INNER_PATCH_FILE ~lolfixer/check.txt~ BEGIN
        READ_2DA_ENTRY i 1 1 "door_name"
      END
      COUNT_REGEXP_INSTANCES CASE_SENSITIVE ~Lock("%door_name%")~ ld
      INNER_ACTION BEGIN
        ACTION_IF (%ld%>0) AND !(%ld%=99999) THEN BEGIN
          PRINT ~SCRIPT: %file% uses Lock("%door_name%")~
          APPEND_OUTER ~lolfixer/check1.txt~  ~DIALOGUE: %file% uses Lock("%door_name%")~
        END
      END
    END
  END
BUT_ONLY_IF_IT_CHANGES

Adding CASE_SENSITIVE seems to have shortened the list considerably... but I'm kinda worried they might leave out Lock("DOOR01") when searching for Lock("Door01")

Anyway, output of the new code:

Spoiler

Installing [Area Stuff - Door Locker (locks doors that need keys but were unlock
ed)] [0.1A]
Copying and patching 2152 files ...

AR0602.ARE error: Door #16 (Cell04) has key (VPSHRKEY.itm) but was not locked! C
hecking...
Appending to files ...

AR1306.ARE error: Door #12 (DOOR09) has key (KEY10.itm) but was not locked! Chec
king...
Appending to files ...

AR1306.ARE error: Door #13 (DOOR10) has key (KEY10.itm) but was not locked! Chec
king...
Appending to files ...

AR1307.ARE error: Door #0 (Door01) has key (KEY10.itm) but was not locked! Check
ing...
Appending to files ...

AR1307.ARE error: Door #1 (Door02) has key (KEY10.itm) but was not locked! Check
ing...
Appending to files ...

AR1307.ARE error: Door #11 (Door12) has key (KEY10.itm) but was not locked! Chec
king...
Appending to files ...

DD7003.ARE error: Door #10 (Door11) has key (keyor.itm) but was not locked! Chec
king...
Appending to files ...

TT4004.ARE error: Door #13 (AR4004Door14) has key (KEYALBI.itm) but was not lock
ed! Checking...
Appending to files ...
Copying and patching 11826 files ...

SCRIPT: AR0602.BCS uses Lock("Cell04")
Appending to files ...

SCRIPT: BH0100.BCS uses Lock("Door12")
Appending to files ...

SCRIPT: CBCAVEIN.BCS uses Lock("Door01")
Appending to files ...

SCRIPT: CBINJAIL.BCS uses Lock("Door01")
Appending to files ...

SCRIPT: CBINJAIL.BCS uses Lock("Door02")
Appending to files ...

SCRIPT: CBINJAIL.BCS uses Lock("Door12")
Appending to files ...

SCRIPT: CBINJAIL.BCS uses Lock("Door11")
Appending to files ...

SCRIPT: CT41GNBP.BCS uses Lock("Door01")
Appending to files ...

SCRIPT: CT41GNBP.BCS uses Lock("Door02")
Appending to files ...

SCRIPT: CUT41G.BCS uses Lock("Door01")
Appending to files ...

SCRIPT: CUT41G.BCS uses Lock("Door02")
Appending to files ...

SCRIPT: CUT41GBP.BCS uses Lock("Door01")
Appending to files ...

SCRIPT: CUT41GBP.BCS uses Lock("Door02")
Appending to files ...

SCRIPT: CUT41GN.BCS uses Lock("Door01")
Appending to files ...

SCRIPT: CUT41GN.BCS uses Lock("Door02")
Appending to files ...

SCRIPT: CUT41L.BCS uses Lock("Door11")
Appending to files ...

SCRIPT: CUT41YBP.BCS uses Lock("Door01")
Appending to files ...

SCRIPT: CUT41YBP.BCS uses Lock("Door02")
Appending to files ...

SCRIPT: PPJON.BCS uses Lock("Door11")
Appending to files ...

SCRIPT: U!CUT41G.BCS uses Lock("Door01")
Appending to files ...

SCRIPT: U!CUT41G.BCS uses Lock("Door02")
Appending to files ...

SCRIPT: UDMASTER.BCS uses Lock("Door01")
Appending to files ...
Copying and patching 6222 files ...

SCRIPT: IMOEN2J.DLG uses Lock("Cell04")
Appending to files ...

[Sasha Al'Therin]

Adding CASE_SENSITIVE seems to have shortened the list considerably... but I'm kinda worried they might leave out Lock("DOOR01") when searching for Lock("Door01")

I don't think it would as I think that the variable string is replaced prior to the case check. You could try without case sensitivity and compare case by case to see what the returns are.

Also do you know if object variable names are case sensitive in game as in door01 is different than DOOR01 or are they treated as the same?
I suppose I could do my own tests... but if the answer is known...

[i30817]

Wrong topic.

Edited by i30817, 13 November 2011 - 06:58 PM.

[Lollorian]

Been trying to get the item swapping component to perfection for the past few days but I noticed something odd... possibly in WeiDU of all things

Neither COPY_EXISTING_REGEXP ~^.+\.cre$~ ~override~ nor COPY_EXISTING_REGEXP GLOB ~^.+\.cre$~ ~override~ seem to load all the cre's in the game

2 of them right off the bat would be ADANGMA3 and AERBOD01. Attaching both the lolfixer.debug and g3 creature invetory debug log (I cross-checked with NI and yup, those creatures do have equippable items)

Also, just in case the problem is with my code, here it is

Spoiler

BEGIN ~Creature Stuff - Inventory Overhauler (moves invalid but equippable items to inventory and equips anything in the inventory to a free slot)~
  GROUP ~Creature Stuff~

//G3 Debugging Suite - Equip invalid items
COPY_EXISTING_REGEXP ~^.+\.cre$~ ~override~
  PATCH_IF (SOURCE_SIZE > 0x2d3) THEN BEGIN
    READ_LONG  0x2b8 "slot_off" ELSE 0
    READ_LONG  0x2bc "itm_off" ELSE 0

    // tracking variables
    SET "2hweapon" = 0
    SET "offhand" = 0
    SET "bow" = 0
    SET "arrows" = 0
    SET "xbow" = 0
    SET "bolts" = 0
    SET "sling" = 0
    SET "bullets" = 0
    SET "helm" = 0
    SET "armor" = 0
    SET "gloves" = 0
    SET "lring" = 0
    SET "rring" = 0
    SET "boots" = 0
    SET "belt" = 0
    SET "amulet" = 0
    SET "weapon1" = 0
    SET "weapon2" = 0
    SET "weapon3" = 0
    SET "weapon4" = 0
    SET "quiver1" = 0
    SET "quiver2" = 0
    SET "quiver3" = 0
    SET "quiver4" = 0
    SET "cloak" = 0
    SET "2handedequip" = 0
    FOR (index = 0 ; index < 36 ; index = index + 1) BEGIN
      READ_SHORT ("%slot_off%" + (0x02 * "%index%")) "ref" ELSE 0xffff
      PATCH_IF ("%ref%" != 0xffff) BEGIN
        READ_ASCII ("%itm_off%" + (0x14 * "%ref%")) "item"
        PATCH_IF (!((~%item%~ STRING_EQUAL_CASE ~AA8BALA~) OR
                    (~%item%~ STRING_EQUAL_CASE ~AADEMRNG~) OR
                    (~%item%~ STRING_EQUAL_CASE ~AAGOLSTN~) OR
                    (~%item%~ STRING_EQUAL_CASE ~AAHELM~) OR
                    (~%item%~ STRING_EQUAL_CASE ~AAOROFN1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~AAREVIMM~) OR
                    (~%item%~ STRING_EQUAL_CASE ~AAWEATH1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~ARROPHEO~) OR
                    (~%item%~ STRING_EQUAL_CASE ~BAZPLO02~) OR
                    (~%item%~ STRING_EQUAL_CASE ~BEHOLDER~) OR
                    (~%item%~ STRING_EQUAL_CASE ~BHAALHP1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~BHAALIMM~) OR
                    (~%item%~ STRING_EQUAL_CASE ~BONEDAG~) OR
                    (~%item%~ STRING_EQUAL_CASE ~CBBNLCH0~) OR
                    (~%item%~ STRING_EQUAL_CASE ~CBBNLCH1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~CHWRAITH~) OR
                    (~%item%~ STRING_EQUAL_CASE ~DRAGGRE1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~DRAGSHA1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~DW#SKRNG~) OR
                    (~%item%~ STRING_EQUAL_CASE ~DWDUST~) OR
                    (~%item%~ STRING_EQUAL_CASE ~FAMMY~) OR
                    (~%item%~ STRING_EQUAL_CASE ~GHOST~) OR
                    (~%item%~ STRING_EQUAL_CASE ~GHOST3~) OR
                    (~%item%~ STRING_EQUAL_CASE ~GOLCLA~) OR
                    (~%item%~ STRING_EQUAL_CASE ~GOLFLE~) OR
                    (~%item%~ STRING_EQUAL_CASE ~GOLSTONE~) OR
                    (~%item%~ STRING_EQUAL_CASE ~GORAIR~) OR
                    (~%item%~ STRING_EQUAL_CASE ~GORMISTI~) OR
                    (~%item%~ STRING_EQUAL_CASE ~ILLBLUR~) OR
                    (~%item%~ STRING_EQUAL_CASE ~IMMCHS~) OR
                    (~%item%~ STRING_EQUAL_CASE ~IMMCLOUD~) OR
                    (~%item%~ STRING_EQUAL_CASE ~IMMUNE1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~IMMUNE10~) OR
                    (~%item%~ STRING_EQUAL_CASE ~IMMUNE2~) OR
                    (~%item%~ STRING_EQUAL_CASE ~IMMUNE3~) OR
                    (~%item%~ STRING_EQUAL_CASE ~IMOENHP1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~IMPINVIS~) OR
                    (~%item%~ STRING_EQUAL_CASE ~INVULNER~) OR
                    (~%item%~ STRING_EQUAL_CASE ~IRONGOL~) OR
                    (~%item%~ STRING_EQUAL_CASE ~JONHP1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~KUORING~) OR
                    (~%item%~ STRING_EQUAL_CASE ~LICH~) OR
                    (~%item%~ STRING_EQUAL_CASE ~LICHIM2~) OR
                    (~%item%~ STRING_EQUAL_CASE ~LK#IBELT~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MAGE03~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MAGE04~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MAGE05~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MAGE06~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MAGEBRAC~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MAHARPER~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MASAKIIM~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MEL01~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MGLOBE~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MINHP1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MINHP20~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MISTPO~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MONHP1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MONHP80~) OR
                    (~%item%~ STRING_EQUAL_CASE ~NOCIRC~) OR
                    (~%item%~ STRING_EQUAL_CASE ~POWEATH1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~REGHP1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~REGHP2R~) OR
                    (~%item%~ STRING_EQUAL_CASE ~RIDRING~) OR
                    (~%item%~ STRING_EQUAL_CASE ~RINGDEMN~) OR
                    (~%item%~ STRING_EQUAL_CASE ~RINGWOLF~) OR
                    (~%item%~ STRING_EQUAL_CASE ~S1-20~) OR
                    (~%item%~ STRING_EQUAL_CASE ~SAREVIMM~) OR
                    (~%item%~ STRING_EQUAL_CASE ~SENGUA04~) OR
                    (~%item%~ STRING_EQUAL_CASE ~SPEC02~) OR
                    (~%item%~ STRING_EQUAL_CASE ~SPECTR~) OR
                    (~%item%~ STRING_EQUAL_CASE ~STONSKIN~) OR
                    (~%item%~ STRING_EQUAL_CASE ~T-BAMM02~) OR
                    (~%item%~ STRING_EQUAL_CASE ~TELSLAV~) OR
                    (~%item%~ STRING_EQUAL_CASE ~TELSLAV2~) OR
                    (~%item%~ STRING_EQUAL_CASE ~TRANS3~) OR
                    (~%item%~ STRING_EQUAL_CASE ~TROLLDIE~) OR
                    (~%item%~ STRING_EQUAL_CASE ~TSTATUE~) OR
                    (~%item%~ STRING_EQUAL_CASE ~TZ25_!SK~) OR
                    (~%item%~ STRING_EQUAL_CASE ~TZ25_#MH~) OR
                    (~%item%~ STRING_EQUAL_CASE ~TZ25__NB~) OR
                    (~%item%~ STRING_EQUAL_CASE ~VAMPREG1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~VAMPREG2~) OR
                    (~%item%~ STRING_EQUAL_CASE ~VERMTYPE~) OR
                    (~%item%~ STRING_EQUAL_CASE ~VORSQUI1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~WALLPASS~) OR
                    (~%item%~ STRING_EQUAL_CASE ~ZY18BALA~) OR
                    (~%item%~ STRING_EQUAL_CASE ~ZYCLCKN1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~ZYHELME5~) OR
                    (~%item%~ STRING_EQUAL_CASE ~ZYHELMN1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~ZYINVULN~) OR
                    (~%item%~ STRING_EQUAL_CASE ~ZYOROFN1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~ZYREG1P3~) OR
                    (~%item%~ STRING_EQUAL_CASE ~ZYRINGN1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~ZYSW1HN3~)) AND (FILE_EXISTS_IN_GAME ~%item%.itm~)) THEN BEGIN
          INNER_PATCH_FILE ~%item%.itm~ BEGIN
            READ_SHORT 0x1c "type"
            READ_BYTE 0x18 "flags"
          END
          PATCH_IF ("%index%" = 0) BEGIN // helm slot
            SET "helm" = 1
            PATCH_IF ("%type%" != 7) BEGIN // helm
              PATCH_PRINT ~%SOURCE_FILE%: Invalid HELM: %item%.itm! Moving to inventory~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~INV~
              SET "helm" = 0
            END
          END
          PATCH_IF ("%index%" = 1) BEGIN // armor slot
            SET "armor" = 1
            PATCH_IF ("%type%" != 2) BEGIN // armor
              PATCH_PRINT ~%SOURCE_FILE%: Invalid ARMOR: %item%.itm! Moving to inventory~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~INV~
              SET "armor" = 0
            END
          END
          PATCH_IF ("%index%" = 2) BEGIN // shield slot
            SET "offhand" = 1
            PATCH_IF (("%flags%" BAND 0b00000010) = 0b00000010) BEGIN // 2h check
              PATCH_PRINT ~%SOURCE_FILE%: 2-HANDED OFFHAND: %item%.itm! Moving to inventory~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~INV~
              SET "offhand" = 0
            END ELSE
            PATCH_IF ("%type%" != 12) BEGIN // if not shield, check for valid melee abilities
              SET "legit_offhand" = 0
              INNER_PATCH_FILE ~%item%.itm~ BEGIN
                READ_LONG  0x64 "abil_off"
                READ_SHORT 0x68 "abil_num"
                FOR (index3 = 0 ; index3 < abil_num ; index3 = index3 + 1) BEGIN
                  READ_BYTE ("%abil_off%" + (0x38 * "%index3%")) "ability"
                  PATCH_IF ("%ability%" = 1) BEGIN // only melee allowed in offhand
                    SET "legit_offhand" = 1
                  END
                END
              END
              PATCH_IF ("%legit_offhand%" = 0) BEGIN
                PATCH_PRINT ~%SOURCE_FILE%: Invalid OFFHAND: %item%.itm! Moving to inventory~
                REMOVE_CRE_ITEM ~%item%~
                ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~INV~
                SET "offhand" = 0
              END
            END
          END
          PATCH_IF ("%index%" = 3) BEGIN // glove slot
            SET "gloves" = 1
            PATCH_IF ("%type%" != 6) BEGIN // gloves
              PATCH_PRINT ~%SOURCE_FILE%: Invalid GLOVES: %item%.itm! Moving to inventory~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~INV~
              SET "gloves" = 0
            END
          END
          PATCH_IF ("%index%" = 4) BEGIN
            SET "lring" = 1
            PATCH_IF ("%type%" != 10) BEGIN // rings
              PATCH_PRINT ~%SOURCE_FILE%: Invalid LRING: %item%.itm! Moving to inventory~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~INV~
              SET "lring" = 0
            END
          END
          PATCH_IF ("%index%" = 5) BEGIN
            SET "rring" = 1
            PATCH_IF ("%type%" != 10) BEGIN // rings
              PATCH_PRINT ~%SOURCE_FILE%: Invalid RRING: %item%.itm! Moving to inventory~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~INV~
              SET "rring" = 0
            END
          END
          PATCH_IF ("%index%" = 6) BEGIN // amulet slot
            SET "amulet" = 1
            PATCH_IF ("%type%" != 1) BEGIN // amulet
              PATCH_PRINT ~%SOURCE_FILE%: Invalid AMULET: %item%.itm! Moving to inventory~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~INV~
              SET "amulet" = 0
            END
          END
          PATCH_IF ("%index%" = 7) BEGIN // belt slot
            SET "belt" = 1
            PATCH_IF ("%type%" != 3) BEGIN // belt
              PATCH_PRINT ~%SOURCE_FILE%: Invalid BELT: %item%.itm! Moving to inventory~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~INV~
              SET "belt" = 0
            END
          END
          PATCH_IF ("%index%" = <img src='http://www.shsforums.net/public/style_emoticons/<#EMO_DIR#>/cool.gif' class='bbc_emoticon' alt='8)' /> BEGIN // boot slot
            SET "boots" = 1
            PATCH_IF ("%type%" != 4) BEGIN // boot
              PATCH_PRINT ~%SOURCE_FILE%: Invalid BOOTS: %item%.itm! Moving to inventory~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~INV~
              SET "boots" = 0
            END
          END
          PATCH_IF ("%index%" = 9) BEGIN // first weapon slot
            SET "weapon1" = 1
            SET "legit_weapon" = 0
            INNER_PATCH_FILE ~%item%.itm~ BEGIN
              READ_BYTE  0x18 "flags"
              READ_LONG  0x64 "abil_off"
              READ_SHORT 0x68 "abil_num"
              FOR (index3 = 0 ; index3 < abil_num ; index3 = index3 + 1) BEGIN
                READ_BYTE ("%abil_off%" + (0x38 * "%index3%")) "ability"
                PATCH_IF (("%ability%" = 1) OR ("%ability%" = 2) OR ("%ability%" = 4)) BEGIN // melee, ranged, or launcher
                  SET "legit_weapon" = 1
                END
              END
              PATCH_IF (("%legit_weapon%" = 1) AND (("%flags%" BAND 0b00000010) = 0b00000010)) BEGIN // 2h check
                  SET "2handedequip" = 1
              END
            END
            PATCH_IF ("%legit_weapon%" = 0) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Invalid WEAPON1: %item%.itm! Moving to inventory~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~INV~
              SET "weapon1" = 0
            END
          END
          PATCH_IF ("%index%" = 10) BEGIN // first weapon slot
            SET "weapon2" = 1
            SET "legit_weapon" = 0
            INNER_PATCH_FILE ~%item%.itm~ BEGIN
              READ_BYTE  0x18 "flags"
              READ_LONG  0x64 "abil_off"
              READ_SHORT 0x68 "abil_num"
              FOR (index3 = 0 ; index3 < abil_num ; index3 = index3 + 1) BEGIN
                READ_BYTE ("%abil_off%" + (0x38 * "%index3%")) "ability"
                PATCH_IF (("%ability%" = 1) OR ("%ability%" = 2) OR ("%ability%" = 4)) BEGIN // melee, ranged, or launcher
                  SET "legit_weapon" = 1
                END
              END
              PATCH_IF (("%legit_weapon%" = 1) AND (("%flags%" BAND 0b00000010) = 0b00000010)) BEGIN // 2h check
                  SET "2handedequip" = 1
              END
            END
            PATCH_IF ("%legit_weapon%" = 0) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Invalid WEAPON2: %item%.itm! Moving to inventory~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~INV~
              SET "weapon2" = 0
            END
          END
          PATCH_IF ("%index%" = 11) BEGIN // first weapon slot
            SET "weapon3" = 1
            SET "legit_weapon" = 0
            INNER_PATCH_FILE ~%item%.itm~ BEGIN
              READ_BYTE  0x18 "flags"
              READ_LONG  0x64 "abil_off"
              READ_SHORT 0x68 "abil_num"
              FOR (index3 = 0 ; index3 < abil_num ; index3 = index3 + 1) BEGIN
                READ_BYTE ("%abil_off%" + (0x38 * "%index3%")) "ability"
                PATCH_IF (("%ability%" = 1) OR ("%ability%" = 2) OR ("%ability%" = 4)) BEGIN // melee, ranged, or launcher
                  SET "legit_weapon" = 1
                END
              END
              PATCH_IF (("%legit_weapon%" = 1) AND (("%flags%" BAND 0b00000010) = 0b00000010)) BEGIN // 2h check
                  SET "2handedequip" = 1
              END
            END
            PATCH_IF ("%legit_weapon%" = 0) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Invalid WEAPON3: %item%.itm! Moving to inventory~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~INV~
              SET "weapon3" = 0
            END
          END
          PATCH_IF ("%index%" = 12) BEGIN // first weapon slot
            SET "weapon4" = 1
            SET "legit_weapon" = 0
            INNER_PATCH_FILE ~%item%.itm~ BEGIN
              READ_BYTE  0x18 "flags"
              READ_LONG  0x64 "abil_off"
              READ_SHORT 0x68 "abil_num"
              FOR (index3 = 0 ; index3 < abil_num ; index3 = index3 + 1) BEGIN
                READ_BYTE ("%abil_off%" + (0x38 * "%index3%")) "ability"
                PATCH_IF (("%ability%" = 1) OR ("%ability%" = 2) OR ("%ability%" = 4)) BEGIN // melee, ranged, or launcher
                  SET "legit_weapon" = 1
                END
              END
              PATCH_IF (("%legit_weapon%" = 1) AND (("%flags%" BAND 0b00000010) = 0b00000010)) BEGIN // 2h check
                  SET "2handedequip" = 1
              END
            END
            PATCH_IF ("%legit_weapon%" = 0) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Invalid WEAPON4: %item%.itm! Moving to inventory~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~INV~
              SET "weapon4" = 0
            END
          END
          PATCH_IF ("%index%" = 13) BEGIN // first quiver slot
            SET "quiver1" = 1
            PATCH_IF NOT (("%type%" = 5) OR ("%type%" = 31) OR ("%type%" = 14)) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Invalid QUIVER1: %item%.itm! Moving to inventory~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~INV~
              SET "quiver1" = 0
            END
          END
          PATCH_IF ("%index%" = 14) BEGIN // first quiver slot
            SET "quiver2" = 1
            PATCH_IF NOT (("%type%" = 5) OR ("%type%" = 31) OR ("%type%" = 14)) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Invalid QUIVER2: %item%.itm! Moving to inventory~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~INV~
              SET "quiver2" = 0
            END
          END
          PATCH_IF ("%index%" = 15) BEGIN // first quiver slot
            SET "quiver3" = 1
            PATCH_IF NOT (("%type%" = 5) OR ("%type%" = 31) OR ("%type%" = 14)) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Invalid QUIVER3: %item%.itm! Moving to inventory~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~INV~
              SET "quiver3" = 0
            END
          END
          PATCH_IF ("%index%" = 16) BEGIN // first quiver slot
            SET "quiver4" = 1
            PATCH_IF NOT (("%type%" = 5) OR ("%type%" = 31) OR ("%type%" = 14)) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Invalid QUIVER4: %item%.itm! Moving to inventory~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~INV~
              SET "quiver4" = 0
            END
          END
          PATCH_IF ("%index%" = 17) BEGIN // cloak
            SET "cloak" = 1
            PATCH_IF ("%type%" != 32) BEGIN // cloak
              PATCH_PRINT ~%SOURCE_FILE%: Invalid CLOAK: %item%.itm! Moving to inventory~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~INV~
            END
          END
          PATCH_IF ((("%type%" =  1) AND ("%amulet%" = 0))) AND ("%index%" > 17) BEGIN
            PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping AMULET~
            REMOVE_CRE_ITEM ~%item%~
            ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~AMULET~
            SET "%amulet%" = 1
          END
          PATCH_IF ((("%type%" =  2) AND ("%armor%" = 0))) AND ("%index%" > 17) BEGIN
            PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping ARMOR~
            REMOVE_CRE_ITEM ~%item%~
            ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~ARMOR~
            SET "%armor%" = 1
          END
          PATCH_IF ((("%type%" =  3) AND ("%belt%" = 0))) AND ("%index%" > 17) BEGIN
            PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping BELT~
            REMOVE_CRE_ITEM ~%item%~
            ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~BELT~
            SET "%belt%" = 1
          END
          PATCH_IF ((("%type%" =  4) AND ("%boots%" = 0))) AND ("%index%" > 17) BEGIN
            PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping BOOTS~
            REMOVE_CRE_ITEM ~%item%~
            ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~BOOTS~
            SET "%boots%" = 1
          END
          PATCH_IF (((("%type%" =  5) OR
                      ("%type%" = 14) OR
                      ("%type%" = 31)) AND ("%quiver1%" = 0)) AND ("%index%" > 17)) BEGIN
            PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping QUIVER1~
            REMOVE_CRE_ITEM ~%item%~
            ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~QUIVER1 INV~
            SET "%quiver1%" = 1
          END ELSE
          PATCH_IF (((("%type%" =  5) OR
                      ("%type%" = 14) OR
                      ("%type%" = 31)) AND ("%quiver2%" = 0)) AND ("%index%" > 17)) BEGIN
            PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping QUIVER2~
            REMOVE_CRE_ITEM ~%item%~
            ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~QUIVER2 INV~
            SET "%quiver2%" = 1
          END ELSE
          PATCH_IF (((("%type%" =  5) OR
                      ("%type%" = 14) OR
                      ("%type%" = 31)) AND ("%quiver3%" = 0)) AND ("%index%" > 17)) BEGIN
            PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping QUIVER3~
            REMOVE_CRE_ITEM ~%item%~
            ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~QUIVER3 INV~
            SET "%quiver3%" = 1
          END ELSE
          PATCH_IF (((("%type%" =  5) OR
                      ("%type%" = 14) OR
                      ("%type%" = 31)) AND ("%quiver4%" = 0)) AND ("%index%" > 17)) BEGIN
            PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping QUIVER4~
            REMOVE_CRE_ITEM ~%item%~
            ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~QUIVER4 INV~
            SET "%quiver4%" = 1
          END
          PATCH_IF ((("%type%" =  6) AND ("%gloves%" = 0))) AND ("%index%" > 17) BEGIN
            PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping GLOVES~
            REMOVE_CRE_ITEM ~%item%~
            ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~GLOVES~
            SET "gloves" = 1
          END
          PATCH_IF ((("%type%" =  7) AND ("%helm%" = 0))) AND ("%index%" > 17) BEGIN
            PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping HELM~
            REMOVE_CRE_ITEM ~%item%~
            ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~HELMET~
            SET "helm" = 1
          END
          PATCH_IF ((("%type%" = 10) AND ("%lring%" = 0))) AND ("%index%" > 17) BEGIN
            PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping LRING~
            REMOVE_CRE_ITEM ~%item%~
            ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~LRING~
            SET "lring" = 1
          END ELSE
          PATCH_IF ((("%type%" = 10) AND ("%rring%" = 0))) AND ("%index%" > 17) BEGIN
            PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping RRING~
            REMOVE_CRE_ITEM ~%item%~
            ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~RRING~
            SET "rring" = 1
          END
          PATCH_IF (((("%type%" = 15) OR // bow
                      ("%type%" = 16) OR // dagger
                      ("%type%" = 17) OR // maces
                      ("%type%" = 18) OR // sling
                      ("%type%" = 19) OR // short sword
                      ("%type%" = 20) OR // swords
                      ("%type%" = 21) OR // hammer
                      ("%type%" = 22) OR // morning stars
                      ("%type%" = 23) OR // flail
                      ("%type%" = 24) OR // darts
                      ("%type%" = 25) OR // axe
                      ("%type%" = 26) OR // staff
                      ("%type%" = 27) OR // xbow
                      ("%type%" = 28) OR // hand to hand
                      ("%type%" = 29) OR // Spear
                      ("%type%" = 30) OR // halberd
                      ("%type%" = 44)) AND ("%weapon1%" = 0) AND ("%index%" > 17)))  BEGIN
            PATCH_IF ((("%flags%" BAND 0b00000010) != 0b00000010) AND ("%offhand%" = 0)) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping WEAPON1~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~WEAPON1 INV~
              SET "%weapon1%" = 1
            END
          END ELSE
          PATCH_IF (((("%type%" = 15) OR // bow
                      ("%type%" = 16) OR // dagger
                      ("%type%" = 17) OR // maces
                      ("%type%" = 18) OR // sling
                      ("%type%" = 19) OR // short sword
                      ("%type%" = 20) OR // swords
                      ("%type%" = 21) OR // hammer
                      ("%type%" = 22) OR // morning stars
                      ("%type%" = 23) OR // flail
                      ("%type%" = 24) OR // darts
                      ("%type%" = 25) OR // axe
                      ("%type%" = 26) OR // staff
                      ("%type%" = 27) OR // xbow
                      ("%type%" = 28) OR // hand to hand
                      ("%type%" = 29) OR // Spear
                      ("%type%" = 30) OR // halberd
                      ("%type%" = 44)) AND ("%weapon2%" = 0) AND ("%index%" > 17)))  BEGIN
            PATCH_IF ((("%flags%" BAND 0b00000010) != 0b00000010) AND ("%offhand%" = 0)) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping WEAPON2~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~WEAPON2 INV~
              SET "%weapon2%" = 1
            END
          END ELSE
          PATCH_IF (((("%type%" = 15) OR // bow
                      ("%type%" = 16) OR // dagger
                      ("%type%" = 17) OR // maces
                      ("%type%" = 18) OR // sling
                      ("%type%" = 19) OR // short sword
                      ("%type%" = 20) OR // swords
                      ("%type%" = 21) OR // hammer
                      ("%type%" = 22) OR // morning stars
                      ("%type%" = 23) OR // flail
                      ("%type%" = 24) OR // darts
                      ("%type%" = 25) OR // axe
                      ("%type%" = 26) OR // staff
                      ("%type%" = 27) OR // xbow
                      ("%type%" = 28) OR // hand to hand
                      ("%type%" = 29) OR // Spear
                      ("%type%" = 30) OR // halberd
                      ("%type%" = 44)) AND ("%weapon3%" = 0) AND ("%index%" > 17)))  BEGIN
            PATCH_IF ((("%flags%" BAND 0b00000010) != 0b00000010) AND ("%offhand%" = 0)) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping WEAPON3~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~WEAPON3 INV~
              SET "%weapon3%" = 1
            END
          END ELSE
          PATCH_IF (((("%type%" = 15) OR // bow
                      ("%type%" = 16) OR // dagger
                      ("%type%" = 17) OR // maces
                      ("%type%" = 18) OR // sling
                      ("%type%" = 19) OR // short sword
                      ("%type%" = 20) OR // swords
                      ("%type%" = 21) OR // hammer
                      ("%type%" = 22) OR // morning stars
                      ("%type%" = 23) OR // flail
                      ("%type%" = 24) OR // darts
                      ("%type%" = 25) OR // axe
                      ("%type%" = 26) OR // staff
                      ("%type%" = 27) OR // xbow
                      ("%type%" = 28) OR // hand to hand
                      ("%type%" = 29) OR // Spear
                      ("%type%" = 30) OR // halberd
                      ("%type%" = 44)) AND ("%weapon4%" = 0) AND ("%index%" > 17)))  BEGIN
            PATCH_IF ((("%flags%" BAND 0b00000010) != 0b00000010) AND ("%offhand%" = 0)) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping WEAPON4~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~WEAPON4 INV~
                SET "%weapon4%" = 1
            END
          END
          PATCH_IF ((("%type%" = 12) AND ("%offhand%" = 0))) AND ("%index%" > 17) BEGIN
            PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping SHIELD~
            REMOVE_CRE_ITEM ~%item%~
            ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~SHIELD~
            SET "offhand" = 1
          END ELSE
          PATCH_IF ((("%type%" != 12) AND ("%offhand%" = 0))) AND ("%index%" > 17) BEGIN // if not shield, check for valid melee abilities
            SET "2handed" = 0
            SET "legit_offhand" = 0
            INNER_PATCH_FILE ~%item%.itm~ BEGIN
              READ_BYTE  0x18 "flags"
              READ_LONG  0x64 "abil_off"
              READ_SHORT 0x68 "abil_num"
              PATCH_IF (("%flags%" BAND 0b00000010) = 0b00000010) BEGIN // 2h check
                  SET "2handed" = 1
              END
              FOR (index3 = 0 ; index3 < abil_num ; index3 = index3 + 1) BEGIN
                READ_BYTE ("%abil_off%" + (0x38 * "%index3%")) "ability"
                PATCH_IF ("%ability%" = 1) BEGIN // only melee allowed in offhand
                  SET "legit_offhand" = 1
                END
              END
            END
            PATCH_IF (("%2handedequip%" = 0) AND ("%legit_offhand%" = 1) AND ("%2handed%" = 0))BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping OFFHAND~
              REMOVE_CRE_ITEM ~%item%~
              ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~SHIELD~
              SET "offhand" = 1
            END
          END
          PATCH_IF ((("%type%" = 32) AND ("%cloak%" = 0))) AND ("%index%" > 17) BEGIN
            PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping CLOAK~
            REMOVE_CRE_ITEM ~%item%~
            ADD_CRE_ITEM ~%item%~ #0 #0 #0 ~IDENTIFIED~ ~CLOAK~
            SET "cloak" = 1
          END
        END
      END
    END
  END
BUT_ONLY_IF_IT_CHANGES

For the cre's it does affect, it works awesome now so...

Attached Files

•  SETUP-LOLFIXER.DEBUG   395.33K   458 downloads
•  debugger_creature_inventory_checker.log   52.66K   558 downloads

Edited by Lollorian, 14 November 2011 - 07:29 PM.

[Sasha Al'Therin]

2 of them right off the bat would be ADANGMA3 and AERBOD01. Attaching both the lolfixer.debug and g3 creature invetory debug log (I cross-checked with NI and yup, those creatures do have equippable items)

ran this to see what would happen on a unmoddifed BG2:TOB there is no adangma3.cre but there is an aerbod01.cre and it was caught and adjusted...

To ensure that each file was loaded I added right after the copy line

PATCH_PRINT ~Loading %SOURCE_FILE% .... ~

my debug showed

Loading AERBOD01.CRE ....
[./override/slng01.itm] loaded, 314 bytes
[./override/slng01.itm] loaded, 314 bytes
[./override/slng01.itm] loaded, 314 bytes
[./override/slng01.itm] loaded, 314 bytes
[./override/slng01.itm] loaded, 314 bytes
[./override/bull01.itm] loaded, 170 bytes
[./override/bull01.itm] loaded, 170 bytes
[./override/bull01.itm] loaded, 170 bytes

AERBOD01.CRE: Equippable items in inventory: leat04.itm! Equipping ARMOR
Copied [AERBOD01.CRE] to [override/AERBOD01.CRE]

Also, my debug shows

Copying and patching 4004 files ...

and NI shows a file total of

CRE - 4004

perhaps your game is modded or has some left over modded files throwing off the results?
EDIT: -- just looked at your debug file... IT IS MODDED!!!!!!!!!! boy you have a lot of mods! Took me to line 814 just to get thru all your listed mods...

I'm pretty sure that the fixpack takes care of a lot of the items in wrong locations, but they go off of the base game so mod added stuff doesn't get fixed

what your debug shows is mod added items, you can clearly see the prefixes AJ#, AG, AA, 1XQ to name a few AND it shows transfered BG1 files like Aldeth & Algernon tho your 'fixer' equips the cloak on Algernon and there is a quest about picking it off of him. I don't think it can be pick pocketed if it is in an equipped slot...
Something to think about...

and your 'fixer' totally broke some mod's pickpocket exploit fix for the bandit scalps by moving the scalp out of the glove slot and back into the inventory slot... (eh I'm testing a script/dialog fix for this which so far seems to be working. i.e. the scalps get created once the creature goes hostile till then they don't have it at all)


So definitely need to do a case by case examination rather than a blind run sorry to burst your bubble

Edited by Sasha Al'Therin, 14 November 2011 - 09:11 PM.

[Lollorian]

To ensure that each file was loaded I added right after the copy line

PATCH_PRINT ~Loading %SOURCE_FILE% .... ~

Awesome idea and yup all teh creatures load (wonder why they aren't being modified though )

perhaps your game is modded or has some left over modded files throwing off the results?
EDIT: -- just looked at your debug file... IT IS MODDED!!!!!!!!!! boy you have a lot of mods! Took me to line 814 just to get thru all your listed mods...

Well lol yeah I'm carrying out all my future tests on this install! Vanilla BGII-ToB is too narrow a case study to perfect this non?

what your debug shows is mod added items, you can clearly see the prefixes AJ#, AG, AA, 1XQ to name a few AND it shows transfered BG1 files like Aldeth & Algernon tho your 'fixer' equips the cloak on Algernon and there is a quest about picking it off of him. I don't think it can be pick pocketed if it is in an equipped slot...

and your 'fixer' totally broke some mod's pickpocket exploit fix for the bandit scalps by moving the scalp out of the glove slot and back into the inventory slot...

We already have quite an extensive skiplist (of stuff like MINHP1 and related immunity items and the like) that shouldn't be swapped

PATCH_IF (!((~%item%~ STRING_EQUAL_CASE ~AA8BALA~) OR
                    (~%item%~ STRING_EQUAL_CASE ~AADEMRNG~) OR
                    (~%item%~ STRING_EQUAL_CASE ~AAGOLSTN~) OR
                    (~%item%~ STRING_EQUAL_CASE ~AAHELM~) OR
                    (~%item%~ STRING_EQUAL_CASE ~AAOROFN1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~AAREVIMM~) OR
                    (~%item%~ STRING_EQUAL_CASE ~AAWEATH1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~ARROPHEO~) OR
                    (~%item%~ STRING_EQUAL_CASE ~BAZPLO02~) OR
                    (~%item%~ STRING_EQUAL_CASE ~BEHOLDER~) OR
                    (~%item%~ STRING_EQUAL_CASE ~BHAALHP1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~BHAALIMM~) OR
                    (~%item%~ STRING_EQUAL_CASE ~BONEDAG~) OR
                    (~%item%~ STRING_EQUAL_CASE ~CBBNLCH0~) OR
                    (~%item%~ STRING_EQUAL_CASE ~CBBNLCH1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~CHWRAITH~) OR
                    (~%item%~ STRING_EQUAL_CASE ~DRAGGRE1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~DRAGSHA1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~DW#SKRNG~) OR
                    (~%item%~ STRING_EQUAL_CASE ~DWDUST~) OR
                    (~%item%~ STRING_EQUAL_CASE ~FAMMY~) OR
                    (~%item%~ STRING_EQUAL_CASE ~GHOST~) OR
                    (~%item%~ STRING_EQUAL_CASE ~GHOST3~) OR
                    (~%item%~ STRING_EQUAL_CASE ~GOLCLA~) OR
                    (~%item%~ STRING_EQUAL_CASE ~GOLFLE~) OR
                    (~%item%~ STRING_EQUAL_CASE ~GOLSTONE~) OR
                    (~%item%~ STRING_EQUAL_CASE ~GORAIR~) OR
                    (~%item%~ STRING_EQUAL_CASE ~GORMISTI~) OR
                    (~%item%~ STRING_EQUAL_CASE ~ILLBLUR~) OR
                    (~%item%~ STRING_EQUAL_CASE ~IMMCHS~) OR
                    (~%item%~ STRING_EQUAL_CASE ~IMMCLOUD~) OR
                    (~%item%~ STRING_EQUAL_CASE ~IMMUNE1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~IMMUNE10~) OR
                    (~%item%~ STRING_EQUAL_CASE ~IMMUNE2~) OR
                    (~%item%~ STRING_EQUAL_CASE ~IMMUNE3~) OR
                    (~%item%~ STRING_EQUAL_CASE ~IMOENHP1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~IMPINVIS~) OR
                    (~%item%~ STRING_EQUAL_CASE ~INVULNER~) OR
                    (~%item%~ STRING_EQUAL_CASE ~IRONGOL~) OR
                    (~%item%~ STRING_EQUAL_CASE ~JONHP1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~KUORING~) OR
                    (~%item%~ STRING_EQUAL_CASE ~LICH~) OR
                    (~%item%~ STRING_EQUAL_CASE ~LICHIM2~) OR
                    (~%item%~ STRING_EQUAL_CASE ~LK#IBELT~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MAGE03~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MAGE04~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MAGE05~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MAGE06~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MAGEBRAC~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MAHARPER~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MASAKIIM~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MEL01~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MGLOBE~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MINHP1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MINHP20~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MISTPO~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MONHP1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~MONHP80~) OR
                    (~%item%~ STRING_EQUAL_CASE ~NOCIRC~) OR
                    (~%item%~ STRING_EQUAL_CASE ~POWEATH1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~REGHP1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~REGHP2R~) OR
                    (~%item%~ STRING_EQUAL_CASE ~RIDRING~) OR
                    (~%item%~ STRING_EQUAL_CASE ~RINGDEMN~) OR
                    (~%item%~ STRING_EQUAL_CASE ~RINGWOLF~) OR
                    (~%item%~ STRING_EQUAL_CASE ~S1-20~) OR
                    (~%item%~ STRING_EQUAL_CASE ~SAREVIMM~) OR
                    (~%item%~ STRING_EQUAL_CASE ~SENGUA04~) OR
                    (~%item%~ STRING_EQUAL_CASE ~SPEC02~) OR
                    (~%item%~ STRING_EQUAL_CASE ~SPECTR~) OR
                    (~%item%~ STRING_EQUAL_CASE ~STONSKIN~) OR
                    (~%item%~ STRING_EQUAL_CASE ~T-BAMM02~) OR
                    (~%item%~ STRING_EQUAL_CASE ~TELSLAV~) OR
                    (~%item%~ STRING_EQUAL_CASE ~TELSLAV2~) OR
                    (~%item%~ STRING_EQUAL_CASE ~TRANS3~) OR
                    (~%item%~ STRING_EQUAL_CASE ~TROLLDIE~) OR
                    (~%item%~ STRING_EQUAL_CASE ~TSTATUE~) OR
                    (~%item%~ STRING_EQUAL_CASE ~TZ25_!SK~) OR
                    (~%item%~ STRING_EQUAL_CASE ~TZ25_#MH~) OR
                    (~%item%~ STRING_EQUAL_CASE ~TZ25__NB~) OR
                    (~%item%~ STRING_EQUAL_CASE ~VAMPREG1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~VAMPREG2~) OR
                    (~%item%~ STRING_EQUAL_CASE ~VERMTYPE~) OR
                    (~%item%~ STRING_EQUAL_CASE ~VORSQUI1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~WALLPASS~) OR
                    (~%item%~ STRING_EQUAL_CASE ~ZY18BALA~) OR
                    (~%item%~ STRING_EQUAL_CASE ~ZYCLCKN1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~ZYHELME5~) OR
                    (~%item%~ STRING_EQUAL_CASE ~ZYHELMN1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~ZYINVULN~) OR
                    (~%item%~ STRING_EQUAL_CASE ~ZYOROFN1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~ZYREG1P3~) OR
                    (~%item%~ STRING_EQUAL_CASE ~ZYRINGN1~) OR
                    (~%item%~ STRING_EQUAL_CASE ~ZYSW1HN3~)) AND (FILE_EXISTS_IN_GAME ~%item%.itm~)) THEN BEGIN

So the bandit scalps and other pcikpocketing eccentricities could (in theory ofcourse) be added to that

I've never pickpocketed anyone in my BG games so dunno if they're unpickable if equipped (which would make sense though Hilarious imagining someone pickpocket a suit of equipped platemail )

PS: I took care to not name the components as fixers ... because I knew they'd break stuff beyond recognition (for now atleast )

PS2: I guess the thread title is kinda misleading then yeah?

[Lollorian]

Added all instances of cheesy-non-pickpocketing-tactic-by-equipping-into-slot items

PATCH_IF (!((~%item%~ STRING_EQUAL_CASE ~MISC86~) OR                                                        //Bandit Scalp
                   ((~%item%~ STRING_EQUAL_CASE ~MISC54~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~JALANT~)) OR        //Child's Body
                   ((~%item%~ STRING_EQUAL_CASE ~RING07~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~RAMAZI~)) OR        //Ramazith's Prot Ring
                   ((~%item%~ STRING_EQUAL_CASE ~MISC2H~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SHANDAL2~)) OR        //Shandalar's Wardstone
                   ((~%item%~ STRING_EQUAL_CASE ~MISC6Z~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~GEMCH02~)) OR        //Imnesvale Chicken's Beljuril
                   ((~%item%~ STRING_EQUAL_CASE ~MISCB7~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~HELLGEN~)) OR        //Genie's Tears of Bhaal
                   ((~%item%~ STRING_EQUAL_CASE ~RING39~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~HLKANG~)) OR        //Kangaxx's Gaxx Ring
                   ((~%item%~ STRING_EQUAL_CASE ~MISC8K~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~TRRAK01~)) OR        //Ihtafeer's Head
                   ((~%item%~ STRING_EQUAL_CASE ~MISCA7~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~UDPRINCE~)) OR        //Kuo-Tuan Prince's Blood
                   ((~%item%~ STRING_EQUAL_CASE ~MISC8H~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~UDSILVER~)) OR        //Adalon's Blood
                   ((~%item%~ STRING_EQUAL_CASE ~MISCCC~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~UDSILVER~)) OR        //Adalon's Note

[Sasha Al'Therin]

just a bit o' friendly advice to keep it as 'look & leave alone' for these types of items. If at some point BGT or another mod switches things and uses any of my BG Fixpack ideas, there could be additional problems created if you decided to have your 'fixer' auto-move these types of items into equipping slots cause that's what you currently expect in the BGT install...

((~%item%~ STRING_EQUAL_CASE ~MISC54~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~JALANT~)) OR        //Child's Body

this item is kinda pointless to be moved to a different slot. it's a bit too heavy to be pickpocketed EVER. setting the flag on this item and leaving it in the inventory should be acceptable IMHO. in fact that's what the BG1 fixpack does/will do.

((~%item%~ STRING_EQUAL_CASE ~RING07~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~RAMAZI~)) OR        //Ramazith's Prot Ring

Its only an exploit because Ramazith is created in 3 different areas. I've fixed it so that you can pickpocket any of his items and they no longer be present in any subsequent creations of his character.

Spoiler

//RamazithsMultiplePickpocketExploit.tph
// ----------------------------------------------------------------------------
//Ramazith Pickpocket Exploit Fix
// Prevent multiple pickpockets of Ramazith's pockets -- but you can still pick his pockets
<<<<<<<< inlined/ramazi.d
//These attempt to false the states so that they don't show again.
ADD_TRANS_TRIGGER ramazi 7 ~False()~ DO 2
ADD_TRANS_TRIGGER ramazi 8 ~False()~ DO 0
>>>>>>>>
COMPILE ~inlined/ramazi.d~
<<<<<<<< ramazi/stuffcheck.baf
//stole is set if taken by pick pocket
IF
Exists("Ramazith")
!Global("ab_BGF_bothgone","GLOBAL",1) //not destroyed
!HasItem("ring07","Ramazith") //stolen
!HasItem("amul16","Ramazith") //stolen
THEN
RESPONSE #100
SetGlobal("ab_BGF_bothstole","GLOBAL",1) //to destroy
END

IF
Exists("Ramazith")
!Global("ab_BGF_amulgone","GLOBAL",1) //not destroyed
HasItem("ring07","Ramazith") //still got
!HasItem("amul16","Ramazith") //stolen
THEN
RESPONSE #100
SetGlobal("ab_BGF_amulstole","GLOBAL",1) //to destroy
END

IF
Exists("Ramazith")
!Global("ab_BGF_ringgone","GLOBAL",1) //not destroyed
HasItem("amul16","Ramazith") //still got
!HasItem("ring07","Ramazith") //stolen
THEN
RESPONSE #100
SetGlobal("ab_BGF_ringstole","GLOBAL",1) //to destroy
END

//gone is set if destroyed because was stolen
IF
Exists("Ramazith")
Global("ab_BGF_bothstole","GLOBAL",1) //to destroy
HasItem("ring07","Ramazith") //has but shouldn't
HasItem("amul16","Ramazith") //has but shouldn't
THEN
RESPONSE #100
ActionOverride("Ramazith",DestroyItem("amul16")) //destroy
ActionOverride("Ramazith",DestroyItem("ring07")) //destroy
SetGlobal("ab_BGF_bothgone","GLOBAL",1) //told gone
END

IF
Exists("Ramazith")
Global("ab_BGF_amulstole","GLOBAL",1) //to destroy
HasItem("amul16","Ramazith") //has but shouldn't
THEN
RESPONSE #100
ActionOverride("Ramazith",DestroyItem("amul16")) //destroy
SetGlobal("ab_BGF_amulgone","GLOBAL",1) //told gone
END

IF
Exists("Ramazith")
Global("ab_BGF_ringstole","GLOBAL",1) //to destroy
HasItem("ring07","Ramazith") //has but shouldn't
THEN
RESPONSE #100
ActionOverride("Ramazith",DestroyItem("ring07")) //destroy
SetGlobal("ab_BGF_ringgone","GLOBAL",1) //told gone
END
>>>>>>>>
COPY_EXISTING ~ramazi.cre~ ~override~
 READ_ASCII 0x248 ~or_script~ //find override script
 INNER_ACTION BEGIN
  ACTION_IF (FILE_EXISTS_IN_GAME ~%or_script%.bcs~) THEN BEGIN //see if it's real
   COPY_EXISTING ~%or_script%.bcs~ ~override/abgframi.bcs~ //copy it and give it our name
   EXTEND_BOTTOM ~abgframi.bcs~ ~ramazi/stuffcheck.baf~ //add our stuff
  END ELSE BEGIN //otherwise
   EXTEND_BOTTOM ~abgframi.bcs~ ~ramazi/stuffcheck.baf~ //make new when add our stuff fails
  END
 END
 WRITE_ASCII_TERMINATE 0x248 ~abgframi~ //reassign override script to our value
BUT_ONLY_IF_IT_CHANGES

and you've of course seen the thread I started about the bandit scalps, so you know about other possibilities that could be employed if so desired.

[Lollorian]

Thing is, there's already an awesome utility in the G3Debugging Suite for debugging the inventory so I'm kinda reluctant to dulicate that code here

I think once my exams get done, I could prolly separate the Inventory Overhauler into a MASSIVE BORKAGE EXPECTED component (that does what it does right now ) and a SPECIFIC ITEM OVERHAULER (that can specifically alter individual items - like adding the stealable flag to body item MISC54 you mentioned )

Also, I didn't wanna dabble in script stuff to fix things, my intention was to make something that could make game resources well... less shittier to the game

That being said, the Area Stuff components look awesome now! Might actually prevent a few crashes and stutter

Recommended components list for now:

~LOLFIXER.TP2~ #0 #1 // Area Stuff - Missing Ambient Remover (removes ambients that don't have their WAV present): 0.1A
~LOLFIXER.TP2~ #0 #2 // Area Stuff - Missing Actor Remover (removes actors that don't have their CRE present): 0.1A
~LOLFIXER.TP2~ #0 #3 // Area Stuff - Missing Spawn Remover (nulls spawn entries that don't have their CRE present): 0.1A
~LOLFIXER.TP2~ #0 #4 // Area Stuff - Missing Rest Spawn Remover (nulls rest spawn entries that don't have their CRE present): 0.1A
~LOLFIXER.TP2~ #0 #6 // Creature Stuff - Creature Resource Fixer (res_fixer for ALL CREATURES): 0.1A
~LOLFIXER.TP2~ #0 #7 // Creature Stuff - Inventory Unborker (removes spurious references to the item table): 0.1A
~LOLFIXER.TP2~ #0 #8 // Creature Stuff - Inventory Cleaner (removes items that don't exist and converts them into already present items where applicable): 0.1A
~LOLFIXER.TP2~ #0 #10 // Item Stuff - Item Resource Fixer (res_fixer for ALL ITEMS): 0.1A
~LOLFIXER.TP2~ #0 #11 // Spell Stuff - Spell Resource Fixer (res_fixer for ALL THE SPELLS): 0.1A
~LOLFIXER.TP2~ #0 #12 // Spell Stuff - Innate Fixer (makes Innate spells level 1): 0.1A

[the bigg]

WeiDU is a 32 bit executable, hence it can't handle more than 2 GB of RAM, even if you had multiple terabytes RAM. Furthermore, OCaml has a default memory limit of 1GB, and the option to increment it is non-functional under Windows.

Your code is failing because the creature has three instances of ringdund.itm in its inventory, and apparently REMOVE_CRE_ITEM doesn't work correctly in that case. Can I have a copy of ringdund.itm, topazeye.itm and scalblue.itm? WeiDU works correctly; however, your code doesn't account for the fact that three items were removed instead of one, and thus starts reading invalid sections of the file instead of the item table.

Edited by the bigg, 28 November 2011 - 01:41 PM.

[10th]

Copy of all three items attached. Cre-file included. Big Picture's BPDRAGTP.CRE has the same inventory setup as the included DRAGTOPE.CRE.

10th

Attached Files

•  ringundtopazeyescalbluedragtope.7z   770bytes   352 downloads

[Lollorian]

WeiDU works correctly; however, your code doesn't account for the fact that three items were removed instead of one, and thus starts reading invalid sections of the file instead of the item table.

Dangnabbit! There should be a funstion to REMOVE_CRE_ITEM_SLOT specifying which slot to remove from Maybe even an EXCHANGE_CRE_ITEM_SLOT

Anyway, resorted to binary hackery and it works now I guess Thanks a million! And it just dawned on me that I could just check whether the item was DROPPABLE before moving them to let go of the omfghuge skiplist (would still be needed for those pickpocket things though )

Again, thanks a lot! Got kinda frustrated about this

Attached Files

•  SkooterTheNPC.zip   624.52K   7579 downloads

Edited by Lollorian, 24 July 2015 - 09:37 AM.

[Lollorian]

And up Here's how it looks now

Spoiler

BEGIN ~Creature Stuff - Inventory Overhauler (moves invalid but equippable items to inventory and equips anything in the inventory to a free slot)~
  GROUP ~Creature Stuff~

//G3 Debugging Suite - Equip invalid items
COPY_EXISTING_REGEXP GLOB ~^.+\.cre$~ ~override~
  PATCH_IF (SOURCE_SIZE > 0x2d3) BEGIN
    READ_LONG  0x2b8 "slot_off"
    READ_LONG  0x2bc "itm_off"

    // tracking variables
    SET "2hweapon" = 0
    SET "offhand" = 0
    SET "bow" = 0
    SET "arrows" = 0
    SET "xbow" = 0
    SET "bolts" = 0
    SET "sling" = 0
    SET "bullets" = 0
    SET "helm" = 0
    SET "armor" = 0
    SET "gloves" = 0
    SET "lring" = 0
    SET "rring" = 0
    SET "boots" = 0
    SET "belt" = 0
    SET "amulet" = 0
    SET "weapon1" = 0
    SET "weapon2" = 0
    SET "weapon3" = 0
    SET "weapon4" = 0
    SET "quiver1" = 0
    SET "quiver2" = 0
    SET "quiver3" = 0
    SET "quiver4" = 0
    SET "cloak" = 0
    SET "2handedequip" = 0
    PATCH_IF (("slot_off" > 0x2d3) AND ("itm_off" > 0x2d3)) BEGIN
      FOR (index = 0 ; index < 36 ; index = index + 1) BEGIN
        READ_SHORT ("%slot_off%" + (0x02 * "%index%")) "ref"
        PATCH_IF ("%ref%" != 0xffff) BEGIN
          READ_ASCII ("%itm_off%" + (0x14 * "%ref%")) "item"
          SET "ignore" = 0
          PATCH_IF ((~%item%~ STRING_EQUAL_CASE ~MISC86~) OR                                                           //Bandit Scalp
                   ((~%item%~ STRING_EQUAL_CASE ~MISC54~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~JALANT~)) OR          //Child's Body
                   ((~%item%~ STRING_EQUAL_CASE ~RING07~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~RAMAZI~)) OR          //Ramazith's Prot Ring
                   ((~%item%~ STRING_EQUAL_CASE ~MISC2H~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SHANDAL2~)) OR        //Shandalar's Wardstone
                   ((~%item%~ STRING_EQUAL_CASE ~MISC6Z~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~GEMCH02~)) OR         //Imnesvale Chicken's Beljuril
                   ((~%item%~ STRING_EQUAL_CASE ~MISCB7~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~HELLGEN~)) OR         //Genie's Tears of Bhaal
                   ((~%item%~ STRING_EQUAL_CASE ~RING39~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~HLKANG~)) OR          //Kangaxx's Gaxx Ring
                   ((~%item%~ STRING_EQUAL_CASE ~MISC8K~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~TRRAK01~)) OR         //Ihtafeer's Head
                   ((~%item%~ STRING_EQUAL_CASE ~MISCA7~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~UDPRINCE~)) OR        //Kuo-Tuan Prince's Blood
                   ((~%item%~ STRING_EQUAL_CASE ~MISC8H~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~UDSILVER~)) OR        //Adalon's Blood
                   ((~%item%~ STRING_EQUAL_CASE ~MISCCC~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~UDSILVER~))           //Adalon's Note
                   ) THEN BEGIN
            SET "ignore" = 1
          END
          PATCH_IF ((FILE_EXISTS_IN_GAME ~%item%.itm~)) THEN BEGIN
            INNER_PATCH_FILE ~%item%.itm~ BEGIN
              READ_SHORT 0x1c "type"
              READ_BYTE 0x18 "flags"
            END
            PATCH_IF ("%index%" = 0) BEGIN // helm slot
              SET "helm" = 1
              PATCH_IF (("%type%" != 7) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) BEGIN // helm
                PATCH_PRINT ~%SOURCE_FILE%: Invalid HELM: %item%.itm! Moving to inventory~
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                SET "ref2" = 1
                FOR (index3 = 21 ; ref2 != 0xffff ; index3 = index3 + 1) BEGIN
                  READ_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref2"
                END
                SET "index3" = "index3" - 1
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref"
                SET "helm" = 0
              END
            END
            PATCH_IF ("%index%" = 1) BEGIN // armor slot
              SET "armor" = 1
              PATCH_IF (("%type%" != 2) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) BEGIN // armor
                PATCH_PRINT ~%SOURCE_FILE%: Invalid ARMOR: %item%.itm! Moving to inventory~
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                SET "ref2" = 1
                FOR (index3 = 21 ; ref2 != 0xffff ; index3 = index3 + 1) BEGIN
                  READ_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref2"
                END
                SET "index3" = "index3" - 1
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref"
                SET "armor" = 0
              END
            END
            PATCH_IF ("%index%" = 2) BEGIN // shield slot
              SET "offhand" = 1
              PATCH_IF ((("%flags%" BAND 0b00000010) = 0b00000010) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) BEGIN // 2h check
                PATCH_PRINT ~%SOURCE_FILE%: 2-HANDED OFFHAND: %item%.itm! Moving to inventory~
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                SET "ref2" = 1
                FOR (index3 = 21 ; ref2 != 0xffff ; index3 = index3 + 1) BEGIN
                  READ_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref2"
                END
                SET "index3" = "index3" - 1
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref"
                SET "offhand" = 0
              END ELSE
              PATCH_IF (("%type%" != 12) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) BEGIN // if not shield, check for valid melee abilities
                SET "legit_offhand" = 0
                INNER_PATCH_FILE ~%item%.itm~ BEGIN
                  READ_LONG  0x64 "abil_off"
                  READ_SHORT 0x68 "abil_num"
                  FOR (index3 = 0 ; index3 < abil_num ; index3 = index3 + 1) BEGIN
                    READ_BYTE ("%abil_off%" + (0x38 * "%index3%")) "ability"
                    PATCH_IF ("%ability%" = 1) BEGIN // only melee allowed in offhand
                      SET "legit_offhand" = 1
                    END
                  END
                END
                PATCH_IF ("%legit_offhand%" = 0) BEGIN
                  PATCH_PRINT ~%SOURCE_FILE%: Invalid OFFHAND: %item%.itm! Moving to inventory~
                  WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                  SET "ref2" = 1
                  FOR (index3 = 21 ; ref2 != 0xffff ; index3 = index3 + 1) BEGIN
                    READ_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref2"
                   END
                  SET "index3" = "index3" - 1
                  WRITE_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref"
                  SET "offhand" = 0
                END
              END
            END
            PATCH_IF ("%index%" = 3) BEGIN // glove slot
              SET "gloves" = 1
              PATCH_IF (("%type%" != 6) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) BEGIN // gloves
                PATCH_PRINT ~%SOURCE_FILE%: Invalid GLOVES: %item%.itm! Moving to inventory~
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                SET "ref2" = 1
                FOR (index3 = 21 ; ref2 != 0xffff ; index3 = index3 + 1) BEGIN
                  READ_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref2"
                END
                SET "index3" = "index3" - 1
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref"
                SET "gloves" = 0
              END
            END
            PATCH_IF ("%index%" = 4) BEGIN
              SET "lring" = 1
              PATCH_IF (("%type%" != 10) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) BEGIN // rings
                PATCH_PRINT ~%SOURCE_FILE%: Invalid LRING: %item%.itm! Moving to inventory~
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                SET "ref2" = 1
                FOR (index3 = 21 ; ref2 != 0xffff ; index3 = index3 + 1) BEGIN
                  READ_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref2"
                END
                SET "index3" = "index3" - 1
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref"
                SET "lring" = 0
              END
            END
            PATCH_IF ("%index%" = 5) BEGIN
              SET "rring" = 1
              PATCH_IF (("%type%" != 10) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) BEGIN // rings
                PATCH_PRINT ~%SOURCE_FILE%: Invalid RRING: %item%.itm! Moving to inventory~
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                SET "ref2" = 1
                FOR (index3 = 21 ; ref2 != 0xffff ; index3 = index3 + 1) BEGIN
                  READ_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref2"
                END
                SET "index3" = "index3" - 1
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref"
                SET "rring" = 0
              END
            END
            PATCH_IF ("%index%" = 6) BEGIN // amulet slot
              SET "amulet" = 1
              PATCH_IF (("%type%" != 1) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) BEGIN // amulet
                PATCH_PRINT ~%SOURCE_FILE%: Invalid AMULET: %item%.itm! Moving to inventory~
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                SET "ref2" = 1
                FOR (index3 = 21 ; ref2 != 0xffff ; index3 = index3 + 1) BEGIN
                  READ_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref2"
                END
                SET "index3" = "index3" - 1
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref"
                SET "amulet" = 0
              END
            END
            PATCH_IF ("%index%" = 7) BEGIN // belt slot
              SET "belt" = 1
              PATCH_IF (("%type%" != 3) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) BEGIN // belt
                PATCH_PRINT ~%SOURCE_FILE%: Invalid BELT: %item%.itm! Moving to inventory~
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                SET "ref2" = 1
                FOR (index3 = 21 ; ref2 != 0xffff ; index3 = index3 + 1) BEGIN
                  READ_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref2"
                END
                SET "index3" = "index3" - 1
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref"
                SET "belt" = 0
              END
            END
            PATCH_IF ("%index%" = <img src='http://www.shsforums.net/public/style_emoticons/<#EMO_DIR#>/cool.gif' class='bbc_emoticon' alt='8)' /> BEGIN // boot slot
              SET "boots" = 1
              PATCH_IF (("%type%" != 4) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) BEGIN // boot
                PATCH_PRINT ~%SOURCE_FILE%: Invalid BOOTS: %item%.itm! Moving to inventory~
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                SET "ref2" = 1
                FOR (index3 = 21 ; ref2 != 0xffff ; index3 = index3 + 1) BEGIN
                  READ_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref2"
                END
                SET "index3" = "index3" - 1
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref"
                SET "boots" = 0
              END
            END
            PATCH_IF ("%index%" = 9) BEGIN // first weapon slot
              SET "weapon1" = 1
              SET "legit_weapon" = 0
              INNER_PATCH_FILE ~%item%.itm~ BEGIN
                READ_BYTE  0x18 "flags"
                READ_LONG  0x64 "abil_off"
                READ_SHORT 0x68 "abil_num"
                FOR (index3 = 0 ; index3 < abil_num ; index3 = index3 + 1) BEGIN
                  READ_BYTE ("%abil_off%" + (0x38 * "%index3%")) "ability"
                  PATCH_IF (("%ability%" = 1) OR ("%ability%" = 2) OR ("%ability%" = 4)) BEGIN // melee, ranged, or launcher
                    SET "legit_weapon" = 1
                  END
                END
                PATCH_IF (("%legit_weapon%" = 1) AND (("%flags%" BAND 0b00000010) = 0b00000010)) BEGIN // 2h check
                    SET "2handedequip" = 1
                END
              END
              PATCH_IF (("%legit_weapon%" = 0) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) BEGIN
                PATCH_PRINT ~%SOURCE_FILE%: Invalid WEAPON1: %item%.itm! Moving to inventory~
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                SET "ref2" = 1
                FOR (index3 = 21 ; ref2 != 0xffff ; index3 = index3 + 1) BEGIN
                  READ_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref2"
                END
                SET "index3" = "index3" - 1
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref"
                SET "weapon1" = 0
              END
            END
            PATCH_IF ("%index%" = 10) BEGIN // first weapon slot
              SET "weapon2" = 1
              SET "legit_weapon" = 0
              INNER_PATCH_FILE ~%item%.itm~ BEGIN
                READ_BYTE  0x18 "flags"
                READ_LONG  0x64 "abil_off"
                READ_SHORT 0x68 "abil_num"
                FOR (index3 = 0 ; index3 < abil_num ; index3 = index3 + 1) BEGIN
                  READ_BYTE ("%abil_off%" + (0x38 * "%index3%")) "ability"
                  PATCH_IF (("%ability%" = 1) OR ("%ability%" = 2) OR ("%ability%" = 4)) BEGIN // melee, ranged, or launcher
                    SET "legit_weapon" = 1
                  END
                END
                PATCH_IF (("%legit_weapon%" = 1) AND (("%flags%" BAND 0b00000010) = 0b00000010)) BEGIN // 2h check
                    SET "2handedequip" = 1
                END
              END
              PATCH_IF (("%legit_weapon%" = 0) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) BEGIN
                PATCH_PRINT ~%SOURCE_FILE%: Invalid WEAPON2: %item%.itm! Moving to inventory~
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                SET "ref2" = 1
                FOR (index3 = 21 ; ref2 != 0xffff ; index3 = index3 + 1) BEGIN
                  READ_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref2"
                END
                SET "index3" = "index3" - 1
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref"
                SET "weapon2" = 0
              END
            END
            PATCH_IF ("%index%" = 11) BEGIN // first weapon slot
              SET "weapon3" = 1
              SET "legit_weapon" = 0
              INNER_PATCH_FILE ~%item%.itm~ BEGIN
                READ_BYTE  0x18 "flags"
                READ_LONG  0x64 "abil_off"
                READ_SHORT 0x68 "abil_num"
                FOR (index3 = 0 ; index3 < abil_num ; index3 = index3 + 1) BEGIN
                  READ_BYTE ("%abil_off%" + (0x38 * "%index3%")) "ability"
                  PATCH_IF (("%ability%" = 1) OR ("%ability%" = 2) OR ("%ability%" = 4)) BEGIN // melee, ranged, or launcher
                    SET "legit_weapon" = 1
                  END
                END
                PATCH_IF (("%legit_weapon%" = 1) AND (("%flags%" BAND 0b00000010) = 0b00000010)) BEGIN // 2h check
                    SET "2handedequip" = 1
                END
              END
              PATCH_IF (("%legit_weapon%" = 0) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) BEGIN
                PATCH_PRINT ~%SOURCE_FILE%: Invalid WEAPON3: %item%.itm! Moving to inventory~
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                SET "ref2" = 1
                FOR (index3 = 21 ; ref2 != 0xffff ; index3 = index3 + 1) BEGIN
                  READ_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref2"
                END
                SET "index3" = "index3" - 1
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref"
                SET "weapon3" = 0
              END
            END
            PATCH_IF ("%index%" = 12) BEGIN // first weapon slot
              SET "weapon4" = 1
              SET "legit_weapon" = 0
              INNER_PATCH_FILE ~%item%.itm~ BEGIN
                READ_BYTE  0x18 "flags"
                READ_LONG  0x64 "abil_off"
                READ_SHORT 0x68 "abil_num"
                FOR (index3 = 0 ; index3 < abil_num ; index3 = index3 + 1) BEGIN
                  READ_BYTE ("%abil_off%" + (0x38 * "%index3%")) "ability"
                  PATCH_IF (("%ability%" = 1) OR ("%ability%" = 2) OR ("%ability%" = 4)) BEGIN // melee, ranged, or launcher
                    SET "legit_weapon" = 1
                  END
                END
                PATCH_IF (("%legit_weapon%" = 1) AND (("%flags%" BAND 0b00000010) = 0b00000010)) BEGIN // 2h check
                    SET "2handedequip" = 1
                END
              END
              PATCH_IF (("%legit_weapon%" = 0) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) BEGIN
                PATCH_PRINT ~%SOURCE_FILE%: Invalid WEAPON4: %item%.itm! Moving to inventory~
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                SET "ref2" = 1
                FOR (index3 = 21 ; ref2 != 0xffff ; index3 = index3 + 1) BEGIN
                  READ_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref2"
                END
                SET "index3" = "index3" - 1
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref"
                SET "weapon4" = 0
              END
            END
            PATCH_IF ("%index%" = 13) BEGIN // first quiver slot
              SET "quiver1" = 1
              PATCH_IF (NOT (("%type%" = 5) OR ("%type%" = 31) OR ("%type%" = 14)) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) BEGIN
                PATCH_PRINT ~%SOURCE_FILE%: Invalid QUIVER1: %item%.itm! Moving to inventory~
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                SET "ref2" = 1
                FOR (index3 = 21 ; ref2 != 0xffff ; index3 = index3 + 1) BEGIN
                  READ_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref2"
                END
                SET "index3" = "index3" - 1
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref"
                SET "quiver1" = 0
              END
            END
            PATCH_IF ("%index%" = 14) BEGIN // first quiver slot
              SET "quiver2" = 1
              PATCH_IF (NOT (("%type%" = 5) OR ("%type%" = 31) OR ("%type%" = 14)) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) BEGIN
                PATCH_PRINT ~%SOURCE_FILE%: Invalid QUIVER2: %item%.itm! Moving to inventory~
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                SET "ref2" = 1
                FOR (index3 = 21 ; ref2 != 0xffff ; index3 = index3 + 1) BEGIN
                  READ_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref2"
                END
                SET "index3" = "index3" - 1
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref"
                SET "quiver2" = 0
              END
            END
            PATCH_IF ("%index%" = 15) BEGIN // first quiver slot
              SET "quiver3" = 1
              PATCH_IF (NOT (("%type%" = 5) OR ("%type%" = 31) OR ("%type%" = 14)) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) BEGIN
                PATCH_PRINT ~%SOURCE_FILE%: Invalid QUIVER3: %item%.itm! Moving to inventory~
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                SET "ref2" = 1
                FOR (index3 = 21 ; ref2 != 0xffff ; index3 = index3 + 1) BEGIN
                  READ_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref2"
                END
                SET "index3" = "index3" - 1
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref"
                SET "quiver3" = 0
              END
            END
            PATCH_IF ("%index%" = 16) BEGIN // first quiver slot
              SET "quiver4" = 1
              PATCH_IF (NOT (("%type%" = 5) OR ("%type%" = 31) OR ("%type%" = 14)) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) BEGIN
                PATCH_PRINT ~%SOURCE_FILE%: Invalid QUIVER4: %item%.itm! Moving to inventory~
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                SET "ref2" = 1
                FOR (index3 = 21 ; ref2 != 0xffff ; index3 = index3 + 1) BEGIN
                  READ_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref2"
                END
                SET "index3" = "index3" - 1
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref"
                SET "quiver4" = 0
              END
            END
            PATCH_IF ("%index%" = 17) BEGIN // cloak
              SET "cloak" = 1
              PATCH_IF (("%type%" != 32) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) BEGIN // cloak
                PATCH_PRINT ~%SOURCE_FILE%: Invalid CLOAK: %item%.itm! Moving to inventory~
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                SET "ref2" = 1
                FOR (index3 = 21 ; ref2 != 0xffff ; index3 = index3 + 1) BEGIN
                  READ_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref2"
                END
                SET "index3" = "index3" - 1
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index3%")) "ref"
                SET "cloak" = 0
              END
            END
            PATCH_IF ((("%type%" =  1) AND ("%amulet%" = 0)) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) AND ("%index%" > 17) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping AMULET~
              WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
              WRITE_SHORT ("%slot_off%" + (0x02 * 6))         "ref"
              SET "%amulet%" = 1
            END ELSE
            PATCH_IF ((("%type%" =  2) AND ("%armor%" = 0)) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) AND ("%index%" > 17) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping ARMOR~
              WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
              WRITE_SHORT ("%slot_off%" + (0x02))             "ref"
              SET "%armor%" = 1
            END ELSE
            PATCH_IF ((("%type%" =  3) AND ("%belt%" = 0)) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) AND ("%index%" > 17) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping BELT~
              WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
              WRITE_SHORT ("%slot_off%" + (0x02 * 7))         "ref"
              SET "%belt%" = 1
            END ELSE
            PATCH_IF ((("%type%" =  4) AND ("%boots%" = 0)) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) AND ("%index%" > 17) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping BOOTS~
              WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
              WRITE_SHORT ("%slot_off%" + (0x02 * <img src='http://www.shsforums.net/public/style_emoticons/<#EMO_DIR#>/cool.gif' class='bbc_emoticon' alt='8)' />)         "ref"
              SET "%boots%" = 1
            END ELSE
            PATCH_IF (((("%type%" =  5) OR
                        ("%type%" = 14) OR
                        ("%type%" = 31)) AND ("%quiver1%" = 0) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) AND ("%index%" > 17)) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping QUIVER1~
              WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
              WRITE_SHORT ("%slot_off%" + (0x02 * 13))        "ref"
              SET "%quiver1%" = 1
            END ELSE
            PATCH_IF (((("%type%" =  5) OR
                        ("%type%" = 14) OR
                        ("%type%" = 31)) AND ("%quiver2%" = 0) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) AND ("%index%" > 17)) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping QUIVER2~
              WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
              WRITE_SHORT ("%slot_off%" + (0x02 * 14))        "ref"
              SET "%quiver2%" = 1
            END ELSE
            PATCH_IF (((("%type%" =  5) OR
                        ("%type%" = 14) OR
                        ("%type%" = 31)) AND ("%quiver3%" = 0) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) AND ("%index%" > 17)) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping QUIVER3~
              WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
              WRITE_SHORT ("%slot_off%" + (0x02 * 15))        "ref"
              SET "%quiver3%" = 1
            END ELSE
            PATCH_IF (((("%type%" =  5) OR
                        ("%type%" = 14) OR
                        ("%type%" = 31)) AND ("%quiver4%" = 0)) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100) AND ("%index%" > 17)) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping QUIVER4~
              WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
              WRITE_SHORT ("%slot_off%" + (0x02 * 16))        "ref"
              SET "%quiver4%" = 1
            END ELSE
            PATCH_IF ((("%type%" =  6) AND ("%gloves%" = 0)) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) AND ("%index%" > 17) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping GLOVES~
              WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
              WRITE_SHORT ("%slot_off%" + (0x02 * 3))         "ref"
              SET "gloves" = 1
            END ELSE
            PATCH_IF ((("%type%" =  7) AND ("%helm%" = 0)) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) AND ("%index%" > 17) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping HELM~
              WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
              WRITE_SHORT ("%slot_off%")                      "ref"
              SET "helm" = 1
            END ELSE
            PATCH_IF ((("%type%" = 10) AND ("%lring%" = 0)) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) AND ("%index%" > 17) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping LRING~
              WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
              WRITE_SHORT ("%slot_off%" + (0x02 * 4))         "ref"
              SET "lring" = 1
            END ELSE
            PATCH_IF ((("%type%" = 10) AND ("%rring%" = 0)) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) AND ("%index%" > 17) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping RRING~
              WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
              WRITE_SHORT ("%slot_off%" + (0x02 * 5))         "ref"
              SET "rring" = 1
            END ELSE
            PATCH_IF (((("%type%" = 15) OR // bow
                        ("%type%" = 16) OR // dagger
                        ("%type%" = 17) OR // maces
                        ("%type%" = 18) OR // sling
                        ("%type%" = 19) OR // short sword
                        ("%type%" = 20) OR // swords
                        ("%type%" = 21) OR // hammer
                        ("%type%" = 22) OR // morning stars
                        ("%type%" = 23) OR // flail
                        ("%type%" = 24) OR // darts
                        ("%type%" = 25) OR // axe
                        ("%type%" = 26) OR // staff
                        ("%type%" = 27) OR // xbow
                        ("%type%" = 28) OR // hand to hand
                        ("%type%" = 29) OR // Spear
                        ("%type%" = 30) OR // halberd
                        ("%type%" = 44)) AND ("%weapon1%" = 0) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100) AND ("%index%" > 17)))  BEGIN
              PATCH_IF ((("%flags%" BAND 0b00000010) != 0b00000010) AND ("%offhand%" = 0)) BEGIN
                PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping WEAPON1~
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                WRITE_SHORT ("%slot_off%" + (0x02 * 9))         "ref"
                SET "%weapon1%" = 1
              END
            END ELSE
            PATCH_IF (((("%type%" = 15) OR // bow
                        ("%type%" = 16) OR // dagger
                        ("%type%" = 17) OR // maces
                        ("%type%" = 18) OR // sling
                        ("%type%" = 19) OR // short sword
                        ("%type%" = 20) OR // swords
                        ("%type%" = 21) OR // hammer
                        ("%type%" = 22) OR // morning stars
                        ("%type%" = 23) OR // flail
                        ("%type%" = 24) OR // darts
                        ("%type%" = 25) OR // axe
                        ("%type%" = 26) OR // staff
                        ("%type%" = 27) OR // xbow
                        ("%type%" = 28) OR // hand to hand
                        ("%type%" = 29) OR // Spear
                        ("%type%" = 30) OR // halberd
                        ("%type%" = 44)) AND ("%weapon2%" = 0) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100) AND ("%index%" > 17)))  BEGIN
              PATCH_IF ((("%flags%" BAND 0b00000010) != 0b00000010) AND ("%offhand%" = 0)) BEGIN
                PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping WEAPON2~
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                WRITE_SHORT ("%slot_off%" + (0x02 * 10))        "ref"
                SET "%weapon2%" = 1
              END
            END ELSE
            PATCH_IF (((("%type%" = 15) OR // bow
                        ("%type%" = 16) OR // dagger
                        ("%type%" = 17) OR // maces
                        ("%type%" = 18) OR // sling
                        ("%type%" = 19) OR // short sword
                        ("%type%" = 20) OR // swords
                        ("%type%" = 21) OR // hammer
                        ("%type%" = 22) OR // morning stars
                        ("%type%" = 23) OR // flail
                        ("%type%" = 24) OR // darts
                        ("%type%" = 25) OR // axe
                        ("%type%" = 26) OR // staff
                        ("%type%" = 27) OR // xbow
                        ("%type%" = 28) OR // hand to hand
                        ("%type%" = 29) OR // Spear
                        ("%type%" = 30) OR // halberd
                        ("%type%" = 44)) AND ("%weapon3%" = 0) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100) AND ("%index%" > 17)))  BEGIN
              PATCH_IF ((("%flags%" BAND 0b00000010) != 0b00000010) AND ("%offhand%" = 0)) BEGIN
                PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping WEAPON3~
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                WRITE_SHORT ("%slot_off%" + (0x02 * 11))        "ref"
                SET "%weapon3%" = 1
              END
            END ELSE
            PATCH_IF (((("%type%" = 15) OR // bow
                        ("%type%" = 16) OR // dagger
                        ("%type%" = 17) OR // maces
                        ("%type%" = 18) OR // sling
                        ("%type%" = 19) OR // short sword
                        ("%type%" = 20) OR // swords
                        ("%type%" = 21) OR // hammer
                        ("%type%" = 22) OR // morning stars
                        ("%type%" = 23) OR // flail
                        ("%type%" = 24) OR // darts
                        ("%type%" = 25) OR // axe
                        ("%type%" = 26) OR // staff
                        ("%type%" = 27) OR // xbow
                        ("%type%" = 28) OR // hand to hand
                        ("%type%" = 29) OR // Spear
                        ("%type%" = 30) OR // halberd
                        ("%type%" = 44)) AND ("%weapon4%" = 0) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100) AND ("%index%" > 17)))  BEGIN
              PATCH_IF ((("%flags%" BAND 0b00000010) != 0b00000010) AND ("%offhand%" = 0)) BEGIN
                PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping WEAPON4~
                WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
                WRITE_SHORT ("%slot_off%" + (0x02 * 12))        "ref"
                  SET "%weapon4%" = 1
              END
            END ELSE
            PATCH_IF ((("%type%" = 12) AND ("%offhand%" = 0) AND ("2handedequip" = 0)) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) AND ("%index%" > 17) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping SHIELD~
              WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
              WRITE_SHORT ("%slot_off%" + (0x02 * 2))         "ref"
              SET "offhand" = 1
            END ELSE
            PATCH_IF ((("%type%" = 32) AND ("%cloak%" = 0)) AND ("%ignore%" = 0) AND (("%flags%" BAND 0b00000100) = 0b00000100)) AND ("%index%" > 17) BEGIN
              PATCH_PRINT ~%SOURCE_FILE%: Equippable items in inventory: %item%.itm! Equipping CLOAK~
              WRITE_SHORT ("%slot_off%" + (0x02 * "%index%")) 0xffff
              WRITE_SHORT ("%slot_off%" + (0x02 * 17))        "ref"
              SET "cloak" = 1
            END
          END
        END
      END
    END
  END
BUT_ONLY_IF_IT_CHANGES

Attached Files

•  lolfixer.7z   7.5K   384 downloads
•  SETUP-LOLFIXER_CBELEDI1.7z   2.98K   338 downloads
•  SETUP-LOLFIXER_GLOB.7z   128.41K   354 downloads
•  CBELEDI1.7z   597bytes   338 downloads

Edited by Lollorian, 29 November 2011 - 03:12 AM.

[i30817]

Say, will you be using this to report to the mods the errors it finds? Or it's a pure fixer with no reporting?

[Lollorian]

It's supposed to be something that can fix only the absolutely OBVIOUS errors so yeah it will fix But anything and everything it does is seen in the console output (in a - hopefully - really simple and understandable way )

I do intend to log everything to a file for easy reporting though... But just concentrating on getting the fixing scripts right before I add in the logging stuff

Meanwhile, might I point you to the oh-so-awesome G3Debugging Suite for its logging? Reports much more than this thing fixes

Edited by Lollorian, 29 November 2011 - 08:44 AM.

[krimine]

Also reports more than necessary, like bg1 proficiencies in bg2 files, which is no problem for the engine.

[Sasha Al'Therin]

also reports map note offsets being off when ran in BG1 which is totally ok since BG1 doesn't use map notes.

[Lollorian]

... also reports shields in the inventory as equippable even if theres a 2-handed weapon already equipped

Anyway, this thread helped fix the Overhauler skipping lots of stuff Now to use the Res_fixer code to create something that can reindex AREs

@Sasha: Its project page says it's just for BGII

Edited by Lollorian, 29 November 2011 - 07:16 PM.

[Sasha Al'Therin]

@Sasha: Its project page says it's just for BGII

Yes but Camdawg told me that I could run it in BG1 since 99% of the file structures were the same. I'd just have to take things like the map note offsets into account ^^