Jump to content


Photo

LolFixer Thread


  • Please log in to reply
355 replies to this topic

#181 dabus

dabus
  • Member
  • 1982 posts

Posted 01 March 2013 - 03:01 AM

https://github.com/o...hive/master.zip
THINK! - It's not illegal.

#182 Creepin

Creepin
  • Administrator
  • 1676 posts

Posted 01 March 2013 - 03:06 AM

Dabus, thanks a lot! :)


The Old Gold - v0.2 WIP (mod for BGT/BWP/BWS)


#183 -Guest-

-Guest-
  • Guest

Posted 25 March 2013 - 06:36 PM

Trying this for the first time in a BWS install, I get hundreds of lines of errors from the Spell Fixer bit, here's a sample:

 

----------

A6SPW425.SPL error: Ability #0 assigned to SPELL slot (was INNATE)...
ABZAWAY.SPL error: Innate Spell is not Level 1! Setting level to 1...
ABZAWAY.SPL error: Ability #0 assigned to INNATE slot (was SPELL)...
AMUL01.SPL error: Innate Spell is not Level 1! Setting level to 1...
AMUL01.SPL error: Ability #0 assigned to INNATE slot (was SPELL)...
AMUL25.SPL error: Innate Spell is not Level 1! Setting level to 1...
AMUL25.SPL error: Ability #0 assigned to INNATE slot (was SPELL)...
B#ARC02.SPL error: Innate Spell is not Level 1! Setting level to 1...

----------

 

Which culminates in:

 

----------


ERROR: parsing [BALDUR.BCS.BAF]: Parsing.Parse_error
ERROR: [BALDUR.BCS] -> [override/BALDUR.BCS] Patching Failed (COPY) (Parsing.Parse_error)
ERROR: Parsing.Parse_error
Spell Stuff - MAJESTIC Spell Fixer (LolFixer) was not installed due to errors.

----------



#184 -Atlas-

-Atlas-
  • Guest

Posted 27 March 2013 - 09:01 PM

I'm also getting a similar error.

 

 

ERROR: parsing [POREST2.BCS.BCS]: Parsing.Parse_error
ERROR: [POREST2.BCS] -> [override/POREST2.BCS] Patching Failed (COPY) (Parsing.Parse_error)
ERROR: Parsing.Parse_error
Spell Stuff - MAJESTIC Spell Fixer (LolFixer) was not installed due to errors.
 
You can try to repair the problem and start the installation of the component
again. In this case please select "retry" after the repair.
D:\Game\Baldur's Gate 2>
 
ERROR: parsing [POREST2.BCS.BCS]: Parsing.Parse_error
ERROR: [POREST2.BCS] -> [override/POREST2.BCS] Patching Failed (COPY) (Parsing.Parse_error)
ERROR: Parsing.Parse_error
Spell Stuff - MAJESTIC Spell Fixer (LolFixer) was not installed due to errors.
 

 



#185 Lollorian

Lollorian

    smiley addict

  • Member
  • 4150 posts

Posted 02 April 2013 - 04:00 AM

Yeah so I've been away a bit and...

 

As for the lolfixer hanging up on random script files, I have no clue :unsure: (unless there's something in those errant scripts that's causing this... which means I'll need a copy of the script before it gets messed around by the lolfixer :D Why do these double extensions show up anyway? :blink:)

 

Don't worry though, harmless snafu is snafu - the BWP ran well without the spell fixer for all these years and it shouldn't matter... much atleast :P

 

Meanwhile, if anyone wants to - feel free to pick up the code and do magic with it ^_^ It might be a while before I pick this up again :P


"I am the smiley addict, yellow and round, this is my grin :D when I'm usually around :P.
When there's trouble brewing, see me post, cuz it's usually a wall o' yellow and your eyes are toast!!!"

BWP GUIDE - BWP FIXES - impFAQ - NPC LIST - KIT LIST - AREA LIST

GitHub Links : BWP Fixpack | Lolfixer | BWP Trimpack | RezMod


#186 Maanape

Maanape
  • Member
  • 32 posts

Posted 25 April 2013 - 03:52 AM

I was noticing that some creatures had much more item drops, such as hobgoblins dropping two lether armors and two bows. Now I've found each iron guard dropping a leather, a chain and a splint armor, when they should only have the splint (which they were originally wearing). After searching with change-log.bat, it turned out the Lolfixer was adding items into creatures' inventories. Is that intended?



#187 Lollorian

Lollorian

    smiley addict

  • Member
  • 4150 posts

Posted 16 August 2013 - 09:04 AM

Time to revisit this again :D Probaby overdue but anyway...

 

@Maanape:

THat's not intended but a side effect of mods not properly removing items from creatures :P

 

Suppose Bobgoblin has items A and B in his inventory.

Mod X came along thinking 'Bobgoblin would be so much cooler with item C instead of A'.

Good mods remove A and add C... but some mods just add C and tell the game to look at C instead of A (which means A is still inside Bob's inventory but can't be seen)

Lolfixer makes it so the game sees every item the creature has in its inventory (primarily so you don't miss out on stuff that might be important, yaknow like unique or quest items :P)

 

So yeah technically, the olfixer doesn't exactly add items to creatures if they weren't already there ;)

 

===============================================================================

 

Now that that's out of the way, it might be a while before I get the git repos set up again so here's Lolfixer_16082013 :D

 

What's new?

- It can now convert tutu items to their BGT counterparts in ARE containers or CRE inventories.

- It will try to fix problems like flaming swords burning the user (if you install the BG2Fixpack BETA Core fixesfrom v10)

- It will try to fix crashing problems caused by a combination 1PP's JC helm animations and InfinityAnimations BG1 NPC animations

 

:cheers:

 

EDIT: Old habits die hard <_< Reuploaded to fix error.

Attached Files


Edited by Lollorian, 16 August 2013 - 09:35 AM.

"I am the smiley addict, yellow and round, this is my grin :D when I'm usually around :P.
When there's trouble brewing, see me post, cuz it's usually a wall o' yellow and your eyes are toast!!!"

BWP GUIDE - BWP FIXES - impFAQ - NPC LIST - KIT LIST - AREA LIST

GitHub Links : BWP Fixpack | Lolfixer | BWP Trimpack | RezMod


#188 Mad Mate

Mad Mate
  • Member
  • 191 posts

Posted 16 August 2013 - 12:41 PM

Thank you Loll!!!!  :clap:

What do you think about PutridWalker's opinion about Inventory Overhauler?

http://www.shsforums...12/#entry560221

I'm now playing BWP without it, following his observation.

Is it safe for next install or it should be done some other way?

Thanks!



#189 Lollorian

Lollorian

    smiley addict

  • Member
  • 4150 posts

Posted 16 August 2013 - 09:14 PM

Creature Stuff - Inventory Overhauler (moves invalid but equippable items to inventory and equips anything in the inventory to a free slot)

 

YAY! The component name! :D

 

 

This seems to me like a very careless component to install.

 

It is :P

 

Some inventory items are not meant for the NPC that holds them to equip (imagine some NPC having a cursed item in his inventory).

 

It will not try to equip an item that is either cursed or undroppable :)

 

And moreover because you can not pickpocket equipped things this will hamper pickpocket a bit.

 

Yes legitimate concern :(

Athough I tried to aleviate this by only equipping items that help change an NPC's appearance (helm, armor, weapon, shield, quiver). So you can still pickpocket rings, amulets, cloaks, boots, gloves and belts, :D

 

And even more yet, this can probably fool the "BG1 Character Animations for NPCs" because that component will patch the new animations if the NPCs are not wielding, say, a Katana. But if the NPC had a katana in his inventory, this component will place it in his hands, despite him having the new animation.

 

I, uh, don't think that's true (yes I know I'll be wrong 2 days from posting this :P)

 

BG1 animation crashes seemed to come from an incomplete helmet animation set (JC) added by 1PP. This set had animations for BG2 but no BG1 animations (as far as I could make out from the crashing patterns :lol:)

 

Also this helm animation was used by 2 very generic helms (HELM12 and HELM22) that almost every BG2 fighter NPC used :D

 

Item Stuff - res_fixer for all items now fixes those crashes if you have 1pp installed :)

 

Now why should you install the Overhauler?

- Crash proofing! It will not allow cases where CREs have 2 handed swords with shields or similar.

- No unfair advantages! An NPC with 3 rings of prot +1 equipped (in the left ring, right ring and armor slots) gets a +3 prot effect... HOW THE HELL CAN YOU WEAR A RING LIKE ARMOR??? If CHARNAME can't do it, neither should an NPC be able to...

- For the looking nice! ^_^ NPCs are look better equipped to be threatening a Bhaalspawn (I had an encounter where unarmored bandits ambushed my toons and attacked with fists - they had all their items in the inventory but hadn't equipped them... any guesses why I coded up this component? :lol:)

 

All that said,I'm open to suggestions on how to fix whatever it does wrong :)


Edited by Lollorian, 16 August 2013 - 10:19 PM.

"I am the smiley addict, yellow and round, this is my grin :D when I'm usually around :P.
When there's trouble brewing, see me post, cuz it's usually a wall o' yellow and your eyes are toast!!!"

BWP GUIDE - BWP FIXES - impFAQ - NPC LIST - KIT LIST - AREA LIST

GitHub Links : BWP Fixpack | Lolfixer | BWP Trimpack | RezMod


#190 Mad Mate

Mad Mate
  • Member
  • 191 posts

Posted 17 August 2013 - 05:33 AM

Thank you for answer! I think this component goes back in my regular setup, just after I finish with my current playthrough.

Keep up good work!



#191 Arturcic

Arturcic
  • Member
  • 119 posts

Posted 17 August 2013 - 02:00 PM

Should we replace the lolFixer inside the BiG World Fixpack folder (_lolFixer_05022013) with this new versión?



#192 The Imp

The Imp

    Not good, see EVIL is better. You'll LIVE.

  • Member
  • 5155 posts

Posted 17 August 2013 - 05:36 PM

Should we replace the lolFixer inside the BiG World Fixpack folder (_lolFixer_05022013) with this new versión?

No, lolFixer is installed at the very end to make sure the other fixes actually are still in game after all the content adding mods that need them are installed ... but before the Generalized Biffing as that just fasterns the game loadup times etc.


Edited by The Imp, 17 August 2013 - 05:37 PM.

Yep, Jarno Mikkola. my Mega Mod FAQ. Use of the BWS, and how to use it(scroll down that post a bit). 
OK, desert dweller, welcome to the sanity, you are free to search for the limit, it's out there, we drew it in the sand. Ouh, actually it was still snow then.. but anyways.


#193 Lollorian

Lollorian

    smiley addict

  • Member
  • 4150 posts

Posted 17 August 2013 - 08:59 PM

@Arturck: Yes :cheers:

 

@Jarno: The BWPFixpack copies the lolfixer to the main BGII folder from that _lolfixer_xxxx folder... the lolfixer is actually installed just where you said anyway :P


"I am the smiley addict, yellow and round, this is my grin :D when I'm usually around :P.
When there's trouble brewing, see me post, cuz it's usually a wall o' yellow and your eyes are toast!!!"

BWP GUIDE - BWP FIXES - impFAQ - NPC LIST - KIT LIST - AREA LIST

GitHub Links : BWP Fixpack | Lolfixer | BWP Trimpack | RezMod


#194 Lollorian

Lollorian

    smiley addict

  • Member
  • 4150 posts

Posted 21 August 2013 - 09:29 AM

Okay then new stuff :D (22 Aug 2013)

 

- [ARE] Will set the CRE not attached flag for actors if the creature file exists

- [ARE] Will set the removal time for actors to -1 (never remove) if it is 0 (which means actors spawn and then get removed immediately :lol: So you never see them... Huzzah for micbaldur! :cheers:)

- [ARE] Fixed stupid error in flag checking for attached CREs before removal

 

- [CRE] _TASIGHT (tutu) script references are converted into WTASIGHT (BGT/2/ToB) script references (if _TASIGHT doesn't exist ofcourse :P)

- [CRE] Items that are removed from invalid slots are now marked unstealable when adding into the inventory (basically means you won't be able to pickpocket friggin body parts out of creatures now :ROFL:... among other things)

 

You'll need a weidu.exe renamed to setup-lolfixer.exe to run this :)

Attached Files


"I am the smiley addict, yellow and round, this is my grin :D when I'm usually around :P.
When there's trouble brewing, see me post, cuz it's usually a wall o' yellow and your eyes are toast!!!"

BWP GUIDE - BWP FIXES - impFAQ - NPC LIST - KIT LIST - AREA LIST

GitHub Links : BWP Fixpack | Lolfixer | BWP Trimpack | RezMod


#195 10th

10th
  • Member
  • 621 posts

Posted 21 August 2013 - 09:51 AM


- ARE Will set the CRE not attached flag for actors if the creature file exists
- ARE Will set the removal time for actors to -1 (never remove) if it is 0 (which means actors spawn and then get removed immediately :lol: So you never see them... Huzzah for micbaldur! :cheers:)
- ARE Fixed stupid error in flag checking for attached CREs before removal

Only removal time -1 is required, at least in my install.

10th

Edited by 10th, 21 August 2013 - 10:00 AM.

Avast! You cannot defeat our titan-mounted submarine staffed by cannibal vikings! - Nodwick

"I grab his deceased spirit and piledrive it back into his body, duplicating raise dead." - Psyren Oots board

#196 Lollorian

Lollorian

    smiley addict

  • Member
  • 4150 posts

Posted 21 August 2013 - 05:59 PM

Yup it's just for file integrity purposes :P

 

At most, I think it is as effective as nulling missing resource references in files - it prevents the engine from looking for something that doesn't exist :D (in this case, an attached CRE)

 

... and coding it up lets me do things to files... I like doing things to files :wub:


"I am the smiley addict, yellow and round, this is my grin :D when I'm usually around :P.
When there's trouble brewing, see me post, cuz it's usually a wall o' yellow and your eyes are toast!!!"

BWP GUIDE - BWP FIXES - impFAQ - NPC LIST - KIT LIST - AREA LIST

GitHub Links : BWP Fixpack | Lolfixer | BWP Trimpack | RezMod


#197 -Myk-

-Myk-
  • Guest

Posted 11 September 2013 - 06:26 PM

Heya, I just did a Tactics-based BWP install and got this error from lolfixer:

 

ERROR: illegal 8-byte read from offset 16564 of 16565-byte file AAR003.ARE
ERROR: [AAR003.ARE] -> [override/AAR003.ARE] Patching Failed (COPY) (Failure("AAR003.ARE: read out of bounds"))
Stopping installation because of error.

 

The entire setup-lolfixer.debug file is 48MB, but here is the relevant section:

Spoiler

 

I was unable to grab the file before generalized-biffing removed it, but I can redo the install if you need it.  Is there any more useful info I can provide?



#198 -Myk-

-Myk-
  • Guest

Posted 11 September 2013 - 07:12 PM

Ok, I found the AAR003 files in the generalized_biffer backup hierarchy.  I can send them to you if you want them.



#199 Lollorian

Lollorian

    smiley addict

  • Member
  • 4150 posts

Posted 12 September 2013 - 06:40 AM

I have a hunch that your thing is caused by the BWPFixpack trying to patch AAR003.ARE instead of overwriting it like every other binary file in a mod. See here for details.

 

Thanks for taking the effort to debug though and even considering reinstalling - won't be necessary btw. Grab micbladur's original fixed AAR003.ARE from the Vecna.rar attachment in this post. The lolfixer should work proper if you put that ARE into your override folder.

 

If it still doesn't work, don't worry, you can skip that lolfixer component without too much damage. Please don't reinstall :)

Upload your AAR003.ARE somewhere and post a link to it here and I'll fix it up for you.


Edited by Lollorian, 12 September 2013 - 06:42 AM.

"I am the smiley addict, yellow and round, this is my grin :D when I'm usually around :P.
When there's trouble brewing, see me post, cuz it's usually a wall o' yellow and your eyes are toast!!!"

BWP GUIDE - BWP FIXES - impFAQ - NPC LIST - KIT LIST - AREA LIST

GitHub Links : BWP Fixpack | Lolfixer | BWP Trimpack | RezMod


#200 -Myk-

-Myk-
  • Guest

Posted 12 September 2013 - 07:19 AM

It does indeed look like that could the problem.  Comparing the hexdumps, I see 0x0a replaced with 0x0d 0x0a.  Is the file being rewritten in ASCII mode instead of binary mode?

 

I'll de-biff, replace, rerun lolfixer, and re-biff.  Thanks for the links!