143 replies to this topic

[i30817]

I see the idea. But i was thinking of (dunno if it would work, so yell if you think not):

Append this to the end of the override script for each joinable char:

Spoiler

//thief trap disarm and lockpicking

IF
        HotKey("%T%")
        ActionListEmpty()
        OR(2)
          CheckStatGT(Myself,1,TRAPS)
          CheckStatGT(Myself,1,LOCKPICKING)
THEN
        RESPONSE #100
          ActionOverride(Myself,ChangeAIScript("i3_thief",OVERRIDE))
END

//thief pickpocket

IF
        HotKey("%G%")
        ActionListEmpty()
        CheckStatGT(Myself,1,PICKPOCKET)
        See([NEUTRAL])
        Range(LastSeenBy(Myself),5)
THEN
        RESPONSE #100
                FaceObject(LastSeenBy(Myself))
                PickPockets(LastSeenBy(Myself))
END

on i3_thief:

Spoiler

//first the traps...
IF

        AreaCheck("%area%")
        CheckStatGT(Myself,1,TRAPS)
        !Disarmed("%trigger%")
        Range("%trigger%",5)
THEN
        RESPONSE #100
          FaceObject("%trigger%")
          RemoveTraps("%trigger%") 
          Continue()
END

...
//then the locks
IF

        AreaCheck("%area%")
        CheckStatGT(Myself,1,LOCKPICKING)
        //err, actually IsLocked.
        //Dunno what can replace it. Maybe it can be omitted?
        !Disarmed("%lock%")
        Range("%lock%",5)
THEN

        RESPONSE #100
          FaceObject("%lock%")
          //what's up with the "This action has not been seen to produce any results." in IESDP? 
          //Only can unlock unconditionally >_>  !?
          PickLock("%lock%") 
          Continue()
END
...
IF
     True()
THEN
     RESPONSE #100
//not quite sure what's the best way to 
//save the original name here - is it different for each char?
//if so, it needs to use copies from this file with the name changed. If not, don't bother.    
     ActionOverride(Myself,ChangeAIScript(%original_override%,OVERRIDE))
END

Or is this swapping too dangerous somehow?

EDIT: edited the pseudo-code to use the same file so it can try to remove traps and unlock the container at the same time...

Edited by i30817, 05 November 2011 - 05:43 PM.

[Sasha Al'Therin]

I wouldn't swap out the script in the override directory slot. extending to the bottom of to handle the hotkey block is fine, but changing the override script itself is asking for trouble with other mods. No the thief actions can be lower on the script priority, if you aren't providing a party ai script leave class open in case the player wants to use one. I'd say leave race open too if they wanna use my party ai script, but I don't have a BG2 version yet which swaps scripts around. That leaves General... but it's up to you, race or general to house the area based thief scripts to be swapped. Also override scripts for joinable NPCs are named differently...

IF
     True()
THEN
     ActionOverride(Myself,ChangeAIScript(%original_override%,OVERRIDE))
END

don't do that... True() always returns true and without anything to check against this block will be a script stopper and not allow any blocks following to be parsed ever...

I would combine the traps & locks together... more weidu hieroglyphics

OUTER_SPRINT ie_file ~ar~
ACTION_IF (FILE_EXISTS_IN_GAME ~FW2600.are~) THEN BEGIN
 OUTER_SPRINT ie_file ~fw~
END
<<<<<<<< inlined/thief_hk_trap.baf
IF
HotKey(%F2%)
Global("%cont_var%","LOCALS",0)
ActionListEmpty()
!Exists([ENEMY])
AreaCheck("%area%")
!Disarmed("%trigger%")
Range("%trigger%",10)
CheckStatGT(Myself,1,TRAPS)
THEN
RESPONSE #100
SetGlobal("%cont_var%","LOCALS",1)
RemoveTraps("%trigger%")
Continue()
END
>>>>>>>>
<<<<<<<< inlined/thief_hk_lock&trap.baf
IF
HotKey(%F2%)
Global("%cont_var%","LOCALS",0)
ActionListEmpty()
!Exists([ENEMY])
!See([NOTGOOD])
AreaCheck("%area%")
!Disarmed("%trigger%")
Range("%trigger%",10)
CheckStatGT(Myself,1,TRAPS)
CheckStatGT(Myself,1,LOCKPICKING)
THEN
RESPONSE #100
SetGlobal("%cont_var%","LOCALS",1)
RemoveTraps("%trigger%")
PickLock("%trigger%")
Continue()
END
>>>>>>>>
<<<<<<<< inlined/thief_hk_lock.baf
IF
HotKey(%F2%)
Global("%cont_var%","LOCALS",0)
ActionListEmpty()
!Exists([ENEMY])
AreaCheck("%area%")
Range("%trigger%",10)
CheckStatGT(Myself,1,LOCKPICKING)
THEN
RESPONSE #100
SetGlobal("%cont_var%","LOCALS",1)
PickLock("%trigger%")
Continue()
END
>>>>>>>>
<<<<<<<< inlined/thief_hk_lock_cant_disarm.baf
IF
HotKey(%F2%)
Global("%cont_var%","LOCALS",0)
ActionListEmpty()
!Exists([ENEMY])
!See([NOTGOOD])
AreaCheck("%area%")
Range("%trigger%",10)
CheckStatGT(Myself,1,LOCKPICKING)
THEN
RESPONSE #100
SetGlobal("%cont_var%","LOCALS",1)
PickLock("%trigger%")
Continue()
END
>>>>>>>>
PRINT @16
ACTION_READLN ~hk~
OUTER_WHILE ((%hk% != 1) AND (%hk% != 2)) BEGIN
 PRINT @5
 PRINT @16
 ACTION_READLN ~hk~
END
OUTER_SPRINT F2 ~D~
ACTION_IF (%hk% = 1) THEN BEGIN
 PRINT @17
 ACTION_READLN ~F2~
 OUTER_WHILE !(~%F2%~ STRING_COMPARE_REGEXP ~[A-Z]~ =0) BEGIN
  PRINT @5
  PRINT @17
  ACTION_READLN ~F2~
 END
END

PRINT @27

OUTER_PATCH ~this_is_not_a_variable~ BEGIN
 FOR ("i1" = 0x0; "i1" < 0x100; "i1" += 0x1) BEGIN
  WRITE_BYTE 0x0 "i1"
  READ_ASCII 0x0 ~c~ (0x1)
  SPRINT EVALUATE_BUFFER ~0t%i1%~ ~%c%~
 END
END
COPY_EXISTING_REGEXP GLOB ~^%ie_file%.*\.are$~ ~override~
 PATCH_IF (SOURCE_SIZE > 0x11b) THEN BEGIN
  SPRINT area ~%SOURCE_RES%~
  READ_SHORT 0x5a "tc"
  READ_LONG  0x5c "to"
  READ_LONG  0x70 "co"
  READ_SHORT 0x74 "cc"
  READ_LONG  0xa4 "dc"
  READ_LONG  0xa8 "do"
  FOR ("i1" = 0x00; "i1" < ("tc" * 0xc4); "i1" += 0xc4) BEGIN
   SPRINT ~trigger~ ~~
   SPRINT ~co_name~ ~~
   READ_SHORT ("to" + "i1" + 0x68) "trap_detect"
   READ_SHORT ("to" + "i1" + 0x6a) "trap_disarm"
   READ_SHORT ("to" + "i1" + 0x6c) "trapped"
   READ_SHORT ("to" + "i1" + 0x20) trig_type
   READ_LONG ("to" + "i1" + 0x60) flag
   PATCH_IF ( (%trig_type% = 0)
          AND ("trap_detect" < 0x64)
          AND ("trap_disarm" < 0x64)
          AND ((%flag% BAND 0b1000) = 0b1000)
          AND (("trapped" & 0x01) = 0x01) ) THEN BEGIN
    FOR ("i2" = 0x00; "i2" < 0x20; "i2" += 0x01) BEGIN
     READ_BYTE ("to" + "i1" + "i2") "char"
     READ_ASCII ("to" + "i1" + "i2") "char2" (1)
     PATCH_IF (~%char%~ = 32) AND (~%char2%~ STRING_COMPARE_REGEXP ~ ~ =0) BEGIN
      SPRINT ~char2~ ~_~
     END
     PATCH_IF (%char% != 0) BEGIN
      SPRINT ~co_name~ ~%co_name%%char2%~
     END
     PATCH_IF (("char" = 0x00) AND ("i2" = 0x00)) THEN BEGIN
      SET "i2" = 0x20
     END
     ELSE
     PATCH_IF (("char" = 0x00) AND ("i2" > 0x00)) THEN BEGIN
      READ_ASCII ("to" + "i1" + 0x00) ~trigger~ ("i2")
      SPRINT ~cont_var~ ~ab_%area%_%co_name%~
      INNER_ACTION BEGIN
       EXTEND_BOTTOM ~abparty.bs~ ~inlined/thief_hk_trap.baf~
        EVALUATE_BUFFER
      END
      SET "i2" = 0x20
     END
    END
   END
  END
  FOR ("i1" = 0x00; "i1" < ("cc" * 0xc0); "i1" += 0xc0) BEGIN
   SPRINT ~trigger~ ~~
   SPRINT ~co_name~ ~~
   READ_SHORT ("co" + "i1" + 0x2c) "trap_detect"
   READ_SHORT ("co" + "i1" + 0x2e) "trap_disarm"
   READ_SHORT ("co" + "i1" + 0x30) "trapped"
   READ_SHORT ("co" + "i1" + 0x26) "lock_dif"
   READ_LONG ("co" + "i1" + 0x28) "flag"
   PATCH_IF ( ("trap_detect" < 0x64)
          AND ("trap_disarm" < 0x64)
          AND (("trapped" & 0x01) = 0x01)
          AND !((%flag% BAND 0b001) = 0b001) ) THEN BEGIN //trapped only
    FOR ("i2" = 0x00; "i2" < 0x20; "i2" += 0x01) BEGIN
     READ_BYTE ("co" + "i1" + "i2") "char"
     READ_ASCII ("co" + "i1" + "i2") "char2" (1)
     PATCH_IF (~%char%~ = 32) AND (~%char2%~ STRING_COMPARE_REGEXP ~ ~ =0) BEGIN
      SPRINT ~char2~ ~_~
     END
     PATCH_IF (%char% != 0) BEGIN
      SPRINT ~co_name~ ~%co_name%%char2%~
     END
     PATCH_IF (("char" = 0x00) AND ("i2" = 0x00)) THEN BEGIN
      SET "i2" = 0x20
     END
     ELSE
     PATCH_IF (("char" = 0x00) AND ("i2" > 0x00)) THEN BEGIN
      READ_ASCII ("co" + "i1" + 0x00) ~trigger~ ("i2")
      SPRINT ~cont_var~ ~ab_%area%_%co_name%~
      INNER_ACTION BEGIN
       EXTEND_BOTTOM ~abparty.bs~ ~inlined/thief_hk_trap.baf~
        EVALUATE_BUFFER
      END
      SET "i2" = 0x20
     END
    END
   END
   PATCH_IF ( ("trap_detect" < 0x64)
          AND ("trap_disarm" < 0x64)
          AND (("trapped" & 0x01) = 0x01)
          AND ((%flag% BAND 0b001) = 0b001)) THEN BEGIN //trapped & locked
    FOR ("i2" = 0x00; "i2" < 0x20; "i2" += 0x01) BEGIN
     READ_BYTE ("co" + "i1" + "i2") "char"
     READ_ASCII ("co" + "i1" + "i2") "char2" (1)
     PATCH_IF (~%char%~ = 32) AND (~%char2%~ STRING_COMPARE_REGEXP ~ ~ =0) BEGIN
      SPRINT ~char2~ ~_~
     END
     PATCH_IF (%char% != 0) BEGIN
      SPRINT ~co_name~ ~%co_name%%char2%~
     END
     PATCH_IF (("char" = 0x00) AND ("i2" = 0x00)) THEN BEGIN
      SET "i2" = 0x20
     END
     ELSE
     PATCH_IF (("char" = 0x00) AND ("i2" > 0x00)) THEN BEGIN
      READ_ASCII ("co" + "i1" + 0x00) ~trigger~ ("i2")
      SPRINT ~cont_var~ ~ab_%area%_%co_name%~
      INNER_ACTION BEGIN
       EXTEND_BOTTOM ~abparty.bs~ ~inlined/thief_hk_lock&trap.baf~
        EVALUATE_BUFFER
      END
      SET "i2" = 0x20
     END
    END
   END
   PATCH_IF ( ("trap_detect" >= 0x64)
          AND ("trap_disarm" >= 0x64)
          AND (("trapped" & 0x01) = 0x01)
          AND ((%flag% BAND 0b001) = 0b001)) THEN BEGIN //trapped but can't remove & locked
    FOR ("i2" = 0x00; "i2" < 0x20; "i2" += 0x01) BEGIN
     READ_BYTE ("co" + "i1" + "i2") "char"
     READ_ASCII ("co" + "i1" + "i2") "char2" (1)
     PATCH_IF (~%char%~ = 32) AND (~%char2%~ STRING_COMPARE_REGEXP ~ ~ =0) BEGIN
      SPRINT ~char2~ ~_~
     END
     PATCH_IF (%char% != 0) BEGIN
      SPRINT ~co_name~ ~%co_name%%char2%~
     END
     PATCH_IF (("char" = 0x00) AND ("i2" = 0x00)) THEN BEGIN
      SET "i2" = 0x20
     END
     ELSE
     PATCH_IF (("char" = 0x00) AND ("i2" > 0x00)) THEN BEGIN
      READ_ASCII ("co" + "i1" + 0x00) ~trigger~ ("i2")
      SPRINT ~cont_var~ ~ab_%area%_%co_name%~
      INNER_ACTION BEGIN
       EXTEND_BOTTOM ~abparty.bs~ ~inlined/thief_hk_lock_cant_disarm.baf~
        EVALUATE_BUFFER
      END
      SET "i2" = 0x20
     END
    END
   END
   PATCH_IF (!(("trapped" & 0x01) = 0x01)
          AND ((%flag% BAND 0b001) = 0b001)) THEN BEGIN //locked only
    FOR ("i2" = 0x00; "i2" < 0x20; "i2" += 0x01) BEGIN
     READ_BYTE ("co" + "i1" + "i2") "char"
     READ_ASCII ("co" + "i1" + "i2") "char2" (1)
     PATCH_IF (~%char%~ = 32) AND (~%char2%~ STRING_COMPARE_REGEXP ~ ~ =0) BEGIN
      SPRINT ~char2~ ~_~
     END
     PATCH_IF (%char% != 0) BEGIN
      SPRINT ~co_name~ ~%co_name%%char2%~
     END
     PATCH_IF (("char" = 0x00) AND ("i2" = 0x00)) THEN BEGIN
      SET "i2" = 0x20
     END
     ELSE
     PATCH_IF (("char" = 0x00) AND ("i2" > 0x00)) THEN BEGIN
      READ_ASCII ("co" + "i1" + 0x00) ~trigger~ ("i2")
      SPRINT ~cont_var~ ~ab_%area%_%co_name%~
      INNER_ACTION BEGIN
       EXTEND_BOTTOM ~abparty.bs~ ~inlined/thief_hk_lock.baf~
        EVALUATE_BUFFER
      END
      SET "i2" = 0x20
     END
    END
   END
  END
  FOR ("i1" = 0x00; "i1" < ("dc" * 0xc8); "i1" += 0xc8) BEGIN
   SPRINT ~trigger~ ~~
   SPRINT ~co_name~ ~~
   READ_SHORT ("do" + "i1" + 0x6c) "trap_detect"
   READ_SHORT ("do" + "i1" + 0x6e) "trap_disarm"
   READ_SHORT ("do" + "i1" + 0x70) "trapped"
   READ_LONG ("do" + "i1" + 0x28) "flag"
   PATCH_IF ( ("trap_detect" < 0x64)
          AND ("trap_disarm" < 0x64)
          AND ((%flag% BAND 0b1000) = 0b1000)
          AND (("trapped" & 0x01) = 0x01)) THEN BEGIN
    FOR ("i2" = 0x00; "i2" < 0x20; "i2" += 0x01) BEGIN
     READ_BYTE ("do" + "i1" + "i2") "char"
     READ_ASCII ("do" + "i1" + "i2") "char2" (1)
     PATCH_IF (~%char%~ = 32) AND (~%char2%~ STRING_COMPARE_REGEXP ~ ~ =0) BEGIN
      SPRINT ~char2~ ~_~
     END
     PATCH_IF (%char% != 0) BEGIN
      SPRINT ~co_name~ ~%co_name%%char2%~
     END
     PATCH_IF (("char" = 0x00) AND ("i2" = 0x00)) THEN BEGIN
      SET "i2" = 0x20
     END
     ELSE
     PATCH_IF (("char" = 0x00) AND ("i2" > 0x00)) THEN BEGIN
      READ_ASCII ("do" + "i1" + 0x00) ~trigger~ ("i2")
      SPRINT ~cont_var~ ~ab_%area%_%co_name%~
      INNER_ACTION BEGIN
       EXTEND_BOTTOM ~abparty.bs~ ~inlined/thief_hk_trap.baf~
        EVALUATE_BUFFER
      END
      SET "i2" = 0x20
     END
    END
   END
  END
 END
BUT_ONLY_IF_IT_CHANGES
COPY ~override/abparty.bs~ ~scripts/abparty.bs~

One thing to note, I have learned that even non-thieves (or those you don't want to have thief actions) will return true with a check stat of GT 1 and that is due to the race modifier and in some cases dexterity modifier. Since you won't be limiting thief actions by class, you'll need to include race checks and stat checks greater than that amount. here's an example for finding traps:

//-------------------------------------------------------------
//Thief Actions
//will look for traps when not in combat mode
IF
  ActionListEmpty()
  !See([ENEMY])
  Global("ab_fight","GLOBAL",0)
  !Race(Myself,DWARF)
  !Race(Myself,GNOME)
  !Race(Myself,HALFLING)
  CheckStatGT(Myself,5,TRAPS)
  !GlobalTimerNotExpired("ab_trap_look","LOCALS")  //one turn timer expired
THEN
  RESPONSE #100
    SetGlobalTimer("ab_trap_look","LOCALS",ONE_TURN)  //one turn timer - don't restart if another action takes precedence
//    FloatMessage(Myself,@41)
    DisplayString(Myself,@41)
    FindTraps()
END
IF
  ActionListEmpty()
  !See([ENEMY])
  Global("ab_fight","GLOBAL",0)
  Race(Myself,HALFLING)
  CheckStatGT(Myself,10,TRAPS)
  !GlobalTimerNotExpired("ab_trap_look","LOCALS")  //one turn timer expired
THEN
  RESPONSE #100
    SetGlobalTimer("ab_trap_look","LOCALS",ONE_TURN)  //one turn timer - don't restart if another action takes precedence
//    FloatMessage(Myself,@41)
    DisplayString(Myself,@41)
    FindTraps()
END
IF
  ActionListEmpty()
  !See([ENEMY])
  Global("ab_fight","GLOBAL",0)
  Race(Myself,GNOME)
  CheckStatGT(Myself,15,TRAPS)
  !GlobalTimerNotExpired("ab_trap_look","LOCALS")  //one turn timer expired
THEN
  RESPONSE #100
    SetGlobalTimer("ab_trap_look","LOCALS",ONE_TURN)  //one turn timer - don't restart if another action takes precedence
//    FloatMessage(Myself,@41)
    DisplayString(Myself,@41)
    FindTraps()
END
IF
  ActionListEmpty()
  !See([ENEMY])
  Global("ab_fight","GLOBAL",0)
  Race(Myself,DWARF)
  CheckStatGT(Myself,20,TRAPS)
  !GlobalTimerNotExpired("ab_trap_look","LOCALS")  //one turn timer expired
THEN
  RESPONSE #100
    SetGlobalTimer("ab_trap_look","LOCALS",ONE_TURN)  //one turn timer - don't restart if another action takes precedence
//    FloatMessage(Myself,@41)
    DisplayString(Myself,@41)
    FindTraps()
END

this is from my bg1 script that I've been reverting from IWD version

Edited by Sasha Al'Therin, 30 October 2011 - 04:53 PM.

[i30817]

I wouldn't swap out the script in the override directory slot. extending to the bottom of to handle the hotkey block is fine, but changing the override script itself is asking for trouble with other mods.

Ok then. There's a alternative i saw in Solaufein that should work (should have thought of it first)...

Extend the end of the override script of each joinable...

Spoiler

//thief pickpocket

IF
        HotKey("%G%")
        ActionListEmpty()
        CheckStatGT(Myself,1,PICKPOCKET)
        See([NEUTRAL])
        Range(LastSeenBy(Myself),5)
THEN
        RESPONSE #100
                FaceObject(LastSeenBy(Myself))
                PickPockets(LastSeenBy(Myself))
END


IF

  OR(2)
     !ActionListEmpty()
     !HotKey("%T%")
THEN

  RESPONSE #100

  //empty, just bailout.
END



//first the traps...
IF

        AreaCheck("%area%")
        !CheckStatGT(Myself,1,TRAPS)
        !Disarmed("%trigger%")
        Range("%trigger%",5)
THEN
        RESPONSE #100
          FaceObject("%trigger%")
          RemoveTraps("%trigger%") 
          Continue()
END

(repeat for all traps)
IF
  !CheckStatGT(Myself,1,LOCKPICKING)
THEN
  RESPONSE #100
  //empty, just bailout.
END

//then the locks
IF

        AreaCheck("%area%")
        //err, actually IsLocked.
        //Dunno what can replace it. Maybe it can be omitted?
        !Disarmed("%lock%")
        Range("%lock%",5)
THEN
        RESPONSE #100
          FaceObject("%lock%")
          //what's up with the "This action has not been seen to produce any results." in IESDP? 
          //Only can unlock unconditionally >_>  !?
          PickLock("%lock%") 
          Continue()
END

(repeat for all locks - should be more locks than traps, so leaving them to last allows early bailout for them)

Should work if installed after all mods that can change that file.


BTW;

don't do that... True() always returns true and without anything to check against this block will be a script stopper and not allow any blocks following to be parsed ever...

Does this also apply for the other character script files?
So if i put a "always happens" block on the OVERRIDE script, the GENERAL never runs at all? Because if so, my early bailout idea still doesn't work dammit.

Actually, i was also assuming that this didn't happen with the first version - since the script file was temporarily different and private, there would be no reason for it to be edited by another mod, so unconditionally triggering that was to return things to normal.

Thanks for the dexterity info! Do i really need to be racist towards halflings, gnomes and dwarfs?

Surely a check of ... say 7-10 pts would be more than enough. And if they have more? By mask, let them try it.

Edited by i30817, 05 November 2011 - 05:44 PM.

[Sasha Al'Therin]

the first block that returns true is ran and the script sequence is restarted and examined till a block returns true.

so your 'bailout' will prevent any later blocks (and lower level scripts as i understand it) from being performed. if it is only your stuff after and it is intentional so be it BUT any stuff that is added after by another mod will not be parsed ever


did i stress that too much?

try this idea...
-------------------------
hotkey turns it on, changes general script to a master area check script (which will change general to specific area thief script)

thief actions perform whenever possible.
block in specific area thief script to change ai back to master area check script if current area does not equal script's area

press hotkey again turns it off, and changes general script to null value

thief actions unavailable.
---------------------------

only requirement - ai button should be on when wanting to do thief actions (this isn't a bad thing to require)

//then the locks
IF

        AreaCheck("%area%")
        //err, actually IsLocked.
        //Dunno what can replace it. Maybe it can be omitted?
        !Disarmed("%lock%")

try: Unlocked(O:Object*) not sure what all it returns, if anything

[i30817]

Know of a way to find out which OVERRIDE script the npc's are using?

EDIT: hmmm, creature offset 0x0248 is it.
Now a simple Weidu question, appending to a resref?

I don't suppose there is a simple way way to discover who is joinable?


Something like the the Worldmap map_mods_areas.tbl but for joinable npcs, so that mods that need to change their dialogs or scripts could just iterate over a array?

Edited by i30817, 31 October 2011 - 05:46 AM.

[Sasha Al'Therin]

pdialog.2da has the data you are looking for. even mod added joinable npcs get added to the file... also lists a number of their ToB scripts to be switched to if they make it into ToB...

several ways to add to a file... depends on what you want to do

may I suggest reading up on the weidu readme html file that is included with the weidu download package

[i30817]

Mmm, yes, but it hasn't their CRE files. I'm worried, of course, that if i just change the OVERRIDE script in the join dialog, i might override one that already is running.

So i'd like to append to those if they exist too. For that i need to iterate over their CRE (joinable only), read the offset, transform that into a file somehow, if not empty append to it, if empty set it.

Is there a better way?

EDIT: wait, the bg2 version is different...

I'd want the column 25OVERRIDE_SCRIPT_FILE?

And what is 25DREAM_SCRIPT_FILE anyway?

Edited by i30817, 31 October 2011 - 08:44 AM.

[Sasha Al'Therin]

You'll have to ask someone else what the dream script does... I've not messed with ToB content at all so I don't want to steer you wrong

[i30817]

Gosh, i'm a terrible coder.

Anyway this is my prototype (haven't compiled yet, and haven't generated the trap disarming and lockpick code yet).
How can i do the same (change the OVERRIDE script) for the protagonist?
He's not in that table. Has he one anyway?

Spoiler

BACKUP ~general_thieving/backup~
AUTHOR ~Uncontactable~

VERSION ~v1.9~

//script we will add to the original OVERRIDE script
//variables: T&L_KEY, P_KEY, NEW_OVERRIDE
<<<<<<<< i3#thief.baf
        IF
        HotKey(~T&L_KEY~)
        ActionListEmpty()
        OR(2)
          CheckStatGT(Myself,20,TRAPS)
          CheckStatGT(Myself,20,LOCKPICKING)
        THEN
          RESPONSE #100
          ActionOverride(Myself,ChangeAIScript(~NEW_OVERRIDE~,OVERRIDE))
        END

        IF
          HotKey(~P_KEY~)
          ActionListEmpty()
          CheckStatGT(Myself,20,PICKPOCKET)
          See([NEUTRAL])
          Range(LastSeenBy(Myself),5)
        THEN
          RESPONSE #100
          FaceObject(LastSeenBy(Myself))
          PickPockets(LastSeenBy(Myself))
        END

       
>>>>>>>>

//script that will hold the trap disarm and open locks code
//variables : ORIGINAL_OVERRIDE
<<<<<<<< i3#exec.baf

//TODO add the lockpick and trap removal code
IF
     True()
THEN
     RESPONSE #100
     DisplayStringHead(Myself,@4)
     ActionOverride(Myself,ChangeAIScript(~ORIGINAL_OVERRIDE~,OVERRIDE))
END
>>>>>>>>


PRINT @1
ACTION_READLN ~T&L_KEY~
//while not hotkey
OUTER_WHILE ((~T&L_KEY~ < 65) OR (~T&L_KEY~ > 90)) BEGIN
 PRINT @5
 PRINT @1
 ACTION_READLN ~T&L_KEY~
END
PRINT @2
ACTION_READLN ~P_KEY~
//while not hotkey
OUTER_WHILE ((~P_KEY~ < 65) OR (~P_KEY~ > 90)) BEGIN
 PRINT @5
 PRINT @2
 ACTION_READLN ~P_KEY~
END


//patch the joinable npc scripts to allow these keys for pickpocket, trap disarm and openlocks
COPY_EXISTING ~pdialog.2da~ ~override~



READ_2DA_ENTRIES_NOW ~_#_#_#pdialog~ 8
  FOR ("i" = 0x0; "i" < ~_#_#_#pdialog~; "i" += 0x1) BEGIN
    READ_2DA_ENTRY_FORMER _#_#_#pdialog 8 ~i~ ~override_name~

    PATCH_IF (~override_name~ STRING_EQUAL ~***~) BEGIN
        //edit pdialog.2da to point to the right script
        SET_2DA_ENTRY_LATER ~_#_#_#pdialog_write~ ~i~ 8 ~i3#thief~                
    END
    ELSE BEGIN
        //append to the OVERRIDE scripts that already exist
        
        SET NEW_OVERRIDE = ~override_name~^~i~
        SET ORIGINAL_OVERRIDE = ~override_name~
        SET NEW_OVERRIDE_FILE = NEW_OVERRIDE^~.baf~
        SET ORIGINAL_OVERRIDE_FILE = ORIGINAL_OVERRIDE^~.bcs~      

        //replace the variables and compile a copy of the new override
        COPY + ~i3#exec~ NEW_OVERRIDE_FILE
        COMPILE EVALUATE_BUFFER NEW_OVERRIDE_FILE
        
        //extend the current override to call into the new one  
        EXTEND_TOP ORIGINAL_OVERRIDE_FILE ~i3#thief.baf~
	EVALUATE_BUFFER
    END
  END

//now compile our new override script not as a patch, but as the primary one
//for npcs that don't have a override script
SET NEW_OVERRIDE = ~i3#exec~
SET ORIGINAL_OVERRIDE = ~i3#thief~

COMPILE EVALUATE_BUFFER ~i3#exec~^~.baf~
COMPILE EVALUATE_BUFFER ~i3#thief~^~.baf~

//then write the changes
SET_2DA_ENTRIES_NOW ~_#_#_#pdialog_write~ 8

Edited by i30817, 05 November 2011 - 05:45 PM.

[Sasha Al'Therin]

protagonist does have an override script slot. don't think an actual script is applied, you'll have to check a save game to see if one does get applied

[i30817]

What's the right place to set the ChangeAIScript

For the protagonist without slowing down anything else?

Edited by i30817, 31 October 2011 - 03:12 PM.

[Sasha Al'Therin]

to be really honest, I'd stick with the empty script slots of race & general. leaving class open for any player chosen party ai scripts. It isn't that big of an issue to require that the party ai button be on. and i've not tested it, it might be that only class level scripts are turned on and off with that button...

honestly the activities that you are wanting the scripts to do are best being kept outside of the normal standard scripts whenever possible. cause using the override script means that your mod has to install dead last or at least after every npc mod added to the game. I can see lots of conflict potential when someone decides they want to try out another NPC without changing the rest of their install...

You will have to tie into existing scripts in order to kick start the process, but that can be minimally done.


rather than having each character process the script changing, since your stuff will be valid for any character because of the stat changes you will be giving them, allow the protagonist to do it for all of them.

1) use baldur.bcs for soa and baldur25.bcs for tob to change only the protagonist's override script to an area check script
2) the area check script will action override all player characters to change race script to the relevant map related script
3) the area check script can also action override all player characters to change general scripts to a basic thief skills script (not area dependent)

globals will need to be set so that blocks aren't constantly repeated unnecessarily


but it is your mod so...

[i30817]

Area check script are run every time you enter a area? How can i know which npc join to know which creature i need to change? Isn't that the same problem you mentioned?

But maybe i can use a item to change the script - i'll need one anyway to simulate the thief level progression...

Edit: bingo
#82 (0x052) Set AI Script [82]

Edited by i30817, 01 November 2011 - 02:30 AM.

[Sasha Al'Therin]

if you aren't messing with pre-existing scripts assigned to joinable npcs you can use any other script to assign a script to the party member's unused script slot


ok let me show you what I said in the last post

extend to the bottom of baldur.bcs & baldur25.bcs

IF
HotKey(F)
Global("ab_thiefactions","GLOBAL",0)
THEN
RESPONSE #100
ActionOverride(Protagonist,ChangeAIScript("abARchk",Override))
SetGlobal("ab_thiefactions","GLOBAL",1)
END
IF
HotKey(F)
Global("ab_thiefactions","GLOBAL",1)
THEN
RESPONSE #100
ActionOverride(Protagonist,ChangeAIScript("",Override))
ActionOverride(Player1,ChangeAIScript("",Race))
ActionOverride(Player2,ChangeAIScript("",Race))
ActionOverride(Player3,ChangeAIScript("",Race))
ActionOverride(Player4,ChangeAIScript("",Race))
ActionOverride(Player5,ChangeAIScript("",Race))
ActionOverride(Player6,ChangeAIScript("",Race))
ActionOverride(Player1,ChangeAIScript("",General))
ActionOverride(Player2,ChangeAIScript("",General))
ActionOverride(Player3,ChangeAIScript("",General))
ActionOverride(Player4,ChangeAIScript("",General))
ActionOverride(Player5,ChangeAIScript("",General))
ActionOverride(Player6,ChangeAIScript("",General))
SetGlobal("ab_thiefactions","GLOBAL",0)
END

then script abarchk.bcs

IF
AreaCheck("arXXXX")
Global("ab_setabTXXXX","GLOBALS",0)
THEN
RESPONSE #100
ActionOverride(Player1,ChangeAIScript("abTXXXX",Race))
ActionOverride(Player2,ChangeAIScript("abTXXXX",Race))
ActionOverride(Player3,ChangeAIScript("abTXXXX",Race))
ActionOverride(Player4,ChangeAIScript("abTXXXX",Race))
ActionOverride(Player5,ChangeAIScript("abTXXXX",Race))
ActionOverride(Player6,ChangeAIScript("abTXXXX",Race))
ActionOverride(Player1,ChangeAIScript("abTbase",General))
ActionOverride(Player2,ChangeAIScript("abTbase",General))
ActionOverride(Player3,ChangeAIScript("abTbase",General))
ActionOverride(Player4,ChangeAIScript("abTbase",General))
ActionOverride(Player5,ChangeAIScript("abTbase",General))
ActionOverride(Player6,ChangeAIScript("abTbase",General))
SetGlobal("ab_setabTXXXX","GLOBALS",1)
END
IF
!AreaCheck("arXXXX")
Global("ab_setabTXXXX","GLOBALS",1)
THEN
RESPONSE #100
SetGlobal("ab_setabTXXXX","GLOBALS",0) //so we can try area specific actions on another visit to the area
END
//repeated for each map  XXXX denotes the unique map number

then abTXXXX.bcs script would have the break down of any area specific thieving actions


#82 (0x052) Set AI Script [82] I'm not sure if that actually works... you could try it if you wish

[i30817]

I'm planning to use the dialog of the item i'm creating to attach and deattach (if you want to) the script.

Seems like the best way not to slow things down, and it also resolves the race issue. Only npcs that want it should get the script.

Now making a dynamic dialog to redistribute changing thieves skills free points...

It might be beyond me ... >_>

The planned text, note that i've combined the descriptions of learning hideinshadows&move silently, picklocks&disarmtraps and detecttraps&detectillusions skills.
I just don't know how to describe those as a book when not combined, probably a lack of imagination.

Think it's a bad idea to combine those and spend points on both if the option is selected? Should i lose the attempt at immersion and just go in your face *learn lockpicking*?

Spoiler

@1 = ~*Attempting locksmithery*~

@2 = ~*Attempting larceny*~

@3 = ~No one I can pickpocket is near~

@4 = ~Nothing here i can disarm or lockpick~

@5 = ~*Scouting*~

@6 = ~*Hiding*~

@7 = ~*Leaving shadows*~

@8 = ~*Casting buffs*~














@19 = ~This ringed book is surprising - its pages are made of a unknown metal, thin and flexible but not brittle, impossible to tear, etched into by some process that made the lettering perfectly regular. The cover is made of some unknown material that is not opaque, but not transparent either.



The book shows no sign of wear, despite the unusual pages. It has obviously travelled far from where it was written or is far older than it appears, maybe both.

~



@20 =~You open the book not knowing what to expect.

You read "We hope reading this book will teach some useful skills to you". Then you press on impatient for the rest.

The script then is like none you've ever seen, the glyphs are few and repeat, but apparently at no discernible rhythm. It might be symbolic, where each glyphs modifies the meaning of the surrounding ones.



Following that, are hundreds of bizarrely elusive pictures. You can see them - abstract pictograms, anatomy figures, mechanisms strange and mundane - but you can't seem to remember details.
~


@21 =~You open the book, eager to know more.~

@22 =~*Skim the book and reflect on what you have learned so far*~

@23 =~*Analise the symbols intently*~

@24 =~Close the book firmly, you do not need these tricks and the world will not slow down for you.~
@25 =~You can't focus on the symbols - you may have reached your limit for now~

@26 =~You feel drained - and ... is it your imagination or are the pictures sharper, the covers changed? You spend some time studying the book before the effect fades...~






//backstab bonus

@28 =~Right away you notice something strange about some images you hadn't noticed before - thin flowing lines overlaid on some anatomy pictures - experimenting with soft jabs on where you think they might be located in your own body is more than enough to convince you these places are extremely sensitive~

//for bhaalspawn (assassin bonus)

@29 =~Right away you notice something strange about some images you hadn't noticed before - thin flowing lines overlaid on some anatomy pictures - looking at them triggers something in your own body - a spasm flows up your spine mirroring the lines. You shudder momentarily like a leaf in a tree~



//find traps and detect illusions

@30 =~*Focus on the inner front cover*~

@31 =~The inner front cover is a marvel. When strong light hits the front of the cover a image of the surroundings is transmitted to the back, but delayed a thousand fold - until you close the cover, whereupon it resets. You spend some time practicing your visualization skills by leaving it open, doing something else and returning to it to see if you can correctly imagine how the shadows looked a little bit after you left it open~



//set (disarm) traps and open locks

@32 =~*Focus on the section with images of mechanisms and locks on various stages of assembly*~

@33 =~You spend some time attempting to construct and deconstruct one of the mechanisms with borrowed supplies from the party~

@34 =~You spend some time attempting to construct and deconstruct one of the mechanisms with makeshift materials and tools~



//pickpocketing

@35 =~*Focus on the section with humanoid images*~

@36 =~You spend some time studying and trying out hand exercise sequences you find. The rigid postures and contortions make your hands ache for hours~

//OR (if party > 2)

@37 =~You spend some time studying and experimenting with a few misdirection body language (or body tapping, whatever it takes) tricks you've learned from the images. Your companions are not amused~



//move silently and hide in shadows

@38 =~*Focus on the inner back cover*~

@39 =~This cover reacts to strong light too, but unlike the front cover does not emit a image. It emits sound. You spend some time practicing sneaking up on the animal life with the book open and in your hands, choosing the path carefully, listening to any sound~



@40 =~You've gleaned all you can from this section~



@41 =~The images fade again, and you close the book~

State machine would be:
@20 first time read
@21 second+ time read

REPLIES:
@22) show the points your char has on the skills (how?)
@23) If you have the EXP, drain experience, set the thief non modal actions script on the RACE slot, possibly add the backstab bonus, goto allocating points state @26
If you don't, goto 25, end
@24) remove the thief non modal actions script, end dialog.

@26) trap until you allocate all level up points (how?) end dialog when all are allocated.

Edited by i30817, 05 November 2011 - 05:46 PM.

[Sasha Al'Therin]

Think it's a bad idea to combine those and spend points on both if the option is selected? Should i lose the attempt at immersion and just go in your face *learn lockpicking*?

reminds me too much of PST "updated my journal" that is so annoying
I certainly don't have a problem with hide in shadows being combined with move silently as those two were split from BG1's singular stealth....

My thought would be that you could just split the points equally...

Or gasp.. create some quests/activities that when actually performed increment a global and after so many successful times a point is awarded. i.e. learn thru use for thieving skills. In BG2 always wanted to instead of gaining party xp, gain towards skill when doing lock picking etc...

have you checked into Rogue Rebalancing? I know there is a lot of thief related stuff worked on in there. perhaps ideas you could garner....

[i30817]

That quest idea would be very nice, although i'm still at the stage where i don't know how to make a dynamic dialog

Problems:

If I try to put in the quest idea, i think i'd need rather a lot of them, even if they gave relatively large bonus.

Which party member would get the skills?

Use by doing systems are the embodiment of grinding (i like QFG like any other OCD, but i admit it).

If i give skills to every member of the party, how would i deal with new members? (This has a obvious solution, "teach" new members).

Where, BG1 or BG2? I'm using BGT.


More mechanical problems i'm having with the dialog now...

How can i check the skills of the npc's the book (or the pc if i go the quests idea) is talking to?

there doesn't appear to be a way to read the current thief skills values (much less increase them).

(important not to overflow due to race bonus, dex bonus -that can changege- etc)

Edited by i30817, 02 November 2011 - 04:01 AM.

[Sasha Al'Therin]

going dialog route whether it be via an item or a creature...

the states in your dialog file can check for the stat value. If you are wanting a range, it would be using
CheckStatGT(LastTalkedToBy,X,STAT)
CheckStatLT(LastTalkedToBy,Y,STAT)

You can create multiple states in your dialog file to cover all the ranges in which you want to deal with

else create one state for each point up to the max you wish to deal with...

[i30817]

The problem is the increase of the stats.

Doing 255 states for 8 stats, just to be able to do +5 is not a good option.

What i'd need is a way to subtract inside the engine, (not on a weidu transformation)

So i'd have 20 pt to destribute, and have a

IF ~GT(Global("thief_stats", LOCALS), 5) AND CheckStatLT(LastTalkedToBy,250, LOCKPICKING)~
THEN DO ~ SetGlobal("thief_stats", SUBTRACT(Global("thief_stats", LOCALS), 5))
ADDSTAT(LastTalkedTo, LOCKPICKING, 5) ~
END

Pseudocode.

Problem is, there doesn't appear to neither a ADDSTAT (crucial, but maybe it can be done with effects) nor a SUBTRACT (in fact there don't seem to be any arithmetic functions that return integers, not booleans).

EDIT AHAH:

found AddGlobals(S:Name*,S:Name2*)


Instead of a single item, or learn by use, i like the idea of trainers (ala, PST), but it's not as convenient...

Edited by i30817, 02 November 2011 - 12:45 PM.

[Sasha Al'Therin]

you are now embarking into realms beyond me

the adding and subtracting of stuff within game is not something i've dealt with before. the thief actions & script switching, yes. but not what you are getting into now.

I see no problem in having 51 states that look for a 5 point range of a given value up to 255. i.e. GT 0 & LT 6; GT 5 & LT 11

but aren't thief skills a percentage and thus max at 100? don't they reset to 0 and have no effect if they go beyond 100? thought I read about something like that at one point....