8 replies to this topic

[Ascension64]

Thanks for the report. I think someone reported the Bladesinger's song going forever. Same issue.
This is being perm disabled for next release until I fix it up. In the mean time, just don't use it.

[GeN1e]

This is being perm disabled for next release until I fix it up.

Introduce a SPL/ITM flag to remove an already existing instance?

[Galactygon]

Seconded. But this will require new opcodes: Dispel resource, where resource can come from an .eff/.itm/.spl, and dispel opcode inside resource (same thing, but leaves the rest of the effects intact, and the effect list applied at the time is not dispelled).

-Galactygon

[Ascension64]

How exactly would you use this? Is it such that: if spell A is already affecting player X, then casting spell A again on player X will remove the old instance of spell A on player X? If so, then the previous implementation of this hack is probably what you want.

[GeN1e]

I suppose what Galactygon says is better. Removing a single resource has always been a pain to handle, and it also allows greater flexibility, such as wizard and priest versions of the same spell (like Protection from Some_Element).

[Galactygon]

How exactly would you use this? Is it such that: if spell A is already affecting player X, then casting spell A again on player X will remove the old instance of spell A on player X? If so, then the previous implementation of this hack is probably what you want.

The first effect in the effect list would so a "remove the effects by resource" by removing previous effects but without touching those effects that come after the effect in the effect list. If this opcode were to be done (which would have many other uses), then it's unnecessary to worry about effect flags.

-Galactygon

[Ascension64]

After however many months, I managed to fix the Disable Duplicate Effect Code stuff, and implemented Galactygon's suggestion of using effect IDs for stacking behaviour. The implementation is as follows:

-----240 Configurable Effect Stacking [M]
Adds bit 25 (Limit Effect Stacking) of the EFF V2.0 Header offset 0x0040 (Save Type), ITM V1.0 Feature Block offset 0x0024 (Save Type), and SPL V1.0 Feature Block offset 0x0024 (Save Type).
When set, TobEx checks EFF V2.0 Header offset 0x0048 (Special), ITM V1.0 Feature Block offset 0x002C (Special), and SPL V1.0 Feature Block offset 0x002C (Special)
for a unique stacking ID. If two effects of the same opcode are applied, both have Limit Effect Stacking Set, and both have the same stacking ID, then the latter applied effect is suspended in application until the former effect expires.
Regardless of whether it is applied, the latter effect will expire at the same time that it would expire if it was applied. In other words, the total duration of some non-stacking effect opcode is not extended because more than one copy of the effect was applied.
Stacking IDs are unique to the opcode being applied. To maintain uniqueness of stacking IDs between different mods, one recommendation is to use the higher word of Special as the modder's Infinity Engine Community Prefix, then use the lower word as an identifying ID. For example, 0x41360001 ('A6' 0x0001).
TobEx also implements bit 26 (Internal: Suspend Effect Application) of the EFF V2.0 Header offset 0x0040 (Save Type), ITM V1.0 Feature Block offset 0x0024 (Save Type), and SPL V1.0 Feature Block offset 0x0024 (Save Type) to prevent effects with limited stacking from being applied.

Options:
-0: disabled
-1: enabled

[Galactygon]

Thanks A64 so much for implementing this, I will try this out sometime this winter when I will have more time!

The suspend effect part seems especially interesting, and opens doors for many uses in the future.

-Galactygon

Edited by Galactygon, 11 November 2012 - 01:32 PM.