99 replies to this topic

[Turambar]

Thanks for your tips, although the widescreen removes the need to change current resolution.

BTW something i just thought. Can you check if the file after patching in 32 bits and 64 bits (in linux and windows i guess) is the same?

My exe is different between win and linux, but, looking at backups, I noticed that the difference only comes from widescreen mod and ghostdog's ui (as I have different resolutions).
The fixpack directly applies a binary patch (actually, a series of patches, as it contains many different fixes) to the executable (it just replaces the first string listed here with the second one, without checking anything else), so, as the mod is the same, it will alter the bytes in the same way, on all OSs.

[aqrit]

Pst-Fix 4g. causes a crash when a movie plays with x64 wine
I'm fairly confident that just nopping the bad cmp statement will fix everything.
So do a search and replace in the file "PST-Fix\tph\EngineFixes.tph"

find all:          83 F8 02 3B C2 0F 84
replace all with:  83 F8 02 90 90 0F 84

save the file then (re)run Setup-PST-Fix.exe


I still don't have a test case...
What are good ways to modify the Current and Max Morales in-game?
I'm now guessing that my morale stayed at 10 after resting because its a new game and I haven't done any adventuring yet.

The current morale was hard coded to reset to 10 in the original version.

Have fun.

[Turambar]

Pst-Fix 4g. causes a crash when a movie plays with x64 wine

Not just playing the rest movie: it also happens when you travel through the worldmap, because the morale has to be set (as eight hours have passed). It does not happen with other videos, from what I've seen.
Examples: travelling to Baator from outlands-> the movie is shown; the game is regular afterwards.
Resting-> video plays; as soon as you end it or the video ends, hang
Travel through worldmap (which lasts 8 game hours)-> the area almost loads, then hangs
Resting in foundry: no movie shown; when you close the shop window, hang!
Disabling patch 4g removes hangs, but causes morale to be reset.

I'm fairly confident that just nopping the bad cmp statement will fix everything.
So do a search and replace in the file "PST-Fix\tph\EngineFixes.tph"

find all:          83 F8 02 3B C2 0F 84
replace all with:  83 F8 02 90 90 0F 84

save the file then (re)run Setup-PST-Fix.exe


I still don't have a test case...
What are good ways to modify the Current and Max Morales in-game?
I'm now guessing that my morale stayed at 10 after resting because its a new game and I haven't done any adventuring yet.

The current morale was hard coded to reset to 10 in the original version.

Have fun.

Actually, I think that the maximum morale (which is the one displayed on the character sheet, and depends on party interaction) should have been reset in the original version, and that's why the fix was written.
I will try that fix now; I'll tell you if I manage to rest.

edit: unfortunately, the problem appears to be somewhere else. The game still hangs after resting.

Edited by Turambar, 23 May 2011 - 07:37 AM.

[aqrit]

That change allows me to rest without the hang occurring.
Please double check to make sure that the patch was applied.
( there should be 2 instances to replace in EngineFixes.tph, the first instance is just a comment )
( you could check out the Exe file with a hex editor, if your ambitious. (4-cd) file offset 00337AD1 should be "90 90", not "3B C2" or "0D 6D")

Edited by aqrit, 23 May 2011 - 08:22 AM.

[Turambar]

That change allows me to rest without the hang occurring.
Please double check to make sure that the patch was applied.
( there should be 2 instances to replace in EngineFixes.tph, the first instance is just a comment )
( you could check out the Exe file with a hex editor, if your ambitious. (4-cd) file offset 00337AD1 should be "90 90", not "3B C2" or "0D 6D")

I have checked it with a hex editor. The patch has been applied, and the two offsets are both 90 (actually, 0x90, I guess? Anyway, 90=0x5A didn't work either).
But the game still hangs, whereas, as I said, Not applying the patch allows me to rest without hanging but resets the morale.

Anyway, (as I said, I don't know assembly or machine language, so I could just be talking nonsense, and I don't know how much can be understood from a binary code), can you see if there are references to some particular memory addresses, which are changed, in the original string or the fixpack string? do they refer to different addresses? The same variable shuld also be used in the "scale of souls" tweak, as that tweak displays the maximum morale on the character's sheet. Perhaps, could that allow us to discover where the morale is stored..?
Actually, I wonder wether this fix really corrected the variable which had to be modified, or wether it just 'jammed' the triggers for the reset, so that they always evaluated to false and the (wrong) reset could never occur (which could be the reason why there were those CMPs you mentioned, which could never evaluate to true)

BTW, if you need it, I'm using linux x86_64 (AMD64 architecture), with wine 1.3.20 (it should be the latest, from wine ppa) from ubuntu repositories

edit: the same issue is present on linux 32 bit, and unfortunately your patch does not work there either

Edited by Turambar, 24 May 2011 - 07:14 AM.

[Turambar]

Check if the original file offsets are the same as the offsets he gave for the original file. Using a dissasembler sometimes, the offsets count not from the start of the file but some kind pointer because of the executable format launcher. As 90 assembly instruction is quite common ( it's NOP ), it might have already been 90.

I did check the string both in the tph, before applying it, and in the exe, after it was patched, with a hex editor.
All bytes around the two "90"s were those expected.

[Turambar]

I sent contacted scient in the civilization gaming network forums. Here is what he said...

Thanks! It's such a pity, such a wonderful game, so beautiful mods, and just that nasty bug which makes it difficult to play it on linux...
Thanks for contacting him!

If qwinn is MIA forever i guess some volunteer that knows WEIDU could volunteer to edit the installer.

If you need it, I think I might be able to help with that

[Turambar]

Guess now someone will have to.

I'm going to send another private message to scient about Qwinn.

Apparently, that message about Quinn was luckily only a troll.

Anyway, until it gets fixed, could someone please tell me if it's possible, and how, to compile a separate version of wine, without the optimizations which cause issues, to be only used with PS:T (I would just put it into my home folder; use a shell script to run that particular wine binary when I launch ps:t, and leave in the usr folder the wine version from wine ppa)? I'm using kubuntu natty AMD64.

Edited by Turambar, 07 June 2011 - 05:06 AM.

[i30817]

Ĩ'm not sure it is the optimizations that cause the issue: it looks like they simply don't avoid it somehow.

If aqrit makes a patcher i guess we could check it.

[i30817]

Interresting.

The fix worked if i edited the exe after installing the fixpack.

Maybe one of the other tweakpack exe edits moves things around and interferes if i tried to install it after that.

Edit actually, i tested it now.

It has nothing to do with the other packs; the fix allows me to rest by using the rest button (first opportunnity is in the tomb where you escape from the mortuary if you take the portal), but still hangs if you use the dialog rest opportunities, like mcbeth or Arlo's inn in a adjacent map.

Edited by i30817, 23 June 2011 - 08:33 AM.

[Turambar]

How can I delete the 4g patch?

You can remove that particular patch by editing [game folder]/pst-fix/tph/enginefixes.tph

Look for 4g. You will see a set of instructions, ending with

LAUNCH_PATCH_MACRO Q_Pattern_Maker
  LAUNCH_PATCH_MACRO Q_Engine_Patcher

Then, there's a space and a line which contains 4h...

Just encolse that code between /* and */ (like C comments):

/*  LAUNCH_PATCH_MACRO Q_Pattern_Maker
  LAUNCH_PATCH_MACRO Q_Engine_Patcher
*/

The effect will be: you will be able to rest. But the morale will be reset every time (so, eg, Da'kkon's blade will rarely improve,...), which was the original issue.
Anyway, all other patches will be installed.