68 replies to this topic

[Fennek]

Will test it tomorrow (or, if I find the time, today), thanks a lot!

[Hoppy]

Will test it tomorrow (or, if I find the time, today), thanks a lot!

Let us know how it works before you thank us.

[Fennek]

Let us know how it works before you thank us.

Weeeeellllllll....

That's the error message
(nothing in the debug, since nothing of component 5 was installed...)

ERROR [AR0400.are]->[ovedrride]Patching failed (copy) (Failure "Unknown function fj_add_are_structure")
Stopping installation becauseo of errors
Error installing (... Component 5...), rolling back to previous state
Will uninstall 15 files blah, blah, blah...

[Miloch]

You need to put your INCLUDEs in an ALWAYS section before your first BEGIN. That means they get included with every component, otherwise they only get included for the component where you INCLUDEd them ().

[Lollorian]

You Miloch, are the epitome of drow-orc eugenics

Added this block:

ALWAYS
  INCLUDE ~ts25mini/lib/fj_add_are_struct.tpp~

right before the first BEGIN

Sorry about the stupidity, Fennek

Attached Files

•  ts25mini_more_hopeful.7z   11.25K   179 downloads

[Miloch]

Sorry about the stupidity

You need an END to close the ALWAYS:

ALWAYS
  INCLUDE ~ts25mini/lib/fj_add_are_struct.tpp~
END

Also, it's hard to tell, since this mod has no English translation (or any other Western language), but I think this whole component...

BEGIN @0

ACTION_IF NOT FILE_EXISTS_IN_GAME ~tz25mnds.tmn~ THEN BEGIN
  COPY_EXISTING ~sw1h01.itm~ ~override/tz25mnds.tmn~
  INCLUDE ~ts25mini/DS/DS.tph~
  INCLUDE ~ts25mini/DS/ds_oldscript.tph~
  OUTER_SPRINT ~detectfile~ ~ts25mini/ds/cddetect.2da~
  OUTER_SPRINT ~statsfile~ ~ts25mini/ds/stats.2da~
  OUTER_SPRINT ~khelbenfile~ ~ts25mini/ds/spwi705.spl~
  LAUNCH_ACTION_MACRO ~detectable_spells~
  OUTER_SPRINT ~detectfile~ ~ts25mini/ds/dw#detect.2da~
  LAUNCH_ACTION_MACRO ~detectable_spells~
  OUTER_SPRINT ~marker~ ~dw#fixasc.mrk~
  OUTER_SPRINT ~oldfiles~ ~ts25mini/DS/oldfiles_asc.2da~
  OUTER_SPRINT ~oldswapfile~ ~ts25mini/DS/oldds_swap.2da~
  LAUNCH_ACTION_MACRO ~fix_old_DS_scripts~ 
  OUTER_SPRINT ~marker~ ~dw#fixkelsey.mrk~
  OUTER_SPRINT ~oldfiles~ ~ts25mini/DS/oldfiles_kelsey.2da~
  OUTER_SPRINT ~oldswapfile~ ~ts25mini/DS/oldds_swap.2da~
  LAUNCH_ACTION_MACRO ~fix_old_DS_scripts~ 
END

...might belong in that ALWAYS block. Because it's not really donig anything except more INCLUDEs, setting variables, and apparently putting in detectable spells (twice, and I'm not sure it needs to even once but maybe it's scripting depends on it, who knows). If it needs that, it doesn't need to go in the ALWAYS but the other stuff probably should.

Fennek, are you trying to translate this from Japanese to German or something, or what?

[Lollorian]

... stupidity ...

Razzam frazzam gurgle coo

Put the entire block into ALWAYS

Attached Files

•  ts25mini_even_more_hopeful.7z   11.25K   175 downloads

[Wisp]

Detectable Spells doesn't need to go in the ALWAYS part. You only need to launch it once (the whole ACTION_IF; the two LAMs use different 2da files) when the mod is installed, then you don't need it any more.

Edit: And Lollorian, you need to retain the ACTION_IF, otherwise it will install DS multiple times (which is non-cumulative but time-consuming).
You can probably keep DS in component 0, since it looks like the components that need DS won't install unless DS is installed.
Yet another edit: Putting DS in an ALWAYS may screw up WeiDU's backup process so don't do that.

Edited by Wisp, 08 October 2010 - 01:48 AM.

[Fennek]

Parse Error (state 796) at ALWAYS
( ... ) parse error at line 15 column 1-6
Near text: always
glr parse error

(... ... ....) parsing.parse_error
FATAL ERROR: parsing.parse_error

But I think we are getting closer.

Fennek, are you trying to translate this from Japanese to German or something, or what?

Actually yes, component 1 and 4 are translated (and can be chosen via the BWS beta if one uses German mods) and I'm almost done with another one. ReadMe and "For Translaters" are also translated. Stuff is added by the fixpack, I think (or the German textpack). If you need something in English, tell me.

The Detectalble Spells component is from an old version of SCSII. The ReadMe says that DS is necessary for alll components except no. 4 (The destination of an undead, or however Leonardo called it in English). I have no idea if this is true, nor have I tested the mod with the new version of SCSII yet.

[Lollorian]

Hmm ... that's kookie moving the ALWAYS block to before the LANGUAGE tag fixed that GLR PARSE error ... ah well, have a go with this

Reverted the DS block back into the ACTION_IF block ...

PS: On the topic of DS, would it be a perk to consider upgrading ts25 (and other mod) DS to the latest version?? (or atleast check for the latest DS from other mods like SCS??)

PS2: I'm on IRC atm

Attached Files

•  ts25mini_ever_so_hopeful.7z   11.25K   180 downloads

Edited by Lollorian, 08 October 2010 - 05:15 AM.

[Chevalier]

PS2: I'm on IRC atm

I have not had that drug, is it any good?

[Lollorian]

I think I'm in a tunnel ... it's dark ... ooooooooh ... my precious

[Fennek]

I'm there, to...

PS: On the topic of DS, would it be a perk to consider upgrading ts25 (and other mod) DS to the latest version?? (or atleast check for the latest DS from other mods like SCS??)

Might run more smoothly then (?) Will post parts of readme tomorrow, if of use. But as Lollorian suggested in that tunnel, maybe it's better to wait until DS is updated...)

Edited by Fennek, 08 October 2010 - 06:51 AM.

[Lollorian]

... maybe it's better to wait until DS is updated...

Kelsey not DS

Kelsey's undersoing revision so it might be better to see how they revise his archaic DS

[Fennek]

Got it. Anyway, I guess the problem is fixed, although I'll do more testing at the weekend. Good night...

[Miloch]

moving the ALWAYS block to before the LANGUAGE tag fixed that GLR PARSE error

Yeah. Kinda stupid it has to go before that (as does README I think, which makes even less sense) but them's the breaks.

[Lollorian]

Ok, next up for review, the entire AR0900 area patching code:

Old code:

Spoiler

//ar0900
// Travel Trigger
<<<<<<<< ...ts25mini-inlined/vertex.2da
4336 1039
4336 956
4269 1019
4269 1103
>>>>>>>>

OUTER_SPRINT "name" "tz25nn_ar0900_to_tzdr01"
OUTER_SET "type" = 2
OUTER_SET "bounding_box_left" = 4269
OUTER_SET "bounding_box_top" = 956
OUTER_SET "bounding_box_right" = 4336
OUTER_SET "bounding_box_bottom" = 1103
OUTER_SET "adding_vertex_num" = 4
OUTER_SET "cursor" = 30
OUTER_SPRINT "destination_area" "tzdr01"
OUTER_SPRINT "entrance_name" "Exit0900"
OUTER_SET "flag1" = 0b00000100 // bitwise
OUTER_SET "flag2" = 0b00000011 // bitwise
OUTER_SET "flag3" = 0b00000000 // bitwise unknown
OUTER_SET "flag4" = 0b00000000 // bitwise unknown
OUTER_SPRINT "info_text" ""
OUTER_SET "trap_detection_difficulty" = 0
OUTER_SET "trap_removal_difficulty" = 0
OUTER_SET "traped" = 0
OUTER_SET "detected" = 0
OUTER_SET "launch_point_x" = 4148
OUTER_SET "launch_point_y" = 916
OUTER_SPRINT "key" ""
OUTER_SPRINT "script" ""
OUTER_SET "activation_point_x" = 0
OUTER_SET "activation_point_y" = 0

COPY_EXISTING ~ar0900.are~ ~override~
LAUNCH_PATCH_MACRO ~add_region~
BUT_ONLY_IF_IT_CHANGES

// Dealing with Door Open-State
<<<<<<<< ...ts25mini-inlined/vertex.2da
4550 890
4560 890
4560 900
4550 900
>>>>>>>>

OUTER_SPRINT "name" "tz25nn_ar0900_to_tzdr01_State1"
OUTER_SET "type" = 0
OUTER_SET "bounding_box_left" = 4550
OUTER_SET "bounding_box_top" = 890
OUTER_SET "bounding_box_right" = 4560
OUTER_SET "bounding_box_bottom" = 900
OUTER_SET "adding_vertex_num" = 4
OUTER_SET "cursor" = 0
OUTER_SPRINT "destination_area" "None"
OUTER_SPRINT "entrance_name" ""
OUTER_SET "flag1" = 0b00000010 // bitwise
OUTER_SET "flag2" = 0b00000000 // bitwise
OUTER_SET "flag3" = 0b00000000 // bitwise unknown
OUTER_SET "flag4" = 0b00000000 // bitwise unknown
OUTER_SPRINT "info_text" ""
OUTER_SET "trap_detection_difficulty" = 0
OUTER_SET "trap_removal_difficulty" = 0
OUTER_SET "traped" = 1
OUTER_SET "detected" = 0
OUTER_SET "launch_point_x" = 4555
OUTER_SET "launch_point_y" = 895
OUTER_SPRINT "key" ""
OUTER_SPRINT "script" "tz25nns1"
OUTER_SET "activation_point_x" = 0
OUTER_SET "activation_point_y" = 0

COPY_EXISTING ~ar0900.are~ ~override~
LAUNCH_PATCH_MACRO ~add_region~
BUT_ONLY_IF_IT_CHANGES

// infotrigger after quests
<<<<<<<< ...ts25mini-inlined/vertex.2da
4336 1039
4336 956
4269 1019
4269 1103
>>>>>>>>

OUTER_SPRINT "name" "tz25nni1"
OUTER_SET "type" = 1
OUTER_SET "bounding_box_left" = 4269
OUTER_SET "bounding_box_top" = 956
OUTER_SET "bounding_box_right" = 4336
OUTER_SET "bounding_box_bottom" = 1103
OUTER_SET "adding_vertex_num" = 4
OUTER_SET "cursor" = 22
OUTER_SPRINT "destination_area" "None"
OUTER_SPRINT "entrance_name" ""
OUTER_SET "flag1" = 0b00000000 // bitwise
OUTER_SET "flag2" = 0b00000001 // bitwise
OUTER_SET "flag3" = 0b00000000 // bitwise unknown
OUTER_SET "flag4" = 0b00000000 // bitwise unknown
OUTER_SPRINT "info_text" @2520
OUTER_SET "trap_detection_difficulty" = 0
OUTER_SET "trap_removal_difficulty" = 0
OUTER_SET "traped" = 0
OUTER_SET "detected" = 0
OUTER_SET "launch_point_x" = 4148
OUTER_SET "launch_point_y" = 916
OUTER_SPRINT "key" ""
OUTER_SPRINT "script" "tz25nni1"
OUTER_SET "activation_point_x" = 0
OUTER_SET "activation_point_y" = 0

COPY_EXISTING ~ar0900.are~ ~override~
LAUNCH_PATCH_MACRO ~add_region~
BUT_ONLY_IF_IT_CHANGES

New code:

Spoiler

COPY_EXISTING ~ar0900.are~ ~override~
LPF fj_add_are_structure
INT_VAR
fj_type = 2 //travel
fj_box_left = 4269
fj_box_top = 956
fj_box_right = 4336
fj_box_bottom = 1103
fj_cursor_idx = 30 //door
fj_vertex_0 = 4336 + (1039 << 16)
fj_vertex_1 = 4336 + (956 << 16)
fj_vertex_2 = 4269 + (1019 << 16)
fj_vertex_3 = 4269 + (1103 << 16)
fj_loc_x = 4148
fj_loc_y = 916
STR_VAR
fj_structure_type = region
fj_name = tz25nn_ar0900_to_tzdr01
fj_destination_area = tzdr01
fj_destination_name = Exit0900
END
LPF fj_add_are_structure
INT_VAR
fj_type = 0
fj_box_left = 4550
fj_box_top = 890
fj_box_right = 4560
fj_box_bottom = 900
fj_cursor_idx = 0
fj_vertex_0 = 4550 + (890 << 16)
fj_vertex_1 = 4560 + (890 << 16)
fj_vertex_2 = 4560 + (900 << 16)
fj_vertex_3 = 4550 + (900 << 16)
fj_trap_active = 1
fj_loc_x = 4555
fj_loc_y = 895
STR_VAR
fj_structure_type = region
fj_name = tz25nn_ar0900_to_tzdr01_State1
END
LPF fj_add_are_structure
INT_VAR
fj_type = 1
fj_box_left = 4269
fj_box_top = 956
fj_box_right = 4336
fj_box_bottom = 1103
fj_cursor_idx = 22
fj_info_point_strref = @2520
fj_vertex_0 = 4336 + (1039 << 16)
fj_vertex_1 = 4336 + (956 << 16)
fj_vertex_2 = 4269 + (1019 << 16)
fj_vertex_3 = 4269 + (1103 << 16)
fj_loc_x = 4148
fj_loc_y = 916
STR_VAR
fj_structure_type = region
fj_name = tz25nni1
END

Things to note:
1) LPF 2 n 3 don't have the destination name and entrance name mentioned. Is that awright??

2) LPF 3 has a string referenced from the .tra ... should that be in quotes or something??

3) LPF 2 has a trap active thingy

4) All three LPF's have different types and cursor indices

[Lollorian]

Thanks O anonymous one Noted!

PS: What might the "hack" between the INNER_PATCH and BEGIN mean?? Is it supposed to be used somewhere??