The attachement is the --change-log-list output of line 513-578 in kelsey.tp2 and big world install log.
Sorry - what I meant is that someone would need to either visually compare the original and/or Spell Revision spells with the Kelsey ones (with
DLTCEP/
NI) or use an automated compare tool to convert them to text files (like igi's
icie.exe maybe) and
then compare them with something like PSPad's TextDiff or similar diff tool. Then write a patch if necessary for the Kelsey changes. A lot of work, I know, but maybe they're changed for a reason. Or someone could just ask jcompton why he overwrote them I guess, assuming he did it and remembers why.
Btw, Miloch, the BWPFixpack changes the Sheena.tp2:
- ACTION_IF NOT FILE_EXISTS ~override\Action.ids~ THEN BEGIN
- COPY ~Sheena\IDS\ACTION.IDS~ ~override\ACTION.IDS~
- END
- ACTION_IF NOT FILE_EXISTS ~override/trigger.ids~ THEN BEGIN
- COPY ~Sheena/ids/trigger.ids~ ~override/trigger.ids~
- END
- ACTION_IF NOT FILE_EXISTS ~override/spell.ids~ THEN BEGIN
- COPY ~Sheena/ids/spell.ids~ ~override/spell.ids~
- END
+// ACTION_IF NOT FILE_EXISTS ~override\Action.ids~ THEN BEGIN
+// COPY ~Sheena\IDS\ACTION.IDS~ ~override\ACTION.IDS~
+// END
+// ACTION_IF NOT FILE_EXISTS ~override/trigger.ids~ THEN BEGIN
+// COPY ~Sheena/ids/trigger.ids~ ~override/trigger.ids~
+// END
+// ACTION_IF NOT FILE_EXISTS ~override/spell.ids~ THEN BEGIN
+// COPY ~Sheena/ids/spell.ids~ ~override/spell.ids~
+// END
+
+COPY_EXISTING_REGEXP GLOB ~^.+\.ids$~ ~override~
I know, which is why I wanted the tp2.
I guess the regex does the damage
That last added line doesn't do the damage, but it is wholly unnecessary and could cause issues. Would someone
please tell the BWFixpack team not to do that sort of thing. There is no reason to copy existing IDS files in the override to the override. And they shouldn't be biffed, but if they are and are unreadable for some reason, that sounds like a
WeiDU issue to me (which was probably fixed ages ago if it was ever a problem, or if not, needs to be fixed).
Edit: Incidentally, the BWFixpack puts this same thing (COPY_EXISTING_REGEXP GLOB ~^.+\.ids$~ ~override~) in Kiara-Zaiya and maybe a bunch of other mods, and it puts it in an ALWAYS statement, which means it gets executed for every mod component
. This is one reason my install is taking a lot longer than it normally would (several days so far). The whole ALWAYS block here, including BWFixpack additions, is totally unneeded. IDS files like action, trigger and spell are always going to be present, whether on
SoA or
ToB.
However, this is the problem, which doesn't get changed by the BWFixpack:
//For those without TOB
ALWAYS
ACTION_IF NOT FILE_EXISTS ~Data/25Dialog.bif~ THEN BEGIN
COPY ~Sheena/ids~ ~override~
END
END
At least three issues here:
- No need to use ALWAYS for a mod that only has one component.
- FILE_EXISTS is a horrible way of checking for ToB or anything else, and apparently it doesn't even work here, because all those IDS files got overwritten by Sheena's. Instead, it should use something like FILE_EXISTS_IN_GAME ~ar6111.are~ until GAME_IS is fixed (probably in the next WeiDU version)
- Overwriting a bunch of IDS files is a bad idea, even if ToB isn't present. It should check for the ones that are known to be missing in SoA w/o ToB and copy only those. It should patch any others it needs to. And it should check whether detectable spells is already installed before trying to install it (hell, I don't think this mod even needs it).
In short, someone should probably just rewrite this tp2 and any others that do similar things. I guess the BWFixpack could try to patch it if it's smart enough, but it just causes another issue without fixing the main one in this case.
Also, if you can give me an idea what mods might be effected and what to look for I'll be happy to test these areas later today.
Cheers. Like I said, any mods that had parsing ERRORs between Sheena and SCS2 may be suspect, and you may need to fix those scripts manually (with
DLTCEP,
NI or
WeiDU) if they didn't compile properly.
Edited by Miloch, 19 November 2009 - 11:17 AM.