10 replies to this topic

[White Agnus]

Hi,
by our BWP Tests a strange problem occured...
BGT messes up the REEVOR.cre and the REEVOR2.cre, the original vanilla BG1 REEVOR.cre and REEVOR2.cre are okay and I didn't find an error in the BGT debug files...
That problem comes and goes (by the one installation, the file messes up, by the other not...)
Can somebody watch over it, I attached the files.

Regards
White Agnus

Attached Files

•  Reevor.rar   196.74K   232 downloads

Edited by White Agnus, 26 October 2009 - 11:26 AM.

[Miloch]

I can't tell what exactly it is either, but I'm pretty sure it's BGT also, since the --change-logs report it's one of the earliest mods. I can't tell what the problem is in BGT's code, but it seems to do something weird with copying files to temp folders, operating on them and who knows what else. Issue was also reported here.

Edit: ok, I think I found the problem... BGT uses a revised routine apparently to add to the random treasure tables. Well it probably works fine if few or no mods are installed before BGT. Maybe it does anyway. But for some reason reevor*.cre ends up with a random treasure he doesn't have in BG1, though reevor3.cre does have a rndtre03.itm. Maybe this is some sort of BGT consistency thing? Anyway, this takes the following code:

COPY + ~BG1CRE~ ~BG1CRE~
  ...
  REPLACE_TEXTUALLY "RNDTRE03" "%dest_tre3%"

And assigns reevor*.cre a RNDMAG013 instead, which is of course an invalid 9-character reference. Ordinarily, it would record only the first 8 characters, but it inserts an extra byte in the file, throwing the rest of the file off and making it unreadable.

First of all, you want to prevent this from happening. You shouldn't end up with more than 9 rows in the random treasure tables anyway - I'm not sure if higher ones are valid. Maybe only certain mods like CtB cause this if installed before BGT. But second of all, there's probably a better way of doing this than REPLACE_TEXTUALLY which can cause fubar files if you're not careful. Aurora's "Realistic Random Treasure" component uses a method by doing various checks and then REMOVE/ADD_CRE_ITEM the variable reference where relevant to INV (the first open inventory slot).

Edited by Miloch, 10 November 2009 - 04:10 PM.

[White Agnus]

I can't tell what exactly it is either, but I'm pretty sure it's BGT also, since the --change-logs report it's one of the earliest mods. I can't tell what the problem is in BGT's code, but it seems to do something weird with copying files to temp folders, operating on them and who knows what else. Issue was also reported here.

Edit: ok, I think I found the problem... BGT uses a revised routine apparently to add to the random treasure tables. Well it probably works fine if few or no mods are installed before BGT. Maybe it does anyway. But for some reason reevor*.cre ends up with a random treasure he doesn't have in BG1, though reevor3.cre does have a rndtre03.itm. Maybe this is some sort of BGT consistency thing? Anyway, this takes the following code:

COPY + ~BG1CRE~ ~BG1CRE~
  ...
  REPLACE_TEXTUALLY "RNDTRE03" "%dest_tre3%"

And assigns reevor*.cre a RNDMAG013 instead, which is of course an invalid 9-character reference. Ordinarily, it would record only the first 8 characters, but it inserts an extra byte in the file, throwing the rest of the file off and making it unreadable.

First of all, you want to prevent this from happening. You shouldn't end up with more than 9 rows in the random treasure tables anyway - I'm not sure if higher ones are valid. Maybe only certain mods like CtB cause this if installed before BGT. But second of all, there's probably a better way of doing this than REPLACE_TEXTUALLY which can cause fubar files if you're not careful. Aurora's "Realistic Random Treasure" component uses a method by doing various checks and then REMOVE/ADD_CRE_ITEM the variable reference where relevant to INV (the first open inventory slot).

Thanks Miloch, I think this problem is caused, when Exnem's Vault is installed before BGT (we have moved it before the big BG2 Mods, beacuse it overwrite the RNDTREAS.2DA)...
This error appears, since we have done that...

I will do a patch for the BWFixpack to solve this problem.

[Miloch]

I will do a patch for the BWFixpack to solve this problem.

Might want to nerf some of those items while you're at it . Otherwise it's the sort of mod that can completely ruin any attempt at balance in someone's game.

[Ascension64]

I have modified the BGT code for the next update so that if the row number is > 9, then it won't do patching. This means that if any mod adds too many rows to any of the RND tables, then BGT won't apply a random treasure patch to overflow tables at all. I can't really change how BGT patches without stuffing up the 1D20 and 2D10 rules (which are already stuffed up if CtB is installed prior to BGT).

[Lollorian]

continued from here ...

While it seems BGT solved the 9-byte issue by only considering upto 9 rows, it seems to now give null values to stuff that have items in 10+ (because ... methinks, it doesn't consider them??)

So, in effect, REEVOR still bugs the game out

[Lollorian]

And apparently, BWP's reevorfixer.tp2 can't fix this too Btw, this is its .tp2 (if anyone wanted )

Copying and patching 2 files ...
ERROR: [REEVOR.cre] -> [override] Patching Failed (COPY) (Invalid_argument("index out of bounds"))
Stopping installation because of error.

ERROR Installing [Fix Reevor if he is messed up], rolling back to previous state
Will uninstall   0 files for [SETUP-REEVORFIXER.TP2] component 0.
Uninstalled      0 files for [SETUP-REEVORFIXER.TP2] component 0.
ERROR: Invalid_argument("index out of bounds")
PLEASE email the file SETUP-REEVORFIXER.DEBUG to me
Automatically Skipping [Fix Reevor if he is messed up] because of error.

NOT INSTALLED DUE TO ERRORS Fix Reevor if he is messed up

[ScuD]

I've just done the expert install using latest versions and fixes and strangely enough I don't get any problems with REEVOR.CRE.

[Lollorian]

This thing seems to come from Exnem's Vault, do you have it?? I'm doing an install without exnem's right now, will report when BGT finishes

[ScuD]

Ah no, I do not use Exnem's Vault

[Lollorian]

And I forgot to report BGT finished an hour ago and well, it IS Exnem's vault then. This install of mine now the reevorfixer.tp2 working for it