1025 replies to this topic

[Lollorian]

Checked for effects in item abilities that targeted Self/Party/Everyone except party and was active while equipped (meaning they're probably equipped effects rather than on-hit effects )

Filtered out all the sound/visual effects and found a bunch In layman terms, ever wondered why an item that was supposed to grant invisibility only made you vanish when you started attacking? This stuff fixes it...

Spoiler

DarkHorizons\BGT\items\CMS1H07.ITM
DarkHorizons\BGT\items\CMSTAF01.ITM
DarkHorizons\BGT\items\CMSWQ15.ITM
DarkHorizons\items\CMS1H07.ITM
DarkHorizons\items\CMSTAF01.ITM
DarkHorizons\items\CMSWQ15.ITM (this one even had a wrong effect count... should've been 0)
- Had wrong ability effect indexes

DarkHorizons\BGT\items\MAFORG09.ITM
DarkHorizons\items\MAFORG09.ITM
Vault\ITM\BOWPHA.ITM error
- Had an extra APR bonus in the ability header... deleted

BG1NPCSoA\ITEMS\depo127.itm
TheUndying\items\CMBW01.ITM
- Moved AC bonus from ability header into global effects

TheUndying\items\CMHA01.ITM
- Moved lots of physical shield effects from the ability header into global effects

AM\itm\HALFEET.itm
BG1NPCSoA\ITEMS\bgsx14.itm
BG1NPCSoA\TIAX & QUAYLE\bgsx14.itm
Vendedor_DLAN\BHMO01_B.itm
- Moved invisibility effect from ability header into global effects

Kiara-Zaiya\Sulda\kzninja.itm
Kiara-Zaiya\WU-JE\sw1h49.itm
- Moved poison immunity bonus from ability header into global effects

Vendedor_DLAN\V-DLAN01.itm
- Moved damage vs. type bonus from ability header into global effects

Attached Files

•  ability_header_stuff.7z   2.17K   203 downloads

Edited by Lollorian, 15 September 2012 - 10:52 AM.

[dabus]

You mean something like that?
If not, you could also use that to find wrong spell targets... at least that's what I understand. Haven't put it through google translator since I don't know what it does with the weidu-code.

[Lollorian]

I ran that and found these Not sure how to go about fixing this though... Also, nothing related to the mod that caused the problem (Askaria)

Chloe\Spells\SPKeDeCR.spl error: Opcode (15), targets preset target!
LR\bcs\copy\DEADJON.SPL error: Opcode (215), targets preset target!
LR\spl\CSLSUCK.SPL error: Opcode (215), targets preset target!
LR\spl\jonchng1.spl error: Opcode (215), targets preset target!
LR\spl\jonchng2.spl error: Opcode (215), targets preset target!
LR\spl\jonchng3.spl error: Opcode (215), targets preset target!

Also is that Taimon? As in ToBHacks Taimon? He's with you guys?

[dabus]

Yeah, he speaks German and the Kerzenburg Forum is together with the Rosenranken arguably the most active German speaking modding Forum.
So why are you that surprised?

The output tells you that the target type is wrong for those spells. At least thats what he said in the thread. Funny how computers make rubbish out of some parts...

[Lollorian]

It wasn't the german thing but the fact that he was still active and debugging (which is awesome... must check that thread out now )

As for the spells, could you please report these to that thread because I have no clue what to set these into (the opcode 15 is Dex Bonus and 215 is Play Visual Effect)... Also the IESDP doesn't mention anything about this stuff so

Can you guess that spells aren't exactly my strong point All those years as a FMT while only relying on the M class in the form of clicking on random stuff... yup, that helps

[Taimon]

I wrote that script in response to a reported assert error. It checks for an invalid target type (2) on the caster/global effects for spells. (The engine doesn't like that and immediately errors out.)
I guess the fix really depends on the respective spell but setting the target type to 1 (self) should be relatively safe.

As for myself, I'm still supporting the german community whenever I can, but sadly I don't have much time anymore.
Debugging assert errors is still fun though.

[Lollorian]

Holy... I'll have them set to self and uploaded soon! Thanks I'm also interested in knowing what made SPIN551 and the other SPINs target (2) for Mooni because no mod I checked changed them to be like that

Also on the topic of assertions, I've always wanted to ask

Why does this crash seem to happen? What are the exact conditions? Does it only affect axes and daggers? What are the is arrow/bolt/bullet flags even used for? Sorry for troubling you with these

[Dakk]

It wasn't the german thing but the fact that he was still active and debugging (which is awesome)

Seconded!

Debugging assert errors is still fun though.

Hooray for weird hangups to the betterment of BG!

[Lollorian]

And here's them target Self (1)ed

I noticed that the IEDSP SPL page does list that target (2) can cause problems (although in a rather obscure place)

Casting Feature Block offset (these feature blocks may not use target type 2)

Also, looking at that page, it seems that target (2) and (6) can outright crash the game on the effects from ability blocks I changed the script to check ability header effects and found that practically every mod has spells that target (2) or (6) (even awesome ones like 1PP and aTweaks)

Is the IEDSP page mistaken?

EDIT: Just realized it meant the target of the ability itself not the effects

Attached Files

•  Taimon_preset_target_effects_fix.7z   632bytes   168 downloads

Edited by Lollorian, 16 September 2012 - 10:02 PM.

[Jarno Mikkola]

Is the IEDSP page mistaken?

What does the latest NearInfinity (compiled by Sam) say about the that ? ...

Casting Extended Header Block offset (these blocks may not use target type 2)

Fixed that for you.

Edited by Jarno Mikkola, 16 September 2012 - 10:19 PM.

[Lollorian]

Nope the IEDSP is right Missed my ninja edit

EDIT: Just realized it meant the target of the ability itself not the effects

I changed the script accordingly and nothing shows up so all's well

Btw, isn't the latest and greatest NI the one on Wisp's (FredrikLindgren) GitHub page?

Edited by Lollorian, 16 September 2012 - 10:08 PM.

[Jarno Mikkola]

Nope the IEDSP is right Missed my ninja edit

And I ninjaed you...

Btw, isn't the latest and greatest NI the one on Wisp's (FredrikLindgren) GitHub page?

Well, still the original link thread is made by Sam...

Now, I just wish this to be fun for you Lollorian... cause I would regret it if it weren't, cause it's to me.

Edited by Jarno Mikkola, 16 September 2012 - 10:19 PM.

[Lollorian]

bw05fgca.cre from TGC1e apparently likes kittens
... and wielding a 2-handed sword with a non-droppable helmet in his shield hand

Moved helmet to where it belongs (hopefully the head )

Now, I just wish this to be fun for you Lollorian... cause I would regret it if it weren't, cause it's to me.

This is as much fun as drinking cough syrup I make faces at first, but the taste catches on after a while

Attached Files

•  TGC1e_2hander_shield_fix.7z   423bytes   164 downloads

Edited by Lollorian, 17 September 2012 - 07:39 PM.

[Lollorian]

Stuff found here... both should really be included ASAP

EDIT: Removed old BPv180 attachment (old report here, actual fix here)

Attached Files

•  TOD_INQUIS_TRUE_SIGHT_innate.7z   28.18K   174 downloads
•  innate_fixer_exclusion_list_deux.7z   93.29K   168 downloads

Edited by Lollorian, 21 September 2012 - 01:51 AM.

[ilot]

Hi

About Sendro03.cre, I tried with the Lollorian's fix and I tried a manually removing the item (BWBOLT01.ITM) via Nearinfinity too, but it seems not to fix the creature and I got CTD in anyway.

Thanks for any help!!

Here is my Sendro03.cre and my baldur.err

Attached Files

•  SENDRO03.CRE   1.21K   174 downloads
•  Baldurerr.doc   10.5K   200 downloads

Edited by ilot, 20 September 2012 - 10:35 AM.

[Lollorian]

The CtD isn't because of SENDRO03.CRE

use NI and change the spell level field of SPCL232.SPL to 2 and SPCL732.SPL to 7 (if they're different) that should fix the CtD that the second and third attachment above is supposed to fix

EDIT: Shit I meant change both their levels to 1 Not 2 or 7

Edited by Lollorian, 20 September 2012 - 10:41 AM.

[ilot]

But I have both theirs level to 1!!! What can I do?........

[Lollorian]

Then your CtD isn't related to the above files and we'd need a new thread with some more details about it (your baldur.err is empty )

Also, here's your SENDRO03.CRE fixed in case you think that's causing the crashing

Attached Files

•  SENDRO03.CRE   1.19K   168 downloads

[ilot]

Then your CtD isn't related to the above files and we'd need a new thread with some more details about it (your baldur.err is empty )

Also, here's your SENDRO03.CRE fixed in case you think that's causing the crashing

Thanks for your help, I tried but your SENDRO03.CRE not fix my CTD, I tried to summon it with Clua but CTD immediatly!!!
Here is my baldur.err
Edit: Here is my Tobex.log too!!

Attached Files

•  Baldurerr.doc   21K   200 downloads
•  TobEx.log   1.26MB   366 downloads

Edited by ilot, 20 September 2012 - 11:18 AM.

[Miloch]

"creatureSize == 0" usually indicates the .cre does not exist IIRC? In which case, it may not be related to the .cre in question. Can you try the Area CRE Checker (in the Modding Tools forum) with the area you get the crash in and see if it says anything?

(Also for future reference ilot, you can just post text files like the above in SPOILER tags rather than as attachments... makes it a bit easier to see and debug them.)