1025 replies to this topic

[Shaitan]

Hi!

All these fine fixes - am I able to just install where ever in the proces? What are they to be specific? Correction to the TP2 which may chrash your games?

Cheers and thanks in advance for the enlightenment.

[berelinde]

Yeah, Player1.cre with a DV of "Player1" is probably there so that people who use the tag with quotes don't go nuts.

Guys, it's great that you want to fix things, but let's keep it real. Posting actual bug reports on a mod's forum is a considerate thing to do. Posting trivial reports and making them sound like game-breaking bugs (peppered with a dozen or so smileys) is anything but considerate.

Look at the code. Is it breaking anything? What's the worst that could happen if this so-called bug were allowed to remain?

Yes, you should probably still let the modder or mod maintainer know about it, but if it's cosmetic, please include a "when you get around to it" kind of statement. Please.

[Lollorian]

Posting actual bug reports on a mod's forum is a considerate thing to do. Posting trivial reports and making them sound like game-breaking bugs (peppered with a dozen or so smileys) is anything but considerate.

please include a "when you get around to it" kind of statement.

I never ever EVER wanted to give the impression of a game-crashing bug Agreed, I should've included that line Again, sorry if I seemed like "NEEDZ NU VERSION NAO!!!:

PS: Smileys are good to break the flow

Look at the code. Is it breaking anything? What's the worst that could happen if this so-called bug were allowed to remain?

Well, if it is a bug, I believe it shouldn't be allowed to remain now, should it?? (still not saying you should version up for every li'l bug below the sun )

Anyway, about using them, I tried to preserve the folder structure so they can just be extracted to where your mod folders are extracted Oh, and none of them are hotfixes (unless mentioned) and should be used before installing

[berelinde]

Probably the most useful thing you can do is find out exactly what is broken. If you don't know, ask somebody. For example a !StateCheck("Player1",CD_STATE_NOTVALID) is *always* going to be trivial. The vanilla game doesn't use it and many mods don't use it. That's because the chances of a PC walking around in an invalid state, i.e. stunned, silenced, or otherwise incapacitated for any length of time are low, unless the player is running a party of Wizard Slayers, which probably doesn't happen a lot.

Misspelled triggers and actions will sometimes, but not always, prevent installation. Misspelled objects sometimes will, if it's something like Ployer6, but most of the time, it will just show up as a parse warning. Some of these are trivial, but they have the potential to be serious, so it's probably worth mentioning it specifically.

I can't speak for every other modder out there, but I'd prefer the fixed package to include nothing but the relevant script/dialogue file and a changelog of the differences between the released script and the new one. What got me so grumbly this morning was opening up the scripts and having to do a line-by-line comparison of the files to tell me what was different about them. You might want to include the text of that changelog in your report post so the modder knows at the outset whether it's a big deal or not. That way, even if you don't understand the code, the modder will, and can tell you whether it's a big deal or not. Sometimes, it is a major problem. InParty("Myself") will cause havoc in a mod, so you're doing a great service to the modder in pointing it out. Other times, like with the !StateCheck("Player1",CD_STATE_NOTVALID), it's relatively insignificant, and can probably be postponed to whenever the modder feels like dealing with it.

[Lollorian]

You might want to include the text of that changelog in your report post so the modder knows at the outset whether it's a big deal or not.

Ok agree on this too It was just this time. I mean, I saw this thread and it struck that I should probably report these to the mod forums. But I thought it'd take a while, so I just copy-pasted the report (while changing the mod name ) but I thought I'd better report it before I forget and ... <whoosh> ... Will include atleast some kind of info about exact fix in future "fixes"

PS: To save you the trouble of line by line comparisons, might I recommend a diffing tool like WinMerge?? Even the latest versions of Notepad++ have this feature (although I WILL make it a point to post some sort of changelog )

Also, about the !StateCheck("Player1",CD_STATE_NOTVALID), when I checked out of some 350 mods, only 3 mods had this (Breager, Kido and Crossmod) Now looking at that kinda hit ratio, one would suspect something was wrong (and that was searching all .tp2's, all .baf's and all .d's )

PS: Sneaky ninja, I am

Edited by Lollorian, 03 April 2010 - 04:06 AM.

[dabus]

Uh, sorry if your in a bad mood and (maybe) I ask a stupid question but why would you compare line by line if it can be done by a program.
I can say that Winmerge was a great help for me checking for changes in last few version of the BiG World Install.bat. You can also use it to create patches if you like to.

Edit: Määh.

Edited by dabus, 03 April 2010 - 03:50 AM.

[berelinde]

Don't have Winmerge. Never needed it before.

[Lollorian]

Ok, now for some more fixing action

Typos within CreateVisualEffect()
Fix: Many scripts refer to mistyped bam/vvc's in CreateVisualEffect() and CreateVisualEffectObject() (finally got the hang of DLTCEP )

As promised, a changelog

Kido
- SPWIRHL -> SPWHIRL

Planarspheremod
- ANCALL -> AMCALL
- SPBASSWT -> SPBASEWT
- SPFINDOI -> SPFINODI
- SPCALLI -> SPCALLLI

d0Questpack
- CHUNKS -> SPCHUNKS

TDD
- SPDIMDR -> SPDIMNDR
- SPPFIRX1 -> SPPFIRXI

and ... ToA had this:

CreateVisualEffectObject("z_igor","SPPORTAL")

which should probably have been...

CreateVisualEffectObject("SPPORTAL","z_igor")

Attached Files

•  Kido_animation_typo.7z   777bytes   293 downloads
•  planarspheremod_animation_typo.7z   1.23K   268 downloads
•  questpack_animation_typo.7z   505bytes   292 downloads
•  TDD_animation_typo.7z   1.11K   280 downloads
•  ToA_animation_typo.7z   1.33K   283 downloads

Edited by Lollorian, 03 April 2010 - 09:12 AM.

[Hoppy]

Ok, now for some more fixing action

Typos within CreateVisualEffect()
Fix: Many scripts refer to mistyped bam/vvc's in CreateVisualEffect() and CreateVisualEffectObject() (finally got the hang of DLTCEP )

As promised, a changelog

Kido
- SPWIRHL -> SPWHIRL

Planarspheremod
- ANCALL -> AMCALL
- SPBASSWT -> SPBASEWT
- SPFINDOI -> SPFINODI
- SPCALLI -> SPCALLLI

d0Questpack
- CHUNKS -> SPCHUNKS

TDD
- SPDIMDR -> SPDIMNDR
- SPPFIRX1 -> SPPFIRXI

and ... ToA had this:

CreateVisualEffectObject("z_igor","SPPORTAL")

which should probably have been...

CreateVisualEffectObject("SPPORTAL","z_igor")

Please attach the TDD fixes in the bug thread so I don't have to comb through this one. It doesn't matter if it is for 1.13 or not, just a little note that it is regarding 1.13 and include a changelog so I can keep track of things. Same with RoT, SoS and CtB please and maybe I will get to them.

Thanks

[Lollorian]

And done

[Miloch]

Yeah, if the modders are still around (or someone is willing to maintain the mods) it really is better to fix this kind of stuff in the original mods than slapping it in the BWP Fixpack. We don't need to create more work for the BWP guys if we don't have to, after all - they do enough as it is.

[Lollorian]

After bam's, we have wav's

Typos in PlaySound()
Fix: Title says it all!

Changelog:

AjocMod
- FF_M09 -> EFF_M09

Boards o Magick Itempack
- DEMOGO1 -> DEMOG01

DSotSC
- GHOST4 -> GHOST5

Also, I'll say that the reason I'm clumping the fixes over here is just cause it's easier for me to link tens of forums to this thread than link to tens of forums from here Individual fixes, I'll post in the forums themselves

Attached Files

•  DSotSC_sound_typo.7z   842bytes   291 downloads
•  AjocMod_sound_typo.7z   446bytes   292 downloads
•  Setup-BoM_sound_typo.7z   548bytes   294 downloads

[amazinggameguru]

I didn't see this posted here. Lol, if you want to post a zip for this fix you are welcome to. SCS install fails with a translation error. fix is Here

[Lollorian]

And that's another one down Thanks amazinggameguru!

ScuD's fix for SCS missing some line and stuff
Fix: here

Got some new OR() fixes for dialogues now
Fix: Dialogues having mistyped OR()'s

Changelog:

BG1NPC Project
Line 1847: OR(5) -> OR(4)

Jastey's Ajantis
c#player1.d line 92: Added missing !StateCheck("anomen",CD_STATE_NOTVALID)
c#ajanp_pr.d: OR(43) -> OR(33) (5 instances)

Luxley Family
Line 1857: OR(9) -> OR(<img src='http://www.shsforums.net/public/style_emoticons/<#EMO_DIR#>/cool.gif' class='bbc_emoticon' alt='8)' />

Daulmakan's Itempack
All files line 9: Removed OR(2)

Misc. crazy typos
Fix: typos made to be ... not-so-typos

Gavin
- b!gavinpid.d Line 80: %tuut_var% -> %tutu_var%
- gavinflirts.d Line 265: _MISC18 -> %tutu_var%MISC18

NeJ
- Line 389: HJescape2 -> HJescape

NeJ2
- Line 162: moganasti -> mogansti

PlanarsphereMod
- psqMin -> psqsMin (8 instances)

Ruad Ro'fhessa
- Line 924: sclr1x -> scrl1x
- Line 1044: wnad05 -> wand05

Beyond the Law
- Line 71: ARROW11 -> AROW11
- Line 149: ARROW15 -> AROW15

Shed's Mods
- Line 197: SD_MS2 -> SD_MD2

PS: I wanna ask this, NeJ seems to have a .baf called HJESCAPE1.baf (which is above the 8-char limit) Should this be renamed?? Or will it properly compile into just HJESCAPE.bcs?? (it did for me ... dunno about everyone else )

Attached Files

•  scs_ScuD_missing_tra_line.7z   8.41K   299 downloads
•  bg1npc_OR_fixes.7z   9.19K   296 downloads
•  c#ajantis_sva_OR_fixes.7z   3.19K   299 downloads
•  Item_Pack_OR_fixes.7z   802bytes   291 downloads
•  LuxleySoA_OR_fixes.7z   39.71K   279 downloads
•  NeJ2_mogansti_typo.7z   4.67K   287 downloads
•  NeJ_hjescape_typo.7z   9.43K   288 downloads
•  ruad_freaky_typo.7z   5.25K   292 downloads
•  planarspheremod_freaky_typo.7z   768bytes   308 downloads
•  aD&L_freaky_typo.7z   2.23K   290 downloads
•  SDMODS_freaky_typo.7z   2.57K   279 downloads
•  gavin_freaky_typo.7z   12.69K   286 downloads

Edited by Lollorian, 04 April 2010 - 05:06 PM.

[Lollorian]

Valiant's Azure-not-showing-up-in-correct-chapter fix
Fix: here

Miloch's infinityanimations missing READ_BYTE
Fix: here

Attached Files

•  Azure_Valiant_correct_chapter_fix.7z   361bytes   267 downloads
•  infinityanimations_Miloch_READ_BYTE.7z   17.11K   291 downloads

Edited by Lollorian, 06 April 2010 - 03:25 AM.

[Lollorian]

Hoppy's TDD CI spawn fix
Fix: here (attached in following post in that thread)

[jastey]

Changelog:
Jastey's Ajantis
c#player1.d line 92: Added missing !StateCheck("anomen",CD_STATE_NOTVALID)

Caution - The missing state would be "StateCheck("anomen",CD_STATE_NOTVALID)", without the "!", as it checks for Anomen not valid to speak.

Thank ypu very much for screening the mod, though. Both added and fixed locally!

[Lollorian]

Caution - The missing state would be "StateCheck("anomen",CD_STATE_NOTVALID)", without the "!", as it checks for Anomen not valid to speak.

Sorry about that Here's a fixed patch (this is the patch from the BWPFixpack ... overwrite the existing file )

Attached Files

•  BWPFixpack_c#ajantis_sva_mishap.7z   568bytes   291 downloads

[Isaya]

Regarding the fixes for Kiara-Zaiya provided here and here, that Leomar sent to Graoumf so that we update Kiara-Zaiya, I have a little suggestion: in the future, test your changes in a bare BG II-ToB installation, please. These fixes won't work and will cause an error when installing in this configuration.

The changes rely on a state added by BG2Fixpack. So it doesn't exist in a plain game. In order for the fixes to work in all conditions, I added a bit of code in the tp2, borrowed from BG2Fixpack, in order to ensure this state is added, if necessary.

REQUIRE_FILE ~Data/25Dialog.bif~ @2

// Isaya : additional code for V1.6.1, retrieved from BG2Fixpack
// Addition of STATE_REALLY_DEAD state, used by several scripts modified by Lollorian

// new state needed to fix Dead() triggers that don't use DVs
APPEND ~state.ids~ ~0x00000FC0 STATE_REALLY_DEAD~ UNLESS ~0x00000FC0 STATE_REALLY_DEAD~

// force WeiDU to reload altered IDS files
CLEAR_IDS_MAP

// Isaya : end of additional code

If I understand properly the WeiDU documention, CLEAR_IDS_MAP shouldn't be required, but since it's used in BG2Fixpack, who am I to question it?

I think there is a small mistake at the end of KZ#DMLRD.baf:

//NO PC FOUND
IF
 See(NearestEnemyOf(Myself))
 Allegiance(Myself,ENEMY)
 !Detect([PC])
 ActionListEmpty()
 !StateCheck(Player1,STATE_REALLY_DEAD)
THEN
 RESPONSE #100
 	ReallyForceSpell(Player1,WIZARD_DIMENSION_DOOR) 
END

The ! before StateCheck was missing in the submitted change (the original script was using !Dead).

Similarly, there was another change that doesn't work in the archive Leomar sent us. The setup-Kiara-Zaiya.tp2 file was moved to the mod directory (originally it was still with the exe). For some reason, probably because of the dash in the directory name, WeiDU can't find the tp2 if it is in the mod directory. If I rename the directory to KiaraZaiya (without the dash), update setup-* file names and change all references in the tp2 file to the directory name, WeiDU will find the renamed tp2 in the renamed directory, so that installation starts.

I'm not very fond of changing the mod directory name for the sake of moving the tp2 file from the BG II directory. This prevents updates by plain overwrite of the archive, for one thing. I'd prefer this apparent restriction on the presence of a dash in the mod name to be solved in WeiDU instead.

Thank you for the changes anyway. Unless there is a big yell from other people, I'll stick to my choice not to rename the mod directory.

Edited by Isaya, 13 April 2010 - 12:09 PM.

[Lollorian]

Sorry for not being around too much these days RL's been a real pain in the ass

The ! before StateCheck was missing in the submitted change (the original script was using !Dead)

A great big WHOOPSIE is in order Thankfully, Kiara-Zaiya's latest fixes aren't in the BWPFixpack 9.0.2 So ...

Also, this absolutely stupid typo (on my part obviously ) in the scsII fixes (incorporated into the BWPFixpack ... this is the correct fixpack file )

Also, I noticed the most recent "replacement fixes" for Ruad, Thael, Uldar, DKDrizzt and MTSCrappack aren't in the fixpack either

Anyway, see ya guys!

Attached Files

•  BiG World Fixpack_scsII_OMG_typo.7z   507bytes   265 downloads
•  Kiara-Zaiya_REAL_bg2fixpack_replacements.7z   1.73K   275 downloads