Took a break to look over this a bit more.
I think I'm going to have to bite the bullet and add some dialogue lines to account for switching infiltrations. There's no point in fixing code that is assed only to make it become half-assed. Might as well fix it right. I think the situation warrants it.
Here's some notes for my own future reference that might interest you all.
It seems like no two factols handle switching factions in the same way (though the Sensates and Xaositects are pretty similar), which is a bit frustrating. The following is how they work before any fixes:
Keldor is the easiest to deal with in terms of this fix, since you -can't- join the Godsmen after joining the Anarchists. Keldor checks your faction both when starting his quest line, and when completing it. The checks at the beginning do not include a check for Anarchists at all. Actually taking the Godsman oath -does- check for Anarchist, though you can't be one at that point. At that point, Keldor is magically aware that you belong to a faction, though he does not know which one. Your responses in that case are of the vague "Okay, I renounce... my old faction" variety. Again note that the anarchist checks can never be true, but it's useful to look at in terms of intent.
Splinter has no quest line, so there's only the one check. He doesn't detect that you belong to a faction, but you are forced to admit it in order to become a Sensate, though in the case of Anarchists your response is of the vague "I will renounce... my old faction" variety.
Barking Wilder also has no quest line, so only one check. You are forced to admit old faction membership in the process of becoming a Chaosman. You basically come right out and admit you're an Anarchist to him, though you then get vague in your actual "Renounce" line if you're infiltrating. Which is kinda stupid.
Emoric is the worst of all, because the normal "You must renounce your old faction" state is orphaned in his dialogue. When you ask to become a Dustman, he magically detects if you are in any faction OTHER than Anarchist. If you're an anarchist, your request to join was an "Infiltrate" line, and if you pick that he doesn't seem to recognize that you are in a faction. If you're in any other faction, he tells you you'll have to renounce it but it never actually hits the state where you actually do so - that state is totally orphaned. I intend to restore that state. (Actually, you can Lie to him with a high enough charisma and evade having to renounce your old faction at the beginning of his questline, so that you can remain in your old faction for the time being - a cool option that's trivial if the Renounce state isn't restored). When it comes time to finally join the Dustmen, there is again no "renounce" state - you are quietly and automatically booted from your old faction when you state that you want to become a Dustman after you've finished his quests. I'll be adding states so that you have to actually agree to renounce your old faction in that situation too, in the same way Keldor's does.
Interestingly, Emoric's orphaned state does NOT allow you to truly renounce the Anarchists, you can only Infiltrate at that point. That would be some backup if I decide not to allow true renunciation of the Anarchists when joining the other factions, but for the time being I'm seeing if I can make that work.
Here are the 9 dialogue lines I'll be adding:
Sensates:
~Infiltrate the Sensates for the Anarchists: "I'm ready to join the Society of Sensation. I feel no more loyalty towards the Godsmen."~
~Infiltrate the Sensates for the Anarchists: "I'm ready to join the Society of Sensation. I feel no more loyalty towards the Dustmen."~
~Infiltrate the Sensates for the Anarchists: "I'm ready to join the Society of Sensation. I feel no more loyalty towards the Xaositects."~
Dustmen:
~Infiltrate the Dustmen for the Anarchists: "If that is what must be, that is what must be. My mind must be true to itself, not to another. As of this moment, I forsake the beliefs of the Godsmen."~
~Infiltrate the Dustmen for the Anarchists: "If that is what must be, that is what must be. My mind must be true to itself, not to another. As of this moment, I forsake the... uh, 'beliefs' of the Chaosmen."~
~Infiltrate the Dustmen for the Anarchists: "If that is what must be, that is what must be. My mind must be true to itself, not to another. As of this moment, I forsake the beliefs of the Sensates."~
Xaositects:
~Infiltrate the Chaosmen for the Anarchists: "Join ready the Xaositects am I. Loyalty none faction old I have Sensates."~
~Infiltrate the Chaosmen for the Anarchists: "Join ready the Xaositects am I. Loyalty none faction old I have Godsmen."~
~Infiltrate the Chaosmen for the Anarchists: "Join ready the Xaositects am I. Loyalty none faction old I have Dustmen."~
Qwinn
Edited by Qwinn, 08 July 2009 - 03:34 PM.