16 replies to this topic

[Kaeloree]

Can you check these variables for me in the CLUAConsole or in Shadowkeeper?

GetGlobal("I#Yoshimo_BY5","GLOBAL")
GetGlobal("I#YoshimoFriendTalks","GLOBAL")

That should help determine what's going on. If you have Near Infinity or Infinity Explorer, it'd be helpful if you could post the contents of the file "yoshimo.bcs".

[Kaeloree]

If they're not there, it means there's a problem with an earlier talk... not sure what's going on, but with any luck this'll fix things in your game. When I have time, I'll look into this further--if you have a moment, it'd be great if you could post your byoshim.dlg file, and maybe the yoshj.dlg file as well, so I can see what went wrong.

Set this in the CLUA console:
CLUAConsole: SetGlobal("I#Yoshimo_BY5","GLOBAL",1)

That should make the first friendship dialogue pop up after 12 ingame hours, and hopefully stop the stutterbug. If not I'll give you a list of variables to set which will definitely fix your game--but I'd rather try this first, since it's simpler.

[Kulyok]

Folks, it's a very bad idea to use RealGlobalTimerExpired("I#YoshimoFriendTalksTimer","GLOBAL") in dialogue file - because if, Seldarine forbid, the timer sets itself at the wrong time, you'll never find the end of it, because you can't even debug it properly. I'd cut these conditions in all talks in dialogue file without delay.

As people start complaining it's Angelo(which is bad), I wanted to debug Yoshi's Friendship - but I can't get through the "TimerExpired" condition, alas. To be blunt, I'd
0) get rid of the "TimerExpired" condition in dialogue(neverevereveragain),
1) recode the thing in clean code,
2) make all "conditioned" talks trigger separately,
3) delete all unnecessary timers and vars, like"I#YoshBrynnlaw".

The dialogues are good, so it'd be a pity to leave a stuttering mod(not offering to help, mind. But it's an hour's work anyway).

[cmorgan]

When you strip out those extra RealGlobalTimerExpired("I#YoshimoFriendTalksTimer","GLOBAL") calls from the dialog, you might also want to reverse the SetGlobal and the RealSetGlobalTimer calls in the dialog.

We had some hassles with globals not setting when we initially moved to kulyok's "open variable in .baf <> close variable in .d" routine, and there was an expert or two who thought it might be because some things evaluate and clear out further actions. We were not able to confirm the whole deal, but I have been recommending <<all actions>> <<realsetglobaltimer>> just in case. We have not been able to confirm a difference between SetGlobalTimer (the ingame time) and RealSetGlobalTimer() (the realworld time), but the "hunch" is that there is a difference. Perhpas devSin or aAvenger or Avenger knows, or could throw an educated guess.

It looks like the change would be

// 5. The Shadow Thieves
IF WEIGHT #-2 ~Global("I#YoshimoFriendTalks","GLOBAL",9)~ y5
  SAY ~So...we are officially under the cloak of the Shadow.  What strange twists of fate happen in this age.~ [i#blank]
  ++ ~I wouldn't have thought you'd mind, Yoshimo.~ DO ~IncrementGlobal("I#YoshimoFriendTalks","GLOBAL",1) RealSetGlobalTimer("I#YoshimoFriendTalksTimer","GLOBAL",3600) ~ + y5.1

 <<snip>>

END

The "backup timers" Domi used in early work has been replaced by the open-in-baf-close-in-dialog pairing. Stuff hangs open until it gets cleared by dialog, so it doesn't need that "window" of time. So unless you really want to create a delay between the talk being available and the talk firing, you don't need the specific talking timers anyway - unless you are trying to avoid that big banter pileup when the party walks into a new area ?

(cosmetic - I know everyone uses IncrementGlobal(), but I just have to put in a plug for setting the actual variable. You will cut down on bughuunting if you open up a "find in all files" in Notepad++ or TextPad or something, and search for "Global("I#YoshimoFriend" and then sort by number - you can track the opening, initiation, condition on the dialog, and closing is a nice neat little patternn that makes problems just leap off of the page).

Edited by cmorgan, 28 March 2009 - 12:01 PM.

[Kaeloree]

I'll try to find some time in the next week to recode it--thanks for the suggestions, Kulyok and cmorgan.

Re: IncrementGlobal() vs. SetGlobal() I just find it easier to plug in Increment() rather than Set--it makes it quicker for me to code. (And for me, at least, I can easily see where any specific variable is at at any point in the script, so it's no real problem in that respect).

[Vlan]

Has this problem ever been fixed?

 

Yoshimo Friendship is really acting strange.

 

Barters start immediately (first three in a row in Irenicus dungeon) after letting Yoshimo join the group and if you refuse to give answers to Yoshimos questions (I don't want to tell you anything), OP's problem kicks in (endless dialogue), otherwise, if you give him straight answers, he is behaving normal.

Edited by Vlan, 25 November 2013 - 08:16 AM.

[cmorgan]

If you currently have SCS on your install (and who doesn't) we have recently found that part of what the current version does is (accidentally) strip custom gtimes.ids entries from the game. So if you are using an older version (not 3.1) then you may be running into that - and you will find that a number of NPC mods use that convention.

If you have v3.1 on your game, then I would really like to see a save and a weidu.log, please - it would mean that what we *think* is the problme with the gtimes.ids timer solution may actually be something else entirely, and something that we very very much want to track down.

[Vlan]

Am using v2.7.

 

thanks for the answer. Do hope that it will be updated in the BWS soon.

[cmorgan]

Just following up - if you are in the middle of a game and don't want to upgrade things way back in the stack, v28 of SCS works just fine with custom .ids entries. Modders should be able to continue to use gtimes.ids materials if they so choose.

[The Imp]

I used the BWS to install all my mods.  Do I just download v28 and let it install?

No... you either make a complete reinstall with BWS and wait for the SCSv28 to be included in it, or you go with the old and more reliable SCSI & SCSII v21 combo ... if it's still there.
 
And yes, I have seen the AI jerking the NPC movement in the unmodified BGEE too... so.

Edited by The Imp, 18 December 2013 - 05:23 AM.

[The Imp]

Okay... so is there anything I can do about it now that I have this issue in game?

You can try setting the character AI(in the character record -> customize -> script) to None, and then resting, as if you succeed in that the character might just clear out it's intentions from the actions list and spontaneously start the actual dialog it was meant to. But of course you can't do that inside a dialog(mode).