364 replies to this topic

[scient]

I've already overhauled the hp progression for next release. There is a small bug introduced by my initial method but only for PC's other than TNO. And then, they're gaining a few hp less than they should rather than more (bug tap reported). I guess due to my anal QA this is the only reported case where my changes have caused problems and will be sorted next update.

I have completely revised the way hp is handled on level up for next release so I'd be interested to know what is causing that hp bug. Actually, I revised TNO hp handling and left other PC's untouched which sorts bug I mentioned above.


edit:
Also, I'd thought I'd say I enjoyed "Expanded Deionarra's Mod" as well.

Edited by scient, 11 March 2009 - 12:45 PM.

[taplonaplo]

I think it's the MINROLL bug in warrior hp table, or has the fix been included in an updated version?

[scient]

The fix to MIN_ROLL wasn't included into v3. I came across it while overhauling TNO progression. It sounds like something else because MIN_ROLL issue would end up giving less hp rather than more. Say MIN_ROLL is 5, it was possible for function to return say 2 or 3 as final hp value.

[taplonaplo]

I'm referring to this from [EDIT: Qwinn removed link to Qwinn's Workroom thread] :

Sorry guys, been hellishly busy last couple days.

Yes, as others have noted, I'm pretty sure MIN_ROLL means that when your CON reaches above a certain amount, you can't get lower than MIN_ROLL on your die roll.

You're right about the methodology of the max hp tweak. Hmm. Good catch. I guess I will have to modify the HPCONBON.2DA to set the entire MIN_ROLL column to 1 when the Max HP Tweak is installed. Still... the damage should've been pretty minimal, no? Seeing as it shouldn't have any effect over level 9, and how many people get a CON of 20+ by level 9? Or does it have some other effect I'm not seeing?

Qwinn

Edited by Qwinn, 11 March 2009 - 11:11 PM.

[Qwinn]

DOH! Thank you for that reminder, Tap, I -totally- forgot about that. (Though, for future reference, please don't link to Qwinn's Workroom threads

Yeah, turns out, it IS an issue with the Max HP Tweak. It only happens when you've got greater than 19 CON before you've reached 9th level in any class... which I stupidly thought would be pretty rare, heh.

I will come up with a fix for that sometime soon, and post it as files you can download directly from the post here.

Qwinn

Edited by Qwinn, 11 March 2009 - 11:12 PM.

[Qwinn]

Ok, I whipped out a fix for the issue. Gave it its own post in the Tweak forum. Grab the file here.

http://www.shsforums...mp;#entry440424

This will unfortunately not fix your HP gain retroactively. It only makes it not happen on future levelups. To fix your HP gain for your existing character, I'm afraid you'd need to either back up to a save game prior to gaining the extra HP, or use a save game editor to fix your HP to the proper amount.

Qwinn

[Qwinn]

Oh, scient, rereading your posts in this thread, I should mention that no, the MIN_ROLL issue (which is what I fix here) isn't what you appear to be thinking it was. What MIN_ROLL was doing, in conjunction with the Max HP Tweak, was that the MIN_ROLL value was being multiplied by the max roll. So, if your MIN_ROLL was 4 and you leveled as a fighter, you were getting 4x10 hp. This sortof makes sense, since the Max HP Tweak works by exchanging the "Number of Sides" and "Number of Dice" columns. (One ten-sided die roll becomes ten one-sided die rolls).

I fix it by reducing the MIN_ROLL to 1 in the HPCONBON file if you're installing the Max HP Tweak. The MIN_ROLL value is obsolete with a Max HP Tweak, because your MIN_ROLL essentially becomes the maximum possible die roll.

Qwinn

Edited by Qwinn, 12 March 2009 - 01:09 AM.

[taplonaplo]

thought you could only see threads(the content) in workroom if you had access so it just wouldn't load, but won't happen again

[Qwinn]

That may indeed be the case, I'm not sure. Just figured I'd edit it to be safe. Besides, if it does work that way, I could see some people getting a "won't load" error and bugging the SHS mods about it, thinking it's an error.

Qwinn

[Qwinn]

Nice one! Fixed for the next version.

Searching for similar instances of the same mistake - something I do whenever I get such a report - I found another case of it in the text of someone in the sensory stone hall:

Original: ~This man's gentle voice compliments his calm and refined demeanor. "Greetings. Are you here to use one of the sensory stones?"~

So that's two fixes you can take credit for

Qwinn

Edited by Qwinn, 26 March 2009 - 11:38 PM.

[Qwinn]

Another nice catch. Yeah, it's pretty easy to figure out what that line should've been... "If you let me out of here now, I'll let you live." (The line that was messed up was for having 13+ strength, the next line for 12 or less strength is correct, but the text of the reply for both should be the same.) Fixed for the next version.

Keep 'em coming!

Qwinn

Edited by Qwinn, 28 March 2009 - 01:07 AM.

[scient]

How do you go about selling the other major skulls to Lothar? I got Morte back and everything but I thought the Fixpack let you sell the rest of the named skulls to him too

I'm not sure about this specifically, Qwinn probably knows, but I do know Lothar area is incomplete. There is a script that toggles a variable "LOTHAR_MAD" or something like that if you try to mess with locks or pickpocket him. However, nothing uses it so you can loot his place in front of him without any consequences. Unfortunately there is nothing that could be restored in UB or any indication how he was intended to react.

[Qwinn]

How do you go about selling the other major skulls to Lothar? I got Morte back and everything but I thought the Fixpack let you sell the rest of the named skulls to him too

No. I haven't looked at this part in like 9 months, but I think the Restoration Pack claimed to do what you're saying but it didn't work. SKARDAVNELNATE also made an attempt to get it to work, I think, but I don't -think- it was working as of his last full version (apologies to SKARD if I'm wrong on that). If I recall from playing through with those installed, the only effect those attempts had was to give the plain old skulls that lie around a printed value of 60 copper, but no one would actually buy them. (EDIT: Wait, now that I'm thinking about it, I think plain skulls were sellable to -any- merchant for 60, not just Lothar).

There is no hint in the game files that selling additional skulls to Lothar was ever actually supposed to be in the game. I don't really have any particular intention to make such a mod, at least for its own sake. I -may- use the idea, though, when I get around to restoring spell keys or perhaps some previously unavailable spells. If I do it that way, it may make it into UB, though if I do so it'll be clear in the readme that that's "new" content used as a reasonable means of restoring original content.

Qwinn

Edited by Qwinn, 28 March 2009 - 04:56 PM.

[Qwinn]

Not at all! I'd much rather get 'em all in a bunch, actually, half the work is in opening up all the applications and files, heh.

Keep 'em coming! Thanks for taking the time.

Qwinn