141 replies to this topic

[Sam.]

Miloch, on 28 Jan 2013 - 20:04, said:

Seems to work for me. I think most of those messages are spurious though maybe a couple might be valid (though probably harmless since it displays as intended). I'll eventually take a look at it unless you want to try fixing it.

I looked at them, and the only real ones were a couple of dead links and missing quotation marks on the parameters for the width/height values for most of the images, but as you say it displays properly so I didn't bother to fix them.  Oh, and I think there was a missing </ div> and/or </ p> somewhere.  I'll add it to my to-do list, but it isn't at the top.

[Sam.]

Sam., on 28 Jan 2013 - 20:33, said:

Miloch, on 28 Jan 2013 - 20:04, said:

Seems to work for me. I think most of those messages are spurious though maybe a couple might be valid (though probably harmless since it displays as intended). I'll eventually take a look at it unless you want to try fixing it.

I looked at them, and the only real ones were a couple of dead links and missing quotation marks on the parameters for the width/height values for most of the images, but as you say it displays properly so I didn't bother to fix them.  Oh, and I think there was a missing </ div> and/or </ p> somewhere.  I'll add it to my to-do list, but it isn't at the top.

Checked off the to-do list .  (Sorry for all the Dropbox update notifications you probably got...)  All of the readmes found in Index of /Mirror for Readmes should now fully pass validation with no errors and essentially no warnings.

[Sam.]

Version 4 uploaded.

Quote

Version 4: 17 Aug 2014
- Updated Polish translation
- Updated WeiDU

Edited by Sam., 18 August 2014 - 11:48 PM.

[Sam.]

my very bad english, on 11 Sept 2014 - 22:57, said:

So, is this work on vanilla BG?

It should, yes.  From the Compatibility section of the readme:

 

Quote

This mod works with any Infinity Engine game except PS:T. However, the new hammer projectiles will only appear for games based on the BG2 engine, since projectile identifiers seem to be hardcoded in other games. Make sure your game has the latest patch.

Edited by Sam., 11 September 2014 - 05:31 PM.

[Sam.]

my very bad english, on 12 Sept 2014 - 02:09, said:

 I'm afraid it wont work on good ole' BG. Last time I used it whenever I tried to throw one of these neat things the game went crushing. 

You were right, it was broken in BG1 (and maybe IWD).  Try the new version and let me know how it goes .  Thanks for pointing out that there was a problem!

[Sam.]

Translators Needed
 
Thanks to K4thos, Thrown Hammers is nearly fully EE compatible.  Basically the only thing missing now is translation updates.  I have corrected and updated the English ones (both EE and non-EE versions), but the French, German, Italian, Polish, Russian, and Spanish translations all need to be updated.  Attached is the updated English TRAs as well as the outdated translations for the other languages, broken into EE and non-EE versions.
 

note for translators (EE update) said:

The only thing changed for the non-English languages is a copy (only items descriptions) of setup.tra named setup-EE.tra. This file should be adopted to use EE engine item description formatting that differs from the one in the vanilla engine. Before you start the work please check the BG:EE or BG2:EE TLK files to see how the descriptions are formatted in your language. Some of these strings already exists in game.

I (Sam.) have modified the English setup.tra and setup-EE.tra files to add as much consistency as possible across EE and non-EE games, and to minimize the effort required to translate two different versions of the same information.  Feel free to use this as a template rather than restructuring the existing translated descriptions yourself.  The English version of the TRAs also now contain more/corrected information compared to the strings shipped in the previous version (v4.1 fom September 15, 2014).

 translations.rar   42.29K   282 downloads
 
Also, if you happen to want to update the readme, the latest version can be found here.  The outdated French one is still here, for now.

Edited by Sam., 24 January 2016 - 10:39 AM.

[Graoumf]

The french team (the d'Oghmatiques) will be on it in the future, but our translator is busy with another translation at the moment.

Edited by Graoumf, 26 January 2016 - 04:37 PM.

[agb1]

BiG World Fixpack patches this section of the setup-hammers2.tp2:

 

  COPY_EXISTING ~tooltip.2da~ ~override~

    COUNT_2DA_COLS cl

    COUNT_2DA_ROWS 1 rw

    SPRINT cz ~~

    SPRINT rx ~          ~

    SPRINT ry ~-1~

    SPRINT rz ~~

    PATCH_IF cl < 5 BEGIN

      SPRINT rz ~$ $ 4~

      FOR (i = 0; i < (rw - 3); i += 1) BEGIN //Cycle through rows

        SPRINT rz ~%rz%~ ^ ~%rx%~ ^ ~%ry%~

      END

    END ELSE BEGIN

      FOR (i = 3; i < (cl - 1); i += 1) BEGIN //Cycle through columns

        SPRINT cz ~%cz%~ ^ ~%rx%~ ^ ~%ry%~

      END

    END

  BUT_ONLY

 

The Fixpack changes i = 3 in that line to i = 4:

 

      FOR (i = 4; i < (cl - 1); i += 1) BEGIN //Cycle through columns

 

Considering that tooltip.2da seems to have 4 columns in both original BG2 and EE, I am not sure what game type that ELSE block (containing the affected line) affects.  Is the Fixpack correct or is that patch unnecessary now?

 

[Mike1072]

The fix is correct.

 

tooltip.2da can support tooltips for more than 3 abilities. (Thrown Hammers requires at least 4.)  The two code paths here deal with the case when tooltip.2da has 4 columns (supporting 3 abilities) or when it has 5 or more columns (supporting 4 or more abilities).  In the first case, it has to append an additional column to all of the rows in the file.  In the latter case, any rows it adds to the file have to padded with additional values.  The fix corrects an indexing error that causes the mod to append too many additional values.

[agb1]

Thanks Mike. The fix was undocumented. I've updated the Fixpack to reference your post here.

[Lollorian]

Reference

[Sam.]

Thanks all .  I have patched the .tp2 as you have suggested and pushed to github:  ThrownHammers.

 

I had links to the github project in this thread, but they were lost when the forum DB was reverted...

Edited by Sam., 12 July 2016 - 03:48 PM.

[agb1]

Sam, if you create a full "release" on GitHub (not just a tag), we can transition BWS to use a redirect URL for the download link so it will always fetch your latest release, instead of having to update BWS manually. Please consider this when you are ready to version up.

https://help.github....ating-releases/

Don't forget to update the version number in the tp2 when you make a new release. Helps with troubleshooting when users report problems because the version in the tp2 shows up in users' WeiDU log.

[Sam.]

agb1, on 13 Jul 2016 - 04:58, said:

Sam, if you create a full "release" on GitHub (not just a tag), we can transition BWS to use a redirect URL for the download link so it will always fetch your latest release, instead of having to update BWS manually. Please consider this when you are ready to version up.

https://help.github....ating-releases/

Don't forget to update the version number in the tp2 when you make a new release. Helps with troubleshooting when users report problems because the version in the tp2 shows up in users' WeiDU log.

I'm not sure I understand why you wouldn't want to automatically grab the commit at the tip of the branch "master" instead?  I'll be sure to update the version number each commit from now on.

 

Edit:  Regardless, I have done as you asked

Edited by Sam., 15 July 2016 - 06:18 PM.

[agb1]

Master branches are not always stable. We want to minimize install problems for users. Taking latest version only gives you control over what BWS will download while simplifying maintenance for us; plus you don't have to be as careful about testing your master branch changes before committing them. Plus you don't need to change version for every commit - only for releases.

Edited by agb1, 15 July 2016 - 09:51 PM.