123 replies to this topic

[berelinde]

In attempting to get T1Dar to compile, I found a transition with no state associated with it. I added the state, but you're going to have to fill in something clever.

This is the added state, to make it easier to find:
IF ~~ THEN BEGIN T1DarRetHelpBye
SAY ~Tempest has to fill in something clever for this state.~
IF ~~ THEN EXIT
END

[Tempest]

Actually, I think Bookwyrm's suggestion may have worked-Weidu's coughing up blood on another part of that pesky dialogue block now:

CHAIN
IF ~NumTimesTalkedTo(0) InParty("Aerie") !Dead("Aerie")~ THEN ~T1DAR T1AeriePartyIntro
~Excuse me, but what is another Avariel doing in Athkatla? You don?t appear to be a warrior.~
== ~AERIEJ~ ~Avariel? another Avariel? You know of my people? And there is another in the city? Please, tell me!~

[berelinde]

OK, sending it via PM. The T1Dar.d compiles. T1Dar.baf won't, but you're still one step closer.

[Tempest]

Thanks a ton. That block you added won't make it in, though-it's just going to link to his RetBye block.

[berelinde]

As a hint, you might want to retain archives using date/time stamp labels. That way, if you ever need to revert to an earlier version, you'll be set.

[Bookwyrme]

Time and date stamping will also help you remember just *which* version you were working on when you stopped at some odd hour in the morning.

[Tempest]

Well, tossing out the initial problems in T1Dar.baf to be chewed over while I sleep: there are errors here:

IF
Global("T1DarMatch","GLOBAL",1)
OR (3) Global("T1DarRomanceActive","GLOBAL",1) Global("T1DarRomanceActive","GLOBAL",2) Global("T1DarRomanceActive","GLOBAL",4) Global("T1DarRomanceActive","GLOBAL",5)
Global("T1DarLovetalk","GLOBAL",1)
RealGlobalTimerExpired("T1DarRomance","GLOBAL")
!AreaType(DUNGEON)
!StateCheck(Player1,STATE_SLEEPING)
!StateCheck(Player1,STATE_SILENCED)
!StateCheck(Player1,STATE_STUNNED)
InParty(Myself)
See(Player1)
!StateCheck(Myself,STATE_SLEEPING)
!StateCheck(Myself,STATE_SILENCED)
!StateCheck(Myself,STATE_STUNNED)
!Dead(Myself)
CombatCounter(0)
!See([ENEMY])
THEN
RESPONSE #100
IncrementGlobal("T1DarLovetalk","GLOBAL",1)
END

In both of these, Weidu says there are errors at column 130-problem is, there is no column 130 for these lines. It then says:

Type mismatch in "Name" argument of [Dead].
Expecting type "string". Recovering.

And in the second script block, Weidu has a problem with this line:

!StateCheck(Myself,STATE_SILENCED)

It says [Global] not found in ACTION.IDS.


And with that, I'm calling it a night on all this.

[Kaeloree]

... why aren't you using !StateCheck(Myself,CD_STATE_NOTVALID)? It's far simpler than all those checks. Includes all of the STATE checks you have there in one check.

[Azkyroth]

Kivan returns home, too, but he's still got a P-file. Keep in mind that there are any number of reasons an NPC can be kicked out, and not all of them involve actually being kicked out. The other day, I was playing BG2, and Minsc was petrified by one of the halfling mages in the planar sphere. I happened to have a "stone to flesh" scroll to de-stone him, but he stood there all blue-circled, and gave his rejoining speech when I re-recruited him.

Did you have any plans in case Darian was petrified?

It's also worth noting that his "fine, I'm leaving then" dialogue would have to be in his P-file too, unless you really want him to leave without even saying something. [EDIT]Which I guess you've already figured out, but for anyone else watching and blinking... O.o

Edited by Azkyroth, 24 September 2007 - 09:57 PM.

[berelinde]

Remember all those times I told you it would be easier to just use !StateCheck(Object,CD_STATE_NOTVALID)? This is why. Less to break. It covers a vast array of conditions under which an NPC won't speak.

You don't need a !Dead(Myself), because dead characters don't run script. You don't need !StateCheck(Object,STATE_CHARMED), for the same reason. Yet CD_STATE_NOTVALID conveniently covers both of those conditions.

I strongly recommend swapping out all those state checks for

!StateCheck(Myself,CD_STATE_NOTVALID)
!StateCheck(Player1,CD_STATE_NOTVALID)

You'll have to patch that into the state.ids, so put this at the top of the tp2, right after

BEGIN ~Darian, Talon of Myrrhavin~

APPEND ~state.ids~ ~0x80101FEF CD_STATE_NOTVALID~
  UNLESS ~CD_STATE_NOTVALID~

[berelinde]

Also, this line is going to ensure that the dialogue never happens, since it can't possibly return true:

OR (3) Global("T1DarRomanceActive","GLOBAL",1) Global("T1DarRomanceActive","GLOBAL",2) Global("T1DarRomanceActive","GLOBAL",4) Global("T1DarRomanceActive","GLOBAL",5)

You have OR(3) with 4 conditions. I'd change that to OR(4).

Edit: for script speed optimization purposes, you might want to move that line further down the script, right before the THEN. With OR() blocks, every condition has to be evaluated before moving on to the next trigger. So it can slow things down marginally. If you have too many instances where OR() blocks run every pass through the script, it will slow things down perceptibly.

Edited by berelinde, 25 September 2007 - 03:58 AM.

[Choo Choo]

Hmm, and if that's for a lovetalk, why do you have the romance variable at 5 included? If I remember correctly, that's non-romantic friendship. I might be wrong on both accounts though.

[Tempest]

Okay, Berelinde, I've been stubborn enough about it before, but I will bow to the CD_STATE_INVALID.

Choo, most of Darian's lovetalks are actually part of his friendship as well-the only romance-only dialogues that are reserved specifically for the romance track are a couple of talks at the end and his four floating scenes.

[Choo Choo]

Ohh, okay. :3

[berelinde]

You're still going to have to make it OR(4), unless it's supposed to be OR(3) /* three globals */ !Global/* fourth global */

[Tempest]

Yep, took care of that while replacing all the !StateChecks with the new variables.

[Kulyok]

CD_STATE_INVALID

CD_STATE_NOTVALID, just in case. And take two lines from BG1 NPC/Romantic Encounters for your .tp2, while you're at it.

[Tempest]

Don't know what two lines you're talking about, Kulyok.

[Kulyok]

The ones that have CD_STATE_NOTVALID in them. I understand that you're waiting for someone to post these lines for you, but really, you could just open the aforementioned mods' .tp2 and look.

[berelinde]

Do you mean these?

APPEND ~state.ids~ ~0x80101FEF CD_STATE_NOTVALID~
  UNLESS ~CD_STATE_NOTVALID~

That came from BG1 NPC, and it's posted above. He probably already got it.