16 replies to this topic

[Jewish]

I've been messing a bit more with NI functions, and it found 1016 errors in triggers and actions files and 1125 errors in scripts (doh!). Some of them are typos, too many/few arguments, missing quotes, argument not found in X.IDS.

Few of them I know how to fix, others I have no clue what is wrong. Some examples:

Too few arguments

TakePartyItem("MISC4Q")
DestroyItem("MISC4Q")
AddexperienceParty(18500)
SetGlobal("AerieTransform","GLOBAL",1)
Wait(1)
Polymorph(MAGE_FEMALE_ELF)
ApplySpell(Myself,AERIE_PORTRAIT)
Wait(2)
StartDialogueNoSet()

In ACTION.IDS: StartDialogNoSet(O:Object*) - 198

Missing quotes

SetGlobal("D0PrisonersFree","GLOBAL",1)
IG("D0Chg2",0,1)
IncrementGlobal("D0Change","GLOBAL",1)
DialogueInterrupt(FALSE)
DestroySelf()

In ACTION.IDS: IG(S:GLOBAL*,S:Area*D0VTYPE,I:Value*) - 163

Too few arguments - Here I assume the state is missing (duh)

IF
!RandomNum(6,4)
OR(2)
!HasBounceEffects(FourthNearestEnemyOf(Myself))
GlobalTimerNotExpired("xyxDoesNotSeeBounce","LOCALS")
OR(2)
GlobalTimerNotExpired("xyxDoesNotSeeBounce","LOCALS")
!HasItemEquiped("CLCK26",FourthNearestEnemyOf(Myself)) // Cloak of Mirroring
!StateCheck(FourthNearestEnemyOf(Myself),)
CheckStat(FourthNearestEnemyOf(Myself),0,SANCTUARY)
OR(2)
GlobalTimerNotExpired("xyxDoesNotSeeImmunity","LOCALS")
CheckStatLT(FourthNearestEnemyOf(Myself),50,RESISTMAGIC)
!Name("Viconia",FourthNearestEnemyOf(Myself))
!HasItem("MINHP1",FourthNearestEnemyOf(Myself)) // No such index
!HasItem("IMOENHP1",FourthNearestEnemyOf(Myself)) // Imoen's Belt
See(FourthNearestEnemyOf(Myself))
False()
THEN
RESPONSE #100
END

In TRIGGER.IDS: StateCheck(O:Object*,I:State*State) - 16439

Well, you get the idea. I'm wondering if NI is going nuts and find errors where there are not... or indeed the errors are there and I'll have to manually fix them? (I guess the shortest way to fix these things is to find their original baf and do it there?)

EDIT:

Some of these scripts might belong to mods, I don't know and probably don't care much. I'm just trying to learn stuff the hard way... so the above are examples and just that.

Just to be clear

Edited by Jewish, 19 October 2004 - 04:15 AM.

[Jewish]

Ok, what I'm trying to learn here is why there are so many arguments in scripts that seem incomplete according to their X.IDS.

For Example, if I set in a script this

IF

blah

THEN

CreateCreature("whatever",[500.600])

END

NI will say that it is erroneus, incomplete, because I don't specify to where should face the creature. But ingame the creature spawns normally.

So many of these errors do not seem to be such, just a way to do things without writting too much?

[SimDing0]

IG("D0Chg2",0,1) isn't an error. NI just doesn't like it because I've introduced syntax that wasn't supported by the original game. In this respect, the checker is minorly flawed.

[Jewish]

I was just looking at that part heh.

So it's possible to add arguments (S:Area*D0VTYPE?) in the .IDS not supported by the game engine. I guess that goes beyond my capacity, I still have not learnt how to make .IDS lines.

ps: I have read your tutorial btw, great stuff.

[SimDing0]

So it's possible to add arguments (S:Area*D0VTYPE?) in the .IDS not supported by the game engine. I guess that goes beyond my capacity, I still have not learnt how to make .IDS lines.

Yes, it's quite possible. I've given a more detailed explanation of how it works here. I believe my scripting guide also mentions IDS editing briefly.

ps: I have read your tutorial btw, great stuff.

Thanks. Hope you found it useful.

[Jewish]

Oookay, I think I got it now. You basically reference the String to another .IDS (D0VTYPE.IDS). You had to do this because WeiDU did not have the new command mentioned in the other thread, so your number of characters had to match with the number of the action that you were trying to replace (this is pure guessing btw, I don't have a clue of WeiDU... yet).

Wow. Simple as.

[SimDing0]

That's pretty much it, yes.

[hlidskialf]

Most cases of (Myself) can be replaced with a simple () without a script error in game.

[Jewish]

I see. So it's possible to cut certain parts of the code without errors in the game. This must be the case in the last script example aswell.

!StateCheck(FourthNearestEnemyOf(Myself),)
Here the script is missing the STATE itself from STATE.IDS, but there is no real need to put it there tho.

I should be fine guessing them by looking at the script then.

EDIT:

One last thing. I've noticed in some scripts (Aerie scripts mainly) some areas marked as OUTSIDE, but in AREATYPE.IDS there is no OUTSIDE flag.

Is there any reason for this, or it is a mistake?

Edited by Jewish, 20 October 2004 - 06:11 AM.

[Stone Wolf]

I can't find any instances of Outside in any of her scripts, though I do have some mods installed. What I did find was Outdoor, which is in Areatype.ids. Is there anything else in the block that would help me find it?

Edited by Stone Wolf, 20 October 2004 - 06:18 AM.

[Jewish]

Sorry for the late response, I have noticed your answer today.
So far I only found this issue in Aerie, Anomen and Minsc dialogues.

AERIEJ.DLG State trigger 14 (Also in 15 and 16)

GlobalTimerExpired("AerieRemindsQuayle","GLOBAL")
Global("AerieReminder","LOCALS",0)
Global("QuayleJob","GLOBAL",0)
AreaType(OUTSIDE)
AreaType(CITY)
!AreaCheck("AR2000")
CombatCounter(0)
Global("HaerDalisPlotStarted","GLOBAL",0)
Global("HaerDalisFree","GLOBAL",0)

BANOMEN.DLG state trigger 34

PartyRested()
AreaType(OUTSIDE)
See(Player1)
!StateCheck(Player1,STATE_SLEEPING)
Global("BAnomen4","LOCALS",0)

MINSCJ.DLG State trigger 19 (also in 20)

GlobalTimerExpired("MinscRemindsImnesvale","GLOBAL")
Global("TalkedToLloyd","GLOBAL",0)
Global("VillageSaved","GLOBAL",0)
AreaType(OUTSIDE)
!AreaCheck("AR1100")
!AreaCheck("AR1400")
See(Player1)
!StateCheck(Player1,STATE_SLEEPING)
Global("MinscReminder","LOCALS",0)



Unfortunately I have also found a great ammount of typos in the game scripts (missing a letter, parenthesis, etc...) I just thought that maybe it's not worth checking them one by one, there are lots.

Edited by Jewish, 22 October 2004 - 06:50 AM.

[Stone Wolf]

Well, I checked my MinscJ.dlg and it has Outdoor in those spots. I guess some mod or patch fixed those.

[Jewish]

That's possible I guess.
I have not found any area coded as outside tho, and as I said the areatype.ids just has outdoor.

Thanks for the answer anyway Stone Wolf!

[Jewish]

That was a good deal of information, thank you Mr. Guest.

I hoped to learn something useful about NI, scripts or anything related to the script search I made, without wasting anyone's time in excess. I could not thank you guys enought for answering in the thread and all the support provided (let alone the patience).

As for editing, currently I have a safe BG install with which I can mess without worries, so there is where I'm trying every change. I guess the best way to learn would be starting some mod myself for personal use, trial and error, and get hands to work.

Anyway, thanks for all your help and patience, this has been most instructive.