8 replies to this topic

[Miloch]

It might help if you provide the link to that other thread and also post the contents of your WeiDU.log file.

[Ascension64]

Could well be

IF
GlobalTimerExpired("Coran","GLOBAL")
InParty(Myself)
!Dead("Wyvern") <--- should be X#CoranWyvern in line with the BG1NPC/BG1UB changes
THEN
RESPONSE #100
ActionOverride("Coran",Dialogue([PC]))
END

To get rid of this in the game, use the CLUAConsole:CreateCreature("WYVERN") command to make a wyvern and then Ctrl+Y the wyvern. That should stop him yapping on.

[Miloch]

That looks like a bug in the vanilla game then, that even BG1UB or BG1NPC doesn't solve, since it only changes the Wyvern's name/death variable. Unless they also do other things, like maybe put a variable check in there so it doesn't loop. I can't see any reference to this in Baldurdash or Dudleyfix either, and I don't recall it from the BG1 Fixpack either though it's possible someone did something about it.

Edit: Actually, shouldn't his dialogue have a LeaveParty() after he says that?

Edited by Miloch, 22 December 2009 - 07:06 AM.

[cmorgan]

bg1npc removes the block

/* Changing Coran's old leaving timer */
  COPY_EXISTING ~%CORAN_BCS%.bcs~ ~override~
	DECOMPILE_BCS_TO_BAF
   REPLACE_TEXTUALLY CASE_INSENSITIVE
	~GlobalTimerExpired("Coran","GLOBAL")~ ~False()~
  COMPILE_BAF_TO_BCS
  BUT_ONLY_IF_IT_CHANGES

and otherwise matches UB's rebuild.

In both Tutu and BGT conversions (and probably vanilla BG), there is a long-standing ever-repeating bug with Coran's Wyverns that prompted the fix by Ascension 64 - Domi and I both gave it (multiple) attempts and failed at permanent fixes, and Ascension64's repair is the one that works. Definitely something for the BG Fixpackers, Miloch

[Miloch]

Eh... I don't get why A64 left the bug in BGT but changed it in BG1UB though. Except maybe that False()ing a vanilla script block isn't really an authentic fix I suppose. If you ask me, that LeaveParty() should be added to his dialogue where he says that line, because it's missing any actions there. Clearly that's what he intended to do (go hunt some wyverns because the party wasn't listening to him). But if you already killed a wyvern, it should check for that in a more certain way than just a !Dead check.

[Ascension64]

Yep, it looks like my theory was correct, at least in this case. It only occurs after you finish the quest but have not killed a DV Wyvern yet. Coran goes into a stutter dialogue, but since all state triggers are false, you get this:


Something I forgot to change last year, I guess.

Note that if you haven't finished Kelddath's quest, Coran will leave as normal, so vanilla BG is not at fault here, and therefore BGFixpack won't need to do anything here.

Now, Tutu will need this as well, so both BG1NPC and BG1UB will need to:

COPY_EXISTING ~%tutu_var%CORAN.BCS~ ~override~
  DECOMPILE_BCS_TO_BAF
  REPLACE_TEXTUALLY ~!Dead("wyvern")~ ~!Dead("X#CoranWyvern")~
  COMPILE_BAF_TO_BCS
BUT_ONLY_IF_IT_CHANGES

to correct this error.

The BG1UB code now looks like this:

ACTION_IF !("%tutuorbgt%" STRING_EQUAL "BGT") THEN BEGIN //BG and Tutu
  COPY_EXISTING ~%tutu_var%WYVERN.CRE~ ~override/X#CORWYV.CRE~
	WRITE_ASCII 0x280 ~X#CoranWyvern~ #32 //script name

  COPY_EXISTING ~%CloakwoodWyverns_WyvernCave%.ARE~ ~override~
	READ_LONG 0x54 actorsOff
	READ_SHORT 0x58 actorsNum
	FOR (i = 0; i < %actorsNum%; i += 1) BEGIN
	  READ_ASCII (%actorsOff% + %i% * 0x110 + 0x80) actorResref
	  PATCH_IF !("%actorResref%" STRING_COMPARE_CASE "%tutu_var%WYVERN") BEGIN
		WRITE_ASCII (%actorsOff% + %i% * 0x110 + 0x80) X#CORWYV (8)
	  END
	END
  BUT_ONLY_IF_IT_CHANGES

  COPY_EXISTING ~%tutu_var%CORAN.BCS~ ~override~
	DECOMPILE_BCS_TO_BAF
	REPLACE_TEXTUALLY ~!Dead("wyvern")~ ~!Dead("X#CoranWyvern")~
	COMPILE_BAF_TO_BCS
  BUT_ONLY_IF_IT_CHANGES

  ACTION_IF ("%tutuorbgt%" STRING_EQUAL "Tutu") THEN BEGIN //Tutu
	COMPILE EVALUATE_BUFFER ~bg1ub/coran/cpm/Wyvern.d~
  END ELSE BEGIN //BG
	COMPILE ~bg1ub/coran/Wyvern.d~
  END
END

wyvern.d

//Ascension64: makes Coran's wyverns unique
REPLACE_TRIGGER_TEXT %CORAN_JOINED% ~!Dead("Wyvern")~ ~!Dead("X#CoranWyvern")~
ADD_STATE_TRIGGER %tutu_var%KELDDA 6 ~Dead("X#CoranWyvern") InParty("Coran")~

The current wording for the fix (as of BG1UB) is

BG/Tutu: fixed a stutter bug for Coran in the specific scenario that: (i) the player has killed the specific wyverns for the quest, (ii) Coran's timer runs out , and (iii) the player has not yet killed any standard non-specific wyverns yet

It appears that there are issues with trying to finish the quest with BG1NPC, so I'll take a look at this for you as well, cm.

Edit: Hmm, after sleeping over it, BG1NPC need not make any changes to the CORAN.BCS script block, since it falsifies that block anyway. So no need for change from BG1NPC side.

Edited by Ascension64, 25 December 2009 - 04:13 PM.